summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* The ExternalTabContainer object which implements the TabContentsDelegate ↵ananta@chromium.org2009-07-222-1/+27
| | | | | | | | | | | | | | interface now implements the ShowHtmlDialog function which is needed to support HTML dialog popups like those displayed by Gears.' Fixes http://b/issue?id=1963582 Bug=1963582 Review URL: http://codereview.chromium.org/159162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix line endings doc files.rafaelw@chromium.org2009-07-227-486/+486
| | | | | | | | TBR Review URL: http://codereview.chromium.org/155927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21288 0039d316-1c4b-4281-b951-d872f2087c98
* Merged FilterHostImpl into PipelineInternal as it was no longer needed and ↵scherkus@chromium.org2009-07-225-238/+110
| | | | | | | | | | | | | | | added complexity. PipelineInternal now directly implements FilterHost and uses an std::map to safely cast from MediaFilter to specialized filter subclasses. PipelineImpl also provides the same set of functions as FilterHost to allow PiplineInternal to acquire the lock and safely update data. BUG=17107 TEST=media_unittests should still pass Review URL: http://codereview.chromium.org/155739 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21287 0039d316-1c4b-4281-b951-d872f2087c98
* Make DND use the anchor name.arv@google.com2009-07-221-1/+2
| | | | | | | | | | | | BUG=17408 TEST=Drag a thumbnail from the NNTP to your desktop of your bookmakrs bar. The title should be used. Review URL: http://codereview.chromium.org/159184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21286 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix a regression from r20404 which keeps a drag into the tabstrip from ↵jhawkins@chromium.org2009-07-222-27/+34
| | | | | | | | | | working. Only destroy the container widget and not the drop info itself when the drag leaves the tab strip; otherwise, we'll lose the drop information used to open the link. BUG=none TEST=Drag a link into the tab strip. The drop arrow should appear and disappear as the mouse enters and leaves the tab strip. Drop the link into the tab strip. The link should be opened in the new tab (or the current tab). Review URL: http://codereview.chromium.org/159178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21285 0039d316-1c4b-4281-b951-d872f2087c98
* Make scrollbars and other controls tint/untint upon main window gainingthakis@chromium.org2009-07-2217-1/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | focus on Mac. This entails the following: - getting notifications that the main window has become or lost key window status (in BrowserWindowController) [new] - ... which tells the RenderWidgetHostView(Mac) to (de)activate [new] - ... which tells the RenderWidgetHost to (de)activate [new] - ... which sends a ViewMsg_SetActive message [new message] to the RenderView [new] - ... which tells the WebView(Impl) to (de)activate [new] - ... which tells its page()'s FocusController to (de)activate [new] - ... which is now in WebKit-land. N.B.: "Activate" is the nomenclature used in WebKit; "focus"/"blur" can sometimes (kind of) mean the same thing, but is ambiguous, since "focus" has a more specific meaning. Added a WebView unit test, which currently only tests to make sure that SetActive() (and IsActive() [also new]) work correctly. The changes to the other classes aren't very testable since they don't actually do anything (other than pass things along). BUG=12507 TEST=webkit/glue/webkit_unittest.cc Patch by viettrungluu@gmail.com (see http://codereview.chromium.org/159048 ), r=avi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21284 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure installer_util_string is always built beforensylvain@chromium.org2009-07-221-6/+15
| | | | | | | | | | | | | installer_util. It was triggering a bug in Incredibuild. By making one of the dependent of install_util a dummy_executable, and making this dummy_executable depends on installer_utils_strings, the odds that it triggers a bug is a lot smaller. I tried 6 clobber builds so far and none of them failed. Review URL: http://codereview.chromium.org/155923 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21283 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some bogus includes.darin@chromium.org2009-07-224-10/+4
| | | | | | | | | | BUG=none TEST=none R=jorlow Review URL: http://codereview.chromium.org/155898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21282 0039d316-1c4b-4281-b951-d872f2087c98
* Update expected test failures after WebKit merge r46143:46194paul@chromium.org2009-07-221-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/155901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21281 0039d316-1c4b-4281-b951-d872f2087c98
* Add a custom subclass of GTMUILocalizer that skips the bundle work so we can ↵thomasvl@chromium.org2009-07-223-5/+56
| | | | | | | | | | | | directly use these from nib files without some extra overhead. Updated the generator to make things based off this subclass. TEST=none BUG=16764 Review URL: http://codereview.chromium.org/159197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21280 0039d316-1c4b-4281-b951-d872f2087c98
* These are gyp file changes that start to make the Mac GYP build work.gspencer@google.com2009-07-2212-35/+69
| | | | | | | | It still doesn't but I want to checkpoint these changes. Review URL: http://codereview.chromium.org/155890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: generate a manpage"evan@chromium.org2009-07-222-90/+0
| | | | | | | This reverts commit r21277, since it failed on the scons build for reasons totally opaque to me. :~( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21278 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generate a manpageevan@chromium.org2009-07-222-0/+90
| | | | | | | | This is not intended to be complete; hopefully we can iterate from here. Review URL: http://codereview.chromium.org/159198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21277 0039d316-1c4b-4281-b951-d872f2087c98
* Limit total number of sockets in the system.phajdan.jr@chromium.org2009-07-228-91/+441
| | | | | | | | | | Based on Eric Roman's patch at http://codereview.chromium.org/62181 http://crbug.com/15093 Review URL: http://codereview.chromium.org/149027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21276 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for gtk_window_add_accel_group in ↵phajdan.jr@chromium.org2009-07-221-11/+0
| | | | | | | | | | | | BrowserWindowGtk::ConnectAccelerators. The leak seems to no longer exist. http://crbug.com/16153 Review URL: http://codereview.chromium.org/159149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21275 0039d316-1c4b-4281-b951-d872f2087c98
* When --gtest_filter is specified, we need to ignore the batch index, ↵erikkay@google.com2009-07-221-0/+4
| | | | | | | | | | | | | otherwise you wind up being unable to run your specific test. BUG=none TEST=none TBR=huanr Review URL: http://codereview.chromium.org/159195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21274 0039d316-1c4b-4281-b951-d872f2087c98
* Kill popups when scrolling.avi@chromium.org2009-07-221-0/+16
| | | | | | | | | BUG=http://crbug.com/17376 TEST=as in bug Review URL: http://codereview.chromium.org/155875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21273 0039d316-1c4b-4281-b951-d872f2087c98
* Starting mac l10n:thomasvl@chromium.org2009-07-2214-163/+582
| | | | | | | | | | | | | | | | | | | Added a script to process a xib file and generate a localizer out of the resource constants it finds in the xib. Update the MainMenu.xib to use a generated localizer. Kill off the menu_localizer in favor of a generated one. ui_localizer is a helper so each "localizer" is as small as possible. Build some menus out of base strings and the product name like windows. Added the dir generated for the localizers so we can load the header to directly create them (menubar one). Enable the other 3 languages we were building to help test. Made the context menu code use the new code for handling window's accelerators and ellipsis. Added unittest for ui_localizer. Opened http://crbug.com/17380 to track the problem with the menu titles so I can move on to other parts of the UI for now. TEST=The main menu will have some items localized now (and more will be localizable in the TC). BUG=16764 Review URL: http://codereview.chromium.org/155774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21272 0039d316-1c4b-4281-b951-d872f2087c98
* This implements the functions necessary for the task manager on Linux.deanm@chromium.org2009-07-221-4/+62
| | | | | | | | | | | Patch by Joel Stanley. BUG=http://crbug.com/16251 Review URL: http://codereview.chromium.org/149455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21271 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: hide code injected by DevTools.mnaganov@chromium.org2009-07-221-1/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21270 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Rename JavaScript console action into Developer Tools.pfeldman@chromium.org2009-07-228-26/+12
| | | | | | Review URL: http://codereview.chromium.org/155914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21269 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Handle errors in evaluation response.pfeldman@chromium.org2009-07-221-5/+7
| | | | | | Review URL: http://codereview.chromium.org/159191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21268 0039d316-1c4b-4281-b951-d872f2087c98
* o Modified the toolbar button handler so that the handler can revert its ↵yusukes@google.com2009-07-222-7/+12
| | | | | | | | | | | | | omnibox when the button pressed is RELOAD, FORWARD, or BACK. o Modified Browser::Reload(). Don't revert the bar when the user hit F5 or Ctrl-r. BUG=15464 TEST=see the comment #3 of issue 15464 Review URL: http://codereview.chromium.org/155908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21267 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 5996: Tooltip gets direction from Chrome langauge, not ↵xji@chromium.org2009-07-222-2/+14
| | | | | | | | | | | | | | | | | | | element (or even page) The related webkit bug is https://bugs.webkit.org/show_bug.cgi?id=24187 After webkit passes both the title string and its directionality to its client, Chrome will force the title to be displayed in correct directionality using Unicode Control characters. BUG=http://crbug.com/5996 TEST=In both English Chrome and Hebrew Chrome 1. open the test case in http://crbug.com/5996 comment #1 2. hover over the red span, tooltip should be displayed as RTL in both English Chrome and Hebrew Chrome. 3. hover over the blue span, tooltip should be displayed as LTR in both English Chrome and Hebrew Chrome. Review URL: http://codereview.chromium.org/147240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21266 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixit changessra@chromium.org2009-07-222-11/+13
| | | | | | | | | | | | | | None of these fix known bugs * pass string by reference * initialize _int_value field (even though guarded by _is_string) BUG=none TEST=none Review URL: http://codereview.chromium.org/155838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21265 0039d316-1c4b-4281-b951-d872f2087c98
* Submit the second part of the revert.nsylvain@chromium.org2009-07-221-1/+0
| | | | | | Review URL: http://codereview.chromium.org/155907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21264 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 21259 because it broke the unit tests on windows.nsylvain@chromium.org2009-07-221-58/+0
| | | | | | | | | | | | - Commit message: Add a unit test for ProcessWatcher::EnsureProcessTerminated(). Review URL: http://codereview.chromium.org/155799 - Review URL: http://codereview.chromium.org/159188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21263 0039d316-1c4b-4281-b951-d872f2087c98
* revert change 21252, which broke the mac build for some reasondpranke@google.com2009-07-225-28/+14
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21262 0039d316-1c4b-4281-b951-d872f2087c98
* mp4 types in omnibox only for chrome, not chromiumfbarchard@chromium.org2009-07-221-0/+3
| | | | | | | | | | | | The types are still claimed as supported because layout tests require them, but the extensions will not map to mimetypes, so typing them into the omnibox will download instead of trying to play the video. The fixes for canPlayType that kyle is doing will fix some of this, and we'll also need to update the media in the layouttests. So that portion of mimetype will be deferred BUG=17323 TEST=in the omni box type in the name of an mp4 and it should work in chrome, but not in chromium. Review URL: http://codereview.chromium.org/155835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21261 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use new xdg-settings "check" feature to determine whether we are the ↵mdm@chromium.org2009-07-222-18/+19
| | | | | | | | | | | default browser. BUG=17093 TEST=in GNOME, let Firefox set itself as the default after Chrome has set itself; Chrome should then detect that it is no longer the default Review URL: http://codereview.chromium.org/155889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21260 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test for ProcessWatcher::EnsureProcessTerminated().thestig@chromium.org2009-07-222-0/+59
| | | | | | Review URL: http://codereview.chromium.org/155799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21259 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the include from "base/gfx/platform_canvas.h" to ↵ajwong@chromium.org2009-07-2210-64/+4
| | | | | | | | | | | | "skia/ext/platform_canvas.h" BUG=None TEST=None Review URL: http://codereview.chromium.org/159057 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21258 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a test which I removed, as it is failing again.eroman@chromium.org2009-07-221-0/+3
| | | | | | | | | | | Baseline must have changed with last merge. BUG=17326 TBR=paul Review URL: http://codereview.chromium.org/155903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21257 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Center the tab text by its meanline, rather than halfway between its ↵estade@chromium.org2009-07-221-1/+3
| | | | | | | | | | | | ascent and descent. The tab text was previously one pixel too high. With this patch it matches Windows. I think before Evan's recent font size patch, this issue was hidden by favorable rounding. Review URL: http://codereview.chromium.org/159169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21256 0039d316-1c4b-4281-b951-d872f2087c98
* When a web contents drag has a URL but no title, make up a title for it.estade@chromium.org2009-07-221-14/+30
| | | | | | | | | BUG=17393 TEST=drag nntp thumbnail to bookmark bar Review URL: http://codereview.chromium.org/155900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21255 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create new tabs for middle clicks on bookmark items when the user ↵estade@chromium.org2009-07-221-0/+6
| | | | | | | | | | | releases off the item. BUG=14518 TEST=see bug Review URL: http://codereview.chromium.org/155902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21254 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixes to keep coverity quiet.sra@chromium.org2009-07-226-9/+35
| | | | | | | | | | | | | | | | | Only the first issue is remotely interesting. * Possibility (low) of using NULL SinkStream* courgette tool 'gen1a' command. * Added initializers for all class members to several constructors. * return 0 at end of from wmain. BUG=none TEST=existing Review URL: http://codereview.chromium.org/155820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21253 0039d316-1c4b-4281-b951-d872f2087c98
* make 'test_shell' target depend on everything needed to pass layout_testsdpranke@google.com2009-07-225-14/+28
| | | | | | | | | | | | | | | | | This adds project dependencies to test_shell so that all (and only?) the targets needed for the layout_tests to run cleanly are built. On most platforms this is test_shell, npapi_test_plugin, and test_worker, and on the Mac this adds the layout_test_helper binary as well also, this moves image_diff from chrome/tools/test to tools/ R=mmentovai@google.com, darin@google.com BUG=none TEST=none Review URL: http://codereview.chromium.org/149714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98
* Split NSSDecryptor out into platform specific files.willchan@chromium.org2009-07-2216-574/+817
| | | | | | | | | | This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs. BUG=http://crbug.com/13929 TEST=Case 1: Start chrome. Use firefox import utility. Browse to some https site. Shouldn't crash. Case 2: Start chrome. Browse to some https site. Use firefox import utility. Continue browsing https sites. Shouldn't crash. Review URL: http://codereview.chromium.org/159165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21251 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add windowless plugin plumbingpiman@google.com2009-07-226-28/+85
| | | | | | | Review URL: http://codereview.chromium.org/159128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21250 0039d316-1c4b-4281-b951-d872f2087c98
* Add <if> blocks to xtb files in the simplest possible way. This currentlytc@google.com2009-07-221-1/+18
| | | | | | | | | | | | only supports checking the OS, but we can add more information if necessary. BUG=16884 Review URL: http://codereview.chromium.org/159148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21249 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add command-line flag to allow debugging of sandboxed processespiman@google.com2009-07-224-4/+20
| | | | | | | Review URL: http://codereview.chromium.org/159124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21248 0039d316-1c4b-4281-b951-d872f2087c98
* Creating a unique user-agent string for ChromeOS builds, so that metrics can ↵evan@chromium.org2009-07-225-9/+152
| | | | | | | | | be aggregated separately from standard Chrome on Linux Review URL: http://codereview.chromium.org/155101 Patch from Chris Masone <cmasone@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21247 0039d316-1c4b-4281-b951-d872f2087c98
* Try again: Add proxy config (using gnome-network-preferences)mattm@chromium.org2009-07-227-55/+142
| | | | | | | | | BUG=11507 TEST=Open options, click change proxy, gnome-network-preferences should launch.  If gnome isn't installed or running, LinuxProxyConfig wiki page should load. Review URL: http://codereview.chromium.org/155792 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21246 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some layout-tests which changed in upstream webkit r46412.ericroman@google.com2009-07-2210-48/+44
| | | | | | | | BUG=http://crbug.com/17326 Review URL: http://codereview.chromium.org/159159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21245 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing minor review comments in ExtensionProcessManager post-submit.finnur@chromium.org2009-07-221-0/+3
| | | | | | | | | BUG=None TEST=None (no significant changes) Review URL: http://codereview.chromium.org/159073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21244 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to share MockAudioOutputStream implementations across 3 platformshclam@google.com2009-07-2220-197/+191
| | | | | | | | | | | | | Re-trying the previous CL. The last change got reverted because of valgrind failure. TBR=scherkus Original CL: http://codereview.chromium.org/155471 Review URL: http://codereview.chromium.org/159167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21242 0039d316-1c4b-4281-b951-d872f2087c98
* Implement bookmark editor. No tree display or hierarchy movement, butjrg@chromium.org2009-07-219-64/+1191
| | | | | | | | | | | | | | | | | | name/url editing works. Get to the edotir from a context menu (Edit, Add Page). Also Implement Open All Bookmarks menu item. BUG=http://crbug.com/8381, http://crbug.com/17006 TEST=Add some bookmarks. Right-click on a bookmark and pick Edit. Test editing the name and URL. Make sure you can't add a bogus URL. Right-click on a bookmark or the bar and Add Page. Fill in name and URL fields to add a new bookmark. Right-click Open All Bookmarks and make sure it hoses your machine. Review URL: http://codereview.chromium.org/155874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21241 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where error pages inserted HTML from a template but thearv@google.com2009-07-212-18/+25
| | | | | | | | | | | | | | | | | | string from the template was used with JST instead of the i18n template and therefore it did not get recursively processed. Also make sure we can support recursive handling of setting innerHTML with the i18n template engine. BUG=17377 TEST=Navigate to http://ponderer.org/tests/redirect-loop.py The error page should show: The webpage at http://ponderer.org/tests/redirect-loop.py has ... Review URL: http://codereview.chromium.org/155884 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21240 0039d316-1c4b-4281-b951-d872f2087c98
* Use a <button> that looks like a link to prevent right click and middle click.arv@google.com2009-07-211-2/+8
| | | | | | | | | | | BUG=9591 TEST=Go to the history page and make sure that "Delete history for this day" still works and that it does not allow opening the "link" in a new window. Review URL: http://codereview.chromium.org/155892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21239 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 03:19:02 +0000