summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add missing SkUnPreMultiply.cpp dependency to fix Linux shared-library build.evan@chromium.org2009-01-161-0/+5
| | | | | | | | Review URL: http://codereview.chromium.org/18333 Patch from Dan Erat <dan@erat.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8237 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 6296 by using a dedicated delegate instance for each infobar that ↵tim@chromium.org2009-01-165-66/+109
| | | | | | | | | | | | | the PasswordManager opens, rather than always using the PasswordManager itself as the delegate. The crash was occuring because before one infobar completely finished closing (i.e during its close animation), another password infobar would be opened, and for a moment in time two infobars are pointing to the same delegate. When the initial closing animation completes, it would null-out a field (pending_decision_manager_), which the now visible infobar would depend on when the user clicks one of the native buttons. This click would dereference a null member, hence causing the crash. Other clients of infobars seem to be immune to this problem because they either all create dedicated delegate instances per infobar, or they don't reset any state on InfoBarClosed. I think (at the very least) the infobar code should document that it can be risky to use a "shared" delegate due to the possibility of two simultaneously visible infobars referring to the same delegate. Review URL: http://codereview.chromium.org/18065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8236 0039d316-1c4b-4281-b951-d872f2087c98
* Pull app modal dialog handling out of the BrowserList to remove the ↵ben@chromium.org2009-01-166-43/+22
| | | | | | | | | | ChromeViews dependency. (Required for porting). TEST=Open two browser windows. In one, enter "javascript:alert('Foo');" into the address bar and hit enter. Click on the other window. The modal dialog should be focused and the window it was opened over should flash in the taskbar, Review URL: http://codereview.chromium.org/18179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage. Missed a file in my last commit :-(darin@chromium.org2009-01-161-4/+0
| | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/18337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8233 0039d316-1c4b-4281-b951-d872f2087c98
* roll forward r8227.jeremy@chromium.org2009-01-161-86/+89
| | | | | | Review URL: http://codereview.chromium.org/18336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8232 0039d316-1c4b-4281-b951-d872f2087c98
* Update te way test shell cleans up on exit.mbelshe@google.com2009-01-161-1/+7
| | | | | | | | | | | | | | | It turns out that the LayoutTestControllers are only reset when a test is started. Some tests leave sub-windows open (e.g. http/tests/security/aboutBlank/security-context-window-open.html) When these tests are run through the purify runner - which only runs one test per test shell - the effect is that the LayoutTestController does not get cleaned up. BUG=5329 Review URL: http://codereview.chromium.org/18300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8231 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8227.dglazkov@google.com2009-01-161-89/+86
| | | | | | Review URL: http://codereview.chromium.org/18177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8230 0039d316-1c4b-4281-b951-d872f2087c98
* "Port" StackTrace to Macmark@chromium.org2009-01-163-31/+8
| | | | | | Review URL: http://codereview.chromium.org/18173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8229 0039d316-1c4b-4281-b951-d872f2087c98
* Provisional Keystone support in Mac TestShellmark@chromium.org2009-01-164-0/+114
| | | | | | Review URL: http://codereview.chromium.org/18117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8228 0039d316-1c4b-4281-b951-d872f2087c98
* Update browser/browser.scons to reconcile OSX and Linux.jeremy@chromium.org2009-01-161-86/+89
| | | | | | Review URL: http://codereview.chromium.org/18170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8227 0039d316-1c4b-4281-b951-d872f2087c98
* re-enable savepage ui testtc@google.com2009-01-161-2/+1
| | | | | | | | | | The ui tests continued to time out after this test was disabled. Looks like someone disconnected the bot and fixed something. the tests are now all passing, so I think we can re-enable. Review URL: http://codereview.chromium.org/18331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8226 0039d316-1c4b-4281-b951-d872f2087c98
* fix linuxben@chromium.org2009-01-161-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8225 0039d316-1c4b-4281-b951-d872f2087c98
* Move url_* to net subdirben@chromium.org2009-01-1640-76/+130
| | | | | | Review URL: http://codereview.chromium.org/18305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8224 0039d316-1c4b-4281-b951-d872f2087c98
* fix build on windowstc@google.com2009-01-161-0/+1
| | | | | | | | | | we don't actually want to run this code on windows. TBR=evanm Review URL: http://codereview.chromium.org/18171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8223 0039d316-1c4b-4281-b951-d872f2087c98
* Mac build fixagl@chromium.org2009-01-161-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/18332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8222 0039d316-1c4b-4281-b951-d872f2087c98
* Windows build fix: sorry, I commit from the wrong tree.agl@chromium.org2009-01-161-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/16611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8221 0039d316-1c4b-4281-b951-d872f2087c98
* Have net_resources.grd generate a .pak file too. Since the tldtc@google.com2009-01-165-9/+28
| | | | | | | | | | | data is generated and included in the .pak file, we need to add a dependency in the SCons build. Making the corresponding changes to mac/win is harder, so punting for now. Review URL: http://codereview.chromium.org/18127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8220 0039d316-1c4b-4281-b951-d872f2087c98
* Use the PluginData object instead of the PluginInfoStore interface to test fordarin@chromium.org2009-01-165-51/+14
| | | | | | | | | | plugin supported mime types. R=jam Review URL: http://codereview.chromium.org/18141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8219 0039d316-1c4b-4281-b951-d872f2087c98
* Add StackTrace debugging utility class.agl@chromium.org2009-01-163-1/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For the moment, it only works on Linux, although it should be pretty easy to get it working on Mac with __builtin_return_address and __builtin_frame_address. It will mostly fail to resolve functions. Use this wrapper script: import os import sys import subprocess import re address = re.compile('.*\[(0x[0-9a-fA-F]{4,8})\].*') if __name__ == '__main__': p = subprocess.Popen(sys.argv[1:], stderr = subprocess.STDOUT, stdout = subprocess.PIPE) addr2line = subprocess.Popen(['addr2line', '-e', sys.argv[1], '-f', '-C', '-s'], stdout = subprocess.PIPE, stdin = subprocess.PIPE) for line in p.stdout.readlines(): m = address.match(line); if m is not None: addr2line.stdin.write(m.groups()[0] + '\n') function = addr2line.stdout.readline()[:-1] location = addr2line.stdout.readline()[:-1] sys.stdout.write('%s (%s)\n' % (function, location)) else: sys.stdout.write(line) Review URL: http://codereview.chromium.org/18303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8218 0039d316-1c4b-4281-b951-d872f2087c98
* window.cc should not include browser_list.h ... dependent (non-browser) ↵ben@chromium.org2009-01-167-53/+47
| | | | | | | | | | windows are closed when they receive a notification rather than by being called directly from BrowserList. Also browser_list.cc should not include window.h, required for porting. TEST=Open browser. Open options dialog box. Close browser. Options dialog should close too. Review URL: http://codereview.chromium.org/18328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8217 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher with --run-singly that was introduced by ↵erikkay@google.com2009-01-161-3/+6
| | | | | | | | http://codereview.chromium.org/18023 Review URL: http://codereview.chromium.org/18167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8216 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 39953:39972, Chromium Side.dglazkov@google.com2009-01-163-10/+15
| | | | | | Review URL: http://codereview.chromium.org/18325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8215 0039d316-1c4b-4281-b951-d872f2087c98
* Moves keygen test to ignored test list as wiring up keygen is a lowsky@google.com2009-01-162-1/+4
| | | | | | | | | | | priority. BUG=none TEST=none Review URL: http://codereview.chromium.org/18168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8212 0039d316-1c4b-4281-b951-d872f2087c98
* looking at test shell tests on mac:thomasvl@chromium.org2009-01-164-41/+36
| | | | | | | | | | | | - unforking TestShell::CreateNewWindow, all code must live in a platform's Initialize method instead (some tests rely on knowing what CreateNewWindow does). (mac had issues w/ this) - Mac: make the code path for tests that forces down windows properly clean up the bits in the same way a trip through the event loop would. - add a few more logs/checks in the mac code to catch issues. Review URL: http://codereview.chromium.org/18166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8211 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "* Dump text/image on notifyDone."kuchhal@chromium.org2009-01-167-136/+199
| | | | | | | Review URL: http://codereview.chromium.org/18330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8209 0039d316-1c4b-4281-b951-d872f2087c98
* Follow-up fixmark@chromium.org2009-01-161-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8208 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TestShell fonts again (see r8206, r8198, r8196, r8113)mark@chromium.org2009-01-161-9/+10
| | | | | | Review URL: http://codereview.chromium.org/18165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8207 0039d316-1c4b-4281-b951-d872f2087c98
* put back the changes that got rolled back.kuchhal@chromium.org2009-01-161-1/+8
| | | | | | Review URL: http://codereview.chromium.org/18164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8206 0039d316-1c4b-4281-b951-d872f2087c98
* This change list fix issues 6093 [settings] bad directionality for gears buttonxji@chromium.org2009-01-163-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | (http://crbug.com/6093). The directionality of gears button is already fixed. This CL fixes the wrong location of ":". It adds RLM at the end of string "Google Gears:" for Hebrew and Arabic Chrome, so that the ":" in "Google Gears:" in Hebrew is displayed leftmost instead of rightmost. Test: 1) open chrome, Hebrew UI 2) option -> under the hood -> google gears Without the fix, the name appears as "Google Gears:". With the fix, the name appears as ":Google Gears". Review URL: http://codereview.chromium.org/18279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8205 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 (webkit/glue side) of cleaning RenderThemeChromiumWin.darin@chromium.org2009-01-163-4/+4
| | | | | | | | R=macdome Review URL: http://codereview.chromium.org/18140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8203 0039d316-1c4b-4281-b951-d872f2087c98
* * Dump text/image on notifyDone.kuchhal@chromium.org2009-01-167-209/+139
| | | | | | | | | BUG=945322 Review URL: http://codereview.chromium.org/17459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8198 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselines the test fast/events/mouse-click-events.html. We need to ↵sky@google.com2009-01-162-8/+1
| | | | | | | | | | | | | | rebaseline this for two reasons: . We've turned on pan and scroll, which results in different middle mouse behavior. . we don't support an OTHER mouse button, resulting in different mouse events. BUG=none TEST=none Review URL: http://codereview.chromium.org/18157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8197 0039d316-1c4b-4281-b951-d872f2087c98
* Use Times, sans New Roman, for layout tests on Macmark@chromium.org2009-01-161-4/+6
| | | | | | Review URL: http://codereview.chromium.org/18163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include guards in tab_contents/* for the new location.brettw@chromium.org2009-01-1623-71/+71
| | | | | | Review URL: http://codereview.chromium.org/18160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8194 0039d316-1c4b-4281-b951-d872f2087c98
* adding more ported files from sconspinkerton@google.com2009-01-161-0/+8
| | | | | | Review URL: http://codereview.chromium.org/18159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8193 0039d316-1c4b-4281-b951-d872f2087c98
* remove chromium-linux baseline for editing/execCommand/19089.html. Thistc@google.com2009-01-161-2/+0
| | | | | | | | | | changed in r8113 where the font name changed from Times to 'times new roman'. We now match the windows results exactly. Review URL: http://codereview.chromium.org/18320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8192 0039d316-1c4b-4281-b951-d872f2087c98
* Going through the svg/w3c-svg-1.1 folder and rebaselining a bunch of test ↵finnur@google.com2009-01-16156-879/+1728
| | | | | | | | | | | (54 actually) that were either missing a baseline, had a wrong baseline or our code is now on par with the mac baseline, minus the usual differences such as font metrics, shading and such. Our code has gone through some slight changes in anti-aliasing/shadowing, and SVG curved lines are now drawn thicker (baseline has some lines too thin). There were also some font kerning changes made by Brett, which needed a rebaseline. I noticed after uploading that there is an extra newline in the text_fixable, which I have removed but didn't bother uploading the new patch. Review URL: http://codereview.chromium.org/18296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8191 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux webkit merge regressions to the test list.tc@google.com2009-01-161-1/+6
| | | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/18321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8190 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a crash when plugin messages are sent to dialogs.zork@google.com2009-01-163-0/+9
| | | | | | Review URL: http://codereview.chromium.org/18130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8189 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions required by the rest of the browser from RenderProcessHost to ↵brettw@chromium.org2009-01-1642-634/+733
| | | | | | | | an interface and move the implementation to BrowserRenderProcessHost. This will allow me to write render view unit tests without using the actual renderer, but there are no tests yet. Review URL: http://codereview.chromium.org/18132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8188 0039d316-1c4b-4281-b951-d872f2087c98
* remove libxslt_config.vcproj and add generate header scripttc@google.com2009-01-1612-221/+26
| | | | | | | | | | | | It turns out that config.h is not used on windows so we don't need to check it in. There's a libxslt/xsltconfig.h that is generated and used, but it's been checked into the tree since initial.commit. I also added a libxslt.vsprops to make updating include paths easier. Review URL: http://codereview.chromium.org/18121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8187 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8180.maruel@chromium.org2009-01-163-11/+1
| | | | | | Review URL: http://codereview.chromium.org/18319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8186 0039d316-1c4b-4281-b951-d872f2087c98
* mac bootstrapping of browser main and app startup bitspinkerton@google.com2009-01-1613-74/+673
| | | | | | Review URL: http://codereview.chromium.org/18112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8185 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable tests now that the WebKit patternskia fix is in. This rolls back ↵mmoss@google.com2009-01-161-6/+0
| | | | | | | | | the rollback from r8118. Review URL: http://codereview.chromium.org/18115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8184 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetSignonRealm a global function as opposed towtc@google.com2009-01-163-17/+13
| | | | | | | | | | | a static method of the LoginHandler class, which should remain an interface with only pure virtual methods. R=eroman Review URL: http://codereview.chromium.org/18106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when handling close tab accelerators. The class would still bebrettw@chromium.org2009-01-161-1/+11
| | | | | | | | | | accessed after the accelerator was handled, and close tab accelerators will cause the view to be deleted out from under us. BUG=6321 Review URL: http://codereview.chromium.org/18151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8182 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselines the testsky@google.com2009-01-164-1/+14
| | | | | | | | | | | | | | LayoutTests/fast/block/positioning/replaced-inside-fixed-top-bottom.html . Our results are different due to font size differences and differences in how we scale images. BUG=none TEST=none TBR=eroman Review URL: http://codereview.chromium.org/18316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8181 0039d316-1c4b-4281-b951-d872f2087c98
* Add thread safety checks but keep them disabled for now until I fix all the ↵maruel@chromium.org2009-01-163-1/+11
| | | | | | | | | | | current places where it triggers. Set back StoreRef as non-thread-safe. BUG5689 Review URL: http://codereview.chromium.org/18272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8180 0039d316-1c4b-4281-b951-d872f2087c98
* Removed a stray string.maruel@chromium.org2009-01-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8179 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the test SavePageTest.CleanFilenameFromPageTitle due to bug 6514.maruel@chromium.org2009-01-161-2/+3
| | | | | | Review URL: http://codereview.chromium.org/18154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8178 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 06:32:43 +0000