| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
perform their click actions when clicked. This is very rough, being committed
in an early form so more people can contribute to the effort.
Includes some early work from andybons too, toward making
popups work.
Known issues:
* Icons don't refresh properly when an extension is installed or removed.
Switching windows, then back again, updates the location bar properly.
* Right- and middle-clicks do nothing
* No tooltips, badges, installation previews, or popups yet
* No unit tests yet
BUG=12281
TEST=none yet
Review URL: http://codereview.chromium.org/427009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/481007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29737
TEST=green is my valley
TBR=dglazkov
Review URL: http://codereview.chromium.org/504004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Chromium on Chromium OS
BUG=30328
Review URL: http://codereview.chromium.org/503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29473
TEST=it passes
Review URL: http://codereview.chromium.org/486037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29737
TEST=still green?
Review URL: http://codereview.chromium.org/497011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add padding to throbber.
Fix merge and sync cutoff.
BUG=27770, 29767, 29788, 29782, 29647
TEST=manually checked all languages,
Review URL: http://codereview.chromium.org/460123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/507001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29709
TEST=none
Review URL: http://codereview.chromium.org/443013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure Alt is clear for our Ctrl+Shift/Shift+Ctrl logic so that Hebrew
IME generated Shift+Ctrl does not pass through and triggers RTL.
BUG=30244
TEST=Verify fix for 30244 and issue 24888 does not regress.
Review URL: http://codereview.chromium.org/497010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/24637
TEST=as in bug
Review URL: http://codereview.chromium.org/488018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust startup perf expectations on Linux after tcmalloc
was enabled.
BUG=none
TEST=linux startup perf test is green
Review URL: http://codereview.chromium.org/500001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionPopup::Show was hard coded to use BubbleBorder::TOP_RIGHT, by changing it to be dynamic that depends on UI Layout fixes this issue.
BUG=29807
TEST=Change chrome language to Arabic, install Sidewiki, the popup will position itself correctly.
Review URL: http://codereview.chromium.org/494008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Very similar to what we did with the extension shelf.
BUG=26990
Review URL: http://codereview.chromium.org/487021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The first patch was broken because a lot of stuff relied on the EXTENSION_PROCESS_CRASHED notification being sent when the extension hadn't actually "crashed". New fix: rename the notification to EXTENSION_PROCESS_TERMINATED, and don't send unload notifications during browser shutdown.
BUG=30057
Review URL: http://codereview.chromium.org/489009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove two server trips and two byte swizzles by keeping the tab image server side (instead of piping it through an SkBitmap). This creates noticeably better performance on drawing attached dragged tabs (i.e. when you drag a tab to reorder it, but don't drag out of the tab strip) on non-compositing WMs (I suspect it is better for compositing as well, but did not test it).
BUG=21657
TEST=see above
Review URL: http://codereview.chromium.org/496002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by thiago.farina@gmail.com ( original code review: http://codereview.chromium.org/469017 ).
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/486044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
install time.
Same as previous patch, except we now have a
BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in
ntp_resource_cache.cc.
BUG=24493,21121
TEST=All the new unit tests pass. All the complex theme startup tests go faster.
Previous Review URL: http://codereview.chromium.org/460050
Review URL: http://codereview.chromium.org/499004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bits system.
TEST=it links!
BUG=none
Review URL: http://codereview.chromium.org/496015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves 'UseReferenceBuild' from NewTabUIStartupTest
into UITest. Run multiple tab switching tests for
the current and reference build. Locate the debug log
based on the current browser directory. Reformat the
output of the test so we print "times" as our test
type instead of "tab_switch" (probably requires a perf
dashboard update).
BUG=25200
TEST=tab switching test also tests reference build
Review URL: http://codereview.chromium.org/491090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a mostly empty email to appear.
BUG=None
TEST=EmailThisPage should work for both native and web mail clients and ampersand in page title/user selection should not cause truncation.
Review URL: http://codereview.chromium.org/482011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing: http://codereview.chromium.org/479012/show
Fix by Roberto Peon.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/491088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/486046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as stable as on the mac now. Sharding the http tests on the mac
did *not* increase flakiness at all.
Also, update comment for a test in test_expectations.
Review URL: http://codereview.chromium.org/494010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SVG filters (r34460). Note that this only greens the WebKit valgrind bots; the main one will probably still be red.
BUG=30346
TEST=none
Review URL: http://codereview.chromium.org/494015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
TEST=none
BUG=30081
Review URL: http://codereview.chromium.org/496014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green please?
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jparent
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/491085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
scons build for chromium OS
TBR=davemoore
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/491086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode. This typically happens when the
initial logon redirects to an intermediate page which we try and abort in IE to ensure that Chrome follows the
redirect.
We try and abort the redirect in IE by returning E_ABORT from our IBindStatusCallback::OnProgress implementation
and also aborting the binding. However at times urlmon continues to follow the redirect and attempts to establish
a connection to the redirected url.
Fix is to check for a NULL binding in our IHttpNegotiate::BeginningTransaction implementation and abort the same.
Added traces in BeginningTransaction to indicate the same.
Bug=30203
Test=As described in the bug.
Review URL: http://codereview.chromium.org/487034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/491084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Old CL: http://codereview.chromium.org/449023
Review URL: http://codereview.chromium.org/488007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/496011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rebaselines.
BUG=29737
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34446
Review URL: http://codereview.chromium.org/491070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/499002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since Build 3442, this test has been causing an error "chrome: Fatal IO error 11 (Resource temporarily unavailable) on X server :9.0" on the "Chromium Linux (x64)" bot, and making the bot hang-up.
To investigate this hang-up, this change temporarily comments out this test on Linux.
TBR=levin
BUG=28445
TEST=none
Review URL: http://codereview.chromium.org/492031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When closing the tab, ResourceDispatcherHost::Receiver is deleted, so
all SocketStreamHost for the receiver should be deleted.
Add CancelRequestsForProcess() in SocketStreamDispatcherHost that deletes
all SocketStreamHost for the |host_id|.
BUG=30290
TEST=visit http://wbe02.mibbit.com/?debug=true&channel=%23websocket, and close the tab. Didn't crash the browser.
Review URL: http://codereview.chromium.org/494011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=MacUtilTest in base_unittest
Review URL: http://codereview.chromium.org/491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As far as we can tell, this isn't used by anything.
BUG=none
TEST=none
R=erikkay@chromium.org
Review URL: http://codereview.chromium.org/495007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: viettrungluu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: viettrungluu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=29737
TEST=none
Review URL: http://codereview.chromium.org/491070
TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/495015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rebaselines.
BUG=29737
TEST=none
Review URL: http://codereview.chromium.org/491070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unnecessary ones from FontLanguageSettingsController.
BUG=30155
TEST=Build with 10.6 SDK.
Review URL: http://codereview.chromium.org/496006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30123
TEST=Press Alt+D should not beep.
Review URL: http://codereview.chromium.org/487035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: viettrungluu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34435 0039d316-1c4b-4281-b951-d872f2087c98
|