| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[retry, fix windows compile failure]
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog.
BUG=11507
Review URL: http://codereview.chromium.org/141020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Dependency on gtest.
* Add intel\mt_lib\{P4_,}memset.obj as AdditionalDependencies.
* Update library directories.
* Make sure BasicRuntimeChecks=0 for both Debug and Release.
* The manifest now comes from the sources list,
not in AdditionalManifestFiles.
* AdditionalOptions to override the build/common.gypi defaults.
* GenerateMapFile
* Fix spelling errors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=no
Review URL: http://codereview.chromium.org/141018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG: 13287
Review URL: http://codereview.chromium.org/140033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14774
TEST=no
Review URL: http://codereview.chromium.org/140032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::map may copy an entry to a new address while resizing,
which invokes the destructor on the old entry and invalidates
its address.
R=eroman
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/141011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Resuscitate the TOOLKIT_VIEWS build by disabling stuff we don't build yet.
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14767
TEST=no
Review URL: http://codereview.chromium.org/140025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the Windows build.
BUG=None
TEST=None
TBR=ben
Review URL: http://codereview.chromium.org/140023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog.
Review URL: http://codereview.chromium.org/125148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds read-write to the client key of google_update
- Adds the logic to track experiment outcome
- Some new geric exitc codes (non error codes)
BUG= b/1484308
TEST= see the bug
Review URL: http://codereview.chromium.org/132058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
debug.
BUG=10055
TEST=no
Review URL: http://codereview.chromium.org/141009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the tab correctly.
BUG=14126
TEST=Use the "Create application shortcut..." menu to bring up the Gears dialog. Press tab, the focus should move around. Press ESC, the dialog should close.
Review URL: http://codereview.chromium.org/140001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk.
- Implements LoginPromptGtk. HTTP Auth now works under Linux.
- Renames ConstrainedWindowImpl to ConstrainedWindowWin
http://crbug.com/11512
Review URL: http://codereview.chromium.org/132047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Supress UMR in RSAPrivateKey::ExportPrivateKey(). From
what I can see, this really is a false positive. The
byte is 0xCD, at the exact place the error is reported
n Purify. Other supporting evidence is that it doesn't
always occur in the same place. Since we are generating
random keys, you'd expect to see the error show up
every so often wherever we are reading that memory.
* Remove supression of MOZ_Z_Deflate. Purify says this no
longer occurs. Not sure why.
Review URL: http://codereview.chromium.org/131097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark 2 tests as flaky (CRASH PASS) that have been failing on/off for the past week+ and remove 3 tests that have been unexpected passes for the last few days.
BUG=14752,14751,14207,10055,14014
TEST=no
Review URL: http://codereview.chromium.org/140012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the LASTCHANGE file (which doesn't actually use the value), which
was causing unnecessary rebuilds of resources and chrome.exe.
Change the output intermediate directory to
<(SHARED_INTERMEDIATE_DIR)/chrome so the on-disk location matches
the name of the changed target (app => chrome).
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/139007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more input and calling parent class forall.
http://crbug.com/14485
Review URL: http://codereview.chromium.org/141004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
two descriptions in hopes of helping the translators.
BUG=12442
TEST=none
Review URL: http://codereview.chromium.org/141001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- SavePageTest.SaveHTMLOnly
- SavePageTest.SaveCompleteHTML
- DownloadTest.UnknownSize
- DownloadTest.IncognitoDownload
BUG=14746,14755
TEST=no
Review URL: http://codereview.chromium.org/139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit f2f30e9d0108f4a776672c6b29d25ed3a8ad19ad.
Review URL: http://codereview.chromium.org/140013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for when to prepend a null byte to integers was
reversed. Fortunately, this had no impact on anything, because:
a) We ignore the null byte on the parse side because we know the
integers we're interested in are always unsigned.
b) It appears openssl does the same thing (I tried it both ways
and it always came up with the same private key data).
Still, better to be correct.
Also, re-enable previously disabled unit tests.
BUG=14640
Review URL: http://codereview.chromium.org/131095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Need to delay load FFmpeg dlls.
Review URL: http://codereview.chromium.org/131088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us a better citizen in OSX text-editing land and is a first step in getting our text entry story to work more natively on OSX.
The selectors are added at runtime to the Cocoa class and invoking them causes the appropriate WebKit core command to be invoked on the currently focused WebFrame.
As a side-effect bug 10862 is fixed.
BUG=10862
TEST=Open a new tab and type some text into an input element, change to a Hebrew keyboard layout and hit command-a, all text should be selected.
Review URL: http://codereview.chromium.org/114070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
friendly when running in purify.
Review URL: http://codereview.chromium.org/139004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r18850, as it had a compile failure.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
valgrind is very slow on the Mac.
BUG=none
TEST=Most/all of the UI tests should pass on the Mac when run under valgrind.
Review URL: http://codereview.chromium.org/140008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
try:-finally: so builds will work without forced upgrades to Python 2.5.
BUG=12818
TEST=successful build
Review URL: http://codereview.chromium.org/140005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=This is a UI test.
Review URL: http://codereview.chromium.org/131012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also notify other browser windows of changes to the order.
BUG=http://code.google.com/p/chromium/issues/detail?id=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest.*
Review URL: http://codereview.chromium.org/131114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Hood panel to be more like on windows and remove stuff that's not needed. Disable all prefs that aren't currently hooked up.
BUG=none
TEST=Prefs on first two panels haven't stopped working.
Review URL: http://codereview.chromium.org/140004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
catch the case when the user closes the last tab in a tabstrip. In this case, we add ourselves as a message loop observer and never get a chance to remove ourselves before the tabstrip is destroyed.
BUG=14648
TEST=Open a new window and press the close button on the tab. The browser should not crash.
Review URL: http://codereview.chromium.org/140006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows.
Create Schannel SSPI CredHandles with certificates for
SSL client authentication.
Remember the client certificates that the user selected
so that we don't ask the user again and again.
R=rvargas,eroman
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/131086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadRequestManager is the object that manages the number of downloads
that can occur in a given tab. It throttles non-user initiated downloads
to prevent carpet-bombing download attacks.
Enabling this object for Mac fixes the issue where we can only download
one file in a given tab.
BUG=None (mac work).
TEST=Can now download more than one item in a tab.
Review URL: http://codereview.chromium.org/132039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting turned on to prevent their dependencies from assuming they emit an
import libary. This implies that these two targets should be loadable_module,
rather than manually setting IgnoreImportLibrary.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/132080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18839 0039d316-1c4b-4281-b951-d872f2087c98
|