| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
All infobars consist of nothing but a non-functioning close button.
Review URL: http://codereview.chromium.org/62070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Modify run_webkit_tests to read test results from OS-specific results directories e.g. chromium-mac-leopard.
We still want to output new baselines to chromium-mac, so a bit of plumbing was needed to not use
the platform name directly to construct the output directory name but instead delegate to path_utils*.
Review URL: http://codereview.chromium.org/59006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
During stopping of the media pipeline in chrome, we
need to detach the filters from WebMediaPlayerDelegateImpl
so it doesn't hold renferences to the filters and filters
can be destructed by the pipeline.
Review URL: http://codereview.chromium.org/60113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
right as it's about to display a JS modal dialog.
I don't know how these would be triggered in the field. I ran into them through misuse of the current API (trying to pass in a NULL WebContents).
Review URL: http://codereview.chromium.org/62079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs).
AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model).
LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation.
---
I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc.
Review URL: http://codereview.chromium.org/50074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/63034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/63016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
We were bucketting all windows files into the "C:" bucket. :(
Review URL: http://codereview.chromium.org/62077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
since I don't think the Linux port supports those modes yet. I also ignored RTL. I've made some minor lint/style cleanups along the way.
BUG=9380
Review URL: http://codereview.chromium.org/60104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For memory calculation purposes, these are identical to their regular counterparts, but the YUV calculation should be done differently.
A jpeg uses full range 0 to 255, whereas mpeg uses 16 to 240.
Ignoring this distinction, means that jpeg will be slightly darker and brighter than it should be.
Since jpeg is not a focus for us, and other decoders do this the same way, I suggest we treat them as the same for now.
Review URL: http://codereview.chromium.org/62062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the bookmark bar only reads state on startup so to see this
work, you have to go to a page, click the star button (that isn't hooked up
yet either), and then restart chromium.
Review URL: http://codereview.chromium.org/60071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
keeping it in sync with the member var.
Review URL: http://codereview.chromium.org/62074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Old files will be removed once new unittests are committed.
Review URL: http://codereview.chromium.org/63023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OnContentsChanged on the controller.
BUG=None
TEST=
1) Navigate to google.com, copy the contents of the OmniBox (the URL) and paste it back into the OmniBox. The dropdown should appear.
2) Navigate to google.com, copy the word Privacy into the clipboard. Open the Find box, Paste into the Find bar. It should search. Close the Find bar. Reopen the Find bar. Paste again. It should search.
Review URL: http://codereview.chromium.org/63014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Try not to pass the entire drawing buffer through X and back -- instead,
just the region covered by the windowless plugin.
- Pass through some events (just hits a later NOTIMPLEMENTED()).
Review URL: http://codereview.chromium.org/56160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Clicking it a second time won't remove the bookmark; need to write the
infobubble next...)
Review URL: http://codereview.chromium.org/63020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data) types from WebKit API are allowed to be used in the browser process.
I added a big note about this to webkit_param_traits.h to explain the details
of this decision.
R=dglazkov
Review URL: http://codereview.chromium.org/62032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was accidentally chunking by lowest-level directory.
TBR to green tree.
Review URL: http://codereview.chromium.org/62068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
version in tab_strip_model.h. This fixes a bug where we didn't receive tab change messages from the model.
Review URL: http://codereview.chromium.org/63021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from m0.
BUG-9393
TEST=see bug
Review URL: http://codereview.chromium.org/62067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with the most tests first. This paves the way for running tests
in parallel.
This is the same as the previous reverted commit except it uses
os.sep instead of '/' to split the paths, and so works on
windows.
Review URL: http://codereview.chromium.org/63018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
text rendering is fixed.
TBR=deanm
Review URL: http://codereview.chromium.org/62066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r13165
Revert "Fix test running break. TBR."
This reverts commit r13169.
Review URL: http://codereview.chromium.org/63015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Suppress setenv() leak, coz it's intentional
- Get rid of unncessary default parameter (".") with --suppressions
Review URL: http://codereview.chromium.org/57069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/60110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures in test_expectations. They seem to be deterministic and
just a result of running the tests in a different order.
All the tests pass locally for me on Mac Debug for what that's worth.
Only code change from previous commit is to move the printing of the
test run timings earlier so that they don't clutter the useful test
output at the end.
Review URL: http://codereview.chromium.org/62023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in r12802.
Original CL: http://codereview.chromium.org/62054
Review URL: http://codereview.chromium.org/62063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
check is disabled from the options menu.
Issue=8589
Review URL: http://codereview.chromium.org/60097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/62059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia doesn't current support any form of text layout (ellipsizing, etc). We
use Pango / Cairo to draw our text on the surface. Also moved the non-flags
version of DrawStringInt into the share chrome_canvas.cc. Stubbed out the
SizeStringInt(), I haven't seen it used on Linux, and it would be wrong.
Review URL: http://codereview.chromium.org/62053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/63012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files, Chromium side.
R=jshin
BUG=9768
Review URL: http://codereview.chromium.org/60058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Establish 2 main scenarios for attach: 'attach to live' and 'start attached'
- Make WebFrameLoaderImpl call setMainFrameDocumentReady only for main frame document.
Review URL: http://codereview.chromium.org/62038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
handling classes (currently mixed).
All the messages except for the DebuggerCommand should go be dispatched on the Renderer thread by the DevToolsAgent.
DebuggerCommand should be handled by the DevToolsAgentFilter separately (for v8 suspend support).
Review URL: http://codereview.chromium.org/62037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The include guards should now match the file paths.
Review URL: http://codereview.chromium.org/62051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/42131
See bug for more info:
http://code.google.com/p/chromium/issues/detail?id=9578
Review URL: http://codereview.chromium.org/63007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Shouldn't muck with where other platforms put their output.
Review URL: http://codereview.chromium.org/63008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This crash occurs under the following conditions:
1. Launch Chrome and navigate to any web page
2. Save that page (via ctrl+s or menu option)
3. Click cancel in the Save As dialog box that appears
4. Save the page again
This fix checks to see if the SavePackage was initialized when
handling a stop operation, and skips it if nothing has started.
BUG=9738 (http://crbug.com/9738)
Review URL: http://codereview.chromium.org/62048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the bug is not there either.
Review URL: http://codereview.chromium.org/56033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in debug. I'm disabling these tests since they fail.
Bug: 9758
Review URL: http://codereview.chromium.org/62047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13142 0039d316-1c4b-4281-b951-d872f2087c98
|