| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648
Review URL: http://codereview.chromium.org/313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/313007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We expand it to $HOME or the appropriate /home/foobar.
BUG=18200
TEST=Extended the unit test with test cases.
Review URL: http://codereview.chromium.org/300026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/293050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running wine.
BUG=valgrind_210481, valgrind_205541
TEST=valgrind net_unittests --gtest_filter=ProxyResolverV8Test.LoadLog ; valgrind wine's unit tests and see no HEAP_CreateSubHeap valgrind warnings
Review URL: http://codereview.chromium.org/306020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running, the Chrome window was not activated.
BUG=19373
TEST=See bug
Review URL: http://codereview.chromium.org/308008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the main.py selenium test runner.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(r29315 was http://codereview.chromium.org/273063.) r29315 incorrectly changed the code for the Text Encoding menu entry to IDC_ENCODING_AUTO_DETECT (from IDC_ENCODING_MENU), which caused it to be incorrectly recognized as the auto detect menu item....
BUG=25397
TEST=Check the View->Text Encoding menu under various circumstances.
Review URL: http://codereview.chromium.org/292047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they can be highlighted / depressed independently.
Got alignment of buttons right.
Support hover and pushed in StatusAreaButton.
Share status area button code.
New icons for battery and wifi.
New images.
Review URL: http://codereview.chromium.org/300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html = CRASH
BUG:25399
Review URL: http://codereview.chromium.org/303020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:19546
Review URL: http://codereview.chromium.org/300038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmdoptleft meant cmdleft and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmdoptleft/right should switch tabs, cmdleft/right should move cursor in text box. Focus web background. cmdoptleft/right should switch tabs, cmdleft/right should do history navigation. Focus omnibox. cmdoptleft/right should still switch tabs, cmdleft/right should move cursor. cmd1/2 should switch tabs in all three places, cmdopt1/2 should not do anything.
Review URL: http://codereview.chromium.org/313004
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/306025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:25399
Review URL: http://codereview.chromium.org/293047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.
Review URL: http://codereview.chromium.org/313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:None, since there is already multiple similar stacks in this file.
TBR
Review URL: http://codereview.chromium.org/307019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change effectively reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=25491 and fixes http://crbug.com/16018 in a different way.
BUG=http://crbug.com/16018
BUG=http://crbug.com/21738
TEST=layout tests should still pass
Review URL: http://codereview.chromium.org/258035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25392
TBR=dank
Review URL: http://codereview.chromium.org/293046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions:
- registerURLSchemeAsLocal
- registerURLSchemeAsNoAccess
- whiteListAccessFromOrigin
- resetOriginAccessWhiteLists
BUG=24601
TEST=Compiled locally, try bot'ed.
Review URL: http://codereview.chromium.org/293021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/295019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/314001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25385
TBR=dank
Review URL: http://codereview.chromium.org/306024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see third_party/icu/source/common/umutex.c)
When two concurrent threads try to call umtx_lock(mutex) for an uninitialized mutex simultaneously, *mutex is read without taking any lock.
However, if *mutex is NULL, a DCLP inside umtx_init(mutex) guarantees that *mutex is initialized exactly once. Otherwise, if *mutex is already a valid pthread_mutex_t, the behavior of the program is not affected.
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=dank
Review URL: http://codereview.chromium.org/303019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unnecessary UTF-8 conversion when converting C strings to WebKit
Strings. Re-enabled WebGL in Dev Channel builds.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/308006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12881
TEST=none
Review URL: http://codereview.chromium.org/307017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=apavlov
Review URL: http://codereview.chromium.org/313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497,24756
TEST=LayoutTests/fast/websockets success
Review URL: http://codereview.chromium.org/243108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The heap checker will be linked with libtcmalloc by default.
This patch was prepared by Alexander Potapenko (cc'ed) and originally reviewed as http://codereview.chromium.org/307005
TBR=evan,bradn (already LGTMed at http://codereview.chromium.org/307005)
Review URL: http://codereview.chromium.org/292043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in-browser-process WebSocket protocol handler, which
will be used inWebSocket live experiment.
Change WebSocket::Delegate to WebSocketDelegate to avoid compile error on MSVC.
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/300035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25294,24214
TEST=DevToolsExtensionDebugTest.TestContentScriptIsPresent
Review URL: http://codereview.chromium.org/295020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=tree goes green
TBR=hclam
Review URL: http://codereview.chromium.org/294036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=yutak
Review URL: http://codereview.chromium.org/300034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/v8/issues/detail?id=475
TEST=none
Review URL: http://codereview.chromium.org/295021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused compile error on Modules XP and Vista.
TBR=tkent
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/312001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green trees
Review URL: http://codereview.chromium.org/294032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=G9798
TEST=tree stays green
TBR=hclam
Review URL: http://codereview.chromium.org/295038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in-browser-process WebSocket protocol handler, which
will be used in WebSocket live experiment.
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/304014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This roll should fix a valgrind error (issue 25297).
R=jamesr
BUG=25297
TEST=none
Review URL: http://codereview.chromium.org/292039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=tree stays green
TBR=hclam
Review URL: http://codereview.chromium.org/294033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/307016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497
TEST=none
Review URL: http://codereview.chromium.org/251087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13907
Review URL: http://codereview.chromium.org/300031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25378
TEST=none
TBR=awalker
Review URL: http://codereview.chromium.org/303016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OnKillFocus() is being called during destruction, and tries to access a render_widget_host_ which has already been NULLed.
BUG=25290, 24248
TBR=jcampan
Review URL: http://codereview.chromium.org/308014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24376
TEST=none
TBR=scherkus
Review URL: http://codereview.chromium.org/311002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=awalker
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
executable slide.
BUG=25372
TEST=green tree
Review URL: http://codereview.chromium.org/311001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It is not needed because r29591 was reverted.
TBR=awalker
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/306023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29603 0039d316-1c4b-4281-b951-d872f2087c98
|