summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Moves webview_impl.cc, webframe_impl.cc and webframeloaderclient_impl.cc intodarin@chromium.org2009-10-3049-6387/+6537
| | | | | | | | | | | | webkit/api/src. R=yaar BUG=25896,25897,25902 TEST=none Review URL: http://codereview.chromium.org/341030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30558 0039d316-1c4b-4281-b951-d872f2087c98
* Connect the various pieces for notifications... hook up ↵johnnyg@chromium.org2009-10-3011-12/+180
| | | | | | | | | | | NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView. BUG=none TEST=none Review URL: http://codereview.chromium.org/342043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30557 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the chrome thread object at the start of the ↵ananta@chromium.org2009-10-301-4/+4
| | | | | | | | | | | | | | | | CFUrlRequestUnittestRunner constructor. This causes a CHECK to fire in the extensions service initialization which happens when we initialize the profile. The CHECK was added in revision 30550. Given the spate of these test failures we should really speed up the process of moving the chrome frame builder to the main waterfall. TBR=tommi Review URL: http://codereview.chromium.org/346019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30556 0039d316-1c4b-4281-b951-d872f2087c98
* Add layoutTestController.counterValueForElementByIdhamaji@chromium.org2009-10-305-4/+39
| | | | | | | | | | | | | | Now we can test CSS counters with dumpAsText(). The corresponding upstream bug: https://bugs.webkit.org/show_bug.cgi?id=30555 BUG=none TEST=none Review URL: http://codereview.chromium.org/338056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30554 0039d316-1c4b-4281-b951-d872f2087c98
* LocalStorageLayoutTests are flakey on Linux as well.jam@chromium.org2009-10-301-5/+1
| | | | | | | | | BUG=24145 TBR=jorlow Review URL: http://codereview.chromium.org/344029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30553 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30551.ukai@chromium.org2009-10-302-48/+35
| | | | | | Review URL: http://codereview.chromium.org/342050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30552 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SocketStream to report error to the delegate.ukai@chromium.org2009-10-302-35/+48
| | | | | | | | | | | error status will be reported to the delegate (e.g. websocket experiment task) BUG=none TEST=none Review URL: http://codereview.chromium.org/346010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30551 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of MessageLoop* caching in extensions code.jam@chromium.org2009-10-3032-361/+315
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30550 0039d316-1c4b-4281-b951-d872f2087c98
* The newly added AboutChromeFrame test for IE full tab mode was failing on ↵ananta@chromium.org2009-10-304-14/+10
| | | | | | | | | | | | | | | | | | | the chrome frame builder which is an XP machine with IE8 (It was not supposed to return on IE8 :) The reason being that the VK_UP keyboard message we were passing in via SendInput needs the extended flag to be true. I added the extended flag as an argument to the SendVirtualKey helper function. On a related note, I removed the GetIEVersion check from the utility function which launches IE as a COM server as the IE version checking function checks the version of the current module and compares it against IE versions which is hilarious. In any case these tests work fine. TBR=amit Review URL: http://codereview.chromium.org/339076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30549 0039d316-1c4b-4281-b951-d872f2087c98
* Change the document root for the test Web Socket server to WebKit/LayoutTestsyuzo@chromium.org2009-10-302-12/+11
| | | | | | | | | | | | | | | from WebKit/LayoutTests/websocket/tests. This makes reusing scripts in WebKit/LayoutTests/fast/js/resources easier. For example, a test in WebKit/LayoutTests/websocket/tests/sample.html can include js-test-pre.js as ../../fast/js/resources/js-test-pre.js. TEST=none BUG=none Review URL: http://codereview.chromium.org/339019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30548 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement form resubmission warning dialogthakis@chromium.org2009-10-304-1/+154
| | | | | | | | | | | Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now. BUG=23526 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload. Review URL: http://codereview.chromium.org/327009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30547 0039d316-1c4b-4281-b951-d872f2087c98
* Based on the rest of the codebase, I think we're supposed to #include ↵pkasting@chromium.org2009-10-303-4/+3
| | | | | | | | | | chromium_strings rather than google_chrome_strings, although I doubt it would matter. BUG=none TEST=none Review URL: http://codereview.chromium.org/343050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30546 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the warm perf load test.chase@chromium.org2009-10-301-1/+1
| | | | | | | | | | | | This is an experiment to see the current status of the test. BUG=13921 TEST=warm perf load test is greenish Review URL: http://codereview.chromium.org/342045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30545 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux view build breakage.chocobo@google.com2009-10-301-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30544 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage.chocobo@google.com2009-10-301-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30543 0039d316-1c4b-4281-b951-d872f2087c98
* Disable form entry while sending credentials. tim@chromium.org2009-10-301-1/+6
| | | | | | | | | | | | BUG=19980 TEST=See the steps in the bug description. Patch by Randy Posynick<randy.posynick@gmail.com> http://codereview.chromium.org/287008 Review URL: http://codereview.chromium.org/339075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98
* Move chromeos code to namespace chromeos.chocobo@google.com2009-10-3051-192/+354
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash when a bookmark URL is an empty string tim@chromium.org2009-10-302-4/+6
| | | | | | | | | | | | BUG=19852 TEST=See repro steps of the bug Patch by Bruno Calvignac <BrunoCalvignac@gmail.com> Original CL http://codereview.chromium.org/282004 Review URL: http://codereview.chromium.org/342046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r30541 since it's still breaking browser_testsben@chromium.org2009-10-304-36/+40
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30539 0039d316-1c4b-4281-b951-d872f2087c98
* -. Rebaseline deletionUI-single-instance pixel result due to upstream ↵victorw@chromium.org2009-10-303-3/+2
| | | | | | | | | | | | | | change: http://trac.webkit.org/changeset/49641 -. Update bug number in test expectations R=japhet BUG=none TEST=none Review URL: http://codereview.chromium.org/343047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30538 0039d316-1c4b-4281-b951-d872f2087c98
* Security patches for ffmpegfbarchard@chromium.org2009-10-301-1/+1
| | | | | | | | | BUG=25275 TEST=play src\media\test\data\48_aac_infinite_loop.m4a and it should not hang. Review URL: http://codereview.chromium.org/343046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30537 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling gyp forward 2 changes.ajwong@chromium.org2009-10-291-1/+1
| | | | | | | | | | | Picks up making vs2008 projects by default, and adding a new variable into make/scons builds. BUG=22307 TEST=gyp try bots were green. Review URL: http://codereview.chromium.org/348016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30536 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist PDF Browser Plugin on Mac for now.stuartmorgan@chromium.org2009-10-291-7/+56
| | | | | | | | | | | Add more comprehensive whitelist/blacklist logic so that we can easily switch defaults. BUG=24918,26110 TEST=Install plugin, follow a link to a PDF; you should not get a page with nothing but a crash notification for the plugin. Review URL: http://codereview.chromium.org/342029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30535 0039d316-1c4b-4281-b951-d872f2087c98
* Change the extension.onRequest even to include the sender info.mpcomplete@chromium.org2009-10-295-39/+179
| | | | | | | | BUG=23865 Review URL: http://codereview.chromium.org/341025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30534 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in latest gyp (now defaults to vs2008 if present).bradnelson@chromium.org2009-10-291-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/342044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30533 0039d316-1c4b-4281-b951-d872f2087c98
* Unflaky tests.thakis@chromium.org2009-10-291-4/+2
| | | | | | | | | | | Since bug 24721 is fixed, these might work again. They don't show up on the flakiness dashboard, suggesting that they behaved for a while. BUG=24632,24889 TEST=Tests not super flaky Review URL: http://codereview.chromium.org/345024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30532 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way the FindBrowserWithProfile/Type methods work.ben@chromium.org2009-10-294-40/+36
| | | | | | | | | | | | | We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab. http://crbug.com/17498 TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first. Review URL: http://codereview.chromium.org/330013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30531 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CHECK() around the SharedMemory ftruncate() call to finger it as a ↵hawk@chromium.org2009-10-291-2/+4
| | | | | | | | | | crash culprit. BUG=16371 TEST=Check the crash logs to see if this CHECK() supplants the CHECK() failure in AsyncResourceHandler::OnWillRead() Review URL: http://codereview.chromium.org/347012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30530 0039d316-1c4b-4281-b951-d872f2087c98
* Make run_webkit_tests work on Windows 7. dpranke@google.com2009-10-294-13/+35
| | | | | | | | | | | | | | | | | We modify test_shell --check-sys-deps to allow Win 7, add a "chromium-win-7" port to platform_utils, a "WIN-7" port to test_expectations, and create an empty shell directory under webkit/data/layout_tests to make the regression scripts happy. The actual new baselines will follow in a separate CL. R=ojan@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/342033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30528 0039d316-1c4b-4281-b951-d872f2087c98
* Some new tab ui fixes.tony@chromium.org2009-10-292-9/+18
| | | | | | | | | | | | | | | | | | | 1) Always intialize the css cache. Previously we were only initializing if not in incognito mode. If the first NTP was an incognito page, it wouldn't be styled. 2) Small optimization in generating the HTML to avoid calling ReplaceFirstSubstringAfterOffset which would need to move the bytes after the placeholder. 3) Only generate the css for the incognito or normal mode. Since the NTP only needs one, we only need to generate one. BUG=26228 Review URL: http://codereview.chromium.org/344027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30527 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing test name (misspelled - Extensio8nL10n, should be ExtensionL10n).cira@chromium.org2009-10-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/346015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30526 0039d316-1c4b-4281-b951-d872f2087c98
* Make LoadLog refcounted-thread safe.eroman@chromium.org2009-10-292-10/+8
| | | | | | | | | | | | | | | | | | This also backs out r26610 (these are the changes to host_resolver_impl.cc), since that code is no longer necessary if LoadLog is refcounted thread safe. LoadLog itself is not thread safe -- however making its refcounting threadsafe simplifies passing it across thread boundaries. Initially I had avoided doing this, and instead was trying to be very careful in when callers would AddRef/Release to avoid races. This approach however turned out to be fragile, and it was difficult to chase down all of the dependencies (they just kept popping up). So now I am changing that decision, and opting for the simpler approach which will be much more robust. The performance impact should be negligable. BUG=22272 Review URL: http://codereview.chromium.org/347021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30525 0039d316-1c4b-4281-b951-d872f2087c98
* Add baseline for new test ↵japhet@chromium.org2009-10-296-3/+20
| | | | | | | | | | | LayoutTests/fast/overflow/position-fixed-transform-clipping.html BUG=22549 TEST=none Review URL: http://codereview.chromium.org/344028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30524 0039d316-1c4b-4281-b951-d872f2087c98
* Original discussion in CL for 337010. See ↵mrossetti@chromium.org2009-10-298-79/+342
| | | | | | | | | | | http://codereview.chromium.org/337010/show/. BUG=25099 TEST=See 337010. Review URL: http://codereview.chromium.org/343042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30523 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add back toolbar border.estade@chromium.org2009-10-292-1/+16
| | | | | | | | | BUG=26239 TEST=launch browser, look at border under toolbar, open findbar Review URL: http://codereview.chromium.org/339074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30522 0039d316-1c4b-4281-b951-d872f2087c98
* - Removes fallback from Prefs to LoadExtension on UI thread.cira@chromium.org2009-10-294-18/+76
| | | | | | | | | | - Fix extension_service_unittest to actually load extensions from prefs. BUG=19733 TEST=Remove extension manifest from Preferences file. Extension shouldn't load even if the necessary files are present. Review URL: http://codereview.chromium.org/339058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30521 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit tests for ChromeFrame IE full tab mode. These test the following ↵ananta@chromium.org2009-10-298-59/+390
| | | | | | | | | | | | | | | | | | | | | cases:- 1. A window.open call issued from a page within ChromeFrame in IE full tab mode makes it back to IE before being shunted into Chrome. 2. Brings up the chrome frame context menu in full tab mode and invokes the About Chrome frame option. While I was working on these tests based on a lot of help from Stoyan, we had these tests use gmock and I also changed the disallowed URL test to use gmock. The other changes are to always run the chrome frame tests in the STA apartment as the newly added full tab mode tests cannot handle calls coming in from background RPC worker threads. Bug=26066,26172 Review URL: http://codereview.chromium.org/340029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30520 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new SearchVersusNavigateClassifier in BrowserRootView. Patch by ↵pkasting@chromium.org2009-10-292-20/+14
| | | | | | | | | Thiago Farina (see http://codereview.chromium.org/347020 ), r=me, tweaked. BUG=21317 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30519 0039d316-1c4b-4281-b951-d872f2087c98
* A bit of polish for the extensions page.finnur@chromium.org2009-10-291-5/+5
| | | | | | | | | | | | | | Minor position changes to the CSS to make the page match the other pages better when flipping betwen the downloads, history and extensions page. BUG=http://crbug.com/26120 TEST=Flip between History and Downloads page and the icon and the header section should line up and be the same size on all three pages. Review URL: http://codereview.chromium.org/339073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30518 0039d316-1c4b-4281-b951-d872f2087c98
* Rename a variable to avoid shadowing.dpranke@google.com2009-10-291-3/+3
| | | | | | | | | | BUG=none TEST=none R=tony@chromium.org Review URL: http://codereview.chromium.org/341040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30517 0039d316-1c4b-4281-b951-d872f2087c98
* Adds default implementations to WebFrameClientyaar@chromium.org2009-10-294-139/+49
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=26068 Review URL: http://codereview.chromium.org/342024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30516 0039d316-1c4b-4281-b951-d872f2087c98
* Taking advantage of new configuration inheritance option.bradnelson@chromium.org2009-10-293-117/+47
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/342041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30515 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrioritizedIOBuffer to FlipIOBuffer, refactor it intombelshe@google.com2009-10-293-0/+74
| | | | | | | | | | | | | | | | | | | | | | its own file, and have it carry a FlipStream pointer. The PrioritizedIOBuffer was more generic, but after we queued IO, we couldn't track which stream should be notified about the IO completion. Having it carry the FlipStream pointer will enable IO tracking, but with a FlipStream pointer, it is really specific to Flip, so I renamed to FlipIOBuffer. I could have kept a generic (void*) pointer (or used a template), but that seemed unnecessary in this case. This CL just changes the refactoring. Will remove the PrioritizedIOBuffer next. BUG=none TEST=none Review URL: http://codereview.chromium.org/341032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30514 0039d316-1c4b-4281-b951-d872f2087c98
* Roll 4 revisions.ajwong@chromium.org2009-10-291-1/+1
| | | | | | | | | | | | | | Pickup: 731) -fPIC fix for scons generator 732) shared library fix for cross-compiling 734) support for configuration inheritance. BUG=300013 TEST=try server. Review URL: http://codereview.chromium.org/343043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30513 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the element_ member of FormField, as we don't use it and shouldn't be ↵jhawkins@chromium.org2009-10-295-43/+18
| | | | | | | | | | using WebCore internals in glue anyway. BUG=none TEST=none Review URL: http://codereview.chromium.org/342032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30512 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Improve look of about dialog.estade@chromium.org2009-10-291-38/+63
| | | | | | | | BUG=26173 Review URL: http://codereview.chromium.org/345022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30511 0039d316-1c4b-4281-b951-d872f2087c98
* Remove out of date comment.ben@chromium.org2009-10-291-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30509 0039d316-1c4b-4281-b951-d872f2087c98
* If we remove a search engine from our prepopulate data, remove it from the ↵pkasting@chromium.org2009-10-293-10/+77
| | | | | | | | | | user's list too if they haven't edited it or made it default. BUG=none TEST=Covered by unittest Review URL: http://codereview.chromium.org/339071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30508 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-enable a test I broke with the find bar changes I made last night.ben@chromium.org2009-10-297-16/+27
| | | | | | | | | | | Remove Browser::find_bar(), make everyone use either Browser::GetFindBarController() which creates the FindBarController on demand, or a new method HasFindBarController(), which can be used to check for its existence (so as to avoid creating it unnecessarily). http://crbug.com/26231 TEST=interactive ui tests, standard find tests Review URL: http://codereview.chromium.org/348015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30507 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in Event.hasListener().aa@chromium.org2009-10-291-1/+1
| | | | | | | | Patch from Kelly Norton <knorton@google.com> TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30506 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 22:42:12 +0000