| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Need to run the MessageLoop one time to run a task to delete the canceled ConnectingSocket.
Also reorder the test to help hide the minor race condition here.
Review URL: http://codereview.chromium.org/115455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=1852854,1852794
TBR=mal
TEST=1. Run CHrome with '--lang=kn' and '--lang=te' command line flags. In Page and App menu,
make sure that low-hanging glyphs are not clipped (see the screenshots attached
to b/1852854 and b/1852789) both on Vista and XP.
2. Kannada Chrome, UI menu font size are reasonably large both on Vista and XP.
Review URL: http://codereview.chromium.org/113513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle.""
This reverts commit c235c719f964cc8f7f9343177ae6d5af724be6c0.
Fixes a use of deleted memory by making a copy instead of keeping a reference to the deleted memory.
Review URL: http://codereview.chromium.org/113512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the current data souce implementation for media resource loading
assumes forward reading, when playing some badly muxed video files that
has out-of-order read patterns a memory leak is observed. Here's the reason:
1. The video file has out-of-order read pattern
2. A lot of BufferedResourceLoader is created and destroyed to accomodate
the seek requests that cannot be served by the buffer.
3. BufferedResourceLoader is not destroyed immediately when a new request
is made, it is destroyed when the request has completed (triggered by
cancelling the request).
4. Since request completion comes at a much lower rate than creation of
BufferedResourceLoader, a lot of BufferedResourceLoader are remain
alive and keep increasing, a leak is resulted.
Adhoc solution:
We can destroy all buffers in BufferedResourceLoader when it is called
to stop. This can greatly reduce the leak amount. Although a lot of
BufferedResourceLoader are still alive, they will be destroyed eventually
(since a request completion is received due to cancelling of the request).
A better solution would be to destroy the BufferedResourceLoader right away
after it is stopped and fix the leak in ResourceDispatcher so we don't need
to lengthen the lifetime of BufferedResourceLoader.
CL for fixing ResourceDispatcher:
http://codereview.chromium.org/115396
Review URL: http://codereview.chromium.org/115394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle."
Broke net_unittests on windows.
Review URL: http://codereview.chromium.org/113510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Provide a new api in ClientSocketPool and ClientSocketHandle for clients (notably HttpNetworkTransaction) to request connected sockets, rather than having to allocate and Connect() sockets themselves. Add a bunch of tests for it. Have not begun switching clients over to using this.
Review URL: http://codereview.chromium.org/99143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Adds messages on windows and makefile rule generate option.
Review URL: http://codereview.chromium.org/115450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgk
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Linux bustage.
Review URL: http://codereview.chromium.org/113507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=abarth
BUG=12105
TEST=0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of IPv6 literals appearing like "2001?4860?b005??84".
Patch by pmarks@google.com.
R=abarth
TEST=View about:dns on an IPv6 network and notice that the address render correctly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=0
TEST=FAIL
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only casualty is a new test, which we don't pass:
http://trac.webkit.org/changeset/43793
TBR=levin
BUG=0
TEST=no regressions on build bots.
Review URL: http://codereview.chromium.org/115447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/11387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default, but
we don't want to lose the test coverage for dynamic font support. So, we turn it on in test_shell.
TBR=darin
http://crbug.com/9633
TEST=The following two webkit tests pass:
LayoutTests/fast/css/font-face-remote.html
LayoutTests/fast/css/font-face-unicode-range.html
Review URL: http://codereview.chromium.org/115445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is now needed for the gyp generated projects that call out to cygwin.
Gyp generated stuff gets this automatically, but for now chrome.sln needs to
have it manually added.
Review URL: http://codereview.chromium.org/115444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(The webkit part is http://codereview.chromium.org/67209/show and
http://bugs.webkit.org/show_bug.cgi?id=25239 )
1. Adds '--enable-remote-fonts' command line switch
2. Adds a field ('enable_remote_fonts) to WebPreference
3. Pass the value of enable_remote_fonts to the corresponding field in WebCore::Settings (m_downloadableBinaryFontsEnabled)
BUG=9633
TEST: 1. Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts.
2. Even without the above flag, Chrome should should get 100/100, with no boxes in the upper right corner (still has the Linktest Failed error).
Review URL: http://codereview.chromium.org/67210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Otherwise you're assuming you have cygwin in order to set it up.
Review URL: http://codereview.chromium.org/113505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
BUG=9223
TBR=mirandac
Review URL: http://codereview.chromium.org/113504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Prevent the status bubble from getting pushed down below the screen.
BUG=4821
TEST=Open a page with a link in the bottom left corner, verify that the status bubble appears to the right. Verify that the status bubble appears in a normal position for all other links
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12038
TEST=Open the bookmark manager (Ctrl+Shift+B), them maximize it and verify that the titlebar is painted when active and inactive.
Review URL: http://codereview.chromium.org/113478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
layout test.
Remove a NOTIMPLEMENTED that was breaking layout tests.
TBR=estade
Review URL: http://codereview.chromium.org/113500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=arv
Review URL: http://codereview.chromium.org/115441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"image/x-ico" entry whereas the rest of the world uses "image/x-icon".
TBR=estade
Review URL: http://codereview.chromium.org/115440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The only change is to properly handle numeric overflow when compiling
count operations.
Review URL: http://codereview.chromium.org/113499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10049
Review URL: http://codereview.chromium.org/113168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension toolstrips and background pages can now retrieve a list of the other "views" (window objects) in their extension and script them directly
R=mpComplete
Review URL: http://codereview.chromium.org/115419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/115434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SimpleDataSource assumes the scheme is file or http and the
response code is 200. We should just check if the response
is successful using response.is_success() and verify the
content_length, which will be -1 in case of unspecified length.
Review URL: http://codereview.chromium.org/113422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in svn.webkit.org.
Review URL: http://codereview.chromium.org/115422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that IP addresses in certificate names are encoded
in binary form (octet strings -- 4 octets for IPv4 and
16 octets for IPv6).
R=eroman
http://crbug.com/12005
TEST=covered by current tests
Review URL: http://codereview.chromium.org/113438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior is ON by default. Using AI_ADDRCONFIG can
actually be harmful, as it causes getaddrinfo to fail
to resolve "localhost" when the computer is not
connected to a network.
R=eroman
http://crbug.com/5234
TEST=See bug 5234 for instructions
Review URL: http://codereview.chromium.org/115424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
generic (no hard-coded list of substitution variables, only use file
names specified from the command line). Update base.gyp with the to
generate file_version_info_linux.h with the new calling convention.
Review URL: http://codereview.chromium.org/113432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
out.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=arv
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation interface. This adds a method to turn on automation of
extension API functions, plumbing that redirects API requests
through the automation interface when appropriate, and a couple
of UITests that exercise the functionality.
See http://codereview.chromium.org/113277 for the original review.
Review URL: http://codereview.chromium.org/115427
Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16206 0039d316-1c4b-4281-b951-d872f2087c98
|