| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This is needed by plugins, as explained in the comment above the new code.
Review URL: http://codereview.chromium.org/20053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
launching UAC dialog on vista and hence making the tests fail. I am trying to figure out how to handle that case. Hence disabled the system level test for time being.
I have also modified GetRegistryKey method to have a out parameter and return bool. The previous could lead to a crash if the reg key value "pv" was not present.
Review URL: http://codereview.chromium.org/21054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also bring up ipc_sync_channel_unittest on OS X.
Review URL: http://codereview.chromium.org/21060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/22002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/transitions/transition-end-event-nested.html from
tests_fixable. I upstreamed some changes to timeout in this test that
should hopefully make is always pass. I prematurely turned this on
yesterday before we pulled down the change.
BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/21059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ExternalTabContainer class can control whether or not it's set.
Review URL: http://codereview.chromium.org/19768
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderWidgetHostManager from the scaffolding.
Review URL: http://codereview.chromium.org/20044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/21056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to platform-specific types in the implementation files and change variable names to match the header. Based on cl 8783 by Evan Martin.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We still crash when you navigate away from the page.
(PS: the plan is to unfork the _gtk.cc file once it gets closer to what we want, so you don't need to look at that too closely. I just wanted to check in what I have since it's getting big.)
Review URL: http://codereview.chromium.org/19413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/21052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For sure, we don't intend to support them on Linux/Win and perhaps it's a
good idea to be consistent although we can support them by building
platform/text/mac.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hierarchy in a window.
http://crbug.com/6260
Review URL: http://codereview.chromium.org/20051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
should be left to the text edit to proceed.
BUG=4874
Review URL: http://codereview.chromium.org/20046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added +media/audio to chrome/browser/DEPS.
Review URL: http://codereview.chromium.org/21053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in Hammer/chrome.
Now we crash in message loop code.
Review URL: http://codereview.chromium.org/21033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714
Note: this CL was previously committed and reverted because it broke the sandbox integration module.
Review URL: http://codereview.chromium.org/21032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AudioRendererHost provide service in browser process for AudioRenderer to access hardware in render process.
There will be one AudioRendererHost for every RenderProcessHost, each one of AudioRendererHost will service multiple AudioRenderer in the related render process.
The main functionality of AudioRendererHost is to group audio related services and provide access to AudioRenderer through IPC. It maps an internal stream id to the actual AudioOutputStream which most calls are delegated to.
AudioRendererHost::IPCAudioSource is to implement audio data source using IPC.
Review URL: http://codereview.chromium.org/21008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add entries for 8 Indian languages to grd files (<translations> section)
* Change the default spellcheck language for new languages to en-US for now. They'll be switched back to
the UI language when we have spell check dictionaries for them
* Add entries for 8 languages to installer's string offset table.
This change will go in after http://codereview.chromium.org/19545 goes in with DEPS file for ICU updated.
BUG=4473
Review URL: http://codereview.chromium.org/19761
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Get rid of forward-declared enums in render_view_host.h and unneeded headers in render_view_host_manager.h.
Review URL: http://codereview.chromium.org/21048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/6702
Review URL: http://codereview.chromium.org/20032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/editing/spelling/spelling-linebreak.html as it relies on
showing spelling errors, which we've decided to defer for now.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/20050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
associated with. This is wrong, its font should be independent of the edit field.
TEST=Open a page with a form that has an input field that uses a huge font. Bring up the autocomplete popup, the items should use a normal size font.
BUG=7372,6326
Review URL: http://codereview.chromium.org/20030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should work except for the Load calls that should load .pak files.
We don't generate .pak files yet so I left that code blank for now.
Mac doesn't compile this yet and is still figuring out how they want to handle
resources.
Review URL: http://codereview.chromium.org/21020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
included the fix for char-encoding.html.
fast/encoding/char-encoding.html should pass on all platforms.
fast/encoding/char-encoding-mac.html should be ignored on Linux and Windows.
Review URL: http://codereview.chromium.org/18700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9141.
TBR=jeremy
Review URL: http://codereview.chromium.org/21049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If IATPatchFunction::Unpatch fails during RestoreImportedFunction
it means that we cannot safely unpatch the import address table
patch. In this case its better to be hands off the intercept as
trying to unpatch again in the destructor of IATPatchFunction is
not going to be any safer.
In real world, when we patch a plugin's SetCursor, we intercept
npswf.dll's IAT entry of SetCursor. It seems that our unpatch
fails when the plugin ref count goes to 0. It could be because
some one else has patched on top of us. Then, during CRT
uninitialization at process shutdown, the destructor of
IATPatchFunction is called. It detects that we haven't unpatched
yet and tries to unpatch. But at this time the plugin DLL is
unloaded and the IAT thunk is invalid. There's no point in
trying to unpatch unloaded DLL's IAT :)
BUG=6886
Review URL: http://codereview.chromium.org/21044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
template_url_model_unittest isn't there; it requires a working database first.
Review URL: http://codereview.chromium.org/19714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
now.
See bug 5671
Review URL: http://codereview.chromium.org/21046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
make sure that we take another look if we fail it when they enable it
again.
Annotate test with description and bug number.
Review URL: http://codereview.chromium.org/21043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
specific to the JSC profiler and the current approach to profiling with V8 will not make these tests pass.
Review URL: http://codereview.chromium.org/21016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
do so after doing the reverse patch).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
flaky. I'll try to check them in again but in smaller chunks tomorrow.
TBR=mpcomplete
Review URL: http://codereview.chromium.org/21039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(fix from craig.schlenter@gmail.com)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I verified that this was broken before my changes by syncing to r9122.
Review URL: http://codereview.chromium.org/21036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
truncated from RightToLeft instead of LeftToRight.
(http://crbug.com/5926)
Basically, the issue is that in RTL locales, the thumbnail title etc. text will always be truncated from left, even if they are pure English. For example, "mail.yahoo.com" whose title is "Yahoo! the best web based email!" will be truncated to "best web-based email!".
We should be able to truncate the title as "Yahoo! the be...".
The fix is to set the direction style of each title in the [New Tab] html page for title to be displayed and truncated correctly.
The fix consists 2 part: new_tab_ui.cc in backend and new_tab.html in frontend.
1. new_tab_ui.cc
For thumbnail title, recent bookmark title, and recently closed tab titles, originally, we set "title" and "url" into the data we pass to JS in new_tab.html. The fix added the title's "direction" to the data. The direction is by default "ltr" and is set as "rtl" when there is character having strong directionality in the title.
2. new_tab.html
2.1 set text-alignment in thumbnail-title, bookmark container, and recently closed container to be "right" for RTL locales.
2.2 explicitly set title's directionality in the above 3 sections.
Test:
1. open Chrome in RTL locales.
2. open the following pages:
http://yahoo.com
http://gmail.com
http://mail.yahoo.com
http://wikipedia.com
http://msdn.microsoft.com/en-us/default.aspx
http://arabic.arabia.msn.com/default.aspx
http://he.wikipedia.org/
3. bookmark, close some of them.
4. open [New Tab]
Review URL: http://codereview.chromium.org/19738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mpcomplete
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9125 0039d316-1c4b-4281-b951-d872f2087c98
|