summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Only show the language restart warning once, and only if needed.glen@chromium.org2008-10-292-3/+10
| | | | | | | | BUG=2835 Review URL: http://codereview.chromium.org/8195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Save Page downloads not notifying their observers on completion.glen@chromium.org2008-10-291-0/+1
| | | | | | | | BUG=3417 Review URL: http://codereview.chromium.org/8804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage - remove reference to exported_sybmols file.jeremy@chromium.org2008-10-291-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4175 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary code instrumentation to gather info on a crash.ericroman@google.com2008-10-292-3/+32
| | | | | | | | | | | | The idea is to see where in DidReadResponseHeaders() things blow up (if at all). This hack adds a value at ebp+8 (parent's frame) which indicates where we were. TBR=wtc Review URL: http://codereview.chromium.org/8890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4174 0039d316-1c4b-4281-b951-d872f2087c98
* The SharedMemory is owned by the GreasemonkeyMaster, not the unit test. My ↵evanm@google.com2008-10-291-5/+5
| | | | | | | | | previous attempt at fixing the purify problem was overzealous; I just needed to fix the uninitialized boolean that my previous "fix" did. This change halfway-reverts to before that state. Review URL: http://codereview.chromium.org/8893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4172 0039d316-1c4b-4281-b951-d872f2087c98
* Add testing to main DEPSjeremy@chromium.org2008-10-291-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4170 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Add a new MULTIPROCESS_TEST_MAIN macro to store child process namesjeremy@chromium.org2008-10-2913-59/+134
| | | | | | | | | | | | | | in a lookup table. Previously we were using different mechanisms on each platform to look up child process names at runtime. This broke on OS X where we strip the symbol table on release executables. 2) Enable process_util_unittest on OS X. Review URL: http://codereview.chromium.org/8864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4165 0039d316-1c4b-4281-b951-d872f2087c98
* Free memory in unit test, so purify doesn't complain.evanm@google.com2008-10-292-5/+6
| | | | | | | Review URL: http://codereview.chromium.org/8405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4163 0039d316-1c4b-4281-b951-d872f2087c98
* remove svg tests from the "skip" list because they no longer timeoutpinkerton@google.com2008-10-291-5/+0
| | | | | | Review URL: http://codereview.chromium.org/8713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4162 0039d316-1c4b-4281-b951-d872f2087c98
* Added strings to support Spellchecker operations in the context menu.sidchat@google.com2008-10-291-0/+12
| | | | | | Review URL: http://codereview.chromium.org/8710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4160 0039d316-1c4b-4281-b951-d872f2087c98
* adjust for our "toolbar" when resizing the window and content area, as it is ↵pinkerton@google.com2008-10-291-2/+5
| | | | | | | | part of the content (it's not a real toolbar) Review URL: http://codereview.chromium.org/8711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4159 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot this file in CL 4153.bradnelson@google.com2008-10-291-1/+8
| | | | | | | It does weird things on buildbot without it. Review URL: http://codereview.chromium.org/8886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of tab related bugs:ben@chromium.org2008-10-293-0/+13
| | | | | | | | | | | | - moving the window while a tab is animating to its final resting position disembodies the tab - it's possible to make a tab disappear while clicking on another tab while a tab is animating to its final resting position http://crbug.com/2388 http://crbug.com/1142 Review URL: http://codereview.chromium.org/8689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4155 0039d316-1c4b-4281-b951-d872f2087c98
* Add command line option to suppress Chrome launch after successful installkuchhal@chromium.org2008-10-297-1066/+1090
| | | | | | | | BUG=1443250 Review URL: http://codereview.chromium.org/8644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4154 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in BuildComponents to allow things like Defer and publishing.bradnelson@google.com2008-10-292-146/+174
| | | | | | Review URL: http://codereview.chromium.org/8666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various Gears build breaks caused by latest Hammer changes.mpcomplete@google.com2008-10-295-35/+47
| | | | | | Review URL: http://codereview.chromium.org/7999 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4151 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executablekuchhal@chromium.org2008-10-291-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4147 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial patch: add whitespace to some SQL statements to turn "INSERT INTO ↵pkasting@chromium.org2008-10-295-15/+13
| | | | | | | | | foo(bar,baz)VALUES(?,?)" into "INSERT INTO foo (bar, baz) VALUES (?,?)" (which is the way we have it in most of our code). This was annoying me while I tried to track down cases where we omitted the appropriate fieldnames from our SQL statements. Review URL: http://codereview.chromium.org/8855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4145 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executable propertykuchhal@chromium.org2008-10-291-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4143 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executable propertykuchhal@chromium.org2008-10-293-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4142 0039d316-1c4b-4281-b951-d872f2087c98
* System includes need to use angle brackets for check_depsagl@chromium.org2008-10-291-1/+1
| | | | | | | | | TBR=tc Review URL: http://codereview.chromium.org/8706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4141 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to disable/enable Spell Check. In addition, remove additional ↵sidchat@google.com2008-10-2913-151/+132
| | | | | | | | | | code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter. Issue = 120 Review URL: http://codereview.chromium.org/7935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4140 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-only dependencies to deps_os['win'].maruel@chromium.org2008-10-291-9/+16
| | | | | | Review URL: http://codereview.chromium.org/8874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4138 0039d316-1c4b-4281-b951-d872f2087c98
* Start writing the GTK code for test_shell.agl@chromium.org2008-10-298-35/+233
| | | | | | | Review URL: http://codereview.chromium.org/8000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4136 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental change to help us diagnose a crashwtc@google.com2008-10-291-0/+1
| | | | | | | | | | | | | | in DoReadHeadersComplete. Add an unused state, STATE_UNUSED, at the old value of STATE_READ_HEADERS_COMPLETE (15 = 0xF) to see if that value has any significance in the crash. TBR=eroman BUG=3772 Review URL: http://codereview.chromium.org/8701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4133 0039d316-1c4b-4281-b951-d872f2087c98
* Add fieldnames to SQL statements for better forward-compatibility. Had we ↵pkasting@chromium.org2008-10-291-2/+8
| | | | | | | | | had this code in place already, I wouldn't have needed to rev the compatible version number in my upcoming database change >:( I checked the rest of our sourcebase's INSERT and SELECT statements, but these were the only ones that needed to have fieldnames added (in a few cases SELECT * was appropriate). Review URL: http://codereview.chromium.org/8684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4130 0039d316-1c4b-4281-b951-d872f2087c98
* Add --port and --root options to the command-line interface to allow runningpamg@google.com2008-10-291-7/+22
| | | | | | | | | | | this server for more general purposes than only layout tests. (In particular, I've found it helpful when testing perf plots.) BUG=none TEST=none Review URL: http://codereview.chromium.org/8668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4129 0039d316-1c4b-4281-b951-d872f2087c98
* Removed magic number for owner rights, avoid to call close(-1).brettw@google.com2008-10-291-2/+2
| | | | | | Patch committed for mendola@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4128 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a string that we'll need when importing bookmarks.sky@google.com2008-10-292-0/+6
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4124 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we would allow the user to spell check words intc@google.com2008-10-291-1/+4
| | | | | | | a readonly textarea. This triggered lots of asserts. Review URL: http://codereview.chromium.org/8860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4119 0039d316-1c4b-4281-b951-d872f2087c98
* When right clicking in a text area that is scrolled, the wrongtc@google.com2008-10-291-8/+19
| | | | | | | | | | | | | | | | | word is selected. This is because we use the wrong node when getting the selection. We want to use the shadow inner node, but the hit test result provided to the ContextMenu is not the shadow node. To work around this, we recompute the hit test result. BUG=613 TEST=Go to a page with a text area, add text until a scroll bar appears, scroll the text area and right click on a word. The word under the cursor should be highlighted. Review URL: http://codereview.chromium.org/8853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4118 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor memory leak.paulg@google.com2008-10-294-8/+6
| | | | | | | | | BUG=1340229 Review URL: http://codereview.chromium.org/8690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4117 0039d316-1c4b-4281-b951-d872f2087c98
* The "extra view" used by the DialogClientView must not be retrieved before ↵ben@chromium.org2008-10-292-8/+17
| | | | | | | | | the contents view has been attached to the view hierarchy. http://crbug.com/2751 Review URL: http://codereview.chromium.org/8681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4116 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the SelfDeletePluginInvokeInSynchronousMouseMove to interactive ui testsananta@chromium.org2008-10-2913-60/+310
| | | | | | | | | | | | | | | | | | | | | | | | | | as we need to simulate mousemoves here. ui tests run on machines which are locked, causing this test to fail. Moved the NPAPITester and NPAPIVisiblePluginTester classes to a common file npapi_test_helper.cc so it can be used from both tests. Relanding the SetCursor patch. It has already been approved by John. Description below:- Proposed fix for http://b/issue?id=1362948, which is a crash in the rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent. This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which returns NULL and hence the crash. The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed. Added a unit test which deletes the plugin instance in a mousemove event. R=jam Bug=1362948 Review URL: http://codereview.chromium.org/8691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4115 0039d316-1c4b-4281-b951-d872f2087c98
* Pass a user agent string to WinHttpOpen to set the userwtc@google.com2008-10-291-60/+61
| | | | | | | | | | | | | | | | | | | agent string on the session handle, which is the only way to specify the User-Agent header for HTTP CONNECT requests. This requires some refactoring. Most of the work done by Session::Init() is moved to the Session constructor. Session::Init() now only creates the primary session handle, and the call to Session::Init() is delayed to the first time we use the primary session handle (session_->internet()). R=darin BUG=552 Review URL: http://codereview.chromium.org/8841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4114 0039d316-1c4b-4281-b951-d872f2087c98
* Add some extra unit-tests to make sure we cover all permutations of ↵ericroman@google.com2008-10-292-0/+44
| | | | | | | | {basic_auth, digest_auth} x {empty_username, empty_password}. Review URL: http://codereview.chromium.org/8863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4113 0039d316-1c4b-4281-b951-d872f2087c98
* Timeout persistent idle connections after 5 minutes, and increase the socket ↵ericroman@google.com2008-10-292-30/+53
| | | | | | | | | cleanup timer from 5 seconds to 10 seconds. http://code.google.com/p/chromium/issues/detail?id=3574 Review URL: http://codereview.chromium.org/8124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4112 0039d316-1c4b-4281-b951-d872f2087c98
* Add an HTTP basic auth unit test for an empty username.wtc@google.com2008-10-281-0/+2
| | | | | | | | R=eroman BUG=297 Review URL: http://codereview.chromium.org/8859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4109 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply 4099, v8 build dir change (after manual buildbot cleaning).sgk@google.com2008-10-281-29/+27
| | | | | | Review URL: http://codereview.chromium.org/8688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4108 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4094; ui_tests failures in SelfDeletePluginInvokeInSynchronousMouseMove.sgk@google.com2008-10-286-131/+21
| | | | | | Review URL: http://codereview.chromium.org/8861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "expected, actual" order in cookie monster unittest (which was mostly ↵pkasting@chromium.org2008-10-281-110/+110
| | | | | | | | | "actual, expected"). This is a by-product of my in-progress cookie fixes. Review URL: http://codereview.chromium.org/8852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4106 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DEPS file to gears. This allows Gears developers to pull the gearsmpcomplete@google.com2008-10-281-0/+28
| | | | | | | | | | component directly, whose DEPS file then grabs the needed build stuff out of the Chrome tree. Since gclient only examines DEPS files at the root of solutions, this file has no effect on dependencies for Chrome developers. Review URL: http://codereview.chromium.org/8675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4105 0039d316-1c4b-4281-b951-d872f2087c98
* Change our phishing 'learn more' URL to something that will soon be translated.glen@chromium.org2008-10-2842-42/+42
| | | | | | | | BUG=2804 Review URL: http://codereview.chromium.org/8196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crbug.com/3684.tim@chromium.org2008-10-282-21/+25
| | | | | | | | | | | | | | | | Change 6053 involved making the PasswordManagerView's table model contain a vector of stack-allocated PasswordRow that owned a heap allocated PasswordForm, but std::vector creates temp PasswordRow's internally (on the stack) that were deleting the PasswordForm in their dtor. This accidental vector-internal delete caused subsequent operations on saved_signons_ to blow up. My fix is to make PasswordRows a vector of heap allocated PasswordRow instead, and have a STLElementDeleter member handle cleanup. Review URL: http://codereview.chromium.org/8651 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4099.sgk@google.com2008-10-281-27/+29
| | | | | | Review URL: http://codereview.chromium.org/8685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4100 0039d316-1c4b-4281-b951-d872f2087c98
* build/SConscript.v8 update, plus fixes:sgk@google.com2008-10-281-29/+27
| | | | | | | | | | | | | | | | * Use SCons -C to invoke the v8 build from our own build directory, using the -Y option to pull all source files from the v8 source directory, to avoid building things under src/v8. * Make sure the build directory exists before we invoke the subsidiary SCons that will chdir there. * Build libv8_snapshot.a in the obj/v8 directory, not src/build. * Remove the svn:ignore property from src/build (specifically libv8snapshot.a). * Correct the $LIBS_DIR location of libv8.a. * Use the actual file names involved instead of local Python variables. * Don't forcibly add our targets to other component's Aliases. Review URL: http://codereview.chromium.org/8851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4099 0039d316-1c4b-4281-b951-d872f2087c98
* Don't automatically deny subresource requests that have minorwtc@google.com2008-10-282-26/+43
| | | | | | | | | | | | | | | | certificate errors (ERR_CERT_NO_REVOCATION_MECHANISM and ERR_CERT_UNABLE_TO_CHECK_REVOCATION). This requires moving the code that automatically denies subresource requests into only the SSLPolicy subclasses that need it. To avoid duplicating that code in five classes, I added convenience methods for handling overridable certificate errors and fatal errors. R=jcampan,abarth Review URL: http://codereview.chromium.org/8085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4098 0039d316-1c4b-4281-b951-d872f2087c98
* Added a class with AutofillForm factory method.petersont@google.com2008-10-282-1/+76
| | | | | | Review URL: http://codereview.chromium.org/8402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4095 0039d316-1c4b-4281-b951-d872f2087c98
* Proposed fix for http://b/issue?id=1362948, which is a crash in the ↵ananta@chromium.org2008-10-286-21/+131
| | | | | | | | | | | | | | rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent. This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which returns NULL and hence the crash. The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed. Added a unit test which deletes the plugin instance in a mousemove event.R=jamBug=1362948 Review URL: http://codereview.chromium.org/8178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4094 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash when closing popups (issue 3631).finnur@google.com2008-10-281-5/+7
| | | | | | | | The Google Bookmarks bookmarklet opens a popup window that allows you to bookmark a page. When the window closes we crash because we dereference a NULL TabContents pointer the we get from GetSelectedTabContents(). This fixes that. Review URL: http://codereview.chromium.org/8185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4093 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-07 00:17:07 +0000