summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Added facility to stub log and check. It is still not ideal but workable.alokp@chromium.org2010-04-212-21/+11
| | | | | | Review URL: http://codereview.chromium.org/1697002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45192 0039d316-1c4b-4281-b951-d872f2087c98
* Client side code should include local logging so it can be stubbed out.alokp@chromium.org2010-04-212-7/+3
| | | | | | Review URL: http://codereview.chromium.org/1714001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45191 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the system to only close browser windows which currently are ↵dhg@chromium.org2010-04-212-10/+35
| | | | | | | | | | | pointed to by the filebrowser. BUG=chromium-os:2547 TEST=NONE Review URL: http://codereview.chromium.org/1690001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45190 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/1610030/show from Luigi:sky@chromium.org2010-04-218-261/+157
| | | | | | | | | | | | | | | | | | This changes makes histograms dynamically defined by external metrics clients, instead of hardcoding them in Chrome source. This is important because making even simple changes to Chrome is laborious and takes a fair amount of learning. Unfortunately user actions still require code in Chrome, because of a pre-processing script that extracts them from the source. BUG=NONE TEST=the included unit test Review URL: http://codereview.chromium.org/1718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45189 0039d316-1c4b-4281-b951-d872f2087c98
* Roll out V8 2.2.4.2, with a bugfix for 42137mnaganov@chromium.org2010-04-211-1/+1
| | | | | | | | BUG=42137 Review URL: http://codereview.chromium.org/1728003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45187 0039d316-1c4b-4281-b951-d872f2087c98
* Rename OnBlockedContentChange to OnContentSettingsChange.bulach@chromium.org2010-04-214-8/+7
| | | | | | | | | | | BUG=None TEST=compiles (Patch from Thiago Farina <thiago.farina@gmail.com> http://codereview.chromium.org/1664003/show) Review URL: http://codereview.chromium.org/1750002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45186 0039d316-1c4b-4281-b951-d872f2087c98
* Update v8 revision in DEPS to latest trunk versionricow@chromium.org2010-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45185 0039d316-1c4b-4281-b951-d872f2087c98
* Increase sleep timeout for valgrind UI tests.bauerb@chromium.org2010-04-211-0/+1
| | | | | | | | | | | | | DownloadTest.CloseNewTab2 is failing (ASSERT failure, not memory leak) under valgrind because of a timeout. This patch increases the sleep timeout for UI tests to the same value as the action timeout (when running the test normally, the default value for the sleep timeout is also the action timeout). BUG=none TEST=DownloadTest.CloseNewTab2 (run under valgrind) Review URL: http://codereview.chromium.org/1725003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45183 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore base/thread_local_storage, not just _posix (ThreadSanitizer)timurrrr@chromium.org2010-04-211-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45182 0039d316-1c4b-4281-b951-d872f2087c98
* Run DiskCache tests under TSan on Wintimurrrr@chromium.org2010-04-211-4/+0
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1746003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45180 0039d316-1c4b-4281-b951-d872f2087c98
* Run more base_ tests under TSan/Wintimurrrr@chromium.org2010-04-211-7/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1757001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45177 0039d316-1c4b-4281-b951-d872f2087c98
* Supresses valgrind tests related to AutoFillProfilebulach@chromium.org2010-04-211-0/+52
| | | | | | | | BUG=42185 Review URL: http://codereview.chromium.org/1756001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45176 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 383.0 to 384.0chrome-release@google.com2010-04-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45174 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation details of 1596023 (UI Language switch implemented).glotov@google.com2010-04-2112-116/+72
| | | | | | | | | | | | | DEPENDS_ON=1648004 (http://codereview.chromium.org/1648004/show) DEPENDS_ON=1596023 (http://codereview.chromium.org/1596023/show) DEPENDS_ON=1568033 (http://codereview.chromium.org/1568033/show) BUG=none TEST=none Review URL: http://codereview.chromium.org/1551029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45172 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 57959 (from 57955)yuzo@chromium.org2010-04-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jamser Review URL: http://codereview.chromium.org/1719004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45170 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error in ShownSectionsHandlerTest.bauerb@chromium.org2010-04-211-1/+1
| | | | | | | | TBR=bauerb Review URL: http://codereview.chromium.org/1716002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45169 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45028: Factor out reading and writing of preferences into |PrefStore|.bauerb@chromium.org2010-04-2127-314/+519
| | | | | | | | | | | | | In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45168 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare to move an InitWebCoreSystemInterface() call intkent@google.com2010-04-212-0/+9
| | | | | | | | | | | third_party/WebKit/WebKitTools/DumpRenderTree/chromium/DumpRenderTree.cpp to webkit_support. BUG=none TEST=none Review URL: http://codereview.chromium.org/1688003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45167 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 57955 from 57952.yuzo@chromium.org2010-04-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jamser Review URL: http://codereview.chromium.org/1753001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45166 0039d316-1c4b-4281-b951-d872f2087c98
* Fix arm compile after turning on gcc warnings.tony@chromium.org2010-04-212-2/+2
| | | | | | | | | | Actually fix a comment that was pointed out during review. TBR=rolandsteiner Review URL: http://codereview.chromium.org/1734003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45165 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DRT build on Windows.tony@chromium.org2010-04-215-10/+58
| | | | | | | | The main fix is to stub out default_plugin when building upstream. Review URL: http://codereview.chromium.org/1658012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45160 0039d316-1c4b-4281-b951-d872f2087c98
* Close a newly opened (by cmd-clicking on a link) tab if it resulted in a ↵bauerb@chromium.org2010-04-2113-5/+236
| | | | | | | | | | | | | | | | download. To test this, the CL adds an automation message AutomationMsg_NavigateAsyncWithDisposition, and a method NavigateToURLAsyncWithDisposition to TabProxy. The only functional change is in TabContents::OnStartDownload, the rest of the changes is for testing. BUG=10764 TEST=DownloadTest.CloseNewTab Manual test: go to http://build.chromium.org/buildbot/continuous/mac/LATEST/, open the link "chrome-mac.zip" in a new tab. The tab should close as soon as the download starts. Review URL: http://codereview.chromium.org/1151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45158 0039d316-1c4b-4281-b951-d872f2087c98
* Enable -Werror on Linux and Win for src/webkit/tony@chromium.org2010-04-216-13/+10
| | | | | | | | BUG=21140 Review URL: http://codereview.chromium.org/1749001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45157 0039d316-1c4b-4281-b951-d872f2087c98
* Don't process the same address for websocket throttling.ukai@chromium.org2010-04-212-0/+41
| | | | | | | | | | | | | | Host resolver might return address list that contains the same address twice or more. In this case, we should not process the address for websocket throttling multiple times. If we don't have duplicate check of address, it would put the job throttle by the job itself (deadlock). I think this is cause of failure in Linux perf (webkit.org) bot and websocket fail to connect localhost on ubuntu (crbug.com/36652) BUG=36652,41319,40995 TEST=none Review URL: http://codereview.chromium.org/1750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45156 0039d316-1c4b-4281-b951-d872f2087c98
* Change input method hot-keys.yusukes@google.com2010-04-211-2/+2
| | | | | | | | | | | | | | | - Remove Shift+space following alcor's offline suggestion. He said we should not use the key combination since it will be used if the user holds down shift while TYPING A STRING. - Add Shift+Alt. The combination seems to be popular at least in Windows: http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts (see the "Toggle between installed keyboard languages" part.) Let's ship R7 with "Alt+`" and "Shift+Alt" and then get feedback from users. BUG=crosbug.com/492 TEST=manual Review URL: http://codereview.chromium.org/1568041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45155 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to r57952.yuzo@chromium.org2010-04-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jamesr Review URL: http://codereview.chromium.org/1734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45154 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the language menu button when no text input area is focused.yusukes@google.com2010-04-215-22/+69
| | | | | | | | | BUG=crosbug.com/2639 TEST=ran browser_tests Review URL: http://codereview.chromium.org/1645012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45153 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45151 - UI review followup for m5 bookmark bar deliverablesjrg@chromium.org2010-04-2111-1727/+55
| | | | | | | | | | | | | | | | | | | Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leakthru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1731001 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/1727004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45152 0039d316-1c4b-4281-b951-d872f2087c98
* UI review follow-up for m5 bookmark bar deliverablesjrg@chromium.org2010-04-2111-55/+1727
| | | | | | | | | | | | | | | | Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1731001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark manager dropping codefeldstein@chromium.org2010-04-211-2/+6
| | | | | | | | | | | | | | | | | | | | Right now whenever you drag bookmarks into the bookmark manager, the extension code tells it there is new dragData via bookmarkManager.onDragEnter. This data sticks around and is never cleared for various reasons, and when you drop random text onto "Other bookmarks" the JS thinks it has valid drag data, but the data in the actual dragging clipboard is invalid. This just checks for that and bails early. The reason onDragEnded is never called is because we call preventDefault during onDragStart. Fixing this won't be sufficient because the JS dragdata will still be populated if you drag in from an external app. BUG=41087 TEST=See bug for repro steps. Review URL: http://codereview.chromium.org/1717003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45147 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Add a simple heuristic to match fax fields.jhawkins@chromium.org2010-04-219-7/+126
| | | | | | | | | BUG=40062 TEST=FaxFieldTest Review URL: http://codereview.chromium.org/1706005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45146 0039d316-1c4b-4281-b951-d872f2087c98
* Use new APIs in candidate_window.ccsatorux@chromium.org2010-04-211-41/+45
| | | | | | | | BUG=crosbug.com/2717 Review URL: http://codereview.chromium.org/1551040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45144 0039d316-1c4b-4281-b951-d872f2087c98
* Incremental progress toward archive loading in o3d-webgl. Implementedkbr@google.com2010-04-2112-19/+1046
| | | | | | | | | | | | | | | | | | | | | ArchiveRequest, which expects to be pointed to the top-level scene.json, and which emulates the behavior of the O3D plugin by downloading the referenced resources and creating RawData objects for each. Pulled in public domain JSON parser from http://www.json.org/ . Implemented portions of TextureCUBE. Fixed some unimplemented functionality and a few bugs related to creation of parameters. At this point a larger refactoring of o3d-webgl is needed to make the deserialization work properly, so this code is being checked in as a checkpoint. Also fixed small bug in the cg_to_glsl converter script. BUG=none TEST=none TBR=petersont,amarinichev Review URL: http://codereview.chromium.org/1745002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45143 0039d316-1c4b-4281-b951-d872f2087c98
* file_util.h won't compile if UNIT_TEST and OS_WIN are defined.yuzo@chromium.org2010-04-211-1/+2
| | | | | | | | | | | src\base/file_util.h(524) : error C2664: 'GetNamedSecurityInfoW' : cannot convert parameter 1 from 'const wchar_t *' to 'LPWSTR' BUG=none TEST=none Review URL: http://codereview.chromium.org/1582040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45142 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager sorting:estade@chromium.org2010-04-216-44/+65
| | | | | | | | | | | | | | - remove dead code that papered over the fact certain columns don't sort, replace with NOTREACHED pothole - allow sorting by the javascript memory column. - allow sorting by goats teleported (useful for debugging) - stabilize \# of goats teleported (remove observer effect) BUG=42037 TEST=sort by these columns in the task manager Review URL: http://codereview.chromium.org/1706002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45139 0039d316-1c4b-4281-b951-d872f2087c98
* revert crazy_filenamesnirnimesh@chromium.org2010-04-219-8/+69
| | | | | | Review URL: http://codereview.chromium.org/1742001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45137 0039d316-1c4b-4281-b951-d872f2087c98
* Put apps in app tab when launched from NTP or launcher.aa@chromium.org2010-04-213-6/+15
| | | | | | | | Also add some space between apps. Review URL: http://codereview.chromium.org/1744001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45133 0039d316-1c4b-4281-b951-d872f2087c98
* Some GL drivers incorrectly return "gl_DepthRange.far" asgman@chromium.org2010-04-216-50/+143
| | | | | | | | | | | | | a uniform when querying the uniforms. This CL checks for that condition and hides that from the client programs. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/1700002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45131 0039d316-1c4b-4281-b951-d872f2087c98
* Check for proper locale before recording search engine data, or offering the ↵mirandac@chromium.org2010-04-213-2/+24
| | | | | | | | | | | search engine experimental dialog. BUG= 37564 TEST= none Review URL: http://codereview.chromium.org/1709003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45129 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_expectations.txt typo committed in r45125.scherkus@chromium.org2010-04-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45128 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent accelerated Mac plugin frame changes from being animatedstuartmorgan@chromium.org2010-04-201-1/+5
| | | | | | | | | BUG=42093 TEST=Open a Core Animation plugin in one tab, and the NTP (with floating bookmark bar) in another. Change back and forth. The plugin should not animate to the correct location. Review URL: http://codereview.chromium.org/1729002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45126 0039d316-1c4b-4281-b951-d872f2087c98
* Updating test_expectations.txt overrides for media tests.scherkus@chromium.org2010-04-201-16/+3
| | | | | | | | | | | | The new baselines have been trickling in from WebKit, removing the need to override the expectations. BUG=19113 TEST=webkit tests remain green TBR=fbarchard, sergeyu Review URL: http://codereview.chromium.org/1706004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45125 0039d316-1c4b-4281-b951-d872f2087c98
* Issues with video loopinghclam@chromium.org2010-04-2011-23/+46
| | | | | | | | | | | | | | | | | Some video streams are badly muxed and have video packets with timestamps greater than the duration. This causes the logic in the video renderer to sleep forever and never read the end-of-stream packet and thus the stream is never ended. This change adjusted the condition on when we should sleep and handle timestamp greater than duration as a special case. TEST=video loops BUG=41579 Review URL: http://codereview.chromium.org/1652011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45124 0039d316-1c4b-4281-b951-d872f2087c98
* [chromium os] Uses login notification to log uptime of login successcmasone@google.com2010-04-205-12/+61
| | | | | | | | | | Landing http://codereview.chromium.org/1701002/show for sosa@chromium.org Moves the emission of the event indicating that login has succeded to a time before we've mounted teh user's encrypted home directory, and also touches a file on disk to indicate that this has occurred. Review URL: http://codereview.chromium.org/1713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45123 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the old Java Deployment plugin if a newer one (with a different ↵jabdelmalek@google.com2010-04-201-3/+20
| | | | | | | | name) exists. Review URL: http://codereview.chromium.org/1672004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45122 0039d316-1c4b-4281-b951-d872f2087c98
* Add remembered networks. Reworked network options UI.chocobo@chromium.org2010-04-209-322/+555
| | | | | | | | BUG=chromium-os:2555 TEST=none Review URL: http://codereview.chromium.org/1662004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45119 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame with the moniker patch enabled we should not process optin ↵ananta@chromium.org2010-04-205-16/+25
| | | | | | | | | | | | urls in the BHO. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42155 Bug=42155 Review URL: http://codereview.chromium.org/1706003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45117 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame with the IMoniker patch on, we should save away the redirect ↵ananta@chromium.org2010-04-204-19/+55
| | | | | | | | | | | | | | | | information received for the initial pending request. This is to ensure that we inform Chrome about this redirect which can then be followed correctly from Chrome. The other change is to save away the URL being navigated to in the bind context context object. This is also updated if we receive a redirect notification in our callback wrapper. The active document refers this URL if it is available and falls back to the old mechanism of retrieving the URL from the moniker if not. This ensures that optin urls continue to work correctly if the initial page is redirected. Review URL: http://codereview.chromium.org/1523028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when closing incognito window with extensionfeldstein@chromium.org2010-04-202-20/+34
| | | | | | | | | | | | | | The extension_context_menu_controller was removing the pref observer in its dealloc method, but since incognito windows have their profile destroyed when the window is closed this would crash the browser when we try to access it. Now it is accessed during the browser_closed notification BUG=41025 TEST=See bug Review URL: http://codereview.chromium.org/1619030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45112 0039d316-1c4b-4281-b951-d872f2087c98
* Changes made to TalkMediator so that its functionality is generic (non ↵sanjeevr@google.com2010-04-2017-78/+244
| | | | | | | | | | | sync-specific) and can be used by other services needing XMPP notifications. This is in preparatoion of moving these set of classes to common. BUG=None TEST=Test Bookmarks sync. The sync unit-tests have been modified accordingly. Review URL: http://codereview.chromium.org/1650009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45111 0039d316-1c4b-4281-b951-d872f2087c98