| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make the incognito badge appear in fullscreen mode.
2. Make the new tab button not run into the incognito badge.
BUG=37574, 37745
TEST=Make an incognito window and go to fullscreen mode; incognito badge should be visible in upper right. Make an incognito window with lots of tabs; new tab button (and tabs) shouldn't run into the badge; resize the window and make sure the badge stays in the right place.
Review URL: http://codereview.chromium.org/691003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NIB change: Added checkbox for pref into web content section of "Under the Hood" and moved other controls down to match.
BUG=37527
TEST=navigate to www.google.co.il using a branded build translate infobar should appear/not appear based on pref.
Review URL: http://codereview.chromium.org/722004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35248
DEPENDS=668067, 668068
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-name=nework
Review URL: http://codereview.chromium.org/661475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderThread::RoutingIDForCurrentContext() whenever possible. In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message. Lastly, make sure that we don't crash in the event
that we can't determine the routing id.
WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758
(Landing again after reverting in 40922)
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/671001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
wrap issue.
This CL depends on CL 661364.
BUG=37293 With RTL UI, items in download shelf can't be hidden correctly when shrinking the browser window.
BUG=37392 Chinese dangerous warning message of download items overflows its boundary.
TEST=See bug report.
Review URL: http://codereview.chromium.org/668053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Beginning Translate".
A complete layout is now done on each state transition, since we can't rely on always being instantiated in the "Beginning translation" state.
This CL also updates the code to pickup changes made on the Windows side, most notable the infobar now no longer updates the model state explicitly.
Quoting from Kuan's fix on the Windows side:
"""
problem happened because infobars are destructed when switching between tabs, only the delegates persist. without the infobar to receive the PAGE_TRANSLATED notification to update the translate state, the infobar gets stuck at translating state when user switches back to the associated tab.
"""
BUG=36895
TEST=See bug description.
Review URL: http://codereview.chromium.org/668241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPAPITester.ManyPlugins.
Make sure that the copied plugin gets deleted, and do it after
the browser has exited.
TEST=less flaky
BUG=28372
Review URL: http://codereview.chromium.org/668255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/660087
Prevents extra layouts and setting window size.
BUG=37533
TEST=Difference perf regression should be fixed, see perf monitor here http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150&rev=-1
Review URL: http://codereview.chromium.org/669238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prompt.
Also, LocalStorage.setItem needs to reset the CookieMessageFilter's
pump_messages_event after it is done with sending its IPC.
To support both of these fixes, the contents of RendererWebCookieJarImpl's
SendSynchronousMessage is merged into RenderThread::Send.
R=jam
BUG=37571
TEST=none
Review URL: http://codereview.chromium.org/669224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For instance, we'll show "Japanese" instead of "Anthy".
Depends on http://codereview.chromium.org/652106
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/652222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
it fails on the builder. This needs to be
debugged.
Bug=37746
Review URL: http://codereview.chromium.org/692002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just move the code. No logic is changed.
This is the first step towards implmenting the input language settings.
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/668061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=bots
BUG=none
Review URL: http://codereview.chromium.org/672018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures. Will watch the build
after I commit.
Revert 40994 - Revert "Launching Chrome with a userdatadir command line switch containing a non ASCII ..."
Speculative revert to try to fix win dbg MultipartResponseUITest.SingleVisit failures.
This reverts commit r40981
TBR=tony
Review URL: http://codereview.chromium.org/707001
TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/712001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/700001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
breaks dependencies on chrome from webkit, app, views
and base.
BUG=37649
TEST=compiles
Review URL: http://codereview.chromium.org/699001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1727
TEST=see the bug
Review URL: http://codereview.chromium.org/669265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36165
TEST=The screen reader JAWS should speak the checked state of a check box when it is toggled.
Review URL: http://codereview.chromium.org/693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
possibilities
BUG=8737
TEST=Check 'Ask where to save each file before downloading' true in the 'Under the Hood' preference and start a download. A temporary file org.chromium.XXXXXX or com.google.chrome.XXXXXX should appear in the user's download directory (e.g. ~/Downloads). After selecting the final destination file the temporary file should go away (and be renamed to the final name).
Review URL: http://codereview.chromium.org/672020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a non ASCII ..."
Speculative revert to try to fix win dbg MultipartResponseUITest.SingleVisit failures.
This reverts commit r40981
TBR=tony
Review URL: http://codereview.chromium.org/707001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18119
TEST=Export some certs, compare files with exports from firefox.
Review URL: http://codereview.chromium.org/669137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type.
* Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF.
TBR=evanm
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
src/app shouldn't depend on src/chrome and I need to break these
dependencies for some upstreaming work.
Review URL: http://codereview.chromium.org/668249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/668219
BUG=27927
TEST=none
Review URL: http://codereview.chromium.org/692001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37727
TEST=tools/valgrind/chrome_tests.sh -t test_shell --gtest_filter=BMPImageDecoderTest.DecodingFast:ICOImageDecoderTest.Decoding:ICOImageDecoderTest.ImageNonZeroFrameIndex
Review URL: http://codereview.chromium.org/690001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=greens the tree
TBR=tony
Review URL: http://codereview.chromium.org/689003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASCII character in the
path like "Test Chrome G�ldine" would cause a DCHECK to fire in the
BrowserRenderProcessHost::AppendRendererCommandLine function while retrieving the
user-data-dir switch value from the browser's command line and setting it back to the renderer's
command line. This was because we would retrieve the value as ASCII which would not work because
of the presence of a non ASCII character in the value. The end result is that a CHECK fires in
the renderer when it tries to validate the existence of the user-data-dir path.
Fix is to use the CommandLine::GetSwitchValuePath function instead which returns a FilePath which
does the right thing.
Test=Covered by a ui test.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=29245
Bug=29245
Review URL: http://codereview.chromium.org/671027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is like Directory Watcher, but only for a single file.
Review URL: http://codereview.chromium.org/661359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to the previous patch for CustomButtons.
BUG=36760
TEST=manual
Review URL: http://codereview.chromium.org/676001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15443
TEST=see bug. Page/app menus + download item menus + bookmark bar menus should be fixed.
Review URL: http://codereview.chromium.org/672024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36107
TEST=Check 'Ask where to save each file before downloading' in 'Under the Hood' preference, start a download and check the file permission.
Review URL: http://codereview.chromium.org/672019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Translate's first time, which caused very interesting bugs.
This key was generated using pack extension, so should be
unique.
Review URL: http://codereview.chromium.org/680001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/652186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a couple unit tests. Also fix another potential crash and other problems uncovered by the tests.
BUG=37208
TEST=See bug. Also, unittests.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40810
Review URL: http://codereview.chromium.org/668046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/678001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/672016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
gfx::Rect in a few more places.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows Pythons that barf on CRLF.
TBR=gregoryd
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/674001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a WindowDelegate::GetWindowAppIcon for BrowserView to expose an
icon to use as ICON_BIG;
- Add an app_icon_ memeber and accessor functions to TabContents;
- Update/Set the app_icon_ of TabContents when web app icon is
downloaded for converting a tab to app or for chrome web app shortcuts
update (this happens when chrome is opened as an app;
- Use the app icon as ICON_BIG in WindowWin::UpdateWindowIcon;
BUG=32039
TEST=Verify fix for issue 32039 and also Alt-Tab list on XP/Vista uses big icon.
Review URL: http://codereview.chromium.org/668265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40962 0039d316-1c4b-4281-b951-d872f2087c98
|