| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6602047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6594027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6612024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6453001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
multi-profile UI before back end is hooked in.
BUG=74731
TEST=none
Review URL: http://codereview.chromium.org/6610015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
engineers had made.
Review URL: http://codereview.chromium.org/6588085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=69467
Review URL: http://codereview.chromium.org/6612018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48911
TEST=Ran previously failing tests and made sure they passed.
Review URL: http://codereview.chromium.org/6598070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code attempted to shorten file:/// URLs to just the filename
when displayed as the title of a page. But that appears to have
regressed sometime in the past. This shortening is consistent with
how we display the title of images (which are like "foo.png (123x456)".)
Chrome does a poor job of displaying longer titles (most of the
tab title ends up being "file:///C:/" anyway).
In any case, using a FilePath to get the filename from a URL may not
have even worked on Windows, where the path separator is a backslash.
It appears Glen wrote the original code, Brett may be the one to have
regressed it in a refactor, and I probably broke it worse in a FilePath
refactor.
BUG=69467
TEST=load a text file via a file: URL; tab title is just the file name
Review URL: http://codereview.chromium.org/6591127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move cross platform code to Widget.
- Move platform-specific code into focused Widget* implementations.
BUG=72040
TEST=existing
Review URL: http://codereview.chromium.org/6609023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, we can move the window right away.
BUG=74805
TEST=By hand on Linux with software rendering, WebGL, and 3D CSS.
Review URL: http://codereview.chromium.org/6613020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few sample PyAuto tests are included that exerise these new hooks.
Contributed by dennisjeffrey@chromium.org.
BUG=64271
TEST=None
Review URL: http://codereview.chromium.org/6610021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
directories that currently depend on common (like gpu).
TBR=bradnelson
Review URL: http://codereview.chromium.org/6603011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be necessary to implement resolveLocalFileSystemURI
for workers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6613008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adding facilities for new-style Google Update commands (ProductCommand, ProductCommands)
- Adding support to the validator to validate the quick-enable-cf command
- Adding juju to the installation and uninstallation flows to put the command into place when installing/upgrading Chrome in multi-install mode when CF is either not installed or is in ready-mode, and making sure the command is not there when Chrome Frame is installed.
BUG=none
TEST=Install Chrome in multi-install mode and see if the Google Update version key for the binaries (app guid {4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}) contains a key named "quick-enable-cf" that has a CommandLine value indicating setup.exe w/ --multi-install [ --system-level ] --quick-enable-cf, a SendsPings value of 1, and a WebAccessible value of 1. Then try the other variations, like install CF in ready-mode and make sure that quick-enable-cf is still there. Make sure that installing CF causes it to be removed, etc.
Review URL: http://codereview.chromium.org/6588003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20809
TEST=Try bots.
Review URL: http://codereview.chromium.org/6602091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63493
TEST=Try bots run.
Review URL: http://codereview.chromium.org/6602056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by fuzzac@gmail.com.
BUG=4823
TEST=Open any web page. Save the page using 'Save page as'. Make sure the file
is listed in the downloads page.
Review URL: http://codereview.chromium.org/6312027
Patch from Magnus Danielsson <fuzzac@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
loads plugins before all command line information is available. In particular, the about:flags flag for NaCl isn't loaded yet. The fix is to always load the plugin and have the PluginService check the command line flags and set the WebPluginInfo.enabled field based on that.
TEST=manual
BUG=71989
Review URL: http://codereview.chromium.org/6610005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pieces. A std::set<> is added that will eventually be used to track the contained infobars in a way that has no knowledge of child views. The exact ordering of calls when adding and removing infobars is adjusted slightly in a way that ought to not cause visible changes (in the case of ChangeTabContents(), it should make things slightly more efficient).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6596111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edges.
Per recent mock updates.
BUG=71471
TEST=Subpages should have only a left visible edge.
Review URL: http://codereview.chromium.org/6612020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=views_examples compiles
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=54567 and also matches a change in Firefox 4.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6581054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I noticed this while reviewing related code. I don't
know of an actual bug, but it is bad form to hold a
lock when calling a function (destructor) unless
necessary. For example, if the destructor posted
a message, it might cause a hang on linux as the
posting could re-enter this helper. It is also
possible that the task deletion will take an
extended period of time, and that can block
other concurrent posts from taking place.
r=darin
Review URL: http://codereview.chromium.org/6602024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Roll WebKit 80210:80245.
TEST=none
BUG=none
TBR=ukai
Review URL: http://codereview.chromium.org/6603020
TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/6615019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/6594124/
TBR=
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=ukai
Review URL: http://codereview.chromium.org/6603020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6597028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new common message generator for the cases where the conversion is trivial.
BUG=none
TEST=
Review URL: http://codereview.chromium.org/6594123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49740
TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.* should pass on Mac.
Review URL: http://codereview.chromium.org/6602070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of our tests want to use Unicode literal strings with the
L"foobar" syntax. Allow us to test FilePaths against these
strings.
BUG=69467
Review URL: http://codereview.chromium.org/6606025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
override TabReplacedAt to correctly update internal state. I also
removed the implementation of TabClosingAt as TabDetachedAt covers it.
BUG=74370
TEST=see bug
Review URL: http://codereview.chromium.org/6602105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=dmaclach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux requires that the proxy_config_service be created on the I/O
thread. Fortunately, ServiceURLRequestContextGetter was already thread safe ref
counted, so we lift creation of that and the (also, fortunately) thread safe
ref counted net::ProxyService up to service process initialization time. That
created proxy service now gets passed in to the dynamic creation of the
ServiceURLRequestContexts. Should have no effect on other platforms.
BUG=74226
TEST=Start Chromium on Linux with --enable-cloud-print-proxy, sign in, and examine ~/.config/chromium/Service State. With the fix, Service State properly contains the needed tokens to properly re-launch and be a proxy.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76612
Review URL: http://codereview.chromium.org/6602041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetWindowScreenBounds
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6615016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add mac_framework_private_headers key to specify which headers should be copied
into the PrivateHeaders folder in a Mac Framework.
Patch by Adam Barth <abarth@chromium.org>.
Review URL: http://codereview.chromium.org/6614019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also change remoting files to use libvpx shim header.
This is upstreaming Gentoo Linux changes.
TBR=scherkus
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6588123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds SyncerThreadAdapter (temp code) to facilitate swapping between
implementations without tearing syncapi apart.
BUG=26339
TEST=unit_tests, sync_unit_tests
Review URL: http://codereview.chromium.org/6576049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11896,chromium-os:12300,chromium-os:12302
TEST=None. Punt until the underlying support is implemented.
Review URL: http://codereview.chromium.org/6592079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74690
TEST=Start up cloud print or remoting, then quit chrome. Move chrome.app somewhere else on your system. Restart chrome. Shouldn't crash.
Review URL: http://codereview.chromium.org/6613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I will be doing some refactoring that will change the way pending extension records for a single extension ID are merged. This change will make PendingExtensionInfo a class with nontrivial member functions. As a first step, this change moves PendingExtensionInfo into its own file.
Fixing crbug.com/61000 by merging pending requests is an example of the changes that will add members to class PendingExtensionInfo.
I changed the type ShouldInstallExtensionPredicate to PendingExtensionInfo::ShouldAllowInstallPredicate. I wanted to get the type defined inside the class, and changing the name avoids some ugly 80-colunm gymnastics because it is slightly shorter.
BUG=None
TEST=ExtensionServiceTest.*
Review URL: http://codereview.chromium.org/6579005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also use a single delete function when removing extension files.
BUG=None
TEST=ExtensionServiceTest.*
Review URL: http://codereview.chromium.org/6596041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The volume indicator is moved up, 'Speak now' text comes in the middle and when recognition
is in progress we show only the spinner with no text. When showing error messages, include
a hyperlink to launch the microphone settings UI. Also includes a bunch of spacing changes
to look like in the mocks.
XIB changes: Added a NSButton widget, changed the cell class to HyperlinkButtonCell and linked it to the obj-c code for handling the click event.
BUG=69886
TEST=manual, start speech input on Mac and verify the bubble UI looks similar to the mocks.
Review URL: http://codereview.chromium.org/6594122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was previously Ctrl-Shift-Delete, which can only be
typed as Ctrl-Shift-Alt-Backspace on Chrome OS devices
without Delete keys. Ctrl-Shift-Delete still deletes to the
end of the line when the focus is in a textarea.
BUG=chromium-os:11137
TEST=manual
Review URL: http://codereview.chromium.org/6606008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=clang bot.
Review URL: http://codereview.chromium.org/6611018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The screen size flows through the video pipeline, instead of
being set statically when that pipeline is constructed.
Only the Windows host actually detects when the screen size has changed.
BUG=72469
TEST=none
Review URL: http://codereview.chromium.org/6573005
TBR=simonmorris@chromium.org
Review URL: http://codereview.chromium.org/6610018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The screen size flows through the video pipeline, instead of
being set statically when that pipeline is constructed.
Only the Windows host actually detects when the screen size has changed.
BUG=72469
TEST=none
Review URL: http://codereview.chromium.org/6573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We do this so that we may make HTTP requests using the javascript libraries available to Google Talk. This is required to allow us to sandbox.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6597092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6607001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where it's needed. Prior to this, at least with the
CHROME_ALLOCATOR=winheap environment variable set, the pointer passed
to kernel32!RegisterApplicationRestart could be invalid.
BUG=70824
TEST=run debug build under full page heap on Windows with CHROME_ALLOCATOR=winheap
Review URL: http://codereview.chromium.org/6602092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76744 0039d316-1c4b-4281-b951-d872f2087c98
|