| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This code should enable the creation of a basic context menu for the Video and Audio tags. The actions for fullscreen, save screenshot, loop, and set playback rate are not yet implemented.
BUG=15686
TEST=None
Review URL: http://codereview.chromium.org/149604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pretty. Animations and aesthetic appeal will come in a
future CL.
BUG=http://crbug.com/14462
BUG=http://crbug.com/14937
BUG=http://crbug.com/15839
BUG=http://crbug.com/16487
TEST=Infobars should show up when expected.
Review URL: http://codereview.chromium.org/155494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/149787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16951
TEST=launch bookmark manager on gnome/metacity, observe that window has icon
Review URL: http://codereview.chromium.org/155672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.
Review URL: http://codereview.chromium.org/155671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only show linux splash page for new windows.
May this be the end of this sad saga.
TEST=if chrome is already running, `./out/Debug/chrome test.html` doesn't open splash page
BUG=http://crbug.com/16893
Review URL: http://codereview.chromium.org/149780
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green build
Review URL: http://codereview.chromium.org/155666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
named bookmark.
Also, change the naming scheme of the DnD targets.
BUG=16791
TEST=select a link in the web page and drag it to the bookmark bar.
Review URL: http://codereview.chromium.org/155661
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, on windows, replace new lines with window style new lines. This call is just there to match Pasteboard::writeSelection(), since AFAICT WebFrameImpl::GetSelection() is never used on any platform besides linux.
BUG=16926
TEST=see bug
Review URL: http://codereview.chromium.org/155650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*) Generate goog.exportSymbol for all o3djs classes,
methods and properties so the JSCompiler does not
delete them
*) Remove goog.exportSymbol from the compiled result.
*) Remove o3djs.require from the compiled result.
*) Add docs to undocumented items in o3djs.
Review URL: http://codereview.chromium.org/155665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
later patch will implement the WebKitClient version of it.
BUG=4360
TEST=none
Review URL: http://codereview.chromium.org/149716
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but needed in unit tests.
TBR=willchan
Review URL: http://codereview.chromium.org/155663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the star and go buttons with a native looking thing, where
we manually draw the theme's button image for the full omnibox area
and then position the star/go buttons on top of that.
Also adds stand in versions of star_noborder and starred_noborder
until Glen can make real icons.
http://crbug.com/16227
http://crbug.com/13967
http://crbug.com/16915
Review URL: http://codereview.chromium.org/149681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Make 3 stage updater fail by deleting <chrome>\Application\Installer\chrome.7z file and make sure "ap" key still contains "-full".
Review URL: http://codereview.chromium.org/149776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a bug where windows would creep up the screen every time you quit/restarted.
BUG=http://crbug.com/16176
BUG=http://crbug.com/12854
TEST=Windows should save/restore in the correct location, with either a single
monitor or multiple monitors.
Review URL: http://codereview.chromium.org/155647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(jsonschema).
In this step, All "normal" api calls and events (those that arrive or originate from the browser process) are routed through a single v8::Extension API Call ("StartRequest").
Additionally, internal string names for methods and events now match the js namespace (i.e. "RemoveTab" -> "tabs.remove"), in anticipation of having names be implicit from their api module & name in the api "IDL".
TBR=aa,mpcomplete
Review URL: http://codereview.chromium.org/149730
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We also now automatically hide the shelf when the downloads are
cleared.
BUG=15855,15893
TEST=Download a few things, clear all downloads and the shelf will
empty and hide.
Review URL: http://codereview.chromium.org/149732
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green build
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16945
TEST=run test_shell_tests under valgrind; they shouldn't hang.
Review URL: http://codereview.chromium.org/149769
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new keychain helper search and refactor a bit to support the deletion.
BUG=15070
TEST=Deleting passwords in Clear Browsing Data... will now work per the design doc (which means we clear passwords we created, and our metadata, but leave passwords created by other browsers alone).
Review URL: http://codereview.chromium.org/149759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=munjal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=right click in a dropdown from a folder on the bookmark bar, select add, you should see that the correct folder is seleted in the bookmark editor tree view. Add a bookmark, it should show up in the right place.
Review URL: http://codereview.chromium.org/149725
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=install theme, check to see that buttons are themed.
Review URL: http://codereview.chromium.org/155646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in tab extensions. Also, use ISO language (e.g. "fr" instead of "French") as return language.
BUG=none
TEST=Enable extensions, add the given toolstrip as extension. For a page, the language of the page should be returned as ISO language (e.g., "french" as "fr")
Review URL: http://codereview.chromium.org/149627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16011
TEST=none
Review URL: http://codereview.chromium.org/155615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fixes any known issues or breaks anything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149702
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Drag a tab out of the browser in a RTL language. The tab should be rendered on the right side of the container.
Review URL: http://codereview.chromium.org/155643
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16512,16871
Review URL: http://codereview.chromium.org/149765
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Loading the data from disk remains on the background thread.
This fix is pseudo-speculative.
BUG=14746,14745,15244,15416
TEST=UI tests stop flaking out.
Review URL: http://codereview.chromium.org/149764
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
output file, so generate them by hand, and always print them. Lets you
copy and paste from the bot into the suppressions file rather than having
to reproduce yourself, which is handy for hard-to-reproduce warnings.
BUG=none
TEST=watch the bot. See the suppressions.
Review URL: http://codereview.chromium.org/149762
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The findMatch function now returns a Match object which aggregates multiple
entries into one, in case (which is expected to be common) that multiple
rules match a given URL.
Since the set of matches is highly dependent on the URL, the Match class
replaces the old RequestData object to be added to URLRequests.
BUG=16932
TEST=Blacklist*
Review URL: http://codereview.chromium.org/149737
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
triggered when FindInPage automation messages come in too quickly.
BUG=Multiple AutomationMsg_Find messages sent rapidly to Chrome (without waiting for the synchronous responses) will trigger this DCHECK().
TEST=Send many AutomationMsg_Find messages very quickly without waiting for responses. Ensure no DCHECKing.
Review URL: http://codereview.chromium.org/155644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
list of expected mac failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=aa
TEST=LayoutTests/http/tests/security/isolatedWorld/ (will be landing soon after this patch)
BUG=12218
Review URL: http://codereview.chromium.org/155626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green build
TBR=ericroman
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16909
TEST=Dragging thumbs on the NTP
Review URL: http://codereview.chromium.org/155640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instances for ExtensionDOMUI if RenderView was reused.
BUG=16853
TEST=Added browser test
Review URL: http://codereview.chromium.org/155592
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green build
TBR=ericroman
Review URL: http://codereview.chromium.org/149756
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor password merge to support the new search.
Rename the fill-targeted search on the adapter for better clarity about the distinction between it and the new search.
BUG=16485
TEST=none yet; UI doesn't exist.
Review URL: http://codereview.chromium.org/149708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
all frames since most of the time you end up with ugly clipping and scroll bars on the printed page.
This also fixes printing issue with print selection since we don't pick up the currently selected text if's not in the main frame.
Also did some refactoring of the printing test in render_view_unittest. Mainly to reuse the new Image class.
BUG=http://crbug.com/15250
TEST=Print pages with frames. Print selection when using multiple frames (one example in bug).
Review URL: http://codereview.chromium.org/149644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16093,16908
TEST=run ui tests on Jaunty with ISP with highish packet loss, verify no getaddrinfo or cssyyparse valgrind warnings
Review URL: http://codereview.chromium.org/155638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebNavigationPolicy.
This is cleanup from the WebWidget patch that you reviewed yesterday.
TEST=none
BUG=none
R=dglazkov
Review URL: http://codereview.chromium.org/155637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16824
Review URL: http://codereview.chromium.org/155639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16855
Review URL: http://codereview.chromium.org/155629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=rebaselining tool
BUG=none
Review URL: http://codereview.chromium.org/149718
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
First reviewed at http://codereview.chromium.org/125272
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20869 0039d316-1c4b-4281-b951-d872f2087c98
|