summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Don't use CancelIo to cancel pending IO before closing awtc@chromium.org2009-04-261-10/+11
| | | | | | | | | | | | | | socket because CancelIo doesn't work when there is a Winsock layered service provider. R=rvargas,darin BUG=9258 TEST=Doing web searches from the Omnibox will exercise the code. Clicking a link on a page that is still loading will also exercise the code. The browser should stay responsive. Review URL: http://codereview.chromium.org/99025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14551 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: implement automation for modal dialogs.agl@chromium.org2009-04-262-5/+18
| | | | | | | | | | | | | | | | | The Linux ui_tests are currently red because BrowserCloseBeforeUnloadOK and BrowserCloseBeforeUnloadCancel are failing. This is because we didn't implement several automation functions regarding modal dialogs and someone obviously wrote a test which needed them. So this is a TBR in order to green the tree. TBR=tony http://codereview.chromium.org/99032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14549 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoring - part 4nsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14536 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoring - part 3nsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash I introduced in r14053. It removed the setting of the controller inbrettw@chromium.org2009-04-251-6/+10
| | | | | | | | | one arm of an if statement. BUG=10930 Review URL: http://codereview.chromium.org/99003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14533 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoringnsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14532 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoringnsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14531 0039d316-1c4b-4281-b951-d872f2087c98
* Catch up chrome.gyp with recent additions:sgk@google.com2009-04-251-8/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * browser/bookmarks/bookmark_menu_controller.{cc,h} (Windows only) * browser/browser_unittest.cc * browser/views/autocomplate/autocomplete_popup_contents_view.{cc,h} * browser/views/autocomplate/autocomplete_popup_win.{cc,h} * browser/views/bookmark_menu_button.{cc,h} * browser/views/frame/browser_root_view.{cc,h} * browser/views/uninstall_dialog.{cc,h} * test/automation/autocomplete_edit_proxy.{cc,h} (Windows only) * test/automation/constrained_window_proxy.{cc,h} * test/ui_test_utils.{cc,h} Add apparently overlooked .h file: * test/automation/automation_constants.h. Add tools/build/win/precompiled_wtl.{cc,h} to 'browser', with the right 'msvs_precompiled_{header,source}' settings to work that magic. Add 'views' to the 'app' dependency list. Add a '-lOleAcc.lib' link setting (Windows only) to 'ui_tests'. Add test/perf/mem_usage.cc to 'page_cycler_tests' (Windows only). Have 'renderer' export its dependency on 'plugin' (for calls to IsPluginProcess()) Remove spurious browser/views/fill_layout.{cc,h} (the real files are just views/fill_layout.{cc,h}). Review URL: http://codereview.chromium.org/92052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14523 0039d316-1c4b-4281-b951-d872f2087c98
* Capture Mozilla's codesighs, for use in executable sizing.sgk@google.com2009-04-2517-0/+8319
| | | | | | | | | | Vanilla code, no changes, except for the addition of: * LICENSE, copied from elsewhere in the Mozilla tree; * README.chromium, documenting what's going on. * codesighs.gyp, for building with the rest of Chromium. Review URL: http://codereview.chromium.org/93155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14522 0039d316-1c4b-4281-b951-d872f2087c98
* Show icons in the new omnibox popup.ben@chromium.org2009-04-252-37/+107
| | | | | | | | Also fix some crashes. Review URL: http://codereview.chromium.org/98003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sudden termination after the latest WebKit merge.jam@chromium.org2009-04-2523-99/+125
| | | | | | | | BUG=10927 Review URL: http://codereview.chromium.org/93104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some layout tests failure due to webkit merge 42725:42805hclam@chromium.org2009-04-251-5/+15
| | | | | | | | TBR=dimich Review URL: http://codereview.chromium.org/100009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14515 0039d316-1c4b-4281-b951-d872f2087c98
* Try once more to make webkit bots happy.estade@chromium.org2009-04-251-1/+0
| | | | | | | | TBR=dimich Review URL: http://codereview.chromium.org/99015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14514 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing expectations in test expectations.estade@chromium.org2009-04-251-3/+3
| | | | | | | | TBR=dimich Review URL: http://codereview.chromium.org/100011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14513 0039d316-1c4b-4281-b951-d872f2087c98
* Port unload_uitest.cc and enable some of the tests on linux.estade@chromium.org2009-04-243-10/+25
| | | | | | | | Make WaitForSingleProcess respect base::kNoTimeout (which is equivalent to INFINITE on windows). Review URL: http://codereview.chromium.org/99008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14508 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable worker tests that fail afterdimich@google.com2009-04-241-0/+5
| | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=14461 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/100006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14507 0039d316-1c4b-4281-b951-d872f2087c98
* Passing correct HWND to CreateChromeWindow(). The HWND of the toplevel windowestade@chromium.org2009-04-241-1/+5
| | | | | | | | | | | should be passed. BUG=9191 patch by yusukes@google.com <http://codereview.chromium.org/97011> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14505 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk file selection filters, first cut.estade@chromium.org2009-04-242-6/+78
| | | | | | Review URL: http://codereview.chromium.org/92153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14502 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note pointing at a bug so others don't waste time.evan@chromium.org2009-04-241-0/+3
| | | | | | Review URL: http://codereview.chromium.org/101002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14501 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "POSIX: Don't spawn zombies." (r14488)agl@chromium.org2009-04-2410-122/+18
| | | | | | | | Something else is trying to reap children in the ui_tests and causing a mess. Reverting since it's a Friday night. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14499 0039d316-1c4b-4281-b951-d872f2087c98
* Rename process_watcher.cc -> process_watcher_win.cc on Windows.agl@chromium.org2009-04-241-1/+1
| | | | | | | (Seems that we still don't use GYP on Windows for a lot of things.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14495 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 2 more layout tests after merge - they need rebaseline on Linux and Mac.dimich@google.com2009-04-241-0/+2
| | | | | | Review URL: http://codereview.chromium.org/99006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14494 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: build fix.agl@chromium.org2009-04-241-1/+1
| | | | | | | | Different header paths it seems, although the tryservers were ok with it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14493 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14489.jcampan@chromium.org2009-04-244-80/+40
| | | | | | Review URL: http://codereview.chromium.org/99004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14492 0039d316-1c4b-4281-b951-d872f2087c98
* For TransportDIB::HandleAndSequenceNumber, make operator<nick@chromium.org2009-04-241-5/+4
| | | | | | | | | | | | | be antisymmetric. The old implementation was flawed because both of the following comparisons were true: "{0, 1} < {1, 0}" and "{1, 0} < {0, 1}" On Windows, std::map<> doesn't like that, and complains -- rightly so. Review URL: http://codereview.chromium.org/93151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14490 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes sure we unregister our Windows window classes when shut-down.jcampan@chromium.org2009-04-244-40/+80
| | | | | | | | | | | | It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/93026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14489 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Don't spawn zombies.agl@chromium.org2009-04-249-17/+121
| | | | | | | | TEST=Navigate to several different sites and check that no Chrome zombies are roaming around. BUG=9401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14488 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: build fix.agl@chromium.org2009-04-241-1/+0
| | | | | | | Remove reference to deleted header file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14487 0039d316-1c4b-4281-b951-d872f2087c98
* No code change, just converting CRLF to LF to prevent changesfinnur@chromium.org2009-04-241-156/+156
| | | | | | | | | | to this file from messing up the try server. TBR=aa Review URL: http://codereview.chromium.org/93156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix word wrapping on the license label.erg@google.com2009-04-241-0/+11
| | | | | | | | | This uses the trick described here: http://blog.16software.com/dynamic-label-wrapping-in-gtk Review URL: http://codereview.chromium.org/93153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14485 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of WebKit merge 42725:42805.dimich@google.com2009-04-2430-90/+145
| | | | | | | | | | | | In addition to the tests that were rebaselined or disabled, the following tests fail on my machine but I suspect it's my local ssl problem and will risk it on buildbot. Will promptly disable them if they don't work there. LayoutTests/http/tests/security/cross-frame-access-protocol-explicit-domain.html = FAIL LayoutTests/http/tests/security/cross-frame-access-protocol.html = FAIL LayoutTests/http/tests/ssl/verify-ssl-enabled.php = FAIL LayoutTests/http/tests/security/originHeader/origin-header-for-https.html = TIMEOUT Review URL: http://codereview.chromium.org/92157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14484 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for minimum size checkevan@chromium.org2009-04-242-2/+6
| | | | | | | | cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t) Review URL: http://codereview.chromium.org/93078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14482 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the ExtensionID to the ExtensionFunctionDispatcher.finnur@chromium.org2009-04-246-8/+30
| | | | | | | | | | | | | | | | This is needed for PageActions that deal with IDs, so that we can check if one PageAction is trying to change another PageAction. This converts the object ExtensionFunctionDispatcher in RenderViewHost from a member to a scoped ptr so we can reset it on navigate. BUG=None TEST=Extensions should work as before (no visible change). Review URL: http://codereview.chromium.org/93125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14481 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Do not send stats from Chromium builds."kuchhal@chromium.org2009-04-248-63/+28
| | | | | | | | | | | | This reverts commit 4a0189db765fe94f5df360c0907a585e26c9f681. Revert "Fix build break." This reverts commit eada493cf28975e56395aa3e2d3a0dc267a7f2c7. Review URL: http://codereview.chromium.org/92162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webworker layout test failures.darin@chromium.org2009-04-241-1/+1
| | | | | | | | | | | | Convert from WebString to string16 when posting a message to force a string copy. This is just a temporary workaround to get the tree green. This matches what we were previously doing. R=jam Review URL: http://codereview.chromium.org/92160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14476 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gcc warning if we don't check the results of ReadParam. Sometc@google.com2009-04-242-7/+8
| | | | | | | | | | | | of the buildbots noticed that we weren't checking the results when generating log output. AGL gets the credit for tracking this down. Review URL: http://codereview.chromium.org/93126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14475 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-248-28/+63
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14474 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall dialog handle keyboard events (TAB).kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=10950 Review URL: http://codereview.chromium.org/93140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14473 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HTML selects as native Cocoa controls for Chrome.paul@chromium.org2009-04-2410-6/+205
| | | | | | | | BUG=8389 (http://crbug.com/8389) Review URL: http://codereview.chromium.org/57032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK when typing certain kinds of input on certain profiles.pkasting@chromium.org2009-04-241-1/+3
| | | | | | | | | This is actually a very old bug that some of my recent changes exposed more widely. In PromoteOrCreateShorterSuggestion(), we could create a totally bogus search base, which, if added to the history matches, would then break. In the old code, we'd create this match, but usually not add it to the history match set because we'd already have a What You Typed match; in my new code that's frequently no longer the case. BUG=10926 Review URL: http://codereview.chromium.org/92154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the SiteInstance leak from the known leaks now that it's fixed.brettw@chromium.org2009-04-241-10/+0
| | | | | | Review URL: http://codereview.chromium.org/92091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14469 0039d316-1c4b-4281-b951-d872f2087c98
* Add SDCH histogram to help detected delayed acksjar@chromium.org2009-04-241-0/+16
| | | | | | | | | | | | SDCH might compress so well, that the return of the ack may come late, and a server may stall on a congestion window limitation. This set of histograms is intended to track that issue during SDCH experimentation. r=huanr Review URL: http://codereview.chromium.org/92139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14468 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for two benign race conditions and one bug detecteddkegel@google.com2009-04-241-21/+7
| | | | | | | | | | | | | by kcc's thread sanitizer: 1) remove extra '&' char; this fix is already upstream in libevent 2) delete unused and deprecated event_sigcb interface 3) avoid setting use_monotonic repeatedly. (Should really be protected with a mutex, but a simple init check seems to quiet the race detector.) Review URL: http://codereview.chromium.org/95012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14467 0039d316-1c4b-4281-b951-d872f2087c98
* Checkbox/RadioButton labels have to reserve space for the focus rects, even ↵ben@chromium.org2009-04-243-1/+10
| | | | | | | | | if they're not actively being painted as focused, otherwise layout breaks badly. http://crbug.com/10958 Review URL: http://codereview.chromium.org/93142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14464 0039d316-1c4b-4281-b951-d872f2087c98
* The accidental search infobar was almost never appearing. Fix that ↵pkasting@chromium.org2009-04-246-103/+87
| | | | | | | | | | | regression. Now we don't rely on the presence of a "what you typed" match in the result set; instead the AutocompleteResult determines the alternate nav URL directly. To do this I refactored some of the code from the history URL provider over to AutocompleteInput. BUG=10808 Review URL: http://codereview.chromium.org/92140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14463 0039d316-1c4b-4281-b951-d872f2087c98
* Create an about dialog for GTK Chromium.erg@google.com2009-04-246-4/+178
| | | | | | Review URL: http://codereview.chromium.org/93128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14462 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWorker and WebWorkerClient from the WebKit API.darin@chromium.org2009-04-2421-333/+336
| | | | | | | | | BUG=10995 R=jam Review URL: http://codereview.chromium.org/92144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14461 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error on gcc.brettw@chromium.org2009-04-241-2/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in the size computation for Skia masking.brettw@chromium.org2009-04-241-2/+14
| | | | | | BUG=10736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14454 0039d316-1c4b-4281-b951-d872f2087c98