| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=17475
TEST=obvious
Review URL: http://codereview.chromium.org/159570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary fix to a much larger problem of dealing with Chrome's audio IPC layer. Since a seek is a small amount of time, we keep the audio IPC conversation going by writing 8k of zeros. Before we were telling the audio IPC layer that we were out of data, which technically was a lie (we were just seeking), and as a result the conversation died at that point.
TEST=seek around in a video, audio should keep playing and remain in sync
BUG=17917
Review URL: http://codereview.chromium.org/160283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/160307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
No functional change, just reducing some cruft.
Review URL: http://codereview.chromium.org/159566
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17797
TEST=none
Review URL: http://codereview.chromium.org/159564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
AutomationMsg_RequestStart.
Review URL: http://codereview.chromium.org/159228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had not unloaded them as a premature optimization, thinking it'd be
better to leave 'em around since they'll eventually be loaded by a page.
But that happens in the plugin process and reading the mime type happens
in the browser process, so it didn't help anyway.
BUG=17444
Review URL: http://codereview.chromium.org/160303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159558
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Plugins need to keep their symbol visibility correct.
BUG=17557
Review URL: http://codereview.chromium.org/160302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=17942
TEST=none
Review URL: http://codereview.chromium.org/160304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
so that document.getElementById('o3d') will work
for finding the o3d div.
Review URL: http://codereview.chromium.org/159556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=www.crbug.com/5574
TEST=Download the test file attached with the bug above. Open the html file in Chrome - the input box should show underlines for misspelled words. Now, edit the HTML file such that spellcheck attribute is false. Check again - misspelled words in the text box should not be underlined this time.
Review URL: http://codereview.chromium.org/159547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Saw this on my Jaunty machine; plugin name included a copyright
symbol.
Review URL: http://codereview.chromium.org/159546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsServiceBackend into a set of utility functions.
The intent of this is:
a) make extensions_service.cc smaller
b) have smaller pieces hanging around that we can more easily
reconfigure to implement new features.
c) improve testability.
Review URL: http://codereview.chromium.org/159400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the section background so that it looks the same on white, but is actually transparent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
change as small as possible for beta merge.
TBR=ben
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
debug.
The test seems to be flaky on windows debug.
BUG=14207
TEST=no new ones.
Review URL: http://codereview.chromium.org/159552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No chrome code changes (does not affect any files that are used in build or tests).
This is the precursor to a build/check-in step to generate extension docs if underlying api or static content has changed.
TBR
Review URL: http://codereview.chromium.org/159551
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Install two themes without closing the infobar - make sure only one infobar is visible.
Review URL: http://codereview.chromium.org/160296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tweaks for the list view mode.
This also fixes an issue where the thumbnails were not positioned
correctly at startup in RTL
BUG=17810, 17811, 17751
TEST=Hide the recent activities and make sure that the right border of
even more is shown. Switch to list mode. Make sure that the filler are
hidden. Try dragging the items in the list view. The text should not
dissappear.
Review URL: http://codereview.chromium.org/160291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=media bear tests should start passing again
BUG=none
Review URL: http://codereview.chromium.org/160295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/159550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ctrl+e = ctrl+k
- alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit)
BUG=none
TEST=use the new hotkeys
Review URL: http://codereview.chromium.org/160292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iframe.
Also, override some styles that gets set in the theme css which is
written for the new new tab page.
BUG=None
TEST=Start chrome with --old-new-tab-page
Review URL: http://codereview.chromium.org/160290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
picker.
BUG=none
TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash
Review URL: http://codereview.chromium.org/159540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when the message loop is destroyed (the MessageLoop deletes its pending tasks on destruction, but not the messages).
BUG=17091
TEST=Run the ui_tests with Purify. We should not be leaking messages.
Review URL: http://codereview.chromium.org/159366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(This is a patch of http://codereview.chromium.org/160109
Reviewer: aa.)
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called after Cleanup, which
results in the AutomationResourceMessageFilter member getting destroyed and a subsequent crash.
Added a NULL check for the same.
Review URL: http://codereview.chromium.org/160293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jcampan
Review URL: http://codereview.chromium.org/159543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/160239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- xlib crashes because GDK_LAST_CURSOR is an invalid param.
- int64 on 64-bit is long, not long long, so we have to cast.
Review URL: http://codereview.chromium.org/160289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Box. WebKit removes all spell check markers in Frame::respondToChangedSelection() if, for a text box, the ShouldSpellcheckByDefault() method we have defined in the glue returns false. The problem is, ShouldSpellcheckByDefault() is also called just after the user clicks outside the textbox. As a result, it either detects that the text box is not a focussed node, or determines that the editor is not editable, and returns false, which makes the Frame remove all the markers from the corresponding document object.
BUG=www.crbug.com/6058
TEST=Write random stuff in a text box - after the underlines appear, click outside the text box - the underlines should not disappear. Other functionalities of spellcheck, such as changing spell check language, toggling spell check language on/off, should not be affected at all.
Review URL: http://codereview.chromium.org/159516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
care of warning seen today at
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20(valgrind)/builds/379/steps/valgrind%20test:%20unit/logs/stdio
BUG=17540
TEST=throw rotten tomatoes at chromium mac valgrind bot if it goes red
Review URL: http://codereview.chromium.org/159531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an unused version of the OnMessageReceived method.
R=brettw
BUG=17104
TEST=none
Review URL: http://codereview.chromium.org/160242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allow the src_url argument of Clipboard::ReadHTML and the
html and base_url arguments of ClipboardUtil::CFHtmlToHtml
to be NULL.
Fix nits reported by cpplint.py.
In Clipboard::SetGtkClipboard, use strdup to duplicate
strings.
R=tony
BUG=http://crbug.com/17101
TEST=none
Review URL: http://codereview.chromium.org/160247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I don't think we're guaranteed to have a pending one.
BUG=17916
Review URL: http://codereview.chromium.org/160286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
negative.
Add a unit test for WriteData(NULL, 0).
R=darin
BUG=none
TEST=new unit test should pass
Review URL: http://codereview.chromium.org/159310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
happened."
TBR=kylep
Review URL: http://codereview.chromium.org/160287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When we use gtk_scrolled_window_add_with_viewport, it sets its own
shadow.
BUG=16913
Review URL: http://codereview.chromium.org/159535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17839
Review URL: http://codereview.chromium.org/160217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
More or less a change to pull out time management from PipelineImpl into a new class ClockImpl. Biggest difference is ClockImpl will use the system clock + linear interpolation to provide a more "precise" representation of the current playback position.
BUG=16508
TEST=a/v sync should remain the same, currentTime should report more precise values
Review URL: http://codereview.chromium.org/159517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It also fixes other minor issues in the code, and makes ftp.vim.org work!
TEST=Visit ftp.vim.org on Linux with Chromium compiled in Debug mode. You should see directory listing after a short while.
BUG=http://crbug.com/15792
Review URL: http://codereview.chromium.org/149368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(I went through the rest of the .grd to check all the window titles,
and filed a bug on the one other bad one.)
Spotted by Michael Monreal.
Review URL: http://codereview.chromium.org/159533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21880 0039d316-1c4b-4281-b951-d872f2087c98
|