| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This version contains a fix for an uninitialized memory read.
BUG=22702
TEST=none
Review URL: http://codereview.chromium.org/229003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This changelist is prepared by Alexander Potapenko, cc'ed)
This is a small refactoring that moves the GDB querying logic into a
separate module to allow us using it from tsan_analyze as well (we need it finally).
The diff is almost equal to http://codereview.chromium.org/175026,
I've only swapped two lines to make it applicable to the current trunk version.
Review URL: http://codereview.chromium.org/211023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/216050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=22570
Review URL: http://codereview.chromium.org/212047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
evaluateInCallFrame is called on InjectedScriptAccess instead of InspectorController in ScriptsPanel.js so we need to update Chrome-specific devtools code.
Review URL: http://codereview.chromium.org/208059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/215054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/219007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories to prevent them from stomping each other when they have names that
are the same.
Also adding some dependencies on theme_resources, webkit_resources,
that were missing, but undetected due to everyone sharing the same output
directory.
BUG=22385
TEST=None
Review URL: http://codereview.chromium.org/208056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
files to be included in the build (common.gypi and */supplement.gypi).
BUG=none
TEST=successful "gclient runhooks"
Review URL: http://codereview.chromium.org/214058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functionality. Call into it and show new battery images
Review URL: http://codereview.chromium.org/215025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We need to start using the /edgedl prefix.
BUG= b/2111073
Review URL: http://codereview.chromium.org/217021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome
Review URL: http://codereview.chromium.org/217020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/224001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Change hardcoded "Google Chrome" to product name.
- Implement for GTK.
BUG=21652
Review URL: http://codereview.chromium.org/212051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22372
Review URL: http://codereview.chromium.org/211056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=22702
TEST=Linux valgrind bots
Review URL: http://codereview.chromium.org/222001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=paul
BUG=None
TEST=Webkit Mac10.5 Debug
Review URL: http://codereview.chromium.org/219002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't update the big_test although I'm happy to
do that in another CL.
I changed the CB renderer code to use this. The only
place I didn't is the state handling code. I'll
consider changing that in another CL.
I changed DoCommand so it gets passed the entire
command data including the command itself where
as it used to get passed the command buffer entry
after the command. I wanted to put the commands
into the structures as I think it makes them easier
to use since they can then correctly set their header.
I could have left DoCommand as is but there would
have been a lot of funky pointer math and I thought
this change made it cleaner.
Some questions I had while doing this.
There are a few places in the code that use
unsigned int instead of uint32. It seems
we should use uint32 because unsigned int
is not guarnteed to be 32bits. So for example
ResourceID is unsigned int right now.
The CMD::Set/CMD::Init/CommandBufferHelper commands
are currently fairly untyped. For example
DESTROY_TEXTURE takes a uint32 id. Should it take
a ResourceID instead? DRAW should maybe take an
enum for primitive_type? If we decide to do that
I'd like to do it in another CL.
There's no checking for overflow. We could add
a bunch of DCHECK like DCHECK_LE(width, 65536)
or DCHECK_LE(semantic_index, 16). I'd like to
do those in another CL as well as I think we
need to discuss what commands we want to change.
All the code is in .h files because we want all
of this code to inline. Theoretically this should
be just as efficient as poking values into arrays
in the opt builds.
Review URL: http://codereview.chromium.org/212018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the number of skipped results on sharded builders. This has been true forever.
I'll have a partial fix for that in a separate change.
This time, the data format is really done and ready to be turned into pretty
graphs. The data for each row in this table is created as an array, then
getHTMLForTableRow is called. The graph version of this should be able to
just rewrite getHTMLForTableRow to use canvas instead.
Review URL: http://codereview.chromium.org/208062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
BUG=22711
TEST=Selenium test bot
Review URL: http://codereview.chromium.org/212054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=paul
BUG=None
TEST=Linux webkit dbg
Review URL: http://codereview.chromium.org/215061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR:paulg
BUG:22702
Review URL: http://codereview.chromium.org/212052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the product dir.
Review URL: http://codereview.chromium.org/210044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
August 3rd rev 22348.
The scary thing is that's a little hard to believe
it's been broken that long and no one noticed
so I hope this is the correct fix but it does
appear to be wrong. The '/'s that were removed
are used in a string concat in the HTML templates.
Sometimes they need to be '' and sometimes 'folder/'
so that urls become
http://foo/bar.html
or
http://foo/folder/bar.html
Review URL: http://codereview.chromium.org/213033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=22702
TEST=Mac and Linux valgrind bots
Review URL: http://codereview.chromium.org/214059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=To be created.
TEST=Covered by layout tests.
Review URL: http://codereview.chromium.org/207064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep TIMEOUT for Windows.
TBR=dumi
BUG=21442,22296,19766
TEST=N/A
Review URL: http://codereview.chromium.org/207063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See o3d/command_buffer/service/cross/cmd_buffer_engine.h.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/207061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
full-screen changes in http://codereview.chromium.org/210005 . Call
CComControlBase::IOleInPlaceObject_SetObjectRects directly as the
superclass implementation of CHostControl::SetObjectRects.
Review URL: http://codereview.chromium.org/216055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
BUG=21442,22296,19766
TEST=N/A
Review URL: http://codereview.chromium.org/217023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22696
TEST=Covered by ui_tests.
Review URL: http://codereview.chromium.org/211053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/217018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
why we're not going to implement some.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/207057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
timer by clearing the command keys for close tab/window before we fire the timer.
BUG=16689
TEST=cmd-w closes tabs/windows correctly based on number of tabs in the window and if the window is a browser window. Also comment 16 in the bug.
Review URL: http://codereview.chromium.org/215056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/210027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none.
Test=Covered by layout tests.
Review URL: http://codereview.chromium.org/208065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=6212
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/208051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
buffers etc) with the CommandBuffer.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/216043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
code for these but discovered to my surprise that no one actually uses them.
Also clean up a few other things, like my AlphaBlend() function using hex alpha values where everyone else uses decimal, or unnecessary global qualifiers, or needlessly long code. I avoided changing postincrement to preincrement :D
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/214054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21442
TEST=none
Review URL: http://codereview.chromium.org/203074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and SSLCertRequestInfo, simply declaring the forward class
definition is not enough to include this header. This header
is really dependent on those two class definitions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/216032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty
TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark
BUG=17360
Review URL: http://codereview.chromium.org/216052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
add a couple new suppressions, widen a couple others,
all found on a -O1 -fno-inlining big-redzone fishing expedition
on mac 'caliban'.
BUG=11134,20541,20459,20653,22450,22519
TEST="sh tools/valgrind/shard-all-tests.sh base_unittests net_unittests ui_tests unit_tests" on mac pro overnight
Review URL: http://codereview.chromium.org/212028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If https://bugs.kde.org/show_bug.cgi?id=208197 is ever fixed,
we can get rid of the patch and change the redzone size
with a commandline option instead.
Install to /usr/local/valgrind-10880-redzone to make it easier to tell which machines have the updated valgrind.
Add DIRNAME variable to valgrind build script to simplify changing name of tarball/build dir/install dir.
Also give -f option to mv because macosx's mv is timid about overwriting symlinks.
Review URL: http://codereview.chromium.org/216048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
represented by 'window'.
The behavior was broken in r20876.
BUG=18749
TEST=window.print() on a subframe works.
Review URL: http://codereview.chromium.org/206033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change POINTs to gfx::Point
- Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build)
-- add new automation messages to replace GetWindowHWND, which is not portable
- re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp)
- compile additional tests on linux (they don't pass, so they are disabled)
- stub out linux tab dragging automation implementation (browser side)
- delete various cruft
BUG=19758
Review URL: http://codereview.chromium.org/211033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/209023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is one appcache service per profile and several request context per profile. The profile holds a reference to the appcache service. Those request contexts which are subject to retrieval from appcaches hold a reference to the appcache service too. The appcache service is provided with a pointer back to the 'main' request context, this context is used when updating appcaches.
Initialization is a little tricky because profiles can't be used on the IO thread and request contexts can't be used on the UI thread.
BUG=22597,22125
TEST=many existing tests exercise profile/context creation
Review URL: http://codereview.chromium.org/215024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26844 0039d316-1c4b-4281-b951-d872f2087c98
|