| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
This previously landed as https://codereview.chromium.org/22339020 and
was reverted due to various scripts/etc still referencing chrome.pak. This
patch still builds chrome.pak, but with only the (tiny) net_resources in
it. After this lands I'll go remove references to chrome.pak and then remove
it completely once all references are gone.
BUG=52609
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218956
R=phajdan.jr@chromium.org, sky@chromium.org, tony@chromium.org
Review URL: https://codereview.chromium.org/23205023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- We found that the reading from |demuxer_| and its read-callback loops run very slowly, in the heavy load situation in the render thread.
to improve the response time of the readings, we run tasks related to |demuxer_| in the media thread.
BUG=268208
Review URL: https://chromiumcodereview.appspot.com/22875030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that the code is unused as of now.
BUG=270469
TEST=none
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/22999047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
BUG=255644
Review URL: https://chromiumcodereview.appspot.com/23361017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes V8VarConverter into a class which has a constructor which
is used specifically for testing. It accepts the MessageLoopProxy to
run callbacks on and a ResourceConverter (which can be mocked). This
allows more modular testing of V8VarConverter.
BUG=177017
Review URL: https://chromiumcodereview.appspot.com/23330008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A number of extra swaps could happen afterwards due to commits.
BUG=274116
Review URL: https://chromiumcodereview.appspot.com/23295030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After allocating an instance ID in the browser process, BrowserPluginManager
calls back into the BrowserPlugin that made the request to inform it of its
instance ID. If, during that time, BrowserPlugin was destroyed, then
BrowserPluginManager would've accessed an invalid BrowserPlugin pointer.
This CL solves this problem by using weak pointers for calling back into
BrowserPlugin. If the calling BrowserPlugin has been destroyed in the meantime,
BrowserPluginManager will not call into it.
BUG=276023
Test=WebViewTest.Shim_TestRemoveWebviewAfterNavigation
Review URL: https://chromiumcodereview.appspot.com/22870029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fileBrowserPrivate.executeTask() can now open files in the browser.
BUG=267313
TEST=Double-click a text file in Files.app. Confirm that the file is opened in the browser as before. Double-click on an unsupported file type. Confirm that the error dialog is shown as before.
R=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/23389002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(which actually disables the feature :)
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/22831037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Update calls to ExtensionSettings, ExtensionCommandsOverlay, and PackExtensionOverlay to use extensions.X so we don't have to declare each outside of extensions.
Update HTML IDs in c/b/r/extensions to use-hyphenated-case.
Review URL: https://chromiumcodereview.appspot.com/22849012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156569:156598&mode=html
TBR=
BUG=
Review URL: https://chromiumcodereview.appspot.com/22861032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All methods except AddEntry and RefreshEntry no longer use ResourceMetadata::resource_id as DB key
BUG=275270
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/23011042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The icon was not set when creating the WebstoreInstaller causing the
app launcher to not have an icon in the grid view during one-click
install.
BUG=262929
Review URL: https://chromiumcodereview.appspot.com/23383011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigation chain.
The preconnect was not marked as used when it appeared in navigation chain. This caused inconsistency of Net.PreconnectTriggerUsed (precision UMA) to Net.PreconnectedLinkNavigations (recall UMA).
BUG=235361
Review URL: https://chromiumcodereview.appspot.com/23264033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the download functions so the commit to the server can be
separated from the building of the commit message. This allows us to
test these functions in download_unittest.cc without needing to use the
heavyweight MockConnectionManager. It also lets us improve our testing
of AppendClientDebugInfoIfNeeded by using less mocks and more real code.
An important side benefit of this change is that it makes progress
towards the removal of ModelTypeInvalidationMap, which is a step
towards implementing crbug.com/233437.
Also included in this change is a new TRACE_EVENT. Though it's not
really new, since it was removed (accidentally) in the Syncer refactor
(r209867). It's not related to this change, but it's a one-liner and I
happen to be modifying nearby code.
BUG=233437
Review URL: https://chromiumcodereview.appspot.com/22849021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initial CL was reverted due to a static initializer in the unit tests
causing a deadlock on Windows.
BUG=257616
R=gavinp@chromium.org, pasko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22842007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/23363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just headless failed on the plain Windows build, for reasons unclear.
Seems worth trying again on Aura. (Another possiblity if this fails on
bots might be to create and update the main window, but just not Show
it?)
R=jochen@chromium.org
BUG=257219
Review URL: https://chromiumcodereview.appspot.com/22887038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently I've added a code to move the notification popups above
so that they can avoid the system tray. However, when the first
notification is created, the popup is still blocked if system tray
opens.
In this CL, I changed the lifetime of WorkAreaObserver to keep
tracking the system tray's visibility and size, and then the
notification popups can appear above the system tray.
BUG=274851
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23346005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
BUG=255644
Review URL: https://chromiumcodereview.appspot.com/22929039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=253092
TEST=none
TBR=samarth@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23061009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "open with browser" actions of the file manager, such as "view-in-browser",
should be handled in file_browser_handlers.cc rather than in file_manager_util.cc,
as these are special cases of file browser handlers.
With this change, we should be able to get rid of fileBrowserPrivate.viewFiles()
as fileBrowserPrivate.executeTask() is now able to handle these actions.
Note that the original code path in file_manager_util.cc (OpenItem() and helper
functions) was mainly (or only) used for opening downloaded files.
BUG=267313
TEST=Save an HTML file. Open the file from the download shelf with "open" menu. Confirm it works as before
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/23049009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically ZoomView installs a listener on the HostZoomMap in the
constructor and removes it in the destructor. To find the HostZoomMap
ZoomView access menu_. Problem is in some situations menu_ may have
been destroyed already. Fix is to add an Observer and do cleanup when
WrenchMenu is destroyed (or in the destructor).
I would have liked a test for this, but that currently requires an
interactive test which I'm loathe to write.
BUG=236581
TEST=with aura build bring up wrench menu, and click close button on
browser. Make sure don't crash.
R=skuhne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23187006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes reference counting from tile management and instead
lazily constructs the PrioritizedTileSet as needed without
ManageTiles() having to be called. A ManageTiles() call will force
the reconstruction of the TileSet.
This doesn't change the current behavior as ManageTiles() is
called whenever the TileSet is changed in a meaningful way. We can
enforce this using DCHECKs but that makes consolidating
ManageTiles() calls harder.
This gives a ~125% performance improvement to
TileManagerPerfTest.ManageTiles.
BUG=268441
TEST=cc_unittests,cc_perftests
Review URL: https://chromiumcodereview.appspot.com/22825029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already implicitly tested by the WeakKey tests, but add simple
explicit tests for GetPublicKeyInfo
This is a re-landing of http://crrev.com/218672, which was reverted due to Win
XP.
BUG=257119
R=wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22978025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
musicManagerPrivate.
BUG=277836
Review URL: https://chromiumcodereview.appspot.com/22831040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the stack
This occurs because we try to activate the last active panel that is currently minimized when a panel in the stack is being closed. We should pick next active panel that is not minimized.
BUG=277155
TEST=update test and add new test
Review URL: https://chromiumcodereview.appspot.com/23137011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
belongs to a reserved IANA range. This includes *all* reserved IANA ranges. Applies to both IPv4 and IPv6.
I used the following IANA links to decide whether a given range is reserved:
https://www.iana.org/assignments/ipv4-address-space/ipv4-address-space.xml
https://www.iana.org/assignments/ipv6-address-space/ipv6-address-space.xml
BUG=225570,119212,116838
TEST=net_unittest
R=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22538003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/22957011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the cellular modem is locked, it appears as a disabled technology in the
login UI. A locked cellular device must be unlocked before the device can be
enabled, so the SIM unlock dialog should be shown.
BUG=167687
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/23319003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RootWindow and in the
corresponding function in the MenuController class.
This is on the same lines as posting the mouse down messages when we are exiting a menu
loop. In this case the user touches outside the menu bounds and the menu should abort while
reposting the gesture to the concerned window.
The other change is to process touch events in the HWNDMessageHandler class asynchronously as we don't
receive touch events if a modal loop is entered in the context of a touch message. Appears to be a bug
in Windows.
BUG=277018
TBR=sky@chromium.org
TEST=RepostTapdownGestureTest
Review URL: https://codereview.chromium.org/22865036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=274832
Review URL: https://chromiumcodereview.appspot.com/22909044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minor code changes were also made to move audio or video
specific functionality out of the base class and into the
derived classes. No functionality changes were introduced.
Code is just being moved around.
TEST=All existing tests still pass.
Review URL: https://chromiumcodereview.appspot.com/23003019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
open foreign windows and tabs. API proposal accessible at go/sessions-apidoc. SyncedDevices / DeviceInfo still needs to be added in once they are written and checked in by chrome.syncedDevices developer. Session name is currently holding the place of DeviceInfo in "info" component of Session object (sessions.json). An "on change" event listener for changes in device sync needs to be added as well.
BUG=123266
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219066
Review URL: https://chromiumcodereview.appspot.com/21022018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes up several places I missed in my previous change.
(https://src.chromium.org/viewvc/chrome?view=rev&revision=218819)
BUG=272993
TEST=All existing LayoutTests still pass.
Review URL: https://chromiumcodereview.appspot.com/23264040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CL splits them up into three separate files.
BUG=174194
Review URL: https://chromiumcodereview.appspot.com/22876013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Should make the failing python test pass...
Review URL: https://chromiumcodereview.appspot.com/23137021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sometimes be the empty-string, the name is pulled out of an AVCodec by looking it up based on the ID from AVCodecContext.
BUG=277802
Review URL: https://chromiumcodereview.appspot.com/23361018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unless I am missing something, it doesn't make too much sense to call a lock
variable "mUiThreadLock", as we employ it specifically to handle class access
from different threads.
This patch renames "mUiThreadLock" -> "mLock".
BUG=None
Review URL: https://chromiumcodereview.appspot.com/22992005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a regression introduced by https://codereview.chromium.org/23137013/
Previously if the requested field is NULL, we will throw an exception and return. The success value is false.
However, the new behavior will return a true success code.
This causes the video size to be incorrectly set in WebMediaPlayerAndroid.
TBR=yfriedman
BUG=277105
Review URL: https://chromiumcodereview.appspot.com/22839019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since Packages doesn't allow for a different source and destination file name, I decided to make the build create the native messaging manifest under the name it eventually has under Linux, which entailed a small change to the Linux installer as well.
One thing I'm not entirely happy about with this CL is that the Mac is installed as org.chromium.chromoting, whereas the native messaging component is called com.google.chome.remote_desktop. It would be nice if we could use the same name for both. For this CL, I think keeping the two different names is best for the sake of keeping it small.
BUG=173509
Review URL: https://chromiumcodereview.appspot.com/22901019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r207876 is not needed since r207921 has moved RegisterHeadsetReceiver() immediately following SetAudioMode(),
and RegisterHeadsetReceiver() will turn on speakerphone when headset is not plugged in.
> Turn on speakerphone by default for WebRTC on Android.
>
> This routes audio to speaker, instead of earpiece, by default for WebRTC on Android.
>
> BUG=243506
> TEST=run https://apprtc.appspot.com/?debug=loopback on Google Android devices. Audio will come out of speaker.
> R=qinmin@chromium.org
>
> Review URL: https://codereview.chromium.org/17491008
TBR=wjia@chromium.org
Review URL: https://codereview.chromium.org/23038024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/23202013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we show the context popup menu by long-press, the subsequent
touch events were processed by ContentViewGestureHandler even after
the popup menu is shown. For example, showing the popup menu by
long-press then moving up and down made the content view scroll.
Also, it caused a crash on executing "Search by Image" on Android.
This CL adds a flag so that the subsequent touch events can be ignored on-request.
BUG=274832
Review URL: https://chromiumcodereview.appspot.com/22891008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/22901027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=267597
TBR=jeremy@chromium.org
Review URL: https://codereview.chromium.org/23112025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This fixes a crash caused when the OMX code fails to load the Vorbis
software decoder .so.
Review URL: https://chromiumcodereview.appspot.com/22875042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
While the title in a Mozilla style URL may not be optional, an empty
title is indistinguishable from one without.
BUG=277264
Review URL: https://chromiumcodereview.appspot.com/22901023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219173 0039d316-1c4b-4281-b951-d872f2087c98
|