summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Implement extension.sendRequest, a simpler way to do messaging.mpcomplete@chromium.org2009-10-2312-25/+784
| | | | | | | | BUG=23865 Review URL: http://codereview.chromium.org/320009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29911 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix keyword editor-related crashesshess@chromium.org2009-10-232-17/+28
| | | | | | | | | | | | | | * Adjust the edit buttons after adding a new keyword. * Don't make NSPointerArray calls which cause exceptions. Patch from rsesek@chromium.org http://codereview.chromium.org/262028 BUG=23350, 22545 TEST=Preferences-->Manage. Add a search engine. Click "Make Default", delete it ("-)". Crash. Review URL: http://codereview.chromium.org/319006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29910 0039d316-1c4b-4281-b951-d872f2087c98
* Add some icons that will be used by future tests.aa@chromium.org2009-10-237-0/+0
| | | | | | | BUG=24669,24472 TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29909 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nsylvainthakis@chromium.org2009-10-236-135/+5
| | | | | | Revert git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29908 0039d316-1c4b-4281-b951-d872f2087c98
* Add dependencies from net_base to bzip2 and zlib.agl@chromium.org2009-10-231-0/+2
| | | | | | | | These were erroneously removed in r29702 and broke the system library build. http://codereview.chromium.org/337003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29907 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make bookmark bar primitive drag destination.thakis@chromium.org2009-10-236-5/+135
| | | | | | | | | BUG=18289 TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar. Review URL: http://codereview.chromium.org/336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29906 0039d316-1c4b-4281-b951-d872f2087c98
* Clarified the manifest example code. Added "version" description.kathyw@google.com2009-10-232-61/+154
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/326008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29905 0039d316-1c4b-4281-b951-d872f2087c98
* When sending resources across the IPC barrier, use increasing sized buffers.erg@google.com2009-10-232-8/+38
| | | | | | | | | | | | | | | | | | | | | | | AsyncResourceHandler::OnWillRead will usually allocate a new piece of shared memory for each 32 kilobyte chunk of a resource to be sent over IPC from the browser to the renderer. Instead, use a 32k chunk, then a 64k chunk, then a 128k chunk up to a maximum size of 512k. Why? Because transferring large resources is really slow. To send a sequence of 32k chunks to the renderer, we need to wait for the renderer to send an ACK message back before we send the next chunk. The themeing on the new tab page is a pathological case for this code. Most of the background images are large, and my test case is about 800k. This was 25 round trips. Now it is 5. According to the web inspector, it used to take ~700ms to transfer said image. Now it's in the ~30ms range. It feels faster, and the web inspector shows the speed up, but tab_complex_theme_cold does not... BUG=http://crbug.com/24493 TEST=Doesn't regress any performance tests. Review URL: http://codereview.chromium.org/331001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29904 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs on linux throb when the title changes. Isky@chromium.org2009-10-2320-53/+143
| | | | | | | | | | | need to resolve with Glen/Nicholas how to handle the windows side. BUG=25308 TEST=none Review URL: http://codereview.chromium.org/314010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
* Add bindings to chrome frame to call the new extension automation apis.rogerta@chromium.org2009-10-2312-63/+402
| | | | | | | | | TEST=see unit tests BUG=0 Review URL: http://codereview.chromium.org/284017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29902 0039d316-1c4b-4281-b951-d872f2087c98
* Fix speleing.mark@chromium.org2009-10-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/333013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29901 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the <keygen> tag for client certificate enrollmentwtc@chromium.org2009-10-2323-10/+806
| | | | | | | | | | | | | | | | under Linux. Currently, no notifications are given to the user that the certificate was successfully enrolled. Patch by Gaurav Shah <gauravsh@chromium.org> of Google. Original review URL: http://codereview.chromium.org/261035 BUG=148 TEST=Can test on the following sites: http://foaf.me/simple_KEYGEN_CreateClientCertificate.php http://www.myopenid.com Review URL: http://codereview.chromium.org/271112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29900 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with startup tests and file urls. asargent@chromium.org2009-10-232-1/+4
| | | | | | | | | | | | | | | For extensions purposes, content scripts don't see any DOM when running on the existing empty.html file. We're curious if using an html file with a real (but empty) body makes any difference in startup time for the extensions tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/332003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29899 0039d316-1c4b-4281-b951-d872f2087c98
* Make the test plugin draw an antialiased green circle with a gradient so webrettw@chromium.org2009-10-234-28/+79
| | | | | | | | | | can see it's working. TEST=none BUG=none Review URL: http://codereview.chromium.org/293053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29898 0039d316-1c4b-4281-b951-d872f2087c98
* Push the native canvas into the plugin implementation. On Windows, this meansbrettw@chromium.org2009-10-2311-197/+165
| | | | | | | | | | | | | | | using SkCanvas instead of an HDC. This way, the pepper implementation can use the more advanced blending of SkCanvas and avoid the Windows API. I did some refactoring in the standard plugin implementation to support this and make it as clean as I could. Hopefully the code is slightly clearer than before. TEST=none BUG=none Review URL: http://codereview.chromium.org/306027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29897 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make sure that Cocoa knows Omnibox field draws with transparency.shess@chromium.org2009-10-231-0/+5
| | | | | | | | | http://crbug.com/24745 TEST=Should not have transparent ring around omnibox in popup windows. Review URL: http://codereview.chromium.org/304005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29896 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes ChromeFrame net tests which run the URLRequest unit tests by launching ↵ananta@chromium.org2009-10-236-22/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | IE and having it issue the corresponding HTTP requests via automation. Fixes as below:- 1. The DefaultAcceptCharset and DefaultAcceptLanguage tests were failing because the URL request automation job would only read the extra headers from the request. These tests set these headers in the URLRequestContext. We needed to mimic the functionality in the URLRequestHttpJob to add in these headers if they were not already present. As part of this I moved the AppendHeaderIfMissing function from url_request_http_job.cc to HttpUtil as it is needed by the automation job as well. 2. The OverrideAcceptLanguage and OverrideAcceptCharset tests started failing in chrome frame net tests after the fixes to get the default versions of these tests to pass. These tests basically pass in the Accept-Language and Accept-Charset headers and expect the same values to be echoed back. IE ends up caching the responses from the default versions of these tests and thus echoes back the old response which causes these tests to fail. I tried passing in the no-cache header from our HTTP server for the EchoHeader tests but this did not work. To fix this we now pass in the echoheaderoverride parameter for the OverrideAcceptLanguage and OverrideAcceptCharset tests. The HTTP server has been updated to support this. 3. NotifyDone can be called on the job if the original request was redirected. Added a check for whether NotifyDone was already called on the job in URLRequestAutomationJob Review URL: http://codereview.chromium.org/322004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29895 0039d316-1c4b-4281-b951-d872f2087c98
* Added a suppression for http://crbug.com/25645timurrrr@chromium.org2009-10-231-0/+8
| | | | | | | | BUG=25645 TBR=dank Review URL: http://codereview.chromium.org/337001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29894 0039d316-1c4b-4281-b951-d872f2087c98
* Added base::subtle::NoBarrier_CompareAndSwap and base::subtle::NoBarrier_Store timurrrr@chromium.org2009-10-231-0/+2
| | | | | | | | | | to the list of functions ignored by ThreadSanitizer on Mac OS. This patch was prepared by Alexander Potapenko (cc'ed) TBR=dank Review URL: http://codereview.chromium.org/333012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29893 0039d316-1c4b-4281-b951-d872f2087c98
* Retrieve only what we need from the skia repo: src and include directories. ↵senorblanco@chromium.org2009-10-231-2/+5
| | | | | | | | | | | | | | This shaves about 38MB off each checkout. NOTE: svn will nag you about your existing skia dir, which is no longer versioned (only the subdirs skia/src and skia/include are). The warning is benign, but in order to silence this nagging, remove the src/third_party/skia line from .gclient_entries. TEST=will it blend--i mean, build? BUG=none Review URL: http://codereview.chromium.org/320007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29892 0039d316-1c4b-4281-b951-d872f2087c98
* Coding style fix: "if(" => "if (".viettrungluu@chromium.org2009-10-232-2/+2
| | | | | | | | | | | | (One of the changes was pointed out to me by pinkerton in a too-late drive-by a while back.) BUG=none TEST=none Review URL: http://codereview.chromium.org/327011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29891 0039d316-1c4b-4281-b951-d872f2087c98
* Permit .keystone_install to perform an initial bootstrapping installation overmark@chromium.org2009-10-231-11/+18
| | | | | | | | | | | | a skeleton directory. The skeleton is a pre-registered Keystone ticket with the correct product ID, URL, and path existence checker, and a preposterous version (like 0), in conjunction with an existing but empty .app. TEST=none BUG=none Review URL: http://codereview.chromium.org/322005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove trailing whitespaceapavlov@chromium.org2009-10-231-2/+2
| | | | | | | | | | TBR=mnaganov@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/330003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29889 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/fast/css/css2-system-fonts.html.tkent@chromium.org2009-10-237-17/+62
| | | | | | | | | | | | | | Move existing expected results for chromium-win to chromium-win-xp, and rebaseline on Vista. The test uses system font names. It essentially depends on OS versions and default settings. BUG=21859 TEST=none Review URL: http://codereview.chromium.org/329005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29888 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 224.2 to 224.3chrome-bot@google.com2009-10-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29887 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Check failure in SocketStream::DidRecevieData().ukai@chromium.org2009-10-231-2/+15
| | | | | | | | | | | | Socket::Read() may return 0, that indicates end-of-file. So, if we get 0 as result of Read(), finish the Socket Stream. BUG=none TEST=none Review URL: http://codereview.chromium.org/329006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29886 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=apatrickgman@google.com2009-10-231-2/+2
| | | | | | | | | | | | | | | Fix for OSX and last libs.gyp change No idea why but mac gyp gets an error with those 2 mac settings set to all_dependent_settings instead of direct_dependent_settings. This fix only makes gyp actually build the xcodeproj files. It doesn't actually make the builds work. Review URL: http://codereview.chromium.org/328005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29885 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile bustage on chromeos builder.eroman@chromium.org2009-10-231-1/+2
| | | | | | | | | | | This is fallout from r29880. TBR=darin BUG=22294 Review URL: http://codereview.chromium.org/328006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29884 0039d316-1c4b-4281-b951-d872f2087c98
* Removed page action references to badges and popups.kathyw@google.com2009-10-232-22/+34
| | | | | | | | | | Added information about the lifetime of show(). TEST=none BUG=none Review URL: http://codereview.chromium.org/336004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29883 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the RootView is sized to the correct bounds when the opaque frame ↵ben@chromium.org2009-10-237-110/+114
| | | | | | | | is maximized.It seems that now, when an opaque frame is maximized we also need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know why, it's just is.I reworked the way Widget allows subclasses to handle sizing of the RootView... I delegate responsibility for determining the RootView's bounds to a helper virtual function which BrowserFrameWin overrides. This seems cleaner to me. I make sure this handling only occurs when the window is not maximized.http://crbug.com/25227TEST=use to a theme or switch off glass on vista or use Xp. Maximize the browser window. The tabs should be entirely visible. Review URL: http://codereview.chromium.org/304007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29882 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/tables/mozilla/bugs/bug96343.html for Windows.tkent@chromium.org2009-10-233-2/+1
| | | | | | | | BUG=21859 TEST=none Review URL: http://codereview.chromium.org/326007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29881 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of ChromeURLRequestContexts to the IO thread.eroman@chromium.org2009-10-2353-574/+1305
| | | | | | | | | | | | | | | | | | | | | | | Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races. So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. The consequence of this is: * Consumers on the UI thread can no longer get access to a URLRequestContext. * Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread. OK, so now the smelly part: There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store. To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe. BUG=http://crbug.com/22294 Review URL: http://codereview.chromium.org/258008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29880 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.thakis@chromium.org2009-10-231-1/+1
| | | | | | TBR: nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29879 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing forward decl in WebSocketStreamHandleClient.hukai@chromium.org2009-10-231-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/335004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29878 0039d316-1c4b-4281-b951-d872f2087c98
* Make user shortcuts override built-in shortcuts.thakis@chromium.org2009-10-231-0/+8
| | | | | | | | | BUG=25330 TEST=Open sysprefs, keyboard, keyboard shortcuts, add a keyboard shortcut that makes cmd-right do "Select Next Tab". Hit cmd-right in chromium. Should switch tabs instead of doing history navigation (note "instead". If it does both tab switching _and_ history navigation, that's wrong). If a text box is focussed, cmd-right should however instead move the cursor and not switch tabs. Switching windows with cmd-` should still work. Switching tabs with cmd-1/2/3 and cmd-{/} should still work. Using backspace/shift-backspace for history should still work. Review URL: http://codereview.chromium.org/325004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29877 0039d316-1c4b-4281-b951-d872f2087c98
* Move overflow-float-stacking.html and line-breaks.html to theirtkent@chromium.org2009-10-231-3/+3
| | | | | | | | | | dedicated bugs. BUG=21859,25616,25617 TEST=none Review URL: http://codereview.chromium.org/335003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29876 0039d316-1c4b-4281-b951-d872f2087c98
* Readding from scratch instead reverting the revert.finnur@chromium.org2009-10-238-18/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It kept eating the files I added, so I recreated the changelist from scratch using the raw patch downloaded from Rietveld. TBR=mpcomplete Original description: We changed the page action manifest from 'icon' -> 'default_icon' and now allow extensions to programmatically specifying an icon. However, page actions that hard-coded an icon using the 'icon' tag in the manifest (don't show an icon programmatically) now lose their icons. This causes a crash when we try to display the icon in the LocationBarView. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/334005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29875 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Address some style comments from a review (which missed the ↵eroman@chromium.org2009-10-239-24/+40
| | | | | | | | original check-in). Review URL: http://codereview.chromium.org/322009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29874 0039d316-1c4b-4281-b951-d872f2087c98
* Disable system suspend while downloading files on win32.mark@chromium.org2009-10-238-1/+146
| | | | | | | | | | | | | | | | | | | | If the system goes into power-save sleep mode while downloading files, the download fails. So, prevent sleep mode until the download finishes. This patch introduces a new RAII class to request that the system's power-save mode be disabled - PowerSaveBlocker. This is only implemented for win32; other platforms are stubbed out. This only partially implements bug 25420 it only attempts to handle the downloading case. Patch by Bryan Donlan <bdonlan@gmail.com> BUG=25420 TEST=Download a large file with the system sleep timeout set to a short interval. Review URL: http://codereview.chromium.org/287017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29873 0039d316-1c4b-4281-b951-d872f2087c98
* Remove passing attribute-listener tests from expectations.johnnyg@chromium.org2009-10-231-5/+0
| | | | | | | | | | TBR=dglazkov BUG=23740 TEST=these Review URL: http://codereview.chromium.org/326006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29872 0039d316-1c4b-4281-b951-d872f2087c98
* This test is flaky, it has failed multiple times on the Linuxfinnur@chromium.org2009-10-231-1/+1
| | | | | | | | | | | | interactive dbg bot tonight. TBR=erg BUG=25614 TEST=none Review URL: http://codereview.chromium.org/332004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29871 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 49957-49961. Lots of rebaselines for new -webkit-shadow ↵johnnyg@chromium.org2009-10-2341-4/+40
| | | | | | | | | | | | attribute in svg. TBR=tc BUG=none TEST=none Review URL: http://codereview.chromium.org/329003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29869 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove flicker when typing in the findbar.rohitrao@chromium.org2009-10-232-0/+7
| | | | | | | | BUG=http://crbug.com/25590 TEST=No flicker when typing in findbar. Review URL: http://codereview.chromium.org/333007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29868 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29861 since this fail on the interactivefinnur@chromium.org2009-10-238-91/+18
| | | | | | | | | | | | | | | | | | | | | | | | linux dbg bot, for some weird reason... Page actions that don't specify an icon (ie. have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. TBR=nsylvain BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29867 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tests for testing browser's overall key events handling behavior.suzhe@chromium.org2009-10-2312-147/+958
| | | | | | | | | | | | This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported. The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/268035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29866 0039d316-1c4b-4281-b951-d872f2087c98
* ValidityState-patternMismatch-001.html has become flaxy. Adding to ↵johnnyg@chromium.org2009-10-231-0/+4
| | | | | | | | | | | | test_expectations. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/326005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29865 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for WebSocket::ProcessFrameData.ukai@chromium.org2009-10-233-65/+189
| | | | | | | | | | | | | | It catches a bug fixed in r29760. Also find another bug and fixed in this change. (same bug found in WebKit code. reported as http://bugs.webkit.org/show_bug.cgi?id=30668) BUG=none TEST=net_unittests passes Review URL: http://codereview.chromium.org/307036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29864 0039d316-1c4b-4281-b951-d872f2087c98
* Make SSLClientSocketMac full-duplexukai@chromium.org2009-10-232-136/+159
| | | | | | | | | BUG=13289,12497 TEST=visit https site and works as before Review URL: http://codereview.chromium.org/266078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29863 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tweak combining characters slightlyevan@chromium.org2009-10-231-1/+4
| | | | | | | | | | | | This fixes Arabic and a Cyrillic test. Behdad has promised to rewrite all of this for WebKit, but for now, this new behavior is less broken than before. BUG=22872,22367 Review URL: http://codereview.chromium.org/327006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29862 0039d316-1c4b-4281-b951-d872f2087c98
* Page actions that don't specify an icon (ie.finnur@chromium.org2009-10-238-18/+91
| | | | | | | | | | | | | | | | | have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29861 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 11:54:37 +0000