| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
branding).
- Stop using CPP on the info.plist since we have to run a script anyways.
- Set the bundleid into a build setting for simple info.plist processing to pick up.
- Add a script for the chrome/app target to manually tweak the info.plist:
- collect the version number from the build tree
- collect the svn revision from the build tree
- update the info.plist keys that need the version number based on collected data.
- record the svn revision into the info.plist for trouble shooting.
Review URL: http://codereview.chromium.org/115187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The style is based on the gtk code (autocomplete_popup_view_gtk.cc), with some local tweaks. I broke this off from the rest of the review so I could experiment with making it nail omnibox-v2, but eventually realized that I don't have enough data for that. This at least makes things look nicer, and I believe it provides all of the function that will be needed (the remainder is precisely defining fonts and colors and possibly minor highlighting variations).
Summary: I want something concrete so that complaints about v2 wrongness can be specific.
Review URL: http://codereview.chromium.org/99312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
dependency of targets that need it (that is, any target with
'rules' or 'actions').
Review URL: http://codereview.chromium.org/115154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains a register allocation crash fix and a
JSC compatibility fix which should fix issues with facebook.
BUG=1717
BUG=11675
Review URL: http://codereview.chromium.org/115194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
committed in issue 114012.
Review URL: http://codereview.chromium.org/115191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I probably got bitten by precompiled headers. :-/
Review URL: http://codereview.chromium.org/115193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another step towards porting the TaskManager.
TEST=Launch Chrome, open the task manager. You should see correctly reported and updated resource data.
http://crbug.com/11461
Review URL: http://codereview.chromium.org/115031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/113209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11616
Review URL: http://codereview.chromium.org/112013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch is contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>.
Original review: http://codereview.chromium.org/39130
R=wtc
http://crbug.com/4965
TEST=None. Work in progress.
Review URL: http://codereview.chromium.org/115137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixes a bug we've had for a long time drawing the wrench button. We would
over-tile the center portion, and draw the right images on top of it.
- Move away from x1 .. x2 parameters to more clear width and height.
- Makes the code significantly more straightforward and efficient.
Review URL: http://codereview.chromium.org/115181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
up in the packaging step.
Review URL: http://codereview.chromium.org/113196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base::DIR_EXE could be a very long path, which causes socket creation to fail because socket paths have a limited length. Let's use a temp directory instead. We should also clean up the temp dir when we're done. Also abort if the socket path is too long.
Reviewed in issue 115107
Review URL: http://codereview.chromium.org/113193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
function RenderViewTest::SendKeyEvent() that sends a keyboard event to a RenderView object.To emulate not only US keyboards but also non-US keyboards, this change adds a new class "MockKeyboard", which implements a mapping function from a triple <keyboard type, key code, modifiers> to a Unicode character so that engineers can write RenderViewTest cases without taking care of keyboard types.As samples for this new function, I updated my test RenderViewTest.OnHandleKeyboardEvent and added another test RenderViewTest.InsertCharacters.I wish this class help engineers write more RenderViewTest cases.
Review URL: http://codereview.chromium.org/92122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac it was regularly hitting the default timeout of 10000 seconds.
(Really should take the size of the shard into account,
but we can do that later if we have lots of hangs.)
Should fix error
14:37:55 common.py [INFO] process timed out
14:37:55 common.py [ERROR] KILLED 17207
14:37:56 common.py [ERROR] TIMEOUT waiting for src/xcodebuild/Debug/ui_tests
in
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/479/steps/valgrind%20test%3A%20ui/logs/stdio
Review URL: http://codereview.chromium.org/114012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
net, testing
Review URL: http://codereview.chromium.org/115175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=0
TEST=Be English sentence structure valid should.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BuG=0
TEST=chec depsk should not fail
Review URL: http://codereview.chromium.org/115174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/113186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provides a way for saving and restoring window placement, obtaining system helpers etc.
http://crbug.com/11633
TEST=make sure window placement saving works, clipboard, and that windows in the taskbar have a chrome icon.
Review URL: http://codereview.chromium.org/113173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for all different scenarios.
Note I grabbed the plugin hwnd and manually checked it instead of looking for callbacks from the plugin's SetWindow since the latter isn't called if the visibility changes.
BUG=1842096
TEST=regression test included, test http://chromedashboard per bug
Review URL: http://codereview.chromium.org/115169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11544
TEST=Load a webpage, resize window larger. Window should not
flash white while resizing.
Review URL: http://codereview.chromium.org/113185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also includes http://codereview.chromium.org/115166 by Craig Schlenter
BUG=11692
Review URL: http://codereview.chromium.org/112012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=beng
Review URL: http://codereview.chromium.org/115165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
'defined but not used' errors (the
strings are used by themes).
TBR=beng
Review URL: http://codereview.chromium.org/113184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
GenerateFrameImages tweaking.
Convert global std::strings to char*
Review URL: http://codereview.chromium.org/115161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/115160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
between the info-bar showing and the first navigation.
If the first navigation was committed after the bar had been shown, the bar
would hide (as it is supposed to hide on navigation).
This CL makes the bar linger for few seconds before it is hidden on the next
navigation.
BUG=11427
TEST=Have a test server that blocks for few seconds before serving a page.
Make that your home page (or set "sessino restore" and make that page your
last visited page). Make sure Chrome is not the default browser.
Start Chrome, the info-bar should appear and stay around. After few
seconds have elapsed, navigating to another page should cause the info-bar
to disappear.
TBR=ben
Review URL: http://codereview.chromium.org/113177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=beng
Review URL: http://codereview.chromium.org/113182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=beng
Review URL: http://codereview.chromium.org/115158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Add ifdef for filepath init (there is probably a better way of doing this).
- Make Linux UI use active/inactive tabs instead of hover/OTR.
TBR=beng
Review URL: http://codereview.chromium.org/113180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Temporarily remove theme resource validation to get unittests passing.
TBR=beng
Review URL: http://codereview.chromium.org/113178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to ThemeProvider later.
TBR=beng
Review URL: http://codereview.chromium.org/115155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=beng
Review URL: http://codereview.chromium.org/113175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15706 0039d316-1c4b-4281-b951-d872f2087c98
|