| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
method which would focus the RootView HWND confusing the button and the click would not trigger WM_COMMAND.
When the button was already focused, we were not setting the focus and the WM_COMMAND was sent correctly.
BUG=9273
TEST=Open the option dialog, click the Manage button in the "Default search" section. This should bring up the dialog. Close the dialog, the focus should be on the Manage button.
Review URL: http://codereview.chromium.org/42616
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
caused purify errors
Review URL: http://codereview.chromium.org/45055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- make more things const
- remove unreferenced declaration of GetGoButton
- fix indentation in one place
Review URL: http://codereview.chromium.org/53053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8786
Review URL: http://codereview.chromium.org/42587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9261
TEST=See bug.
Review URL: http://codereview.chromium.org/42582
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/encoding/char-decoding.html in platform/chromium-{win,mac}/fast/encoding. Somehow, they're baselined to have a bunch of 'FAIL' lines. The expected result in the test directory (LayoutTests/fast/encoding/char-decoding-expected.txt) shouldwork for all the platforms. It's platform-independent. BUG=9247
Review URL: http://codereview.chromium.org/42583
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to various methods and classes. Fix lint errors along the way.
R=darin,wtc
BUG=8993
Review URL: http://codereview.chromium.org/42541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than when it is pending. This makes it change at the same time the
page changes.
To support this, we now have to keep track of both a pending and a committed
DOMUI object. This is tracked by the RenderManager, which does a similar
swapping between pending and committed RenderViewHosts.
BUG=8963
Review URL: http://codereview.chromium.org/42512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
clock_gettime(). Add it to link_settings, and add the
right export_dependent_settings to propagate it through
the hierarchy appropriately.
Review URL: http://codereview.chromium.org/53057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This matches Firefox's behavior.
BUG=8170
Review URL: http://codereview.chromium.org/42452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the Unix/Winsock function gethostname.
R=eroman
Review URL: http://codereview.chromium.org/42590
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Modify SunSpider to work with the UI test framework.
BUG=8785
Review URL: http://codereview.chromium.org/42581
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r12459 - it broke the world.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, one can close a HANDLE which is currently being waited on. The MSDN
documentation says that the resulting behaviour is 'undefined', but it doesn't
crash. Currently, on POSIX, one couldn't use WaitableEventWatcher to watch an
event which gets deleted. This mismatch has bitten us several times now.
This patch allows WaitableEvents to be deleted while a WaitableEventWatcher is
still watching them. It applies only to watchers, the usual Wait() and
WaitMany() calls still require that all their target be valid until the end of
the call.
http://crbug.com/8809
Review URL: http://codereview.chromium.org/53026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
DEPS roll for latest gyp with 'link_languages' support.
Review URL: http://codereview.chromium.org/53041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bogus as InfoBar adds a button that invokes this method as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/53034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42568
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--run-part=x:y runs the xth part out of yth.
X is 1 based.
example, to run all the tests in 3 runs :
--run-part=1:3
--run-part=2:3
--run-part=3:3
Review URL: http://codereview.chromium.org/42170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for the rebaselining is the error message which is the same on all
platforms.
Review URL: http://codereview.chromium.org/53052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
go green
Review URL: http://codereview.chromium.org/53038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that the security token in V8 was set to the string
"null" for all data urls. Therefore, the access check succeeded. The
cause of the regression was that securityOrigin's toString
implementation was changed in WebKit to return "null" instead of
String().
R=kasperl@chromium.org
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/53049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Add an empty line at the end of the README file.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/47009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
platform-posix file in one more place.
Review URL: http://codereview.chromium.org/42595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
file and add a couple of new -inl.h files to the project.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/53044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/53043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Contains a number of bug fixes and an optimization for creating nested
object and array literals.
Review URL: http://codereview.chromium.org/45032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in turn calls uscript_getCode() to get the script code and compare it against
Hebrew and Arabic scripts (as opposed to languages).
TEST=L10n*.GetTextDirection
Review URL: http://codereview.chromium.org/40125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is almost the same change as <http://codereview.chromium.org/39252/show>, which caused a build break on a Linux buildbot while compiling my new template function in "chrome/common/render_messages.h".
Even though I was not able to reproduce the build errors on my Linux box, I removed this function and use the int type in my IPC message 'ViewMsg_SetTextDirection'.
BUG=1845
Review URL: http://codereview.chromium.org/42495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nico Weber <nicolasweber@gmx.de>.
Review URL: http://codereview.chromium.org/42561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Firefox has had this shortcut for a long time and I am told IE8+ added it as well.
In any case, we should match Firefox.
BUG=8458
TEST=Press Ctrl+Shift+Del and the Clear Browsing Data dialog should show up.
Review URL: http://codereview.chromium.org/42540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Basic factory support for 16 PCM audio
- Adds PCM audio using Queue Services
- Many functions not implemented, trying to keep CLs to a decent size
- Added two unit tests
Review URL: http://codereview.chromium.org/42494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of test_shell_tests.
Fixes following valgrind warning:
380 bytes in 9 blocks are possibly lost in loss record 331 of 423
at operator new(unsigned int) vg_replace_malloc.c:230
by std::string::_Rep::_S_create(unsigned int, unsigned int, std::allocator<char> const&) (in libstdc++.so.6.0.9)
by (within libstdc++.so.6.0.9)
by std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in libstdc++.so.6.0.9)
by CommandLine::CommandLine(int, char const* const*) src/base/command_line.cc:96
by CommandLine::Init(int, char const* const*) src/base/command_line.cc:177
by main src/webkit/tools/test_shell/run_all_tests.cc:57
Review URL: http://codereview.chromium.org/45041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the autofill popup.
Pressing up would not trigger that behavior.
This happened because the default processing of the up arrow key is to move the caret to the beginning of the text input.
Showing the autofill is done as a posted task.
Because the caret was not at the end of the text-field by the time that task got executed, the popup would not show.
The fix is to not default process the up/down arrow key messages when an autofill popup will be shown.
Also fixed the WebViewImpl::HideAutoCompletePopup (harmless bug, calling it twice would cause it to hide the already hidden popup).
BUG=6437
TEST=Make sure up/down arrow keys trigger the autofill menu correctly (especially when there is already text in the text-field). Make sure autofill still works as expected.
Review URL: http://codereview.chromium.org/53017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=2074,3823
TEST=1. LayoutTests/fast/encoding
2. chromium/fast/encoding
3. Go to https://bug381412.bugzilla.mozilla.org/attachment.cgi?id=267398
and see a bunch of 'inverse question marks' for U+FFFD. Also, hovering the mouse
over 'aaa' should not bring up an alert box. A real layout test will be added
later.
TBR=agl
Review URL: http://codereview.chromium.org/45039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
s.html' file. Update the unit test to match the change in bookmark_html_writer.cc
The initial CL got reverted because the unittest failed. This CL changes the unittest.
BUG=6957
Review URL: http://codereview.chromium.org/48042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I realize this will all go away Any Day Now. Until then, we can speed things up a bit more.
Review URL: http://codereview.chromium.org/53029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This lets you use regular full-optimization Release builds.
Review URL: http://codereview.chromium.org/53022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9214
Review URL: http://codereview.chromium.org/53033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12422 0039d316-1c4b-4281-b951-d872f2087c98
|