| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/306049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
buildbots seemed to ignore the heapchecker symbols defined previously in ldflags)
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=evan,mbelshe,bradn already LGTM'd at http://codereview.chromium.org/300039
Review URL: http://codereview.chromium.org/315015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In layout_tests, test_shell crashed by
/base/ref_counted.cc(60)] Check failed: in_dtor_. RefCountedThreadSafe object deleted without calling Release()
in context of
test_shell(webkit_glue::WebSocketStreamHandleImpl::Context::DidClose(WebKit::WebSocketStreamHandle*)+0x7d) [0x8f6b34b]
Since bridge instance is ref counted object, we must not delete it.
Make base class WebSocketStreamHandleBridge RefCountedThreadSafe,
and manage it by scoped_refptr.
BUG=25399
TEST=layout tests not crashed in XHR tests.
Review URL: http://codereview.chromium.org/316008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRASH
TBR=nsylvain
BUG=25399
TEST=none
Review URL: http://codereview.chromium.org/315014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old image had the "inset" border though this field has "inputtext"
CSS class, which has "border:1px solid #bdc7d8".
It still fails on WIN-VISTA. The field on WIN-VISTA is wider than on
WIN-XP by 2 pixels.
BUG=21859
TEST=none
Review URL: http://codereview.chromium.org/307035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocketStreamHandleBridge.
Fix memory leak of WebSocketStreamHandleBridge hold in Context.
Detach Context before WebSocketStreamHandle is deleted.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/315011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These tests are no longer failing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/303032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=erikkay
Review URL: http://codereview.chromium.org/306046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23974
TEST=http://fbarchard-kir.ad.corp.google.com/testmatrix/red/red2.ogv
Review URL: http://codereview.chromium.org/316005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The compiler warned about this. See
http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-49#section-4.2
for how to calculate the length.
Review URL: http://codereview.chromium.org/293055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Review: http://codereview.chromium.org/297003
BUG=24846
TEST=URLRequestTest.DataURLImageTest, NetUtilTest.GetSuggestedFilename
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions:
- registerURLSchemeAsLocal
- registerURLSchemeAsNoAccess
- whiteListAccessFromOrigin
- resetOriginAccessWhiteLists
BUG=24601
TEST=Compiled locally, try bot'ed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29639
Review URL: http://codereview.chromium.org/293021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=should start passing
TBR=hclam
Review URL: http://codereview.chromium.org/318001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/49619 add a mac baseline where the test is expected to fail. Refer to https://bugs.webkit.org/show_bug.cgi?id=26856 for discussion.
We're still passing the test, so we need yet another baseline.
BUG=n/a
TEST=should pass again
TBR=dglazkov
Review URL: http://codereview.chromium.org/307034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has been merged.
BUG=13907
TEST=it should start running + passing
TBR=hclam
Review URL: http://codereview.chromium.org/292062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
session/local storage.
BUG=none
TEST=|'localStorage' in window| should only be true iff enablelocalstorage
is specified
Review URL: http://codereview.chromium.org/293032
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/315009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the media resource is a file:// we can always report that we have enough data to play the file. We end up passing a bunch of layout tests.
BUG=13907
TEST=more layout tests pass
Review URL: http://codereview.chromium.org/316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
more like the mocks).
BUG=12119
TEST=chrome://extensions page should look more like the screenshot in the bug.
Review URL: http://codereview.chromium.org/303028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=go go green tree!
TBR=hclam
Review URL: http://codereview.chromium.org/316007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
well for nested run loops under our own control (those started by Run) and
those beyond our control (native event loops).
Previously, upon any exit from a nested native loop, we would schedule
nesting-deferred work for processing. However, some nested native loops do
not execute in a single loop; rather, they start and stop the CFRunLoop
rapidly. In such cases, each exit from the CFRunLoop would cause
nesting-deferred work to be scheduled, and on each new entry to the CFRunLoop,
we would attempt to process it. This rapid-fire action meant that we'd never
sleep. Nested loops managed by Run were exempt from these problems since
r28811, because we could defer scheduling nesting-deferred work until
returning to Run.
The new strategy is to detect whether any nested loops (native or managed by
Run) had run before the run loop goes to sleep or exits. If any nested loops
did run, nesting-deferred work is scheduled for processing.
BUG=24968
TEST=1. Test case from bug 24968, printing: open any page, press command-P,
leave the dialog up, and check Chrome's CPU usage. No Chrome process
should be monopolizing any CPU. This tests nested native run loops.
2. Test case from bug 24337, JS alerts: open Gmail, start composing a new
message in a new window, address it to yourself, move focus to the
subject field, click the Discard button, and click "OK" at the alert.
The alert and composition window should close.
3. Test case from bug 24383, JS alerts: no Chrome processes should use
100% CPU after visiting javascript:alert("hi"). The JS alert cases
test nested run loops managed by Run.
4. Test case from bug 13468 comment 5, autocomplete: autocomplete should
still work after using "Back" from a contextual menu. This tests
that nesting-deferred work is processed after leaving a nested run
loop.
5. First run UI test case (no bug). Remove or move aside the profile
directory (~/Library/Application Support/Chromium or
~/Library/Application Support/Google/Chrome) and launch the
application. There should be first-run UI and it should be usable.
Upon clicking "Start (application)", the application should start and
be usable as normal. This tests delegateless run loops and
delegateless work redispatch.
6. base_unittests --gtest_filter='MessageLoopTest.*'
Review URL: http://codereview.chromium.org/300044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakage fixed itself when WebKit reverted!
BUG=none
TEST=none
TBR=tc,jshin
Review URL: http://codereview.chromium.org/293051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage
is specified
Review URL: http://codereview.chromium.org/293032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/292059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=should start passing
TBR=hclam
Review URL: http://codereview.chromium.org/292058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23825
TEST=Close all browser windows. Check that Help->Chromium Help (or Google Chrome Help) is enabled and works correctly.
Review URL: http://codereview.chromium.org/303030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
original state.
BUG=23514
TEST=Type a URL into the omnibox, then Cmd-Return. The omnibox text should revert to its original state.
Review URL: http://codereview.chromium.org/260008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ability to run a client with ssl & compression turned off.
Update the command line to accomodate.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/315006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=tree goes green
TBR=hclam
Review URL: http://codereview.chromium.org/306042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The latter became necessary by webkit revision 49899 : http://trac.webkit.org/changeset/49899.
The former is to support am/sw versions of Chrome.
BUG=25401,25451
TEST=1. With '--lang=am' or '--lang=sw' on Windows or 'LANGUAGES=am chrome' on Linux, language names in Options | Advanced | Languages and Fonts menu are actually translated into Amharic and Swahili.
2. LayoutTests/fast/text/international/japanese-kana-letters.html passes.
TBR=johnnyg
Review URL: http://codereview.chromium.org/303027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25314
Review URL: http://codereview.chromium.org/315005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GCC_SYMBOLS_PRIVATE_EXTERN set to 'NO', or the plugin gets over-stripped and broken.
Review URL: http://codereview.chromium.org/300046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targets.
Pulling in latest nacl with fix for x86 autodetection.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/313012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/307031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
uninitialized after the object is constructed.
CID=1632
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous code used an elaborate system of checks, which was gradually
becoming unmaintainable. Now that -resetFieldEditorFrameIfNeeded is
implemented using dirty tricks, it is pretty easy to just check if it
changed rather than trying to predict it.
BUGS=none
TEST=none
Review URL: http://codereview.chromium.org/295036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internal. This ensures
that the linker won't complain about IP relative addressing for symbols that could be overridden at
run-time.
- avoided using "g" register constraints, as there has been a report of some versions of GCC
erroneously generating code that is no longer position independant when this constraint is used.
- removed the old code that fork()'s a child to try to extend mappings of libraries at run-time. This
code always was somewhat fragile and caused a measurable performance penalty when the sandbox was
started. Replaced with code that remapped just the very first page. This can actually be done in a
running process without disrupting the use of the libraries.
- added a special case for the instrumentation code allowing it to deal with jumps between the VDSO
and VSyscalls even if the instructions would normally not be eligible for interception as they are IP
relative. After making this change, we can again find sufficiently large code snippets to rewrite them
successfully. This is only a concern on x86_64.
- fixed a bug that would erroneously look for IP relative addressing on x86_32. It doesn't exist for
that architecture.
TEST=none
BUG=http://code.google.com/p/chromium/issues/detail?id=18337
Review URL: http://codereview.chromium.org/306036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was lost when ImagePainter was refactored as part of the fix to http://crbug.com/23261.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/300019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ability to list files and display them in JS via DOMUI.
BUG=none
TEST=none
Original review: http://codereview.chromium.org/255090
Patch by David Garcia.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests were all fixed upstream to use onload events, rather than setTimeouts to wait for iframe loading.
All were clearly flaky before the fix and haven't flaked since.
Webkit change: http://trac.webkit.org/changeset/49592
TEST=layout test try servers
BUG=9798,12341
Review URL: http://codereview.chromium.org/295047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24085
TEST=<a href="aim:goim?screenname=JerseyGrl&message=lol">Click here to message me on AIM!</a>
Review URL: http://codereview.chromium.org/306017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from a worker thread.
BUG=24307
TEST=current unit tests / valgrind
Review URL: http://codereview.chromium.org/309001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=With crash reporting enabled, renderer process command line doesn't have a trailing '?' in the --enable-crash-reporter switch value.
Review URL: http://codereview.chromium.org/307027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
purpose of the class.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=2635
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/300042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and shows it on the page.
BUG=12119
TEST=Open chrome://extensions and all extensions that
have an icon associated with them, should show the
icon and those that don't have the generic plugin
icon.
Review URL: http://codereview.chromium.org/292048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=tree stays green
TBR=hclam
Review URL: http://codereview.chromium.org/306035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=25429
Review URL: http://codereview.chromium.org/293057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29711 0039d316-1c4b-4281-b951-d872f2087c98
|