summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Start Chrome button on First Run customize view should launch Chrome.kuchhal@chromium.org2009-07-092-1/+1
| | | | | | | | BUG=16358 Review URL: http://codereview.chromium.org/149398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20295 0039d316-1c4b-4281-b951-d872f2087c98
* Remove reference counting from WebWidgetDelegate.darin@chromium.org2009-07-096-28/+3
| | | | | | | | | | | | | | | | | This was added as a speculative crash fix by eseidel back in June of 2008. See http://b/1211911 for details. It didn't appear to resolve the crash then (as another patch was required to fix the bug), and it doesn't seem to be necessary since the RenderView, which is the delegate and owns the WebView, is the one in charge of allocating the WebView and destroying the WebView. So, it is not possible for the WebView to outlive the RenderView. BUG=16234 TEST=none R=brettw Review URL: http://codereview.chromium.org/155292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20294 0039d316-1c4b-4281-b951-d872f2087c98
* Set the save file type index properly if there was only one file type.paul@chromium.org2009-07-091-0/+2
| | | | | | | | | | | | | | The save file indexes are 1 based, and if there is only one file type that the page can be saved as (such as a page like foo.com/notes.txt), the index is set to 0 which will cause a crash. BUG=15555 (http://crbug.com/15555) TEST=Go to a web page that is a text file and try to save it. Chrome should not crash. Review URL: http://codereview.chromium.org/155264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20293 0039d316-1c4b-4281-b951-d872f2087c98
* Perf bots are "happy enough", enable the throbber for real.pinkerton@chromium.org2009-07-091-22/+10
| | | | | | | | BUG=12699 TEST=throbber animations in tabs while page loading. Review URL: http://codereview.chromium.org/149400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20292 0039d316-1c4b-4281-b951-d872f2087c98
* Support running app_unittests under Valgrindnirnimesh@chromium.org2009-07-091-0/+4
| | | | | | Review URL: http://codereview.chromium.org/155216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20290 0039d316-1c4b-4281-b951-d872f2087c98
* Converts linux2 in grd file to chromeos.sky@chromium.org2009-07-091-1/+1
| | | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/155300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20289 0039d316-1c4b-4281-b951-d872f2087c98
* Try a new set of buttons (which should also work much better with themes).glen@chromium.org2009-07-0916-0/+0
| | | | | | | | | TBR=mirandac BUG=13821 TEST=Verify that our toolbar buttons have the same visual style in normal, hover and pressed states git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20288 0039d316-1c4b-4281-b951-d872f2087c98
* In preparation for becoming an internal plugin in chrome I did these things:apatrick@google.com2009-07-0917-1205/+1294
| | | | | | | | | | | - Move declarations in the global namespace into the o3d namespace to avoid conflicts with Chrome. - Ifdef out code that we do not want to run as an internal plugin (like breakpad, DllMain, etc) - Prevent NP_Initialize, etc from being exported as an internal plugin. Unfortunately I had to move functions around to group them by namespace so the diffs look like there is more change than there actually is. Review URL: http://codereview.chromium.org/149130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20285 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the v8 npruntime bindings and use the upstreamed ones.japhet@chromium.org2009-07-096-618/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20284 0039d316-1c4b-4281-b951-d872f2087c98
* This CL prevents the first run UI from showing in the browser tests, as it ↵jcampan@chromium.org2009-07-091-0/+3
| | | | | | | | | | | | would be unexpected and cause the test to hang waiting for user interaction. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/155293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20283 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 193.0 to 194.0laforge@chromium.org2009-07-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20282 0039d316-1c4b-4281-b951-d872f2087c98
* Disable media ui test again because it doesn't run without audio devicehclam@chromium.org2009-07-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20280 0039d316-1c4b-4281-b951-d872f2087c98
* Add additional render histogramsjar@chromium.org2009-07-091-2/+30
| | | | | | | | | | Trying to debuge distinction in between several start times (request vs start, vs begin). r=davemoore Review URL: http://codereview.chromium.org/149396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: add LOG(FATAL) to try and catch an error."agl@chromium.org2009-07-091-8/+0
| | | | | | | | This reverts commit r20271. The FATAL log triggered on the build bots, which is a very useful data point! git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20278 0039d316-1c4b-4281-b951-d872f2087c98
* Add expected timeout for a flaky test, which has been timing out with some ↵eroman@chromium.org2009-07-091-1/+1
| | | | | | | | | | | | regularity today. Seems to have increased in flakiness around build 3894 of Webkit Linux (dbg)(3). TBR=tony Review URL: http://codereview.chromium.org/149395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20277 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most flakiness-prone Browser UI tests to browser_tests framework.phajdan.jr@chromium.org2009-07-093-76/+86
| | | | | | | | | TEST=none BUG=http://crbug.com/16062 Review URL: http://codereview.chromium.org/149365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20276 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UI test MediaTest.VideoBearH264hclam@chromium.org2009-07-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20275 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NOTIMPLs into a bug.estade@chromium.org2009-07-091-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20274 0039d316-1c4b-4281-b951-d872f2087c98
* Testing perfbots with throbber enabledpinkerton@chromium.org2009-07-091-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20273 0039d316-1c4b-4281-b951-d872f2087c98
* Change ThumbnailStore to use sqlite instead of individual files try 2. ↵meelapshah@chromium.org2009-07-097-279/+226
| | | | | | | | Previous try failed interactive_ui_tests. Review URL: http://codereview.chromium.org/149361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20272 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add LOG(FATAL) to try and catch an error.agl@chromium.org2009-07-091-0/+8
| | | | | | | | | | | | | | | Crash reports like: http://crash/reportview?product=Chrome_Linux&version=3.0.192.0&date=&signature=WebCore::TextRunWalker::nextScriptRun()-3F2080B are popping up and I don't know why. I suspect that we might we returning an empty family string from fontconfig, so I'm adding a LOG(FATAL) to catch this. We'll see in the crash reports from next week if it's getting hit. R=evan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20271 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that SDCH is initialized at all times.jar@chromium.org2009-07-091-11/+8
| | | | | | | | | | | | There is an active A/B experiment to test the impact of SDCH support. This change correctly toggles support by simulating the command line flag, rather than incorrectly avoiding initialization of the module. BUG=16274 r=huanr Review URL: http://codereview.chromium.org/155277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20270 0039d316-1c4b-4281-b951-d872f2087c98
* Make the toolbar theme align with the left edge of the browser and the top ↵glen@chromium.org2009-07-094-7/+10
| | | | | | | | | | | edge of the tab strip. BUG=none TEST=install a theme with lines across the toolbar and frame, and verify that the lines line up across the frame,toolbar,bookmarks bar and find bar. Review URL: http://codereview.chromium.org/155124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20269 0039d316-1c4b-4281-b951-d872f2087c98
* A prototype of resource loading through automationamit@chromium.org2009-07-0922-98/+881
| | | | | | | | | | | | | | | | In a test scenario where we need to load resources over automation, we intercept the URL reqeusts and serve them using automation IPCs. This resource loading can be enabled per tab created by automation. BUG=none TEST=none Review URL: http://codereview.chromium.org/145024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20267 0039d316-1c4b-4281-b951-d872f2087c98
* mac workaround.evan@chromium.org2009-07-091-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20266 0039d316-1c4b-4281-b951-d872f2087c98
* Copy parsed URL into CF_UNICODETEXT when user select entire of Omnibox.hamaji@chromium.org2009-07-091-12/+15
| | | | | | | | | | | | | | | | | | | | BUG=2820 BUG=8162 TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 荳雁慍. Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 荳雁慍. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". Paste the copied text into URL-aware softwares such as MS-word and check if the pasted text contains 荳雁慍. Check if the link in MS-word is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0). TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 again and select "q=荳雁慍" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=荳雁慍". TEST=Copy "荳雁慍" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded. Review URL: http://codereview.chromium.org/119352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20265 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement the sad pluginevan@chromium.org2009-07-095-15/+20
| | | | | | | | | | | | | | This required moving the sad plugin resource out of the Windows-specific code. Note that it doesn't display right yet, since the place to display is covered by the GtkSocket that used to host the plugin. But that is a separate issue. (I had it draw to the side to verify the image was correctly getting loaded.) BUG=16158 Review URL: http://codereview.chromium.org/155262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20264 0039d316-1c4b-4281-b951-d872f2087c98
* Revert unintentional change.abarth@chromium.org2009-07-091-5/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20263 0039d316-1c4b-4281-b951-d872f2087c98
* Add more suppressions, adapt more to work on hardy (and not just jaunty), ↵dkegel@google.com2009-07-091-30/+101
| | | | | | | | | | | | fix the whitespace problem (again?!) BUG=10737,10737,16129,16153,16156,16161,16324,16326 TEST=watch linux ui valgrind test bot go greener Review URL: http://codereview.chromium.org/155196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20262 0039d316-1c4b-4281-b951-d872f2087c98
* I've seen recently a race condition while debugging printing. The pages are ↵sverrir@google.com2009-07-091-1/+5
| | | | | | | | | | | | | not sent from the renderer quickly enough which causes the print thread to hang (no new page notifications are sent any more). This change simply adds a poll every half a second for a new page. BUG=none TEST=none Review URL: http://codereview.chromium.org/149390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20261 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable test (disabled while moving printing functionality to printing ↵sverrir@google.com2009-07-093-15/+14
| | | | | | | | | | | library). TEST=Run printing_unittests (no functional change). BUG=none Review URL: http://codereview.chromium.org/149288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20260 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Nuke unused debugger test.pfeldman@chromium.org2009-07-094-452/+0
| | | | | | Review URL: http://codereview.chromium.org/150214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20259 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'resize_leading_on_bounds_change' property into the SingleSplitView.pfeldman@chromium.org2009-07-093-1/+29
| | | | | | | | When it is turned on, leading component is resized when split view gets new bounds. Review URL: http://codereview.chromium.org/155214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20258 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: paint devtools split with COLOR_TOOLBAR.pfeldman@chromium.org2009-07-091-0/+5
| | | | | | Review URL: http://codereview.chromium.org/149258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20257 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.2.13.2 to bring in newkasperl@google.com2009-07-091-1/+1
| | | | | | | | | | v8.gyp file. BUG=none TEST=none Review URL: http://codereview.chromium.org/149384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20256 0039d316-1c4b-4281-b951-d872f2087c98
* abarth apparently did not run ↵jorlow@chromium.org2009-07-091-1/+1
| | | | | | | | | | | | "\src\webkit\tools\layout_tests>run_webkit_tests.bat --lint-test-files" :-) TBR=abarth BUG=none TEST=none Review URL: http://codereview.chromium.org/155280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20255 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPSabarth@chromium.org2009-07-099-21/+31
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/155278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20254 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: show property type names in Elements panel and Console.yurys@google.com2009-07-092-28/+49
| | | | | | | BUG=15988 Review URL: http://codereview.chromium.org/149341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20253 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try updating V8 in Chromium to version 1.2.13, but now using thekasperl@google.com2009-07-091-1/+1
| | | | | | | | | old v8.gyp file. TBR=deanm@chromium.org Review URL: http://codereview.chromium.org/155275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20252 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20249.kasperl@google.com2009-07-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20250 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.2.13.kasperl@google.com2009-07-091-1/+1
| | | | | | | | BUG=16276 TEST=none Review URL: http://codereview.chromium.org/149382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20249 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 20247bradnelson@chromium.org2009-07-091-1/+1
| | | | | | | | TBR=sgk Review URL: http://codereview.chromium.org/155273 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20248 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling in new gyp version.bradnelson@chromium.org2009-07-091-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/149379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20247 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Position always off-screen when starting upyuzo@chromium.org2009-07-091-1/+2
| | | | | | | | | | | | | | Fixed the offset-by-taskbar logic. Tested with dual monitors, trying left-right and up-down monitor layouts. TEST=Use dual monitors (first:left, second:right) and open, close, and reopen Chromium in the second (right) window. Without this change, the window appears far to the right from the last location. BUG=15199 Review URL: http://codereview.chromium.org/155201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20246 0039d316-1c4b-4281-b951-d872f2087c98
* GtkPluginContainerManager::UnrealizeCallback should be void.craig.schlenter@chromium.org2009-07-092-3/+3
| | | | | | Review URL: http://codereview.chromium.org/149347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20245 0039d316-1c4b-4281-b951-d872f2087c98
* - Fix janklist issue #1: "there is a pixel line below the mainjrg@chromium.org2009-07-0912-115/+272
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | toolbar. The main toolbar should blend in with the bookmark bar when it's open" - Fix janklist issue #2: "It's way too tall - the distance from the bottom of the bar to a bookmark button bottom edge should be the same as the distance from the omnibox to the bookmark button top edge (this will probably mean that the bar has to overlap the toolbar)." - Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons have a frame around them ... " - Fix janklist issue #9: "the show/hide animation is very janky... I see a dark gray area behind". Even with animators the grey is gone, but animators are disabled for now due to races. - Fix unlisted jank related to 9: don't use animator when opening bar on launch. - Also chipped away on unit tests. TEST=Launch with bookmark bar both open and closed. Make sure OK on launch. In each case open and close a few times fast. Repeat with multiple windows open. Sanity check jank descriptions listed above are fixed. BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724 Review URL: http://codereview.chromium.org/149308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20244 0039d316-1c4b-4281-b951-d872f2087c98
* Windowed plugins like Flash would cause the hung plugin dialog to show up ↵ananta@chromium.org2009-07-0911-50/+146
| | | | | | | | | | | | | | | when the print dialog was displayed. The proposed fix is to signal the modal dialog event which would ensure that the renderer and plugins both pump messages when the print dialog is displayed. This fixes http://code.google.com/p/chromium/issues/detail?id=13804 Bug=13804 Review URL: http://codereview.chromium.org/155133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20243 0039d316-1c4b-4281-b951-d872f2087c98
* Updated FFmpegDemuxerTest and FFmpegVideoDecoderTest to use the gmock-based ↵scherkus@chromium.org2009-07-096-340/+30
| | | | | | | | | | | | | MockFilterHost. Also deleted the old MockPipeline and MockFilterHost code as it has been completely deprecated. BUG=16008 TEST=FFmpegDemuxerTest and FFmpegVideoDecoderTest Review URL: http://codereview.chromium.org/149366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20242 0039d316-1c4b-4281-b951-d872f2087c98
* Update mini installer to include FFmpeg DLLs for Chromium.scherkus@chromium.org2009-07-091-2/+2
| | | | | | | | | TEST=mini installer should include the DLLs BUG=15906 Review URL: http://codereview.chromium.org/149372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20241 0039d316-1c4b-4281-b951-d872f2087c98
* Hack and slash TabStrip2 into mostly working state - DWM frame is now ↵ben@chromium.org2009-07-093-15/+1
| | | | | | | | properly adjusted with --enable-tabtastic2, tab text doesn't cause black squares to be rendered etc.Also, remove some code invalidated by my fix earlier this week to make the distributor logo not overlap the window controls.BUG=noneTEST=none Review URL: http://codereview.chromium.org/155267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20240 0039d316-1c4b-4281-b951-d872f2087c98