summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use NotificationRegistrar to handle notification observing.pkasting@chromium.org2009-05-216-37/+20
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16559 0039d316-1c4b-4281-b951-d872f2087c98
* Send the V8 histograms to UMAdavemoore@chromium.org2009-05-211-1/+5
| | | | | | Review URL: http://codereview.chromium.org/115183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16558 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2125-793/+516
| | | | | | | | This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811. Review URL: http://codereview.chromium.org/113680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark editor. We crash when we don't have a selected folder, ↵erg@google.com2009-05-211-5/+11
| | | | | | | | | | but we don't select a folder by default when we're adding a new bookmark. Review URL: http://codereview.chromium.org/115598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16556 0039d316-1c4b-4281-b951-d872f2087c98
* Relax decoding error handling requirements.hclam@chromium.org2009-05-211-4/+15
| | | | | | | | Set the error_recognition and error_concealment flags in the codec context similar to ffplay.c. Also silently drops frames that didn't decode properly instead of stops the entire pipeline. Review URL: http://codereview.chromium.org/113653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16555 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NotificationRegistrar safe for use in Singletons, which may outlive ↵pkasting@chromium.org2009-05-213-5/+26
| | | | | | | | | | | the NotificationService instances, by checking whether the service exists before calling RemoveObserver() on it. Also add comments in NotificationService telling people to use NotificationRegistrar. BUG=2381 Review URL: http://codereview.chromium.org/115601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16554 0039d316-1c4b-4281-b951-d872f2087c98
* Register the icons for play/pause and max-volume/mute in the resource files, ↵ajwong@chromium.org2009-05-212-0/+9
| | | | | | | | and expose the names to webkit. Review URL: http://codereview.chromium.org/113665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16553 0039d316-1c4b-4281-b951-d872f2087c98
* Need to disable two print test temporarily to green the tree.levin@chromium.org2009-05-212-2/+2
| | | | | | | | | | TBR=dimich BUG=12363 TEST=none, just disabling some unit test temporarily. Review URL: http://codereview.chromium.org/115610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16552 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test expectations for newly added test.levin@chromium.org2009-05-201-0/+2
| | | | | | | | | BUG=12361 TEST=none, this change only notes that a newly added test is failing. Review URL: http://codereview.chromium.org/113676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16551 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit deps to pick up KURLGoogle.cpp with assert disabled.levin@chromium.org2009-05-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16550 0039d316-1c4b-4281-b951-d872f2087c98
* Use upstreamed v8 bindings for V8DOMWindowCustomjaphet@chromium.org2009-05-202-292/+1
| | | | | | | | BUG=12274 Review URL: http://codereview.chromium.org/113607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16549 0039d316-1c4b-4281-b951-d872f2087c98
* Remove widget_win.h dependency from fullscreen_exit_bubble.h. It is unused inbrettw@chromium.org2009-05-202-1/+1
| | | | | | | the header so I moved it to the .cc. Review URL: http://codereview.chromium.org/115578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16548 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2025-516/+793
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16547 0039d316-1c4b-4281-b951-d872f2087c98
* Remove JSDOMBinding, which is no longer used.dglazkov@chromium.org2009-05-204-96/+0
| | | | | | | | | | R=levin BUG=3319 TEST=no test regressions Review URL: http://codereview.chromium.org/113372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16546 0039d316-1c4b-4281-b951-d872f2087c98
* About box development.jrg@chromium.org2009-05-208-15/+950
| | | | | | | | | | | BUG=http://codereview.chromium.org/112044 Note pieces of chrome.gyp come from a different CL (keystone_glue work associated with this). Review URL: http://codereview.chromium.org/113614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16545 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 43889:43933levin@chromium.org2009-05-202-2/+7
| | | | | | | | | | | | Test expectation has updates for new failures along with bugs that list the change that caused the failures. BUG=0 TEST=none Review URL: http://codereview.chromium.org/115594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16544 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp deps. This includes the following change:tc@google.com2009-05-201-1/+1
| | | | | | | | | | | | | r496 | sgk@chromium.org | 2009-05-20 11:11:15 -0700 (Wed, 20 May 2009) | 3 lines Make copied files part of target_files, not prerequisites, so they get installed even if the target has no other output files. Review URL: http://codereview.chromium.org/113647 Review URL: http://codereview.chromium.org/113666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16543 0039d316-1c4b-4281-b951-d872f2087c98
* Add Croc code coverage config for linux.rspangler@google.com2009-05-201-0/+89
| | | | | | Review URL: http://codereview.chromium.org/115591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16542 0039d316-1c4b-4281-b951-d872f2087c98
* Image files for media elementshclam@chromium.org2009-05-204-0/+0
| | | | | | | | | | | | Uploaded the following images: muted: webkit\glue\resources\media_sound_none.png not muted: webkit\glue\resources\media_sound_full.png play: webkit\glue\resources\media_play.png pause: webkit\glue\resources\media_pause.png Review URL: http://codereview.chromium.org/113668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16541 0039d316-1c4b-4281-b951-d872f2087c98
* Development of keystone glue.jrg@chromium.org2009-05-204-37/+375
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=http://codereview.chromium.org/112044 chrome.gyp caught in a different CL but here is the relevant part of the diff: --- chrome.gyp (revision 16158) +++ chrome.gyp (working copy) @@ -2679,6 +2682,11 @@ ], 'sources': [ 'app/breakpad_mac_stubs.mm', + # *NO* files in chrome/app have unit tests (except keystone_glue)!!! + # It seems a waste to have an app_unittests target, so for now + # I add keystone_glue.m explicitly to this target. + 'app/keystone_glue.m', + 'app/keystone_glue_unittest.mm', # All unittests in browser, common, and renderer. 'browser/autocomplete/autocomplete_unittest.cc', 'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm', Review URL: http://codereview.chromium.org/113613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16540 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent setting the checkbox value in menus from activating the menu item.erg@google.com2009-05-201-0/+21
| | | | | | | | http://crbug.com/11942 Review URL: http://codereview.chromium.org/115589 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16539 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2024-793/+516
| | | | | | | | This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a. Review URL: http://codereview.chromium.org/113664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
* Looks like svg/custom/grayscale-gradient-mask.svg always passes in release mode.darin@chromium.org2009-05-201-1/+1
| | | | | | | | R=levin Review URL: http://codereview.chromium.org/113663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16537 0039d316-1c4b-4281-b951-d872f2087c98
* Unified the ways Font and Canvas get the pixel size of strings, using pangodavemoore@chromium.org2009-05-202-15/+38
| | | | | | Review URL: http://codereview.chromium.org/115586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16535 0039d316-1c4b-4281-b951-d872f2087c98
* Add HKLM + HKCU lookup for COM history indexercpu@google.com2009-05-201-16/+43
| | | | | | | | | | | | - slight refactor TEST= there are no tests BUG= http://b/issue?id=1860803 Review URL: http://codereview.chromium.org/113605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16534 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reject empty file filters for file chooser dialogs.estade@chromium.org2009-05-201-3/+10
| | | | | | | | | | Note that this is temporary in that, in the long run, we should be using mime type filters rather than shell-style globs. TEST=right click/save as on a link. There should be no "*." filter. Review URL: http://codereview.chromium.org/113660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16533 0039d316-1c4b-4281-b951-d872f2087c98
* Minor gtk-views cleanup:sky@chromium.org2009-05-209-23/+177
| | | | | | | | | | | | | . Makes closing widget work. . Makes clicking button send action. . Fixes ownership of native controls. BUG=none TEST=none Review URL: http://codereview.chromium.org/113657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16532 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring cygwin project and dependencies that seem to have been clobbered ↵bradnelson@google.com2009-05-201-0/+36
| | | | | | | | at some point. Review URL: http://codereview.chromium.org/115590 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16531 0039d316-1c4b-4281-b951-d872f2087c98
* mac_util::SetOverrideAppBundle() are handled in class ChromeTestSuite.jrg@chromium.org2009-05-201-10/+0
| | | | | | | | | They should not be modified here (and especially should not be undone in TearDown since it breaks things for following unit tests). Review URL: http://codereview.chromium.org/115554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16530 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2024-516/+793
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
* Implement process singleton on linux so if the user tries totc@google.com2009-05-203-16/+281
| | | | | | | | | | | | | | open multiple chrome processes, the first one just opens a new window. This is based on http://codereview.chromium.org/88067 by Nikita Ofitserov (himikof). BUG=8073 Review URL: http://codereview.chromium.org/115572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16528 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most of the Find UI tests to InProcBrowser tests. I might be able to ↵finnur@chromium.org2009-05-203-194/+235
| | | | | | | | | | | | | convert the remaining ones, but this is enough for a first pass. I also added a new disabled test, which will soon be enabled. BUG=None TEST=This whole changelist is about tests. :) Review URL: http://codereview.chromium.org/113646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16527 0039d316-1c4b-4281-b951-d872f2087c98
* Enable IDC_CLOSE_WINDOW on linux.estade@chromium.org2009-05-203-5/+5
| | | | | | | | I filed http://crbug.com/12334 to fix the ifdefed-out block in ui_test.cc. Review URL: http://codereview.chromium.org/113655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16526 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for MP3 decoding by duplicating packets before handing them to ↵scherkus@chromium.org2009-05-205-0/+117
| | | | | | | | | | the decoder. Turns out packets filled out by av_read_frame() were being modifying on subsequent calls to av_read_frame(). Might be a case of setting the data pointer to internal memory as opposed to allocated memory. Review URL: http://codereview.chromium.org/115561 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16525 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add background image theming to bookmark bar.estade@chromium.org2009-05-203-25/+57
| | | | | | | | | | I got rid of the border padding in an attempt to more closely match windows, where the bookmark bar is very compact. BUG=http://crbug.com/12216 Review URL: http://codereview.chromium.org/115551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16524 0039d316-1c4b-4281-b951-d872f2087c98
* Don't die on glib/gtk/gdk errors in release mode.estade@chromium.org2009-05-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/113654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16523 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to make the Gmail checker more robust in the face of errors.aa@chromium.org2009-05-201-47/+91
| | | | | | | | | | | | | The heart of this is that I wrapped up the request to the feed in a timeout and a bunch more error handling and abstracted all that into one function so I could be sure all the errors were getting handled the same way. Also general cleaning while I was in there. BUG=11969 TEST=Install Gmail Checker, go offline, go back online. It should start showing message counts again when you go back online. Review URL: http://codereview.chromium.org/115584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16522 0039d316-1c4b-4281-b951-d872f2087c98
* Update views deps to reflect new string source.ben@chromium.org2009-05-201-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/113658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16521 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPixbufNamed to ThemeProvider. GetPixbufNamed converts a loaded theme ↵jhawkins@chromium.org2009-05-207-25/+91
| | | | | | | | bitmap to a GdkPixbuf and caches the image so ThemeProvider users don't need to release them ala ResourceBundle::GetPixbufNamed. Review URL: http://codereview.chromium.org/113626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark bar where we had conflicting ids.erg@google.com2009-05-203-11/+42
| | | | | | | | http://crbug.com/12304 Review URL: http://codereview.chromium.org/115581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16519 0039d316-1c4b-4281-b951-d872f2087c98
* Change RenderWidgetHostViewGtk::Destroy() to call gtk_widget_destroy().willchan@chromium.org2009-05-201-0/+8
| | | | | | | | | BUG=http://www.crbug.com/11847. TEST=Navigate to an interstitial page. Click on Proceed. It should not crash. Review URL: http://codereview.chromium.org/115549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test redness.levin@chromium.org2009-05-201-0/+5
| | | | | | | | | | | | | | Add failures for recurring layout tests failures. This reverts part of r16498 which removed one of these test but the test is failing consistently now. BUG=http://crbug.com/12002, http://crbug.com/12340, http://crbug.com/12341 TEST=none needed. Just test expectations update. Review URL: http://codereview.chromium.org/115585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16517 0039d316-1c4b-4281-b951-d872f2087c98
* didn't mean to check these inben@chromium.org2009-05-202-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16516 0039d316-1c4b-4281-b951-d872f2087c98
* these strings were somehow removed in my earlier revert. add back to fix the ↵ben@chromium.org2009-05-203-2/+131
| | | | | | build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16515 0039d316-1c4b-4281-b951-d872f2087c98
* Use av_rescale_q() for converting FFmpeg timestamps to base::TimeDelta ↵scherkus@chromium.org2009-05-207-18/+64
| | | | | | | | | | | | (second attempt). Previously we were using integer math to convert to microseconds, but depending on the frame rate and packet size we could introduce enough error that could accumulate and introduce audio/video synchronization drift. av_rescale_q() is a simple function but is designed to minimize error as much as possible. Second attempt since I forgot to manually resolve av_rescale_q() for unittests. Review URL: http://codereview.chromium.org/113619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16514 0039d316-1c4b-4281-b951-d872f2087c98
* Make views/ use strings from app_strings.ben@chromium.org2009-05-2013-196/+69
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16512 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing gyp-generated app\* files to svn:ignoresgk@google.com2009-05-200-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16511 0039d316-1c4b-4281-b951-d872f2087c98
* Added a script to remove headers from the target.thomasvl@chromium.org2009-05-204-8/+65
| | | | | | | | Added a default in common.gypi to remove headers from all mac applications that are bundles. Added a var to control the inclusion of keystone to chrome.gyp defaulted on branding and then honor it for the shipping work. Review URL: http://codereview.chromium.org/113652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16510 0039d316-1c4b-4281-b951-d872f2087c98
* revert this change, svn seems to have committed it with my property-edit.ben@chromium.org2009-05-2013-69/+196
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16509 0039d316-1c4b-4281-b951-d872f2087c98
* Add generated files to svn:ignore list for views subdir.ben@chromium.org2009-05-2011-67/+66
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16508 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 10:54:12 +0000