| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This object may be deleted within a signal handler for its widget, which causes a DCHECK. Fix by using MessageLoop::DeleteSoon() instead.
BUG=http://www.crbug.com/11847
TEST=Open browser, navigate to www.google.com. Navigate to www.yahoo.com. This will delete the old RWHV. It shouldn't crash.
Review URL: http://codereview.chromium.org/113316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing.
This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators.
Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused.
BUG=11538
TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus.
Also test that tab traversal still work as expected in the browser and in the option dialog.
Review URL: http://codereview.chromium.org/113307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 81242e3b9c6e6fbc42ccf5f973b27ed4cf4401d6.
This wasn't the cause of the breakage.
Review URL: http://codereview.chromium.org/115337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit f2d9a44f3886aeab1378c8dbc1ce445202bc0ca5.
Review URL: http://codereview.chromium.org/115335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently only supports {left, top, width, height}.
Also, added extensions_api_client_unittest tests for CreateWindow, UpdateWindow & RemoveWindow
BUG=11200
R=mpComplete
Review URL: http://codereview.chromium.org/115316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now wait with a zero timeout. If the wait times out,
we take the same code path as WSAEWOULDBLOCK/WSA_IO_PENDING.
R=rvargas
http://crbug.com/9258
TEST=Covered by existing unit tests
Review URL: http://codereview.chromium.org/113371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
asynchronously.
This helps with jank (i.e. bug 11701 which I couldn't repro with this) and also with deadlocks (fixes 11421 for painting).
BUG=11421,11701
Review URL: http://codereview.chromium.org/115216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificate errors, do not map them to our (server)
certificate errors because the errors are referring to the
(missing) client certificate. If we incorrectly handle
them as server certificate errors, we will crash because
we can't get the server certificate from Schannel when the
handshake fails.
Fumitoshi Ukai of Google tracked down the bug and proposed
an alternative fix.
R=rvargas,ukai
BUG=http://crbug.com/11646
TEST=Visit https://www.cdep.ro/. Chromium should not crash.
Review URL: http://codereview.chromium.org/113375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Valgrind pointed out that we need extra events like focus-out to be processed
before we delete the object.
(While I'm at it, remove a useless if statement.)
BUG=9500
Review URL: http://codereview.chromium.org/113382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/113377
Patch from Matt Mueller <mattm@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
V8CanvasPixelArrayCustom.cpp
TEST=Use the dom elements: document.location and the canvas pixels
BUG=http://crbug.com/11917
Review URL: http://codereview.chromium.org/113364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as a whole and not just these changes).
Change global std::strings to chars* in browser theme provider.
Add ability for ReplaceStringPlaceHolder to take up to 9 replacements.
BUG=11235,11685
Review URL: http://codereview.chromium.org/115172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
dcheck failures when running page load tests with --enable-dcheck.
Review URL: http://codereview.chromium.org/113314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was requested for Ubuntu packaging.
Review URL: http://codereview.chromium.org/115332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unregister the sdch_dictionary_fetcher so that it destroys any pending
URLFetcher instances when we are nearing shutdown time. Dictionaries
are only *potentially* useful (and not needed) for future SDCH
fetches, so abandoning any pending items is safe and harmless.
b=9669
r=wtc
Review URL: http://codereview.chromium.org/113235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes FileDescriptorSet.BasicAddAndClose and FileDescriptorSet.SetDescriptors.
http://crbug.com/11724
Review URL: http://codereview.chromium.org/115326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/9420
Review URL: http://codereview.chromium.org/100358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
row and high levels that step thru the image.
Low level is implemented in MMX assembly.
Mac and Linux use reference code for this version.
Review URL: http://codereview.chromium.org/113247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Enable IDNToUnicodeFast test under Valgrind.
BUG=9172
Review URL: http://codereview.chromium.org/113370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
BUG=11924
Review URL: http://codereview.chromium.org/115329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=playmobil
Review URL: http://codereview.chromium.org/113367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
String util changes by darin@chromium.org.
BUG=11699
Review URL: http://codereview.chromium.org/115215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/113366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=11330
TEST=Go to the NTP and click "Remove thumbnails". This should hide the "Show
full history" link.
Review URL: http://codereview.chromium.org/112020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- turn off transparency when glass isn't active
- make transparency when glass is active more opaque
- decrease the size of text to match the current omnibox popup
- make dim text in highlighted rows invert.
Review URL: http://codereview.chromium.org/113242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The alternative is that gyp silently succeeds and your build mysteriously
doesn't link, even after you've installed the dependencies, and you need
to know to rerun "gclient runhooks --force".
BUG=11432
Review URL: http://codereview.chromium.org/114007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/115324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(to exclude third_party/skia/src/core/core_files.mk).
Review URL: http://codereview.chromium.org/115320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Oversight in a previous change.
Review URL: http://codereview.chromium.org/115321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally reviewed at http://codereview.chromium.org/100353
Eliminate webkit/glue/webhistoryitem* in favor of adding a
NavigateBackForwardSoon method WebViewDelegate. This moves
all of the hacky details of how we intercept "history.{back,
forward,go}" into the webkit layer. My eventual plan is to
teach WebCore how to make this not hacky.
In this version of the CL, TestWebViewDelegate performs the
back/forward navigation directly in NavigateBackForwardSoon
instead of using PostTask to delay it. I'm doing this to
minimize regressions so that I can hopefully get the rest of
this CL landed.
I also already made the changes to WebKit to force history.
{back,forward,go} to be processed asynchronously.
Finally, it was necessary to move DumpBackForwardList out of
webkit_glue.cc since it was using itemAtIndex to generate
those results, and now that we return synthetic URLs for
that function, the results were very wrong. The fix is to
move DumpBackForwardList into TestShell so that it can more
directly inspect the TestNavigationController. Now, it is
necessary for webkit_glue.h to expose a function to dump
a content state string (aka a WebCore::HistoryItem).
BUG=11423
R=mpcomplete
Review URL: http://codereview.chromium.org/113328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tests failing due to upstream r43604, but abarth with investigate.
Otherwise, just some new baselines.
Review URL: http://codereview.chromium.org/115319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Install latest dev/beta channel build.
2. Install latest stable build.
3. Install latest dev/beta channel build at System level.
4. Install latest stable build at system level.
5. Install latest dev/beta full installer over previous dev/beta full installer.
6. Install latest stable full installer over previous stable full installer.
7. Install latest dev/beta diff installer over previous dev/beta full installer.
8. Install latest stable diff installer over previous stable full installer.
9. Install latest stable full installer over ChromeSetup.exe
10. Install latest beta full installer over beta ChromeSetup.exe
Review URL: http://codereview.chromium.org/115159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is in the docs, but there are a lot of docs, and all the other files
it's pulling flags from are printed during startup.
Review URL: http://codereview.chromium.org/113358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extensions) to the TabContentsView. Enable the zoom button on Mac to utilize it. Ensure we only send the IPC notification when the value changes, as WebCore tends to over-report that it has changed. Fix const-ness in delegate API where it's not necessary.
Review URL: http://codereview.chromium.org/115138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CPAPI (0.10) functions for gears drag drop; one to extract the
drag type/data given an NPObject *event, one to override the
drop effect (drag cursor).
Gears drag drop API receives a browser event as an NPObject* so
the event is untrusted. Provide IPC calls to the renderer so
gears can pass the event to renderer/V8 for checking, prior to
drag type/data extraction, or the setting of the drop effect.
V8 event checking is a TODO(noel), http://mondrian/10947778 for
the CPAPI (0.10) change submitted to gears.
BUG=7995
Original patch by Noel Gordon via:
http://codereview.chromium.org/99240
Review URL: http://codereview.chromium.org/115280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This worked before, but regressed for Chromium builds.
BUG=2278
Review URL: http://codereview.chromium.org/113350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15985 0039d316-1c4b-4281-b951-d872f2087c98
|