| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=34659
TEST=none
Review URL: http://codereview.chromium.org/600080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a cross platform base class
This will make the linux & mac impementations much simpler
BUG=11246
TEST=Aded wifi_data_provider_common_unittest.cc. Run: unit_tests.exe --gtest_filer=Geoloc*
Review URL: http://codereview.chromium.org/604019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jparent
Review URL: http://codereview.chromium.org/604032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jar,antonm
Review URL: http://codereview.chromium.org/596083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26734
TBR=pfeldman
Review URL: http://codereview.chromium.org/600096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, if the database has multiple cookies defined for the same (host, cookie name, cookie path), we will delete all but the most recently created cookie.
This step happens right after loading the cookie database.
I don't expect this to have any real impact on startup performance, since the cookie database is small, and compared to the cost of reading the DB from disk, should be cheap.
This CL also includes two other related changes:
(1) Added a histogram "Net.NumDuplicateCookiesInDb" that measures how common the need to remove duplicates is.
(2) If the in-memory store is ever found to contain duplicates after initializion, fail hard (crash).
The effect of this change will be users that had a bad database will get it fixed, and will no longer be sending duplicate cookies to servers.
-----------------------
Background:
-----------------------
Ok, so why does the corruption happen in the first place?
From what I can tell, the problem stems from how the interface between CookieMonster and the PersistentCookieStore is defined. Notably:
* It implements overwrites as "delete" + "insert" operations.
* It doesn't define the behavior when a "delete" or "insert" operation fails.
The steps that CookieMonster() runs through to overwrite a cookie is:
(a) Find the existing cookie, |old_cookie|, in the in-memory store.
(b) Delete |old_cookie| from the in-memory store.
(c) Ask the persistent cookie backing store to delete |old_cookie| (keyed by its creation time)
(d) Insert |new_cookie| into the in-memory store.
(e) Ask the persistent backing store to insert |new_cookie|.
This ordering assumes that no failures can happen during steps (c) and (e).
However in actuality, SQLitePersistentCookieStore swallows any errors it encounters writing to the DB, and does not attempt retries.
Here is one sequence of steps that could lead to your database getting hosed:
(1) Your cookie database becomes temporarily unwritable (maybe your home directory is network mounted and your kerberose ticket just expired).
(2) The browser gets a set-cookie to overwrite an existing cookie (perhaps a ping-back from gmail, which happen often).
Clearly steps (c) and (e) will now fail, since the database is offline. So the in-memory store will get changed, but the on-disk one won't.
(3) Now your cookie database becomes writable again (maybe you renewed the ticket).
(4) Another cookie update is received. This time, the update will cause us to insert a duplicate into the cookie database.
This happens because in step (c) the on-disk database is asked to delete the previous (at least according to the in-memory store) cookie. Well, the on-disk DB never wrote that value, so this has no effect, and the actual previous value remains. Next we insert the new value, kaboom.
A next step will be to re-work the PersistentCookieStore interface so SQLitePersistentCookieStore isn't as fragile to errors while overwriting.
BUG=17855
TEST=CookieMonsterTest.DontImportDuplicateCookies
Review URL: http://codereview.chromium.org/602029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe that the bug happened in this sequence of events:
1.) JS gets blocked on the web page, icon appears. The renderer (correctly) thinks js is blocked.
2.) User hits "reload"
3.) RenderView::didCommitProvisionalLoad() calls RenderView::UpdateURL() which sends ViewHostMsg_FrameNavigate to the browser which clears the content settings images in the location bar
4.) RenderView::allowScripts() gets called during page loading. The renderer still thinks that js is blocked and hence doesn't notify the browser.
5.) RenderView::didReceiveResponse() clears the content blocked flags (too late)
This CL moves the content blocked flags into navigationstate, which should prevent this "race" because there's one new navigationstate per page.
BUG=35011
TEST=See bug.
Review URL: http://codereview.chromium.org/596039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Point to this doc from the chrome.* APIs page.
While I'm in there, fix some typos in the generated doc,
add "nodoc" to experimental.accessibility (which was
never generated), and remove experimental.popup.html
(which was never *successfully* generated).
TEST=none
BUG=34766
Review URL: http://codereview.chromium.org/603019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35219
TEST=See bug report.
Review URL: http://codereview.chromium.org/600066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are:
- Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
- The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information.
- Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
- The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
- Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards.
- Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
- There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
- Cocoa databinding is utilized to syncronize dependent parts of the UI.
- All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
The things remaining to do are:
- Hook the UI up to the backend model, specifically the PersonalDataManager data.
- Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons.
- Scroll-to-Point support for autoscrolling when tabbing between fields.
- Billing and shipping address popups in the credit card section.
- Any validation of input (need to circle back with UI folks on this).
- Input validation unit tests.
- String concatenation of the summary label needs to be internationalized.
BUG=33029
TEST=none
Review URL: http://codereview.chromium.org/558066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=fbarchard
BUG=35492
TEST=none
Review URL: http://codereview.chromium.org/606010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35492
TEST=webkit layout tests should pass.
Review URL: http://codereview.chromium.org/593077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/603024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new files and the config.h files for every platform.
BUG=32755
TEST=build chromium/chrome on all platforms.
Review URL: http://codereview.chromium.org/578024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the window:
* Works on opaque mode frames
* Miscalculated bounds on glass frame now fixed
BUG=6961
TEST=Clicking in the upper left corner of any Chrome window, where an icon would normally be, should show the app menu. Double-clicking should close the window.
Review URL: http://codereview.chromium.org/596073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch does the following:
1. Split the implementation of X11 and GL into two separate files
2. Add implementation of GLES render
Review URL: http://codereview.chromium.org/596055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/594039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also removed a test that was commented out (looks like it's passing based
on visual inspection of the results).
BUG=23487
Review URL: http://codereview.chromium.org/595020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
BUG=35467
TEST=none
Review URL: http://codereview.chromium.org/600090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, left-align fonts and vertical-align them so that their baseline lines up with the baseline of their labels.
BUG= 33296
TEST= adjust fonts and languages. name of font size should not be clipped.
Review URL: http://codereview.chromium.org/572046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will let us remove a few strings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compiler to make GLSL shaders DesktopGL complient.
Shader source is now saved by the decoder because
when glGetShaderSource is called we must return
the source that was passed, not the munged source.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/594037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27870
TEST=none
Review URL: http://codereview.chromium.org/604022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a simple round rect for the visual treatment.
Add some rect conversion utils.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/597012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35288
TEST=see bug
Review URL: http://codereview.chromium.org/596054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Factors the code to allow popups from plugins if they are triggered by user action into a cross-platform method. Also moves some Windows-only code in the header into ifdefs.
BUG=none
TEST=Click on a plugin that should open a popup window. Without this patch, it worked only every other time on the Mac.
Review URL: http://codereview.chromium.org/593055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This merely adds a way to enable content scripts and browser actions in incognito windows. They still don't work properly because none of the APIs work with incognito tabs.
The way to enable an extension is to add an "incognito" bit in the user prefs file. My plan is to add UI for this later.
BUG=32365
Review URL: http://codereview.chromium.org/567037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also mark the history test as flaky.
BUG=35430, 26296
TEST=ExtensionApiTest.FLAKY_History
Review URL: http://codereview.chromium.org/601049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/566023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cache grab it when needed.
BUG=26729
TEST=none.
Review URL: http://codereview.chromium.org/594041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than just bookmarks, and (b) set the client_unique_tag during commits.
BUG=none
TEST=hack-enabled prefs, saw commit go through.
Review URL: http://codereview.chromium.org/606004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes two cases where message delays can cause the plugin painting system to use invalidation rects that are larger than the plugin is by the time they are handled.
BUG=35328
TEST=See bug.
Review URL: http://codereview.chromium.org/593063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on the discussion of drag-out feature on whatwg: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html
BUG=none
TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder.
Review URL: http://codereview.chromium.org/598043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
BUG=27218
TEST=current tests.
Review URL: http://codereview.chromium.org/597050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35178
TEST=none
Review URL: http://codereview.chromium.org/601048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a simple round rect for the visual treatment.
Add some rect conversion utils.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/597012
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run tests under valgrind - no errors.
BUG=35367
Review URL: http://codereview.chromium.org/606001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a simple round rect for the visual treatment.
Add some rect conversion utils.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/597012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35073
TEST=Add a language (for example French) to the accept list
(Options/Under the Hood tab/Change Font and language Settings button/
language tab). Visit a french site (ex: www.voila.fr), the translate
info-bar should not be shown. Without restarting Chrome, add Chinese
to the accept language list and visit a Chinese site (ex: wwww.baidu.com),
the info-bar should not be shown.
Review URL: http://codereview.chromium.org/602009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
over during the Omnibox 2 changes.
BUG=none
TEST=Entering "?" in the address bar should show "<enter query> - Google Search"
Review URL: http://codereview.chromium.org/598076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33261
TEST=manual
Review URL: http://codereview.chromium.org/597035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/593031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/598074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it with calls to the new applyAutocompleteSuggestions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/597033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Chagned main menu to use TYPE_WINDOW instead of POPUP.
* Added hooks to close main menu when a user clicked non content area. (see MainMenuContainer::OnMousePressed and MainMenu::ActiveWindowChanged)
* removed entry view from CompactNavigationBar view. We probably should rename this class (later).
* Fixed a mouse coordinates issue in WidgetGtk: A location in the mouse event may not be in its gdk_window when it's originated from child gdk_window.
* UIStyle's enum has to start with 0 * removed DLOG thas I checked in by accident.
BUG=31766
TEST=manual: switch to compact navigation bar using ctrl-shift-c and confirm that no navigation entry in title bar.
main menu has the navigation entry instead.
Review URL: http://codereview.chromium.org/604015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also includes a small valgrind error fix.
Review URL: http://codereview.chromium.org/598046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
needs to be set before the windows get shown (in Init()), otherwise the windows are not displayed topmost.
BUG=35426
TEST=create a notification and focus a window over it
Review URL: http://codereview.chromium.org/604020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38814 0039d316-1c4b-4281-b951-d872f2087c98
|