| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
to bug 63574.
BUG=63574
TEST=file_system_operation_unittest.cc and manually tested on FAT32.
Review URL: http://codereview.chromium.org/5259003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just disables a new NPAPI test added by r67029 on valgrind.
TBR=stuartmorgan
BUG=30661
TEST=make the "Chromium Mac UI (valgrind)(4)" bot green.
Review URL: http://codereview.chromium.org/5318004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=loislo
Review URL: http://codereview.chromium.org/5328006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* webkit/glue/
- Add overloads of queryLocalizedString() functions
They will be added to WebKit::WebKitClient later.
- Add implementations for WebLocalizedString::Validation*
- Add message strings
The English strings are different from WebKit's to avoid the brusque
WebKit's strings.
Port some messages from Mozilla.
* webkit/tools/test_shell/ and webkit/support/
Hook queryLocalizedString() functions in order to return messages same as
WebKit in layout test.
BUG=28264
TEST=LayoutTests/fast/forms/validationMessage.html
Review URL: http://codereview.chromium.org/4678006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5303007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
{SLOW|MEDIUM|FAST}. How these constants map to actual input speed is still
browser specific and not covered by the wire protocol. This change implements
the following url:
/session/:sessionId/speed
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3647001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64316
TEST=manual (see bug)
Review URL: http://codereview.chromium.org/5316005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by yzshen@google.com, original review http://codereview.chromium.org/4194001/
Implement exponential back-off mechanism. Enforce it at the URLRequestHttpJob level for all outgoing HTTP requests.
The reason why to make this change is that we need back-off logic at a lower enough level to manage all outgoing HTTP traffic, so that the browser won't cause any DDoS attack.
This change:
1) patches http://codereview.chromium.org/2487001/show, which is the exponential back-off implementation.
2) resolves conflicts with URLFetcher, by removing its own back-off logic:
-- removes url_fetcher_protect.{h,cc};
-- integrates the sliding window mechanism of URLFetcherProtectEntry into RequestThrottlerEntry.
3) resolves conflicts with CloudPrintURLFetcher.
4) makes unit tests of CloudPrintURLFetcher, URLFetcher and URLRequest work.
BUG=none
TEST=pass all existing tests and also the newly-added request_throttler_unittest.cc
Review URL: http://codereview.chromium.org/5276007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug where page was visible from the beginning.
BUG=chromium-os:8285
TEST=none
Review URL: http://codereview.chromium.org/5283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9623
TEST=see the bug for repro step.
Review URL: http://codereview.chromium.org/5347004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8552
TEST=See issue, but note: networks should only be remembered if the owner is nogged in, i.e. 'guest' apples to any non owner login.
Review URL: http://codereview.chromium.org/5278011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5321009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Need to pass abs path to .zip file
Review URL: http://codereview.chromium.org/5385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4207001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/5364001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
check in InstantLoader to see if we needed to update was testing too
much.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5263004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- includes Darin's changes to move StreamCreated() to main thread
- callback for delivering handles to proxy
- changes to trusted interface
BUG=none
TEST=chrome/src/ppapi/examples/audio/audio.cc
Review URL: http://codereview.chromium.org/5202002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
animation. This would happen when typing a character and we already
have the suggested text. In particular we would cancel the animation
because the selection changed, and never restart it because of the
early return when the suggested text matched current suggested text.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5316006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
database file.
BUG=64287
TEST=none
Review URL: http://codereview.chromium.org/5255010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9100
TEST=See issue. Test repeatedly connecting to a variety of secure and 'other' wifi networks.
Review URL: http://codereview.chromium.org/5303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61121
TEST=None
Review URL: http://codereview.chromium.org/5270003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(a) Only save a profile if there are at least 3 fillable address fields; same for credit cards.
(b) Don't upload empty profiles to the autofill server
BUG=63540
TEST=unit_tests --gtest_filter=PersonalDataManagerTest.*
Review URL: http://codereview.chromium.org/5188010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5321006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes nothing, except that I now initialize memory_used in oom_priority_manager.cc to placate the incorrect gcc warning about it being used when uninitialized.
The original review is here: http://codereview.chromium.org/4498001/
BUG=none
TEST=Passed chromeos try-bot, built both debug and release locally.
Review URL: http://codereview.chromium.org/5328003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62865
TEST=none
Review URL: http://codereview.chromium.org/5299003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cellular plan.
BUG=chromium-os:9634
TEST=wait for the plan to expire / gets used, try to buy another plan, make sure the overlay div that shows immediately as the page is being loaded actually has title of 'Connecting to ...'
Review URL: http://codereview.chromium.org/5295002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failure.
Revert 67281 to fix failing FullLogin test - The earlier TabContentsWrapper changes had incomplete support for password manager.
This wires up Password Manager properly, making sure it observes all notifications that it needs to function.
http://crbug.com/63664
TEST=see bug
Review URL: http://codereview.chromium.org/5311006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/5291004
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/5347003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=loislo
Review URL: http://codereview.chromium.org/5380001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) De-couple the Layer abstraction from the implementations details of Texture, giving JavaScript more control over the scene:
- Create a Pattern class backed by Cairo's cairo_pattern_t types (which we were already using implicitly) to represent a particular pattern to paint on a layer (think of it like a brush in PhotoShop/GIMP). A Pattern can be created from either a Texture or a solid colour. This will later allow us to move the PaintBackground() method out in to JS-space.
- Axe the overloaded Layer scaling parameters (which were used to represent both the width/height of the Layer and the scaling applied to the Texture), and replace them with separate width/height parameters to describe the Layer dimensions and scale_x/scale_y parameters to describe the scaling applied to the Pattern.
(2) Code clean-up:
- Use properties instead of functions in the Layer class.
- Use double instead of float.
- Get rid of unnecessary inheritance of Layer from ParamObject.
- Get rid of many unnecessary #include directives in layer.h.
- Get rid of super-spammy log message in RendererCairo::Paint().
- Improve comments.
TEST=compiled and loaded on Linux in both GL mode and Cairo mode with simple test scenes
BUG=none
Review URL: http://codereview.chromium.org/5276006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is more prep for the MessageLoop based SyncerThread.
Somewhat subtle: previously, if HasMoreToSync returned true, we'd grab a fresh copy of routing_info and workers for the next session, but now we hold the data constant, which I think is more sane.
BUG=26339, 64136
TEST=sync_unit_tests, sync_integration_tests
Review URL: http://codereview.chromium.org/5307001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If there is suggested text it is committed.
. If there is no suggested text, but instant is active instant is
committed.
BUG=64340
TEST=see bug
Review URL: http://codereview.chromium.org/5328005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
displayed in
chrome frame pages.
BUG=Fixes bug http://b/issue?id=3200366
TEST=None
Review URL: http://codereview.chromium.org/5266002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5007002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugin rectangle is small.
BUG=49832
TEST=NONE
Review URL: http://codereview.chromium.org/5378001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5096010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize destinations variables before calling GL functions
because if the context is lost those variables will
be uninitialized.
TEST=ran chrome, conformance tests, unit tests and hand edited gles2_demo to test
BUG=none
Review URL: http://codereview.chromium.org/5305005
TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/5383001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AudioOutputProxy implements AudioOutputStream interface, but opens
audio device only when audio is playing.
BUG=39825
TEST=Unittests.
Review URL: http://codereview.chromium.org/5158003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes had incomplete support for password manager.
This wires up Password Manager properly, making sure it observes all notifications that it needs to function.
http://crbug.com/63664
TEST=see bug
Review URL: http://codereview.chromium.org/5311006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/5291004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
saved passwords'
BUG=63827
TEST=run chrome with --enable-tabbed-options. Go to the Personal Stuff tab,
see if the text of the button is "Manage saved passwords".
Review URL: http://codereview.chromium.org/5132007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- show buy plan button when we detect that plan purchase is required
- show no plans available message when plan information is non-existent or can't be loaded
BUG=chromium-os:9368
TEST=make sure that buy data plan only shows when we ended up in restricted pool with an activated device
Review URL: http://codereview.chromium.org/5280005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- added the last piece of activation recovery - if we end up in restricted pool with no
connectivity, we will now retry the entire activation process. This will result in reconnection
and eventually get us out of this state.
- speeded up reconnect part after payment
TEST=the first part of the change is a tough one to repro, continuos activation tries could eventually leave the machine in a state where payment portal page is not accessible (host not found). if we detect this state correctly on flimflam side, this cl should help us recover from it (reconnects to cellular service).
BUG=chromium-os:9594
Review URL: http://codereview.chromium.org/5279001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None.
Review URL: http://codereview.chromium.org/4222004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=64260
Review URL: http://codereview.chromium.org/5334006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in URLFetcher::Core. This allows the thread that created the URLFetcher object to go away without causing the IO thread to crash.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5283001
TBR=sanjeevr@chromium.org
Review URL: http://codereview.chromium.org/5382001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you want to test this simply load some page in the browser. Go to
settings and disable cookies. Then type in the address bar :
javascript:alert(navigator.cookieEnabled);
You should see a box saying "false" if you see true or even worse
don't see anything at all the test has failed.
BUG=63309
TEST=Disable cookies and try alert(navigator.cookieEnabled); should be false.
Review URL: http://codereview.chromium.org/5091006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit a97a25051cbbc50ccf99268ca515df241428ad03.
Revert URL: http://codereview.chromium.org/5291001/
BUG=63838
TEST=run chrome with --enable-tabbed-options. Go to UTH, you should see
'Customize fonts' in 'Web Content' section.
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/5273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5349002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL mainly changes APIs and stubs out functionality needed to
actually create the correct auth token stanzas.
BUG=None
TEST=compiles.
Review URL: http://codereview.chromium.org/4941001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
TEST=see included unit test
Review URL: http://codereview.chromium.org/5331003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67311 0039d316-1c4b-4281-b951-d872f2087c98
|