summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Adding API tests for getViews and infobars.finnur@chromium.org2010-03-3119-13/+236
| | | | | | | | | | | | | Also fixing a bug where the wrong window id was returned back after creating the infobar, and changing html path param when calling show() from htlpPath to path as requrested by aa. TEST=See chrome_tests.gypi BUG=26463 Review URL: http://codereview.chromium.org/1561003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43168 - Add suppression for a memory error during shutdown, calling ↵eroman@chromium.org2010-03-311-14/+0
| | | | | | | | | | | | | | FileDescriptorWatcher::StopWatchignFileDescriptor() after the message loop has been destroyed. BUG=39932 TBR=rsesek Review URL: http://codereview.chromium.org/1546006 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/1545009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43175 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43127 [It resulted in a free memory write because of a consumer that ↵eroman@chromium.org2010-03-313-136/+23
| | | | | | | | | | | | | | | | | | | was relying on the old ordering (BUG=39932).] Don't call Thread::CleanUp() before the MessageLoop destruction observers have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/1517006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43174 0039d316-1c4b-4281-b951-d872f2087c98
* dds some docs about the command buffer andgman@chromium.org2010-03-312-1/+2207
| | | | | | | | | | | | adds an option to the autogen tool to make a docs friendly version of the commands formats. TEST=none BUG=none Review URL: http://codereview.chromium.org/1568007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43173 0039d316-1c4b-4281-b951-d872f2087c98
* Added item to Show/Hide video controls in the context menu for <video>.scherkus@chromium.org2010-03-312-0/+30
| | | | | | | | | | | | | Patch by sergeyu@chromium.org http://codereview.chromium.org/1081011/show BUG=19848 TEST=Right-click on video, toggle "Show Controls". For audio the item must be disabled. Review URL: http://codereview.chromium.org/1589003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43172 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land sqlite diagnosticscpu@chromium.org2010-03-314-6/+125
| | | | | | | | | | | | | | - Forgot to update a stupid number in the tests See http://codereview.chromium.org/1548005 BUG=27885 TEST=included Review URL: http://codereview.chromium.org/1543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43169 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for a memory error during shutdown, calling ↵eroman@chromium.org2010-03-311-0/+14
| | | | | | | | | | | FileDescriptorWatcher::StopWatchignFileDescriptor() after the message loop has been destroyed. BUG=39932 TBR=rsesek Review URL: http://codereview.chromium.org/1546006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43168 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 56772:56820hclam@chromium.org2010-03-311-1/+1
| | | | | | | | | | | TBR=levin@chromium.org TEST=tree stays green Rolling WebKit to 56820. Review URL: http://codereview.chromium.org/1558007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43167 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing Roberto's change for landing:mbelshe@chromium.org2010-03-314-223/+256
| | | | | | | | | | | | http://codereview.chromium.org/1128007/show Integrated changes for the spdy-in-memory-server from the google server side. BUG=none TEST=none Review URL: http://codereview.chromium.org/1526005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43165 0039d316-1c4b-4281-b951-d872f2087c98
* Rev O3D DEPS to pull in new Nixysa.maf@google.com2010-03-311-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1530010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43164 0039d316-1c4b-4281-b951-d872f2087c98
* cleanup: Include base/path_service.h in tests that use it.thestig@chromium.org2010-03-318-4/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1571004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43163 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up extension apps notification permission, take tworafaelw@chromium.org2010-03-3114-109/+137
| | | | | | | | | | | | | | | This is the chromium side of a change which will wait to land on the webkit side landing. (https://bugs.webkit.org/show_bug.cgi?id=36625) It changes the NotificationPresenter to pass the sourceURL, rather than the SecurityOrigin in checking permission. The full URL is required to match the app extent. BUG=32361, 31024 TEST=NONE Review URL: http://codereview.chromium.org/1383001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43162 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting for rginda@ cl http://codereview.chromium.org/1390003zelidrag@chromium.org2010-03-314-3/+46
| | | | | | | | | | | | | | | | add keyboard acclerators to login wizard This is to make it possible to put the login wizard into a known state for testing purposes. Ctrl-Alt-L navigates to the login screen, from there Atl-U focuses the username field Alt-P focuses the password field BUG=none TEST=none TBR=zelidrag@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43161 0039d316-1c4b-4281-b951-d872f2087c98
* Make build-bisect script work on win.nirnimesh@chromium.org2010-03-311-33/+62
| | | | | | | | | | | | Unzip using python rather than using the unzip command which might not be available on windows. TEST=NONE BUG=NONE Review URL: http://codereview.chromium.org/1549006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43160 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in image_loading_tracker_unittest.sky@chromium.org2010-03-311-3/+3
| | | | | | | | | | TBR=aa@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/1512006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43159 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implemet tooltip for status icons on windows.atwilson@chromium.org2010-03-312-1/+10
| | | | | | | | | | | | | | | | BUG=38993 TEST=run chrome\Debug\chrome --long-lived-extensions, move mouse through the status icon, see if a tooltip text appears. Patch from Thiago Farina <thiago.farina@gmail.com> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43099 Landed as r43099. Review URL: http://codereview.chromium.org/1378007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43158 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Select the previous node when the last cookie in the list is deleted.rsesek@chromium.org2010-03-313-16/+64
| | | | | | | | | | | | Also recursively bubble up the delete if removing a child node will leave the parent empty. Empty parents look awkward. BUG=33320 TEST=See bug report. Partially covered by unit tests. Review URL: http://codereview.chromium.org/1598001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43157 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TabRestoreUITest.RestoreIntoSameWindow as flaky.arv@chromium.org2010-03-311-1/+2
| | | | | | | | | BUT=39925 TEST=None TBR=dmaclach git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43156 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SessionRestoreUITest.TwoWindowsCloseOneRestoreOnlyOne as flakyarv@chromium.org2010-03-311-1/+2
| | | | | | | | | BUG=39905 TEST=None TBR=dmaclach git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43155 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: set the new star button's IDestade@chromium.org2010-03-311-0/+2
| | | | | | | | | | | | Fixes ViewIDTest.Basic BUG=none TEST=ViewIDTest.Basic r=arv Review URL: http://codereview.chromium.org/1578005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43154 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BookmarkFolderTargetTest.* under Valgrind because new leak traces ↵rsesek@chromium.org2010-03-311-0/+3
| | | | | | | | | | | keep popping out. BUG=39282 TEST=Valgrind goes green Review URL: http://codereview.chromium.org/1574004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43153 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43143 - Implement db corruption tests for diagnostic modearv@chromium.org2010-03-313-123/+4
| | | | | | | | | | | | | | | Uses sqlite's pragma integrity_check Tests the 5 main databases BUG=27885 TEST=none Review URL: http://codereview.chromium.org/1548005 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/1539006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43152 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad conflict resolution for r43146.estade@chromium.org2010-03-311-9/+2
| | | | | | | | | | TBR=arv TEST=local compile BUG=none Review URL: http://codereview.chromium.org/1586006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43151 0039d316-1c4b-4281-b951-d872f2087c98
* Disable executable stack on Linux.willchan@chromium.org2010-03-301-1/+1
| | | | | | | | | | | | | | | | | | BUG=29824 TEST= william@penguin:~/src/chromium2/src$ out/Debug/chrome --user-data-dir=/tmp/foo& [2] 28679 william@penguin:~/src/chromium2/src$ cat /proc/28679/maps | grep stack 7fff3fc4d000-7fff3fc63000 rw-p 00000000 00:00 0 [stack] william@penguin:~/src/chromium2/src$ eu-readelf -l out/Debug/chrome | grep STACK GNU_STACK 0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RW 0x8 eu-readelf shows that the GNU_STACK segment indicates the stack should be RW (no X for execute). `cat/proc/{pid}/maps | grep stack` shows that the stack mapping is indeed RW (if the dynamic linker encounters a shared library that needs an executable stack, it will globally enable executable stacks. Review URL: http://codereview.chromium.org/1555002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43150 0039d316-1c4b-4281-b951-d872f2087c98
* Follow the latest rename for the WebFrameClient interface to do ↵johnnyg@chromium.org2010-03-302-6/+6
| | | | | | | | | | | site-isolation logging. BUG=none TEST=none Review URL: http://codereview.chromium.org/1546005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43149 0039d316-1c4b-4281-b951-d872f2087c98
* Appcache Manifest Parsing Rule. If the manifest's <scheme> is secure, and ↵inferno@chromium.org2010-03-302-0/+34
| | | | | | | | | | the resulting absolute URL does not have the same origin as the manifest's URL, then don't process that url. BUG=31935 TEST=ManifestParserTest.DifferentOriginUrlWithSecureScheme Review URL: http://codereview.chromium.org/1521006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43148 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow dragging browser actions between regular and incognito windows.mpcomplete@chromium.org2010-03-306-18/+33
| | | | | | | | | | | | This fixes a crash. Also small fix to Pickle::ReadBytes to fix up the iterator if it is NULL. BUG=39340 Review URL: http://codereview.chromium.org/1542007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43147 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: toolbar reload/star shuffle.estade@chromium.org2010-03-3011-274/+177
| | | | | | | | | BUG=37866 TEST=manual Review URL: http://codereview.chromium.org/1491003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43146 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bug 31096 checks (resolved).vandebo@chromium.org2010-03-302-5/+0
| | | | | | | | | TEST=none BUG=31096 Review URL: http://codereview.chromium.org/1562003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43145 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: New extension install prompt ui.estade@chromium.org2010-03-304-23/+199
| | | | | | | | | BUG=29633 TEST=manual Review URL: http://codereview.chromium.org/1513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43144 0039d316-1c4b-4281-b951-d872f2087c98
* Implement db corruption tests for diagnostic modecpu@chromium.org2010-03-303-4/+123
| | | | | | | | | | | | | - Uses sqlite's pragma integrity_check - Tests the 5 main databases BUG=27885 TEST=none Review URL: http://codereview.chromium.org/1548005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43143 0039d316-1c4b-4281-b951-d872f2087c98
* Send ping days parameter for extension blacklist update checksasargent@chromium.org2010-03-307-28/+34
| | | | | | | | | | BUG=39745 TEST=Extension update in general, and blacklisting, should still work normally. Review URL: http://codereview.chromium.org/1540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43142 0039d316-1c4b-4281-b951-d872f2087c98
* Flip seccomp sandbox back off, now that we have some perf numbers.evan@chromium.org2010-03-301-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential NULL pointer error in HtmlDialogView::InitDialog.brettw@chromium.org2010-03-301-1/+1
| | | | | | | | | BUG=37275 TEST=None Checked in for jaysoffian@gmail.com Original review: http://codereview.chromium.org/661439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43137 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Label::GetFont() to unix_hacker style. Original patch by Thiago ↵pkasting@chromium.org2010-03-3013-27/+28
| | | | | | | | | | Farina (see http://codereview.chromium.org/1580002 ), r=me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1528009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43136 0039d316-1c4b-4281-b951-d872f2087c98
* Add a list of excluded files to checkbins.py and enable it on build bots.scherkus@chromium.org2010-03-301-4/+12
| | | | | | | | | | After some research it turns out we can exclude certain .exe/.dll files from /NXCOMPAT and /DYNAMICBASE due to various reasons (pure data DLLs, special purpose applications, non-shipping code, etc...) BUG=25952 TEST=checkbins step on buildbot should stay green with no failing files Review URL: http://codereview.chromium.org/1576003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43135 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set the whiltelist filter on the default auth handlerwtc@chromium.org2010-03-301-13/+11
| | | | | | | | | | | | factory unless the --auth-server-whitelist command-line option is specified. R=ahendrickson,cbentzel BUG=29596 TEST=HTTP NTLM or Negotiate authentication should work again. Review URL: http://codereview.chromium.org/1569007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43099 - Windows implementation of StatusIcon::SetToolTip()atwilson@chromium.org2010-03-302-10/+1
| | | | | | | | | I will resubmit with the proper patch attribution. TBR=atwilson@google.com Review URL: http://codereview.chromium.org/1558006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43133 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a geolocation tab in the content settings dialog (on Windows). Also ↵pkasting@chromium.org2010-03-3012-201/+217
| | | | | | | | | | refactors the various views for this dialog in hopes of simplifying a few things. BUG=none TEST=Open content settings dialog, observe Location tab. (Note: Exceptions button is not wired up.) Review URL: http://codereview.chromium.org/1526004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43132 0039d316-1c4b-4281-b951-d872f2087c98
* Mac SSL fix: Go back to not enabling break-on-auth when we have a client ↵snej@chromium.org2010-03-301-14/+26
| | | | | | | | | | | cert to send. BUG=38905 TEST=None (don't have a way for me to reproduce this yet) Review URL: http://codereview.chromium.org/1514004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43131 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this. Patch is exactly same as last time around.sky@chromium.org2010-03-3016-49/+351
| | | | | | | | | | | | Adds ability for ImageLoadingTracker to cache images. BUG=none TEST=none TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1534006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43130 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and resubmit 42959zork@chromium.org2010-03-301-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1508005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43129 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bug where themes wouldn't sync properly if it had been installedakalin@chromium.org2010-03-301-13/+20
| | | | | | | | | | | | | before. Did some refactoring and fixed comments. BUG=none TEST=manually Review URL: http://codereview.chromium.org/1543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43128 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call Thread::CleanUp() before the MessageLoop destruction observers ↵eroman@chromium.org2010-03-303-23/+136
| | | | | | | | | | | | | | have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43127 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit should now interpret "Closed" (upper case C) as meaning the tree ↵apatrick@chromium.org2010-03-301-1/+1
| | | | | | | | | | | is closed. TEST=none at all BUG=none Review URL: http://codereview.chromium.org/1560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43126 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Get rid of the custom run loop for dragging the Browser Actions ↵andybons@chromium.org2010-03-303-32/+28
| | | | | | | | | | container, update cursors properly and fix a bug where a newly added extension would be put in the overflow menu if all extensions were shown. BUG=36697 TEST=none Review URL: http://codereview.chromium.org/1581003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43125 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent warning on Mac about uninitialized variable by initializing thebrettw@chromium.org2010-03-301-0/+1
| | | | | | | | | | variable in the failure case. BUG=none TEST=none Review URL: http://codereview.chromium.org/1534007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43124 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the file browser/chooser to support more modes of operation, and plumbbrettw@chromium.org2010-03-3018-93/+416
| | | | | | | | | | | | | it through to the pepper API. This pepper API just supports adding the filename to the "upload files" whitelist and returning it to the plugin, but it does not actually give any ability for a sandboxed plugin to read the file (this will come in a separate changelist). TEST=none BUG=none Review URL: http://codereview.chromium.org/1094004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43123 0039d316-1c4b-4281-b951-d872f2087c98
* linux: enable seccomp sandbox by defaultevan@chromium.org2010-03-308-17/+57
| | | | | | | | | | | | | | | It seems the best way to keep the seccomp sandbox working is to have everyone's development environment have it on by default. So we turn on the seccomp sandbox, but only for non-official builds. If the build-time flag is set: --disable-seccomp-sandbox turns it off. If the build-time flag is *not* set: --enable-seccomp-sandbox turns it on. BUG=36133 Review URL: http://codereview.chromium.org/1558003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43122 0039d316-1c4b-4281-b951-d872f2087c98
* Label scraping for AutoFill, tables.dhollowa@chromium.org2010-03-302-2/+80
| | | | | | | | | | | | | | | Adds label scraping to AutoFill where labels reside in tables. Infers labels from surrounding context of input fields in the WebKit DOM. Specific case added is: - Table cell element containing text preceding INPUT element contained in a table cell. Eg. <TR><TD>First name:</TD><TD><INPUT type="text" id="firstname" value="John"/></TD></TR> BUG=33031 TEST=FormManagerTest.LabelsFromInferredTableCell Review URL: http://codereview.chromium.org/1517005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43121 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 17:43:56 +0000