summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Changes the UI for HTTP/FTP auth challenges to include the server's port. So ↵ericroman@google.com2009-05-2111-68/+113
| | | | | | | | | | | instead of "www.foo.com" it will say "www.foo.com:80". We need to include the port number since otherwise it can be ambiguous what the actual target server is. This change also introduces utility function "GetHostAnd[Optional]Port()" to help with forming <host> [":" <port>] strings. BUG=12073 Review URL: http://codereview.chromium.org/112041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16672 0039d316-1c4b-4281-b951-d872f2087c98
* Put back in code that installs ThrobberView, but comment out timer. Add a ↵pinkerton@chromium.org2009-05-212-19/+12
| | | | | | big comment about why this is so slow. BUG=none TEST=none. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16671 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the now-unused linux/version.sh.sgk@google.com2009-05-211-65/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16670 0039d316-1c4b-4281-b951-d872f2087c98
* Implement temporary First Run Dialog on OS Xjeremy@chromium.org2009-05-2112-13/+856
| | | | | | | | | | | | | | | | | | | | | | We use a modal dialog with a single checkbox on OS X. We use the OSX defaults system since we want something quick and reliable. The dialog is displayed at a very early stage in Chrome startup (Before any subsystems start relying on the stats variable). This means there are a few quirks in displaying the UI. A change was also needed to our event handling code since when the dialog is shown we spin an event loop at a very early stage in the process lifetime. Changed default value for stats to false and updated unit tests to reflect that. Also some misc. minor cleanup. BUG=11971,12046 Review URL: http://codereview.chromium.org/115608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16669 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another name I missed.thomasvl@chromium.org2009-05-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/113727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16668 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-214-44/+16
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115651 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16667 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.BUG=2381pkasting@chromium.org2009-05-215-60/+18
| | | | | | Review URL: http://codereview.chromium.org/115650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16666 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-219-45/+34
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/113717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16665 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make page/app menu buttons depress while they're showing the menus.estade@chromium.org2009-05-214-6/+76
| | | | | | | | TEST=click the page/app menu buttons. Observe that they are looking active. Dismiss the menu. Observe that the buttons are normal again. Review URL: http://codereview.chromium.org/113724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16664 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix crash when right clicking on a tab in the tabstrip.erg@google.com2009-05-211-1/+6
| | | | | | | | http://crbug.com/12439 Review URL: http://codereview.chromium.org/115661 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16663 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent a worker that loops forever from preventing shutdown of the worker ↵jam@chromium.org2009-05-212-2/+42
| | | | | | | | | process. BUG=11672 Review URL: http://codereview.chromium.org/112049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16662 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-212-10/+3
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/113719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16661 0039d316-1c4b-4281-b951-d872f2087c98
* Gets LocationBarView to compile on linux. PageInfoWindow is nearlysky@chromium.org2009-05-218-66/+142
| | | | | | | | | | | there too, but needs Separator to actually completely compile. BUG=none TEST=none Review URL: http://codereview.chromium.org/113720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16660 0039d316-1c4b-4281-b951-d872f2087c98
* Properly dismiss cocoa popup menus.paul@chromium.org2009-05-211-2/+3
| | | | | | | | | | | | | | | | | | The virtual key code for mac popup menus was not set properly so HTML select menus, when dismissed by hitting escape or clicking outside of the popup menu area, were not shut down cleanly. WebInputEventFactory requires the charactersIgnoringModifiers field of the NSEvent to be set to VK_ESCAPE (0x1b) for the dimiss to work. The key event type also needs to be a key down (NSKeyDown) since PopupListBox::handleKeyEvent ignores the key up. Review URL: http://codereview.chromium.org/115618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16659 0039d316-1c4b-4281-b951-d872f2087c98
* More tests for tab_cold. commenting out drawRect entirely.pinkerton@chromium.org2009-05-212-1/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16658 0039d316-1c4b-4281-b951-d872f2087c98
* Allow external whitelisted protocols on the Mac.avi@chromium.org2009-05-211-3/+27
| | | | | | | | http://crbug.com/12287 Review URL: http://codereview.chromium.org/115660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16657 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-216-44/+24
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16656 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 on fixing Linux buildpkasting@chromium.org2009-05-211-2/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16655 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux buildpkasting@chromium.org2009-05-211-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16654 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Clean up the bookmark bar context menuerg@google.com2009-05-213-4/+10
| | | | | | | | | - Make items that should be checkboxes into checkboxes - Clean up accelerator spam. Review URL: http://codereview.chromium.org/113721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16653 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-213-218/+85
| | | | | | | | | Also clean up a bunch of code to make it shorter/clearer/more style-guide compliant. BUG=2381 Review URL: http://codereview.chromium.org/113718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16652 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all but one Find test from ui_test to In-Processfinnur@chromium.org2009-05-214-74/+101
| | | | | | | | | | | | | Browser test. I also added initialization for a struct that static code analysis complained about. Not technically needed, but harmless to add. BUG=None TEST=None (covered by tests already). Review URL: http://codereview.chromium.org/115652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16651 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-217-57/+31
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16650 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-212-16/+9
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16649 0039d316-1c4b-4281-b951-d872f2087c98
* Theme the find bar.glen@chromium.org2009-05-2110-52/+53
| | | | | | | | | | The image resources are additional, as we don't want to mess with Linux. BUG=11702 Review URL: http://codereview.chromium.org/115613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16647 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency from browser_view on the bug report dialog. I am going tobrettw@chromium.org2009-05-214-41/+65
| | | | | | | | be moving more of the dialogs to this file to reduce dependencies and make it more portable. Review URL: http://codereview.chromium.org/113678 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16645 0039d316-1c4b-4281-b951-d872f2087c98
* Start adding gyp-generated VS files to svn:ignore.sgk@google.com2009-05-210-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16644 0039d316-1c4b-4281-b951-d872f2087c98
* Back to square zero, throbber disabled.pinkerton@chromium.org2009-05-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16643 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts parts of ↵jam@chromium.org2009-05-213-32/+0
| | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=16474 which aren't needed anymore. Review URL: http://codereview.chromium.org/113669 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16642 0039d316-1c4b-4281-b951-d872f2087c98
* Meta key is not the same as Alt key on Windows.avi@chromium.org2009-05-211-3/+3
| | | | | | | | | | See http://trac.webkit.org/changeset/29375 http://crbug.com/2215 Review URL: http://codereview.chromium.org/113716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16641 0039d316-1c4b-4281-b951-d872f2087c98
* Move the validation of icons for page actions to load time.finnur@chromium.org2009-05-213-16/+22
| | | | | | | | | | | | This is in line with how we validate content scripts and enables installing page actions as .crx filed. BUG=None TEST=Install a Page Action as a .crx file. It should install. Review URL: http://codereview.chromium.org/115644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16640 0039d316-1c4b-4281-b951-d872f2087c98
* Third attempt at http://codereview.chromium.org/115276ajwong@chromium.org2009-05-216-4/+798
| | | | | | Review URL: http://codereview.chromium.org/115645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16639 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure workers don't outlive crashed renderers.jam@chromium.org2009-05-214-1/+12
| | | | | | Review URL: http://codereview.chromium.org/114035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16638 0039d316-1c4b-4281-b951-d872f2087c98
* Close the old browser window after SessionRestore.willchan@chromium.org2009-05-211-0/+7
| | | | | | | | | | | SessionRestore needs to know the last active browser in order to close it after the session restore. Add the call to BrowserList::SetLastActive() to accomplish this. BUG=http://www.crbug.com/12372 TEST=Crash the browser. Open a new browser. Click on restore. The old browser window should close and the old session should appear in the new browser window. Review URL: http://codereview.chromium.org/113691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16637 0039d316-1c4b-4281-b951-d872f2087c98
* Rewriting to use CIImage in hopes of better performance. Still playing with ↵pinkerton@chromium.org2009-05-213-7/+24
| | | | | | | | perf bot. Review URL: http://codereview.chromium.org/115643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16636 0039d316-1c4b-4281-b951-d872f2087c98
* Use NotificationRegistrar to handle notification observing.Also cleans up ↵pkasting@chromium.org2009-05-2110-334/+172
| | | | | | | | some other stuff: use {} on multi-line conditional bodies, remove a bunch of unused routing_id members, don't wrap lines that don't need to, etc.BUG=2381 Review URL: http://codereview.chromium.org/115602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16634 0039d316-1c4b-4281-b951-d872f2087c98
* ZwOpenKeyEx is now documented at ↵nsylvain@chromium.org2009-05-213-8/+8
| | | | | | | | | | | | | | | | http://msdn.microsoft.com/en-us/library/dd535803.aspx The last unknown parameter is OpenOptions. We do not support it at this point, since it involves links, which wont be trivial to secure, and giving "special" privileges. Updating the code accordingly. BUG:7611 TEST:No code change Review URL: http://codereview.chromium.org/115640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16633 0039d316-1c4b-4281-b951-d872f2087c98
* Make the link to Chromium project page depend on UI locale.yutak@chromium.org2009-05-212-2/+6
| | | | | | | | | | There is a link to the Chromium project in About dialog. It should go to the project page of the current UI language. BUG=5909 TEST=See issue 5909 Review URL: http://codereview.chromium.org/113682 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16632 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed on official app name used for unittests that I missed before.thomasvl@chromium.org2009-05-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16631 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use correct tabstrip background in Incognito mode.erg@google.com2009-05-212-6/+7
| | | | | | | | http://crbug.com/12421 Review URL: http://codereview.chromium.org/115642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16630 0039d316-1c4b-4281-b951-d872f2087c98
* Remove trailing NULL is data sent between chrome processes.tc@google.com2009-05-211-5/+4
| | | | | | | | | | | | Since we split on NULL, the final NULL results in an extra command line token passed to the original browser process. Bug found by willchan. Review URL: http://codereview.chromium.org/113714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16629 0039d316-1c4b-4281-b951-d872f2087c98
* Remove one more notimpl.estade@chromium.org2009-05-211-4/+3
| | | | | | | | BUG=12052 Review URL: http://codereview.chromium.org/113713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16628 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "View page info" context menu only for pages which developer commandsestade@chromium.org2009-05-211-3/+3
| | | | | | | | | | | | | | | | | | are meaningful for. "View page info" can be treated as if it were a developer command in deciding whether to enable it. For example, viewing page info of chrome://newtab doesn't make much sense. Tested manually. ------------- patch by yuzo@google.com review url: <http://codereview.chromium.org/115563> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16627 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r16622estade@chromium.org2009-05-216-798/+4
| | | | | | | | TBR=ajwong Review URL: http://codereview.chromium.org/115641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16626 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't instantly hide the status bubble; set a callback that does it ↵erg@google.com2009-05-212-2/+26
| | | | | | | | after a delay. Review URL: http://codereview.chromium.org/115639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16625 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Import Dialog in Linuxtc@google.com2009-05-212-7/+2
| | | | | | | | | | | Remove reference of gtk.h as well as unnecessary casting. Patch by Mohamed Mansour in http://codereview.chromium.org/113616 Review URL: http://codereview.chromium.org/113711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16624 0039d316-1c4b-4281-b951-d872f2087c98
* Activate download shelf button while the menu is showing.estade@chromium.org2009-05-214-9/+55
| | | | | | | | TEST=download something. Press the down arrow button on the right of the item. A menu should popup and the button should appear to depress. The button should pop back when you close the menu (either by clicking away from it or by choosing an item in it). Review URL: http://codereview.chromium.org/113684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16623 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply http://codereview.chromium.org/115276ajwong@chromium.org2009-05-216-4/+798
| | | | | | Review URL: http://codereview.chromium.org/115638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16622 0039d316-1c4b-4281-b951-d872f2087c98
* Check if the test server started successfully before using it.phajdan.jr@chromium.org2009-05-211-3/+60
| | | | | | | | | | Prevents a crash in unit tests. http://crbug.com/9644 Review URL: http://codereview.chromium.org/117002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16621 0039d316-1c4b-4281-b951-d872f2087c98
* Include the resources directory in the linux zip file.tc@google.com2009-05-211-0/+1
| | | | | | | | | | This directory includes the files necessary for the web inspector to work. This matches the windows FILES list. Review URL: http://codereview.chromium.org/115596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16618 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-23 02:46:12 +0000