summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* The desktop notification service infobar would not display in ChromeFrame ↵ananta@chromium.org2010-05-273-12/+16
| | | | | | | | | | | | | | | | rendered pages as the code assumed the existing of a BrowserList and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913 Bug=44913 Review URL: http://codereview.chromium.org/2294002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48348 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionOverrideTest.OverrideHistory on Windows, because it's ↵jhawkins@chromium.org2010-05-271-1/+8
| | | | | | | | | | | | consistenly hanging. TBR=rafaelw BUG=45173 TEST=ExtensionOverrideTest.OverrideHistory Review URL: http://codereview.chromium.org/2240006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48347 0039d316-1c4b-4281-b951-d872f2087c98
* Check for bookmark bar visibility before showing any deletion animations.mrossetti@chromium.org2010-05-271-1/+1
| | | | | | | | | BUG=44967 TEST=1) Hide bookmark bar. 2) Show bookmark manager. 3) Delete a bookmark which would show on the bookmark bar. 4) Verify no 'poof' occurs. 5) Type an URL into the omnibox. 6) Click on the Star to bookmark. 7) Press the 'Remove' button. 8) Verify no 'poof' occurs. 9) Show the bookmark bar. 10) Delete a bookmark which shows on the bookmark bar. 11) Verify that the 'poof' animation occurs. Review URL: http://codereview.chromium.org/2294001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48346 0039d316-1c4b-4281-b951-d872f2087c98
* Slight cleanup of some first-run/master-prefs stuff.viettrungluu@chromium.org2010-05-276-48/+27
| | | | | | | | | | | | | | | | | - let AddFirstRunNewTabs() run as elsewhere on Mac (the list of first-run tabs will be empty) - move various #if defined(OS_MACOSX) stuff to (existing!) Mac-specific files instead - remove an essentially-unused argument to FirstRun::ProcessMasterPreferences() (the location of the master prefs was never specified, so the standard location was always used) BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/2077025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48345 0039d316-1c4b-4281-b951-d872f2087c98
* net-internals: use the async interface for displaying cache statistics.rvargas@google.com2010-05-273-1/+8
| | | | | | | | | BUG=26729 TEST=none Review URL: http://codereview.chromium.org/2279003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48344 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust xpdual moz expectations for some extra metrics.chase@chromium.org2010-05-271-3/+3
| | | | | | | | | | | | | This fixes expectations for 3 measures: times, total_op_r, and total_byte_r. BUG=44944 TEST=xpdual moz is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/2224005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48343 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of http://codereview.chromium.org/2079016thakis@chromium.org2010-05-265-12/+435
| | | | | | | | BUG=10952 Review URL: http://codereview.chromium.org/2295001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48337 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable tests whose disabling bug has been fixedstuartmorgan@chromium.org2010-05-261-32/+35
| | | | | | | | | | | Restores a bunch of tests that were disabled by bugs 36630 and 30307 (both of which were closed as fixed without the tests being re-enabled) to whatever state they had before. BUG=30307,36630 TEST=Tests should run, and hopefully not hang or crash anything Review URL: http://codereview.chromium.org/2157009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48336 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore so that if the last tab is closed explicitlysky@chromium.org2010-05-264-13/+42
| | | | | | | | | | | | | | | (control-w, middle click ...) the tab is not restored. OTOH if the user closes the window, then the tab is restored. BUG=4923 TEST=turn on session restore and close the last tab by clicking the tab close button, it shouldn't be restored. Then close the last window with one tab by way of alt-f4 (or clicking the window close button) and make sure the tab is restored. Review URL: http://codereview.chromium.org/2251002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48335 0039d316-1c4b-4281-b951-d872f2087c98
* Strip PDF from QuickTime's list of MIME types on the Macstuartmorgan@chromium.org2010-05-261-0/+7
| | | | | | | | | | | | | Replaces the recently-removed pdf MIME-type stripping with a version specifically targeted to QuickTime. Other plugins to handle PDF can just be disabled by the user without side effects since they are specific to PDF. BUG=None TEST=QuickTime should continue to *not* handle PDFs; any other plugin should be able to register for PDF. Review URL: http://codereview.chromium.org/2241006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48334 0039d316-1c4b-4281-b951-d872f2087c98
* Switch failing HistoryTester tests from DISABLED to FAILSstuartmorgan@chromium.org2010-05-261-6/+5
| | | | | | | | | BUG=39785 TEST=VerifyHistoryLength* tests should be run. Review URL: http://codereview.chromium.org/2293001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48332 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some non-functional plugins from the Mac blacklist now that users can ↵stuartmorgan@chromium.org2010-05-261-13/+4
| | | | | | | | | | | | | disable plugins PDF Browser and O3D were blacklisted because having them handle content in Chrome was worse than not, but there was no way for users to prevent that without uninstalling the plugin entirely. Now that there's UI for disabling plugins, there's no need to keep them on the blacklist. BUG=25068 TEST=PDF Browser and O3D should show up in about:plugins if installed (although current versions won't actually work). Review URL: http://codereview.chromium.org/2270004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48331 0039d316-1c4b-4281-b951-d872f2087c98
* ExtApps: Show the bookmark bar again on NTP (except inside the App Launcher ↵finnur@chromium.org2010-05-261-5/+2
| | | | | | | | | | | panel). BUG=44077 TEST=Bookmark bar should always be visible on the NTP if extension apps are disabled (default) and should be visible if attached when extension apps are enabled. Review URL: http://codereview.chromium.org/2225004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48330 0039d316-1c4b-4281-b951-d872f2087c98
* Removed PushSource::Packet. SeekableBuffer.current_time() fixed to returnsergeyu@chromium.org2010-05-266-71/+40
| | | | | | | | | | kInvalidTimestamp when the time is unknown. TEST=media_unittests BUG=28654 Review URL: http://codereview.chromium.org/2140001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48329 0039d316-1c4b-4281-b951-d872f2087c98
* refactoring decoder interfacejiesun@google.com2010-05-2611-94/+137
| | | | | | | | | | 1. install permanent buffer exchange callback. 2. render provide buffer in read=>fillthisbuffer. 3. for ffmpeg path, the provided buffer is just dummy. it had no relation to decoded buffer. so as to keep the code almost same. Review URL: http://codereview.chromium.org/2101022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48328 0039d316-1c4b-4281-b951-d872f2087c98
* Disable internal plugin on all platforms by default.jam@chromium.org2010-05-261-6/+0
| | | | | | Review URL: http://codereview.chromium.org/2291003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48327 0039d316-1c4b-4281-b951-d872f2087c98
* Re-commit the notification presenter changes (undo r47765).dpranke@chromium.org2010-05-263-9/+17
| | | | | | | | | | | | This didn't cause a perf regression from what I can tell. BUG=none TEST=none R=johnnyg@chromium.org Review URL: http://codereview.chromium.org/2143008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48326 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48315 - Linux: Initial scaffolding for default plugin.thakis@chromium.org2010-05-2611-560/+85
| | | | | | | | | | | | | | | | | | | | | Basically the linux version of http://codereview.chromium.org/2075006 BUG=10952 TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plugin" text should look slightly different than it did before. Also, the plugin area is now grey instead of transparent. (this test depends on a small webkit shown below) Requires commenting out if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin) return 0; in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load. Review URL: http://codereview.chromium.org/2079016 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2291004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48325 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling default apps in officials ChromeOS builds so that the app launcher ↵jcivelli@chromium.org2010-05-261-10/+16
| | | | | | | | | | | | is not empty. BUG=None TEST=Start an official ChromeOS build, open the NTP. GMail, Calendar and Docs should be available as apps. Review URL: http://codereview.chromium.org/2237003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48321 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled pepper 3d test after fixing glsl translator.alokp@chromium.org2010-05-261-1/+1
| | | | | | | TBR=gman@chromium.org Review URL: http://codereview.chromium.org/2286001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48320 0039d316-1c4b-4281-b951-d872f2087c98
* Implement upgrade notifications.finnur@chromium.org2010-05-2626-20/+586
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we detect that the installed version is newer than the version you are running we show a little throbbing orange dot over the wrench menu. If you open the wrench menu and close it again, the throbbing will stop. However, if you look at the contents of the wrench menu you'll notice that the About box menu item has been removed and in its place is a menu item "Update Chrome Now" with a bright orange icon to draw your attention to it. Clicking on the icon shows a dialog box asking whether you want to restart Chrome. If you do, the browser restarts with your session restored (even if you have Session Restore turned off). Known issues: - Currently this is Windows only. We'll have to port this to Linux and do something differnet for Mac (which doesn't have the wrench menu). - Showing an icon in front of Update Chrome causes the checkbox for the bookmark bar menu to go away. Given that we will soon redesign the menus I'm not going to spend much time trying to fix it. BUG=27941 TEST=Wait for Chrome to be upgraded in the background, an orange dot should appear over the wrench menu and if you select Update Chrome your session should be retained. Review URL: http://codereview.chromium.org/2225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48318 0039d316-1c4b-4281-b951-d872f2087c98
* Resize the "For quick access..." and "Import bookmarks now..." components ↵mrossetti@chromium.org2010-05-267-12/+121
| | | | | | | | | | | | | | | | | | shown in the bookmark bar when there are no bookmarks in the bar, when the window resizes. Show ellipses when each gets trimmed and hide them when they get too small. BookmarkBar.xib changes: Connect the "Import bookmarks now..." button up to the importBookmarksButton_ outlet in the BookmarkBarView. BUG=32557 TEST=1) Start up a browser with no bookmarks on the bookmarks bar. 2) Verify that the "For quick access..." and "Import bookmarks now..." test fully shows. 3) Start shrinking the width of the browser window. 4) Verify that the "Import bookmarks now..." text is shrunk/clipped and finally disappears as the window gets narrower. 5) Continue shrinking the width and verify that the "For quick access..." text is shrunk/clipped with ellipses as the window gets narrower. 6) Grow the window and verify that the "For quick access..." reappears and then the "Import book now..." does. Review URL: http://codereview.chromium.org/2243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48316 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Initial scaffolding for default plugin.thakis@chromium.org2010-05-2611-85/+560
| | | | | | | | | | | | | | | | | | Basically the linux version of http://codereview.chromium.org/2075006 BUG=10952 TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plug-in" text should look slightly different than it did before. Also, the plugin area is now grey instead of transparent. (this test depends on a small webkit shown below) Requires commenting out if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin) return 0; in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load. Review URL: http://codereview.chromium.org/2079016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48315 0039d316-1c4b-4281-b951-d872f2087c98
* spelling error FLAKEY->FLAKY. EarlyReturnTest.ToastCrasherrafaelw@chromium.org2010-05-261-1/+1
| | | | | | | | | BUG=45115 TBR=jhawkins Review URL: http://codereview.chromium.org/2249003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48303 0039d316-1c4b-4281-b951-d872f2087c98
* Switch hanging session restore tests from FAILS to RESTOREstuartmorgan@chromium.org2010-05-261-2/+2
| | | | | | | | | | | TBR=mark BUG=45108 TEST=Greener Mac UI test bots. Review URL: http://codereview.chromium.org/2238003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48302 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for ExtensionMessageService::DispatchEventToRenderers mem leakrafaelw@chromium.org2010-05-261-0/+20
| | | | | | | | | BUG=45133 TBR=mpcomplete Review URL: http://codereview.chromium.org/2239008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48301 0039d316-1c4b-4281-b951-d872f2087c98
* Drop files from the gyp that don't exist. list_background.h was committed ↵avi@chromium.org2010-05-262-7/+3
| | | | | | | | | | | with the wrong path, standard_menus.h went away in r46987, pref_store.h in r47915, spellchecker_common in r32561, transport_dib.h in 42101. BUG=none TEST=none Review URL: http://codereview.chromium.org/2247006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48300 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 60217:60239.jparent@chromium.org2010-05-261-1/+1
| | | | | | | | | | TEST=canaries, try bots BUG=none TBR=tony git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48299 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of CreateWizardBorder instance in WebPageView.dpolukhin@chromium.org2010-05-264-30/+5
| | | | | | | | | | | WizardBorder won't paint border it will be done by WizardPainter, WizardBorder will provide only insets. BUG=none TEST=none Review URL: http://codereview.chromium.org/2281002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48298 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the SessionRestoreUITest tests on the Macstuartmorgan@chromium.org2010-05-262-2/+12
| | | | | | | | | | | Changes the shutdown type in the test on the Mac, since closing the last window (the default) destroys the session on the Mac. Marks two tests that fail consistently accordingly. BUG=45108 TEST=SessionRestoreUITest tests should run. Review URL: http://codereview.chromium.org/2280002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48297 0039d316-1c4b-4281-b951-d872f2087c98
* Get the internal plugin working on Mac.jabdelmalek@google.com2010-05-264-16/+10
| | | | | | Review URL: http://codereview.chromium.org/2271002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48296 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestStepOut and TestStepIn on win because they timeout.tonyg@chromium.org2010-05-261-4/+10
| | | | | | | | | | | | r48279 did this for TestStepOver, but all of the TestStep* tests are timing out on win, not just TestStepOver. TEST=DevToolsSanityTest.TestStep* BUG=45080 Review URL: http://codereview.chromium.org/2240003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48295 0039d316-1c4b-4281-b951-d872f2087c98
* Allow "chrome-extension://" to be used as web app url.xiyuan@chromium.org2010-05-261-0/+1
| | | | | | | | | BUG=29201 TEST=Verify a web app shortcut for "chrome-extension://" url could be created. Review URL: http://codereview.chromium.org/2193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48294 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of moving Pepper ReadImageData to the Testing interface.brettw@chromium.org2010-05-264-21/+21
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/2233001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48293 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes visual glitch in new tab animation.sky@chromium.org2010-05-261-1/+7
| | | | | | | | | BUG=44780 TEST=see bug Review URL: http://codereview.chromium.org/2226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48292 0039d316-1c4b-4281-b951-d872f2087c98
* Drop a file from the gyp that was deleted in r35326.avi@chromium.org2010-05-261-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2276003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48291 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp the location bar font's height so it doesn't overflow the bar, even if ↵pkasting@chromium.org2010-05-261-0/+6
| | | | | | | | | | the user has enormous standard fonts. BUG=43268 TEST=Set your system fonts to enormous sizes. Type in the location bar. The font should be small enough to fit. Review URL: http://codereview.chromium.org/2132027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48288 0039d316-1c4b-4281-b951-d872f2087c98
* Use some built-in methods on the Font object to avoid storing so many data ↵pkasting@chromium.org2010-05-262-10/+6
| | | | | | | | | | members on the AutocompleteEdit. BUG=none TEST=none Review URL: http://codereview.chromium.org/2182002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48287 0039d316-1c4b-4281-b951-d872f2087c98
* Marking EarlyReturnTest.ToastCrasher as flakyrafaelw@chromium.org2010-05-261-1/+2
| | | | | | | | | BUG=45115 TBR=cpu Review URL: http://codereview.chromium.org/2234004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48286 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust xpdual moz total_byte_b expectations.chase@chromium.org2010-05-261-1/+1
| | | | | | | | | | | | | This test behavior changed in 47458:47478. It became more erratic in 47633:47650. BUG=44944 TEST=xpdual moz is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/2287001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48285 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".erg@chromium.org2010-05-2611-21/+15
| | | | | | | | | | | | The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect has a constructor that just takes a Size. BUG=none TEST=none Review URL: http://codereview.chromium.org/2204001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TestRendererAccessibilityTree test.ctguil@chromium.org2010-05-261-12/+11
| | | | | | | | | | | Update role check to reflect recent accessibility changes. BUG=44546 TEST=none Review URL: http://codereview.chromium.org/2243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48282 0039d316-1c4b-4281-b951-d872f2087c98
* Add an inset border to the action button.arv@chromium.org2010-05-261-1/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2248001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48281 0039d316-1c4b-4281-b951-d872f2087c98
* Marking svg/clip-path/clip-path-evenodd-nonzero.svg as flaky.tonyg@chromium.org2010-05-261-1/+4
| | | | | | | | | BUG=45106 TEST=svg/clip-path/clip-path-evenodd-nonzero.svg Review URL: http://codereview.chromium.org/2218004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48280 0039d316-1c4b-4281-b951-d872f2087c98
* DevToolsSanityTest.TestStepOver needs to be disabled (not just marked FLAKY)tonyg@chromium.org2010-05-261-2/+2
| | | | | | | | | | | because it is timing out rather than failing. BUG=45080 TEST=DevToolsSanityTest.TestStepOver Review URL: http://codereview.chromium.org/2263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48279 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: remove xcodebodge tool.phajdan.jr@chromium.org2010-05-261-1274/+0
| | | | | | | | | | | It's no longer needed. Now we have gyp, and Xcode project files are generated by gyp. TEST=none BUG=none Review URL: http://codereview.chromium.org/2167003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48278 0039d316-1c4b-4281-b951-d872f2087c98
* Add a call to SetLastError before calling SetClassLongPtr. It turns out that ↵robertshield@chromium.org2010-05-261-0/+2
| | | | | | | | | | | | SetClasSLongPtr doesn't reset the error code on success and yet said code must be used to check for failure. BUG=45041 TEST=none Review URL: http://codereview.chromium.org/2229003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48277 0039d316-1c4b-4281-b951-d872f2087c98
* Updated ANGLE revision.alokp@chromium.org2010-05-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2091022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48276 0039d316-1c4b-4281-b951-d872f2087c98
* Update list of known crashes for recent reliability test failures: hunspell ↵pam@chromium.org2010-05-261-13/+3
| | | | | | | | | | | | crashes. TBR=tonyg BUG=43247 TEST=reliability bot Review URL: http://codereview.chromium.org/2258004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48275 0039d316-1c4b-4281-b951-d872f2087c98
* Add URL constants and command-line switches for ongoing print preview work.viettrungluu@chromium.org2010-05-264-0/+8
| | | | | | | | | BUG=173 TEST=none Review URL: http://codereview.chromium.org/2256001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48274 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 16:15:34 +0000