| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimized for the way we do internationalization with JST before
and is about 4 times faster (average 4.8ms vs 22.8ms) for the history
page.
The syntax for this is very similar to JsTemplates. It uses the
attributes i18n-values and i18n-content which worls like jsvalues and
jscontent except that it does not allow arbitrary expressions.
BUG=None
TEST=All UI pages should work as before
Review URL: http://codereview.chromium.org/149420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149575
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16675
TEST=None
Review URL: http://codereview.chromium.org/149586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Plus a quick part of the original patch missed on checkin.)
BUG=none
TEST=none
TBR
Review URL: http://codereview.chromium.org/149587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5406
Review URL: http://codereview.chromium.org/155399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/149581
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16657
TEST=nightly builds of Chromium should include avutil-50.dll, avformat-52.dll, avcodec-52.dll and pthreadGC2.dll
Review URL: http://codereview.chromium.org/149571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed to put them in a folder called "reference"
since that is what Josie needs to publish without
renaming.
Also fixed a few path issues.
Review URL: http://codereview.chromium.org/155467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16634
TEST=none
Review URL: http://codereview.chromium.org/155441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erg
Review URL: http://codereview.chromium.org/155466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failures. Will watch tree after commit.
TBR=evan
Review URL: http://codereview.chromium.org/155449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an age old bug that dropdown menus still looked depressed after you select something from them and they collapse. It also fixes the more recent bug that you could have focus in the render view without any indication drawn by the renderer. I suspect there was a change to webkit that exacerbated this bug, because it seems like something we would have noticed earlier.
Verified in a debugger that showing/hiding a dropdown menu doesn't emit focus signals, but does emit grab notify signals. Also verified that the bug is no longer reproducible in a simple page with <select> and <input> elements.
BUG=16313
TEST=see desc.
Review URL: http://codereview.chromium.org/149506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename AddLogin to AddPassword for consistency with other method names.
Remove a confusing out param from the form merge check function.
BUG=16486
TEST=Once the UI exists, deleting individual passwords should work on the Mac.
Review URL: http://codereview.chromium.org/155451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary hack that might not work in all locales and definitely won't work if we ever let users change font sizes. GtkLabels are just plain broken. Pango is also broken because you can get height-for-width for a layout but not width-for-height.
Thus we should switch to using skia to draw download items fonts, but this solution will work for now.
BUG=16389
TEST=download the Dansk version of open office for windows
Review URL: http://codereview.chromium.org/155395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16599
TEST=previous session should restore + linux splash page
Review URL: http://codereview.chromium.org/149555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add Terms of Service link for google chrome (not chromium).
BUG=16544
TEST=use dark theme, look at version in about:chrome
Review URL: http://codereview.chromium.org/155454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Honestly I'm not completely sure why this is happening, all I know is the internal widget isn't getting sized as large as we want it, so I changed it to take a more direct action to set the size.
BUG=16412
TEST=go to c, see infobar, switch tabs and go back and re-look at infobar. Should look same, with no 4 pixel strip of plainness.
Review URL: http://codereview.chromium.org/149579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since moving from ResourceBundle to ThemeProvider, we needed to
plumb through GetRTLEnabledPixbufNamed in ThemeProvider.
Review URL: http://codereview.chromium.org/149483
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Note I fixed a bug in AlertInfoBar while I was at it.
Review URL: http://codereview.chromium.org/155462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=UI tests on Mac should no longer all log that kills are failing.
Review URL: http://codereview.chromium.org/155297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Valgrind issue. The fix is in bookmark_storage.h - initialized the newly
added member ids_reassigned_ of LoadDetails class.
See http://codereview.chromium.org/149310 for the original CL.
TEST=NONE
BUG=16068
Review URL: http://codereview.chromium.org/155456
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
TEST=Disable cookie saving and try to login to iGoogle. Reenable and try again.
Review URL: http://codereview.chromium.org/149574
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
window.
Review URL: http://codereview.chromium.org/155432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes large amounts of plumbing because:
- All GtkChromeButtons are constructed from GtkThemeProvider which keeps a reference to all live buttons and sends them theme change notifications.
- CustomDrawButtons now subscribe themselves to the BROWSER_THEME_CHANGED notification; this gets rid of a LOT of plubming.
- Removes the GtkThemeProperties struct; just pass the theme provider around.
- Move all the constants from the themes namespace to class statics, per tony's suggestion
Review URL: http://codereview.chromium.org/149547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by alcor.
Original review: http://codereview.chromium.org/149204
BUG=http://crbug.com/14451
TEST=Open a theme, watch it apply.
Review URL: http://codereview.chromium.org/155355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It compiles and links on Linux after this change, but doesn't pass, so I don't enable it.
Review URL: http://codereview.chromium.org/149561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to mimic an array returns 'function' so certain tests fail. Skip over those tests in Safari.
Review URL: http://codereview.chromium.org/155442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r20532 because valgrind was complaining
about uninitialized memory:
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio
TBR=munjal
Review URL: http://codereview.chromium.org/155448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
protocols URLOpenStream supports. Fixes IE hang.
Review URL: http://codereview.chromium.org/149563
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16657
Review URL: http://codereview.chromium.org/149554
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=mark
BUG=16394
TEST=no build bot breakages
Review URL: http://codereview.chromium.org/155445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
"real" DEPS file.
Review URL: http://codereview.chromium.org/151188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
change for this is to get rid of the concept of a "current" toolstrip and the idea that there's only one handle around. Instead, each toolstrip has its own handle and each can be displaying it independently. There's some initial work for moles in there, but it's disabled since this will require some other plumbing to hook up properly.
Review URL: http://codereview.chromium.org/155192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
code changes.
Review URL: http://codereview.chromium.org/149572
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149497
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16554
TEST=AudioRendererHostTest.MockStreamDataConversation
Review URL: http://codereview.chromium.org/155412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
leaving the default to "disabled" until they work better.
Temporary, for use by people who like living on the bleeding edge.
BUG=none
TEST=none
jam: review
evan,jon: FYI
Review URL: http://codereview.chromium.org/149570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a protobuf-based metrics communication scheme between Chrome OS and
Chrome. Essentially, Chrome is used as a metrics upload service, and this hacks
in a simple IPC mechanism for Chrome OS to use to communicate metrics info to
Chrome for upload. We eventually want to do this using protobuffers over DBus,
but this protobuffers-over-X-properties mechanism will work for now.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the trails left behind when scrolling with the findbar open.
BUG=16124
TEST=Scroll with the find bar or popup blocker open. Make sure there are
no trails left behind or other drawing issues.
Review URL: http://codereview.chromium.org/149556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none; mac password storage has no UI yet. (Once it does: opting never to remember passwords for a site should not create a Keycahin entry.)
Review URL: http://codereview.chromium.org/155389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20537 0039d316-1c4b-4281-b951-d872f2087c98
|