summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert my change to get the tree green. Not sure why the tests became ↵jam@chromium.org2009-02-0461-1534/+1796
| | | | | | | | | | flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Review URL: http://codereview.chromium.org/21039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix delete to be delete[].mbelshe@google.com2009-02-041-1/+1
| | | | | | | (fix from craig.schlenter@gmail.com) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9131 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SecondLaunch which started failing after I did a clean build.jam@chromium.org2009-02-041-1/+1
| | | | | | | | I verified that this was broken before my changes by syncing to r9122. Review URL: http://codereview.chromium.org/21036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9130 0039d316-1c4b-4281-b951-d872f2087c98
* This change list fix issue 5926 -- RTL: Text in [New Tab] should be ↵xji@chromium.org2009-02-042-19/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | truncated from RightToLeft instead of LeftToRight. (http://crbug.com/5926) Basically, the issue is that in RTL locales, the thumbnail title etc. text will always be truncated from left, even if they are pure English. For example, "mail.yahoo.com" whose title is "Yahoo! the best web based email!" will be truncated to "best web-based email!". We should be able to truncate the title as "Yahoo! the be...". The fix is to set the direction style of each title in the [New Tab] html page for title to be displayed and truncated correctly. The fix consists 2 part: new_tab_ui.cc in backend and new_tab.html in frontend. 1. new_tab_ui.cc For thumbnail title, recent bookmark title, and recently closed tab titles, originally, we set "title" and "url" into the data we pass to JS in new_tab.html. The fix added the title's "direction" to the data. The direction is by default "ltr" and is set as "rtl" when there is character having strong directionality in the title. 2. new_tab.html 2.1 set text-alignment in thumbnail-title, bookmark container, and recently closed container to be "right" for RTL locales. 2.2 explicitly set title's directionality in the above 3 sections. Test: 1. open Chrome in RTL locales. 2. open the following pages: http://yahoo.com http://gmail.com http://mail.yahoo.com http://wikipedia.com http://msdn.microsoft.com/en-us/default.aspx http://arabic.arabia.msn.com/default.aspx http://he.wikipedia.org/ 3. bookmark, close some of them. 4. open [New Tab] Review URL: http://codereview.chromium.org/19738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9129 0039d316-1c4b-4281-b951-d872f2087c98
* try to fix mac buildjam@chromium.org2009-02-042-4/+3
| | | | | | Review URL: http://codereview.chromium.org/21035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9128 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ui test failurejam@chromium.org2009-02-041-2/+1
| | | | | | TBR=mpcomplete git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9125 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a passing test.ericroman@google.com2009-02-041-1/+0
| | | | | | | | | | (fixed by 40464:40500 webkit merge). TBR=levin@chromium.org Review URL: http://codereview.chromium.org/20034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9124 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easier/less work/less error-prone to create new IPC channel types ↵jam@chromium.org2009-02-0461-1854/+1535
| | | | | | | | (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
* The first step towards Turkish spell-checker.This is a set of fixes for ↵hbono@chromium.org2009-02-043-15/+36
| | | | | | | | | supporting the Turkish dictionary provided by the tr-spell project (*1).As I wrote in http://crbug.com/4782, this issue consists of three issues: one is against our convert_dict tool, and two are against our hunspell client.(*1) http://code.google.com/p/tr-spell/Unfortunately, the BDIC file converted from this Turkish dictionary is huge (7.1MB) because the dictionary has a lot of affix rules (> 18,000) and the most of the BDIC file is occupied by "AF" lines. BUG=4782 Review URL: http://codereview.chromium.org/18041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9122 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 40474:40500 [chromium-side].ericroman@google.com2009-02-047-35/+38
| | | | | | Review URL: http://codereview.chromium.org/21029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9121 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes MOST of a layout test. Before the font was WAY off because itdsh@google.com2009-02-044-1/+10
| | | | | | | | | | | couldn't find the correct font. Now the font is perfect, but the listbox controls are different. This is expected, so I'm rebaselining the pixel test. The text diff is still off by one number, so I'm leaving that alone until we figure it out. Review URL: http://codereview.chromium.org/23001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9120 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the usage stats opt-in javascript on the in EULA dialog to return ↵gwilson@google.com2009-02-041-2/+2
| | | | | | | | | | | the correct value when the checkbox is (not) selected. BUG=7368 R=cpu Review URL: http://codereview.chromium.org/21031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9119 0039d316-1c4b-4281-b951-d872f2087c98
* This file uses commas to separate apparently. ojan@google.com2009-02-041-4/+1
| | | | | | | | We should probably make it use line-breaks for consistency sake. In either case, make it use commas for now to green the tree. Review URL: http://codereview.chromium.org/21030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9117 0039d316-1c4b-4281-b951-d872f2087c98
* Improved OTR avatar and popup window rendering. Neither one precisely ↵pkasting@chromium.org2009-02-049-149/+132
| | | | | | | | | | | matches the old code but IMO each looks better. Once again, the aero_glass_non_client_view changes here are hackish, and will get cleaned up later. BUG=5054 Review URL: http://codereview.chromium.org/20011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9116 0039d316-1c4b-4281-b951-d872f2087c98
* Add site_instance, navigation_entry, browsing_instance, ↵pinkerton@chromium.org2009-02-046-55/+130
| | | | | | | | renderer_security_policy, and render_widget_helper to mac and linux builds. Adds a hash for Profile so it can be put into a hash table on gcc. Review URL: http://codereview.chromium.org/21021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9115 0039d316-1c4b-4281-b951-d872f2087c98
* Properly honor base::SharedMemory semantics for name="" to meanjrg@chromium.org2009-02-0413-57/+390
| | | | | | | | | | | | new/private shared memory on POSIX. Transition base::SharedMemory implementation to file/mmap() to prevent leaking of wired kernel resources and allow easier cleanup. Enable one more shared_memory unit test for POSIX. Enable stats_table_unittest.cc for Mac, and modify it so it cleans up. Review URL: http://codereview.chromium.org/19724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the extension installation code.erikkay@google.com2009-02-042-3/+6
| | | | | | Review URL: http://codereview.chromium.org/21027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9113 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists to better match the state of the tree. TBRojan@google.com2009-02-031-7/+2
| | | | | | Review URL: http://codereview.chromium.org/21026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9112 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily mask selenium failures.ericroman@google.com2009-02-031-1/+4
| | | | | | | | These broke with the webkit merge 40409:40464. Review URL: http://codereview.chromium.org/23002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9111 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9109.ojan@google.com2009-02-039-126/+10
| | | | | | | Broke the build. Review URL: http://codereview.chromium.org/20029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9110 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-039-10/+126
| | | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Review URL: http://codereview.chromium.org/21018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline an SVG layout test. There are only very slight pixel differences ↵sidchat@google.com2009-02-034-9/+9
| | | | | | | | in the way the rotated border is drawn, compared to the existing baseline. This probably happens due to slight difference in the way Skia anti-aliases lines. Review URL: http://codereview.chromium.org/19519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9108 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag to load a single extension from an arbitrary ↵erikkay@google.com2009-02-037-23/+78
| | | | | | | | (non-versioned) directory. This is designed for developers to iterate on extension development without having to go through the install process. Review URL: http://codereview.chromium.org/20020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9107 0039d316-1c4b-4281-b951-d872f2087c98
* Remember change in Spell Check language by putting it in the list of accept ↵sidchat@google.com2009-02-033-0/+47
| | | | | | | | | | | languages when the user changes the language from languages options menu. It also includes a fix (required for this change to work) when existing users are updated to use language only code for spellcheck languages instead of languages+region. Issue=5829 Review URL: http://codereview.chromium.org/19520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9106 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where we would try to add a finnur@google.com2009-02-031-15/+18
| | | | | | | | | | | | | | | | | | | | DocumentMarker with the same start- and endOffset, which AddMarker in WebKit will ignore. As a result, our marker vector is empty and we try to access the element with index -1. Also added a check to avoid a NOTREACHED in debug build, which can happen under normal circumstances (when you navigate away from a page when a search is in progress). BUG=http://crbug.com/7250 TEST=We don't have reproduction steps for the crash but if we stop seeing this on our crash server we'll know that it is fixed. Review URL: http://codereview.chromium.org/20028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9105 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for Windows 7 - 64 bit.rvargas@google.com2009-02-032-15/+43
| | | | | | | | | | BUG=4324 TEST=IntegrationTestsTest.* Review URL: http://codereview.chromium.org/20026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak.kuchhal@chromium.org2009-02-031-5/+5
| | | | | | | | | Bug=6535 Review URL: http://codereview.chromium.org/20009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9102 0039d316-1c4b-4281-b951-d872f2087c98
* Update SCons to latest checkpoint release, 1.2.0.d20090113.sgk@google.com2009-02-03175-708/+1312
| | | | | | | | Key new features include support for batch compilation (directly supported for Visual C/C++) and ${UN,}CHANGED_{SOURCES,TARGETS} variables. Review URL: http://codereview.chromium.org/20025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9101 0039d316-1c4b-4281-b951-d872f2087c98
* fix --new-baseline for image baselines on linux/mactc@google.com2009-02-032-24/+47
| | | | | | | | | | | | The previous change was causing image baselines to be treated as text only diffs so images were being copied into the chromium-win dir by accident. Fix this by reverting the change from test_type_base.py and applying it to text_diff.py instead. Review URL: http://codereview.chromium.org/20021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9100 0039d316-1c4b-4281-b951-d872f2087c98
* Bail saving window placement if the function is called after WM_DESTROY ↵ben@chromium.org2009-02-031-0/+7
| | | | | | | | | | (window_delegate_ is NULL). http://crbug.com/6376 Review URL: http://codereview.chromium.org/21004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9099 0039d316-1c4b-4281-b951-d872f2087c98
* Use Vars for the webkit repo and revision number. This wayojan@google.com2009-02-033-18/+31
| | | | | | | | | | we can override the via custom_vars in .gclient on the bots and official builds updates the merge script appropriately. Also updates checkdeps to be Var-aware. Review URL: http://codereview.chromium.org/19508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9098 0039d316-1c4b-4281-b951-d872f2087c98
* revert r9096. rvargas@google.com2009-02-032-41/+15
| | | | | | | TBD nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9097 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for Windows 7 - 64 bit.rvargas@google.com2009-02-032-15/+41
| | | | | | | | | BUG=4324 TEST=IntegrationTestsTest.* Review URL: http://codereview.chromium.org/20023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9096 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Update wow helper to support Windows 7.rvargas@google.com2009-02-032-0/+0
| | | | | | | | See http://codereview.chromium.org/20023 Review URL: http://codereview.chromium.org/20024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9095 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9090.ojan@google.com2009-02-0314-532/+645
| | | | | | | Broke chromium full build. Review URL: http://codereview.chromium.org/21024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9094 0039d316-1c4b-4281-b951-d872f2087c98
* adding GTM to thirdparty svn:ignore (like we do all the other things pulledthomasvl@chromium.org2009-02-030-0/+0
| | | | | | | in via deps) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9092 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the test transitions/transition-end-event-nested.html from ↵sky@google.com2009-02-031-3/+0
| | | | | | | | | | | | | | tests_fixable. I upstreamed a change that should make this always pass. BUG=none TEST=none TBR=finnur Review URL: http://codereview.chromium.org/21022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9091 0039d316-1c4b-4281-b951-d872f2087c98
* Move the about:ipc tab to a dialog. This patch is kind of a hack, the Windowsbrettw@chromium.org2009-02-0314-645/+532
| | | | | | | | | specific code for the settings dialog and the table view are just copied from the old dialog. I tried to change as little as possible. The only significant change should be that I commented out saving the settings in the profile. Review URL: http://codereview.chromium.org/19741 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9090 0039d316-1c4b-4281-b951-d872f2087c98
* Use _NSGetEnviron instead of environ (see "man environ"). environ isn'tmark@chromium.org2009-02-031-5/+2
| | | | | | | | available in a dylib, and with this change, gyp/xcode is able to build libbase as a dylib. Review URL: http://codereview.chromium.org/21019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9089 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out platform specific chrome_paths calls into platform specific files.tc@google.com2009-02-038-65/+172
| | | | | | | Review URL: http://codereview.chromium.org/19760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9088 0039d316-1c4b-4281-b951-d872f2087c98
* Add NOTIMPLEMENTED(); in temporary scaffolding stubs.phajdan.jr@chromium.org2009-02-032-247/+558
| | | | | | | | | More and more things link, but we need some indication that it's just smoke and mirrors. Review URL: http://codereview.chromium.org/19754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9087 0039d316-1c4b-4281-b951-d872f2087c98
* Adds implementation of web history in LayoutTestController, causing 18 ↵jcampan@chromium.org2009-02-033-25/+18
| | | | | | | | failing layout tests to pass. Review URL: http://codereview.chromium.org/19544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9086 0039d316-1c4b-4281-b951-d872f2087c98
* Pull GTM into the mac build via deps in prep of the UI layers needing it.thomasvl@chromium.org2009-02-031-0/+4
| | | | | | Review URL: http://codereview.chromium.org/20019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9085 0039d316-1c4b-4281-b951-d872f2087c98
* Move certificate verification off the IO thread.wtc@chromium.org2009-02-0314-364/+499
| | | | | | | | | | | | | | | | Move the MapNetErrorToCertStatus and MapCertStatusToNetError functions to cert_status_flags.h so they can be shared with Mac and Linux code. Move the certificate verification function to the X509Certificate class. Right now X509Certificate::Verify is only implemented on Windows. R=eroman BUG=3592 Review URL: http://codereview.chromium.org/14915 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9084 0039d316-1c4b-4281-b951-d872f2087c98
* Marking one test that passes on mac as such.thomasvl@chromium.org2009-02-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/21017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9083 0039d316-1c4b-4281-b951-d872f2087c98
* Extension loading improvements.erikkay@google.com2009-02-032-30/+74
| | | | | | | | | | | Add a method that allows loading a single specific extension. Load extensions upon successful install. Review is for which ever one of you gets in first, or both if you care. ;-) Review URL: http://codereview.chromium.org/19759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9082 0039d316-1c4b-4281-b951-d872f2087c98
* Updating test list to account for tests that are no longerfinnur@google.com2009-02-031-6/+1
| | | | | | | | failing (have been passing for a while now). Review URL: http://codereview.chromium.org/19801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9081 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in webkit/glue/phajdan.jr@chromium.org2009-02-039-47/+45
| | | | | | | | | | | - make more methods const - remove unneeded #includes BUG=7210 Review URL: http://codereview.chromium.org/19535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9080 0039d316-1c4b-4281-b951-d872f2087c98
* Porting unit tests.phajdan.jr@chromium.org2009-02-032-7/+4
| | | | | | Review URL: http://codereview.chromium.org/19723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9079 0039d316-1c4b-4281-b951-d872f2087c98
* This is for post-merge. I missed one failure (refresh-headers.php).ericroman@google.com2009-02-031-5/+6
| | | | | | | | | And the failures for MAC were duplicates. TBR=ojan Review URL: http://codereview.chromium.org/20016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9078 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 14:20:44 +0000