summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Makes the browser fetch the translate script regularly.jcivelli@chromium.org2010-07-2010-72/+137
| | | | | | | | | | | | | | | | | New versions of that script may get pushed from time to time. Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions. Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide). BUG=None TEST=Run the unit-tests. Original review: http://codereview.chromium.org/3034013/show Review URL: http://codereview.chromium.org/3041010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53016 0039d316-1c4b-4281-b951-d872f2087c98
* Remove temporary test expectations from v8 push (changes are now upstream in ↵ricow@chromium.org2010-07-201-5/+0
| | | | | | | | webkit). Review URL: http://codereview.chromium.org/3035009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53015 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed invalid reads when XmppClient is destroyed.akalin@chromium.org2010-07-203-5/+38
| | | | | | | | | BUG=49274 TEST=manual testing with code to trigger bug repro Review URL: http://codereview.chromium.org/3034016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53014 0039d316-1c4b-4281-b951-d872f2087c98
* Final M6 tweaks for sync strings.tim@chromium.org2010-07-201-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3011013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53010 0039d316-1c4b-4281-b951-d872f2087c98
* Handle client-tag duplicates on server items.nick@chromium.org2010-07-206-233/+429
| | | | | | | | | | | | The server no longer properly enforces this. In the event of a clash, pay attention only to the item with the lexically least ID. The lookup must be done at ProcessUpdate time; Verify is too early (clashes within a batch can't be handled). Add unit tests for hopefully all the corner cases. BUG=41696,48158,36599 TEST=new sync_unit_tests Review URL: http://codereview.chromium.org/3038008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53009 0039d316-1c4b-4281-b951-d872f2087c98
* Write HTML and CSS for Languages and Input options, based on Cole's mock.satorux@chromium.org2010-07-205-4/+104
| | | | | | | | | | | | | | Still no logic implemented, but it's nice to have something looking pretty. :) The current screenshot can be found at: http://chromium-os.googlecode.com/issues/attachment?aid=6893314955718114103&name=domui.png&token=09541fa12341c817ca5b2ecff2e5d463&inline=1 BUG=chromium-os:4573 TEST=manually Review URL: http://codereview.chromium.org/2836052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53008 0039d316-1c4b-4281-b951-d872f2087c98
* Initial bookmark bar folder window tries harder to be on-screen.jrg@chromium.org2010-07-202-0/+14
| | | | | | | | | | BUG=http://crbug.com/48832 TEST=Move window all the way to the right of screen so a folder would spill off. Open bookmark bar folder in question --> see it "pushed left" to get back on screen. Review URL: http://codereview.chromium.org/2884026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53007 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add buttons to the collected cookies dialog to add content exceptions.jochen@chromium.org2010-07-203-84/+456
| | | | | | | | | | | | | | | | This is the Mac side of http://codereview.chromium.org/2808053 . Looks like this: http://imgur.com/leY4C.png To provide user feedback, after an exception has been added, the exceptions window is shown. XIB changes: Add a button to the allowed cookies outline views to block cookies and two to the blocked cookies one to allow them; set the NSSplitView delegate to File's Owner. Review URL: http://codereview.chromium.org/2884024 Patch from Bernhard Bauer <bauerb@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53005 0039d316-1c4b-4281-b951-d872f2087c98
* media seek to any frame for ffmpegfbarchard@chromium.org2010-07-201-0/+4
| | | | | | | | | BUG=none TEST=should help layout tests when combined with a roll Review URL: http://codereview.chromium.org/2809061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53004 0039d316-1c4b-4281-b951-d872f2087c98
* Remove test which works on local Win machines but fails the Win bots ↵mirandac@google.com2010-07-201-35/+0
| | | | | | | | | | (suspect test harness issues). TBR=arv Review URL: http://codereview.chromium.org/3040009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53003 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to back off from Kerberos authentication if we don't have credentials.ahendrickson@google.com2010-07-208-10/+82
| | | | | | | | | | | | | | | | | | | If the user has a stale TGT, or is unable to generate a TGS for the server they are trying to communicate to, then generating an authentication token fails. Rather than fail the entire network transaction in that case, we resend the request with an empty Authenticate (or Proxy-Authenticate) header, and remember that the Negotiate scheme is not a valid option for this particular transaction. If the server responds back with headers like WWW-Authenticate: Negotiate WWW-Authenticate: Digest realm=foo then the digest scheme is chosen in the next round. BUG=33033 TEST=None Review URL: http://codereview.chromium.org/3010010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53002 0039d316-1c4b-4281-b951-d872f2087c98
* Fix start up crash when --disable-breakpad is used.huanr@chromium.org2010-07-201-0/+12
| | | | | | | | | | | | We should check whether breakpad is initialized before setting custom entries. BUG=49368 TEST=Chrome.exe --disable-breakpad Review URL: http://codereview.chromium.org/3010013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53001 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SpdyStream state for WebSocket supportukai@chromium.org2010-07-209-51/+360
| | | | | | | | | | | | | | In HTTP, it doesn't use STATE_READ_BODY/STATE_READ_BODY_COMPLETE states. Reading body message is handled in OnDataReceived() and DoLoop() is not involved in this state. In WebSocket, it will send frame after handshake has been finished, and need to get how many data has been written. STATE_OPEN handles this. BUG=none TEST=none Review URL: http://codereview.chromium.org/2962015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53000 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Disable NPAPITester.NPObjectReleasedOnDestruction.thestig@chromium.org2010-07-202-1/+3
| | | | | | | | BUG=30661,49576 TEST=none Review URL: http://codereview.chromium.org/3035008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52999 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Use the store as the last thumbnail in case we have no apps installed.arv@chromium.org2010-07-2013-43/+112
| | | | | | | | | | | | | 1. If no apps are installed we add an item for the store to the most visited section. 2. No longer hide the most visited by default. 3. This removes the default apps on non ChromeOS BUG=46028, 47700 TEST=With a clean profile without any apps installed you should see the store thumbnail unless you blacklist it or pin 8 ohter pages. Review URL: http://codereview.chromium.org/3001003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52998 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 63692:63707.tonyg@chromium.org2010-07-201-1/+1
| | | | | | | | | TBR=tony TEST=None BUG=None Review URL: http://codereview.chromium.org/3052002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52997 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing typo in name of offset variable.rlp@chromium.org2010-07-201-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2805090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52996 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix a valgrind leak.thakis@chromium.org2010-07-201-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This shows up as Suppression: { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE11_M_get_nodeEv fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE14_M_create_nodeERKS7_ fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE9_M_insertEPSt18_Rb_tree_node_baseSE_RKS7_ fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE13insert_uniqueESt17_Rb_tree_iteratorIS7_ERKS7_ fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEE6insertESt17_Rb_tree_iteratorIS8_ERKS8_ fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_ fun:_ZN23ExtensionMessageService24DispatchEventToRenderersERKSsS1_bRK4GURL fun:_ZL13DispatchEventP7ProfilePKcSs fun:_ZL26DispatchSimpleBrowserEventP7ProfileiPKc fun:_ZN27ExtensionBrowserEventRouter17OnBrowserRemovingEPK7Browser fun:_ZN11BrowserList13RemoveBrowserEP7Browser fun:_ZN7BrowserD0Ev fun:object_cxxDestructFromClass fun:_ZN12_GLOBAL__N_113ZombieDeallocEP11objc_objectP13objc_selector fun:-[NSResponder dealloc] fun:-[NSWindowController dealloc] fun:-[BrowserWindowController dealloc] fun:-[NSWindowController release] fun:__delayedPerformCleanup fun:CFRunLoopTimerInvalidate fun:CFRunLoopRunSpecific } , with c++filt __ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_ being map::operator[] and the symbol above it being map::insert(). (e.g. http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(3)/builds/3538/steps/memory%20test:%20ui/logs/stdio ). Seems to happen only on mac. This shouldn't leak, but maybe we're hitting an STL leak (I tried to build a reduced test case for a few minutes and failed). Maybe it goes away with this. BUG=none TEST=One fewer "Suppression:" line on mac ui_tests valgrind bots (2 instead of 3 atm). TBR=mpcomplete Review URL: http://codereview.chromium.org/2870060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52995 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a valgrind leak.thakis@chromium.org2010-07-201-0/+8
| | | | | | | | | | | BUG=46886 TEST=net_tests goes green on memory waterfall. TBR=phajdan,willchan Review URL: http://codereview.chromium.org/2819056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52994 0039d316-1c4b-4281-b951-d872f2087c98
* Add bookmark promo to NTP on first run.mirandac@google.com2010-07-2011-16/+158
| | | | | | | | | BUG=49328 TEST=First tip seen on import to empty profile is import bookmarks promo. This promo appears on the first 5 browser restarts, unless bookmarks are imported. Review URL: http://codereview.chromium.org/2805089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52993 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Profiles dialog handles multi-select and delete on Macdhollowa@chromium.org2010-07-204-67/+184
| | | | | | | | | | | | | | | | Changes the AutoFill dialog on Mac to support multi-select and delete of items in the address and credit card table. The "Edit..." button disables when multiple items are selected. Nib changes in AutoFillDialog.xib: (1) Enables multi-select for the table view, (2) binds the enabled state of the "Edit..." button to the new |multipleSelected| property, (3) connects edit button to outlet. BUG=49344 TEST=AutoFillDialogControllerTest.DeleteMultiple. Review URL: http://codereview.chromium.org/3039014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52989 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an unitialized read in a unit test to appease valgrindthakis@chromium.org2010-07-203-25/+1
| | | | | | | | | | | See http://codereview.chromium.org/2908003 for some backstory. BUG=none TEST=Webkit Mac memory bot goes green. Review URL: http://codereview.chromium.org/2825059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52988 0039d316-1c4b-4281-b951-d872f2087c98
* Negotiate on by default on all platforms.cbentzel@chromium.org2010-07-201-4/+1
| | | | | | | | | BUG=33033 TEST=Run chrome on POSIX plaforms without explicitly turning on Negotiate. Review URL: http://codereview.chromium.org/3014013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52987 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-2060-3248/+300
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* Use different separators for service-type and service-name in Kerberos SPN.cbentzel@chromium.org2010-07-202-3/+30
| | | | | | | | | | | | GSSAPI expects SPNs to be in the form HTTP@<server_name> and SSPI expects SPNs to be in the form HTTP/<server_name>. BUG=33033 TEST=net_unittests --gtest_filter="*HttpAuthHandlerNegotiate*", go against Kerberized server on Linux or OSX and see that the TGS is retrieved correctly. Review URL: http://codereview.chromium.org/3055001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52984 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve clipboard compatibility with firefox + evolution.estade@chromium.org2010-07-203-19/+20
| | | | | | | | | | BUG=48424 TEST=copying from the chrome bookmark manager into firefox should save the bookmark's title as well as url TEST=copying the address from the omnibox into evolution copies text, and doesn't create an attachment Review URL: http://codereview.chromium.org/3022004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52983 0039d316-1c4b-4281-b951-d872f2087c98
* Load the download animation image as an NSImage rather than a CGImageRef.rsesek@chromium.org2010-07-202-6/+5
| | | | | | | | | BUG=none TEST=ui_tests don't crash Review URL: http://codereview.chromium.org/3005018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52982 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix for a bug where extensions were not being notified when no window ↵andybons@chromium.org2010-07-203-0/+36
| | | | | | | | | | was in focus on the mac. BUG=32932 TEST=check bug. Review URL: http://codereview.chromium.org/2847062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52981 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Several functional fixes:jhawkins@chromium.org2010-07-204-35/+81
| | | | | | | | | | | | | * Don't fill CC data on non-HTTPS pages. * Don't display non-unique suggestions in the popup. * Fix displaying the 'AutoFill Options' suggestion (was a regression). BUG=48499 TEST=none Review URL: http://codereview.chromium.org/3040004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52980 0039d316-1c4b-4281-b951-d872f2087c98
* Some pyauto hooks crash in Debug mode.nirnimesh@chromium.org2010-07-201-16/+52
| | | | | | | | | | | 1. GetBrowserInfo() uses a method which was supposed to run on IO thread only, so fails in Debug 2. Fix AutomationJsonReply usage in SaveTabContents() TEST=python chrome/test/functional/pyauto_functional.py in Debug mode Review URL: http://codereview.chromium.org/3022012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52979 0039d316-1c4b-4281-b951-d872f2087c98
* notifications/views: Make use of the cross platform ↵tfarina@chromium.org2010-07-202-51/+9
| | | | | | | | | | | | | | | | NotificationOptionsMenuModel. This is the second part of the implementation of the cross platform model that makes use of the implementation in the views side and get rid of the duplicated coded. BUG=None TEST=Go to http://0xfe.muthanna.com/notifyme.html, request permission for notifications, notify it. Click on the wrench menu in the notification balloon, the menu should work as before. Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52978 0039d316-1c4b-4281-b951-d872f2087c98
* Send the gpu information along with the rest of the metrics.rlp@chromium.org2010-07-201-0/+9
| | | | | | | | | | | Note: this won't go green until issue 2857035 goes in. BUG=38736 TEST=none (suggestions welcome) Review URL: http://codereview.chromium.org/2895014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52977 0039d316-1c4b-4281-b951-d872f2087c98
* Disable pyautolib for chromium multi dll build. Will reenable itvictorw@chromium.org2010-07-201-1/+2
| | | | | | | | | | | | once it compiles for multi dll build. R=maruel BUG=none TEST=none Review URL: http://codereview.chromium.org/3050003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52976 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable BrowserTest.ThirtyFourTabs on mac.rvargas@google.com2010-07-201-7/+1
| | | | | | | | | | | BUG=49193 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/3037009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52975 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with extensions:mpcomplete@chromium.org2010-07-209-43/+84
| | | | | | | | | | | | | | | - Default to Allow file permissions for unpacked extensions. - Fix incognito warning display when extensions are reshuffled. - Remove SCHEMES_ALL BUG=48124 BUG=48526 BUG=49243 TEST=no Review URL: http://codereview.chromium.org/3039005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52974 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the client code for the X11 version.garykac@google.com2010-07-2028-638/+710
| | | | | | | | | | | | | Make ChromotingViews responsible for initializing themselves. Move all x11-related code into X11View. Create InputCapturer class manage client input capture. BUG=none TEST=ran Win host + X11 client Review URL: http://codereview.chromium.org/2861047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52973 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit DEPS 63669:63692.tony@chromium.org2010-07-203-3/+3
| | | | | | | | | | | Also fix video tests after webkit r63684. Webkit r63684 removes the load event, so change the layout tests to use canplaythrough instead. Review URL: http://codereview.chromium.org/3038010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52971 0039d316-1c4b-4281-b951-d872f2087c98
* Created a host for running the utility process as a child of the service ↵sanjeevr@chromium.org2010-07-2014-1/+732
| | | | | | | | | | | process. This is used for rendering PDFs to a metafile in a sandbox for the Cloud Print proxy on Windows. BUG=None TEST=Test Windows Cloud Print proxy Review URL: http://codereview.chromium.org/2917013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52970 0039d316-1c4b-4281-b951-d872f2087c98
* Send lock ready signal after Windowmanager has drawn the screen.oshima@chromium.org2010-07-207-48/+95
| | | | | | | | | | | | | Added ScreenLockerBackgroundView to re-layout lock_widget on resize. For 4399, we'll update WM to make lock window fullscreen, and update chrome to use window but not popup. BUG=chromium-os:4078, chromium-os:4399 TEST=none Review URL: http://codereview.chromium.org/3034012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52969 0039d316-1c4b-4281-b951-d872f2087c98
* Put sidetab menu back to wrench menu (confirmed with sky)oshima@chromium.org2010-07-209-72/+11
| | | | | | | | | | | | Removed OpenTanMode (confirmed with cole) Removed ToolbarView::SetAppMenuModel BUG=49229 TEST=none. Review URL: http://codereview.chromium.org/2832058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52968 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in renderer process when Pepper plugin fails to initialize.apatrick@chromium.org2010-07-201-0/+3
| | | | | | | | | | | Adding a null plugin delegate to current_oldstyle_pepper_plugins_ caused a crash when the element was later dereferenced. TEST=try BUG=none Review URL: http://codereview.chromium.org/2945019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52967 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Display a quick animation when a popup is blocked so the user notices ↵rsesek@chromium.org2010-07-2013-117/+1942
| | | | | | | | | | | | | | it in the Omnibox. This refactors the animation code of the DownloadStartedAnimationMac into AnimatableImage. BUG=49341 TEST=Go to http://www.popuptest.com/popuptest3.html. When a popup is opened, see animation. TEST=Download a file. Animation still plays. Review URL: http://codereview.chromium.org/3014005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52965 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Stop evictions while performing final cleanup.rvargas@google.com2010-07-204-2/+31
| | | | | | | | | | | | | The evictions code may post tasks for further processing and that is a problem at cache destruction, so add an explicit method to stop evictions. BUG=49547 TEST=none Review URL: http://codereview.chromium.org/2854053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52964 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Minor tweaks to the Wrench menu.rsesek@chromium.org2010-07-193-2/+12
| | | | | | | | | | | | | * Swap the +/- zoom buttons so that minus is first. * Invert the fullscreen arrows when in fullscreen mode. BUG=49449 TEST=Visual TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen. Review URL: http://codereview.chromium.org/3008010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52963 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stats table on linux. There were two problems:mbelshe@chromium.org2010-07-191-17/+31
| | | | | | | | | | | | a) We were using the wrong pid for the browser pid b) We weren't initializing the StatsTable after running the zygote. BUG=none TEST=none Review URL: http://codereview.chromium.org/3051003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52962 0039d316-1c4b-4281-b951-d872f2087c98
* I reversed the order of the EXPECT_EQ tests so expected value is first, ↵cbentzel@chromium.org2010-07-191-12/+12
| | | | | | | | | | | actual value is second. BUG=None TEST=unit_tests --gtest_filter="*CreditCardTest*" Review URL: http://codereview.chromium.org/3014014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52961 0039d316-1c4b-4281-b951-d872f2087c98
* Respect Spaces when dragging tabs on OS Xdavidben@chromium.org2010-07-192-0/+76
| | | | | | | | | | | | | | For 10.6 and above, we can simply filter windows out with isOnActiveSpace. For 10.5, there is another API in CoreGraphics that gives us the same information. It is slow and causes noticeable CPU usage during a drag, so cache it per-drag. R=pinkerton BUG=32796 TEST=open windows on separate spaces, drag a tab over where a window is on the other space Review URL: http://codereview.chromium.org/2962018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52960 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adjust omnibox decoration dragging to keep image under mouse.shess@chromium.org2010-07-196-16/+52
| | | | | | | | | | | | | | | | | | | LocationBarDecoration::GetDragImageFrame() added to let decorations specify where their GetDragImage() image is in the decoration. The mouse-down code ensures that the mouse drags from the expected point within that area, or centeres the image under the mouse if the drag is from somewhere else in the decoration. Additionally tracked down why -isFlipped affected the drag point and rewrote the code to be -isFlipped agnostic. BUG=49102, 40771 TEST=Goto https://www.thawte.com/. Drag from ev text, lock icon should be under cursor. TEST=drag from location or lock icon should drag from point in icon mouse click was in. Review URL: http://codereview.chromium.org/2870059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52959 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad from r609 to r627. This includes Mac DWARF CFI fixes ↵thestig@chromium.org2010-07-191-1/+1
| | | | | | | | | | and improvements to the Linux/Mac symbol dumper. BUG=none TEST=none Review URL: http://codereview.chromium.org/3038009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52958 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Prefs dialog on Mac should list derived labels for profiles, not ↵dhollowa@chromium.org2010-07-193-3/+47
| | | | | | | | | | | | | summaries. Changes the AutoFill dialog on Mac to display list of derived labels and not summaries. BUG=49344 TEST=Manual test as in bug. AutoFillDialogControllerTest.* Review URL: http://codereview.chromium.org/3041007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52957 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 02:10:50 +0000