summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* CreateDirectory() should check if an existing path is actually a directory ↵mmoss@google.com2008-09-116-21/+63
| | | | | | | | before skipping it. Also update a couple instances and comments to reflect current behaviour (see also http://codereview.chromium.org/1681). Review URL: http://codereview.chromium.org/1709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2060 0039d316-1c4b-4281-b951-d872f2087c98
* Return the exit code from setup.exe instead of returning a generic return code.kuchhal@chromium.org2008-09-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2059 0039d316-1c4b-4281-b951-d872f2087c98
* Closing a tab with a constrained pop-up showing an SSL interstitial would ↵jcampan@chromium.org2008-09-113-3/+40
| | | | | | | | | | crash the browser. BUG=1966 TEST=Open a page that opens a popup which is served over bad SSL. Close the tab. Review URL: http://codereview.chromium.org/1898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2058 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-1150-837/+790
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use the Windows high-resolution Time::Now hacks on Posix, the normal ↵deanm@chromium.org2008-09-114-66/+46
| | | | | | | | resultion from the time APIs there should be enough. Review URL: http://codereview.chromium.org/2420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2056 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to the latest trunk version.ager@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2055 0039d316-1c4b-4281-b951-d872f2087c98
* Put all prebuild scripts in external files. Scripts to run unit tests aremark@chromium.org2008-09-1110-26/+398
| | | | | | | staying put for now, because they're all trivial and identical. Review URL: http://codereview.chromium.org/1925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2054 0039d316-1c4b-4281-b951-d872f2087c98
* Tuck the ram/num_processes map into a function, and remove a static initializer.deanm@chromium.org2008-09-111-12/+11
| | | | | | Review URL: http://codereview.chromium.org/1936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2053 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IDNtoUnicode and unittest. jungshik@google.com2008-09-113-4/+10
| | | | | | | | | | | | | | | | | | | | 1. Check whether uloc_getdata returns the default locale because an invalid or unsupported (not a part of ICU data file we use) locale is passed. 2. Replace 'se' with 'sv' in IDNToUnicode test and change the corresponding test result to true. U+00C4 IS used in Swedish, but the result was set to false because the test results were machine generated with the same typo ('se' in place of 'sv') under en_US.UTF-8 locale on Linux and we ran this test only on Windows with en_US locale. 1st part of patch is by Matthias Reitinger <reimarvin@gmail.com> BUG=1153 TEST=NetUtilTest.IDNToUnicode passes in various locales, C, en_US, en_US.utf8, ja_JP.utf8, sv_SE.utf8, hi_IN.utf8, ru_RU.utf8, fr_CA Review URL: http://codereview.chromium.org/1655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2052 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the tabstrip doesn't have the chin above it in maximized view in aero.beng@google.com2008-09-111-1/+2
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/2414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
* Add the shared memory test to the scons build.paulg@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1928 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2050 0039d316-1c4b-4281-b951-d872f2087c98
* Add test to svn:ignore.maruel@google.com2008-09-110-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2048 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of porting the shared memory unittest. We still needpaulg@google.com2008-09-112-85/+113
| | | | | | | | | to port the underlying SharedMemory machinery, like ShareToProcess, before we can add all the tests in this file to the Mac and linux builds. This change removes the Windows threading dependencies. Review URL: http://codereview.chromium.org/1922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2046 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all but one place in this file where we returnwtc@google.com2008-09-111-2/+6
| | | | | | | | | | | | ERR_FAILED. In the remaining place, log the original Win32 error code to help diagnose a failure in the field. R=darin Review URL: http://codereview.chromium.org/2401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2044 0039d316-1c4b-4281-b951-d872f2087c98
* Set an upper limit to the number of characters that can appear in a tooltip ↵beng@google.com2008-09-112-0/+19
| | | | | | | | | | string. B=1368905 Review URL: http://codereview.chromium.org/2409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2042 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 1669: Renderer crashes on FindNextfinnur@google.com2008-09-102-20/+57
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1669 Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0. When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping. To recap on how Find works (since I know it has been a while since you looked at this problem): Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead. BUG=1341577 Review URL: http://codereview.chromium.org/1847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
* Double clicking on an item in the task manager should bring the relevant tab ↵petersont@google.com2008-09-107-10/+101
| | | | | | | | forward. Review URL: http://codereview.chromium.org/1822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix escaping of hrefs on A tags in the inspector. ojan@google.com2008-09-102-8/+9
| | | | | | | | | I will pursue making this change upstream as well, but as best I can tell, this function is dead code upstream and should just be deleted. Review URL: http://codereview.chromium.org/1880 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2023 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate unnecessary recompile/relink in the glue target by being more carefulmark@chromium.org2008-09-101-5/+4
| | | | | | | with webkit_version.h. Remove duplicate file from glue target. Review URL: http://codereview.chromium.org/1713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2021 0039d316-1c4b-4281-b951-d872f2087c98
* fix case for case-sensitive file systemspinkerton@google.com2008-09-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2018 0039d316-1c4b-4281-b951-d872f2087c98
* Bring test shell test into the mac projectavi@google.com2008-09-102-5/+10
| | | | | | Review URL: http://codereview.chromium.org/1705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2017 0039d316-1c4b-4281-b951-d872f2087c98
* Accommodate removal of gfx\platform_canvas_unittest_win.cc in thesgk@google.com2008-09-102-2/+1
| | | | | | | | SCons build (linked by the parent SConscript file). bitmap_platform_device.cc => bitmap_platform_device_win.cc Review URL: http://codereview.chromium.org/1710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2014 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the SSL tunnel establishment code so that itwtc@google.com2008-09-102-135/+62
| | | | | | | | | | | | | | | | | | | | | reuses the four states of writing the request headers and reading the response headers. Add a boolean member is_connect_method_ to tell, while we're in one of those four states, whether we're doing the HTTP CONNECT method (to set up a tunnel) or the real transaction. The motivation of this refactoring is that I need to read the response body when the CONNECT request fails, which makes me realize I'd need to duplicate more code with the original design. R=darin BUG=b/1272555 Review URL: http://codereview.chromium.org/1875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2011 0039d316-1c4b-4281-b951-d872f2087c98
* Google Update gave us a new IDL and asked us to change the CLSID const we ↵finnur@google.com2008-09-103-10/+23
| | | | | | | | use. Effectively there should be no change here. This is not required for the beta branch. Review URL: http://codereview.chromium.org/1901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2008 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetFreeDiskSpace for POSIX and GetSystemMemory for Linux.mark@chromium.org2008-09-102-6/+31
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com> http://codereview.chromium.org/1891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 580 that JavaScript cannot talk to Java applets.fqian@google.com2008-09-101-3/+3
| | | | | | | | | | | The cause was that the DOM binding code didn't treat HTMLAppletElement as a plugin element. I couldn't add a layout test because it requires Java plugin installed to run. Review URL: http://codereview.chromium.org/1900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2006 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at splitting the AutocompleteEdit into Model and View. This was ↵pkasting@chromium.org2008-09-1014-1302/+1571
| | | | | | | | | noticeably harder than with the Popup and I'm not at all sure I've made the right decisions :(. The View code is about 3x larger than the model. BUG=1343512 Review URL: http://codereview.chromium.org/1872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2004 0039d316-1c4b-4281-b951-d872f2087c98
* The About box was needlessly blocking Chrome on Vista SP1 (with UAC ↵finnur@google.com2008-09-103-3/+29
| | | | | | | | disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit. Review URL: http://codereview.chromium.org/1708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2003 0039d316-1c4b-4281-b951-d872f2087c98
* remove ifdefs around code since all our port platforms will use them.pinkerton@google.com2008-09-105-13/+2
| | | | | | Review URL: http://codereview.chromium.org/1707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2000 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 153 dev cyclemal@chromium.org2008-09-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1999 0039d316-1c4b-4281-b951-d872f2087c98
* If you click a link to a malware page or if a page redirects to malware, the ↵jcampan@chromium.org2008-09-101-3/+2
| | | | | | | | | | | | malware blocking page is shown but it says that the malware page is a resource of the originating page. This is because the blocking page was using the page URL to determine if we are dealing with the main frame, and in these cases the URL was not set yet. BUG=1335251 TEST=Navigate to a page that has a link to malware. Click on the link. The malware blocking page should be displayed and should indicate that the page is malware (and not that the originating page contains malware). Review URL: http://codereview.chromium.org/1881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grab bag of AeroGlassFrame issues:beng@google.com2008-09-105-21/+22
| | | | | | | | | | | | - better names and documentation for varions kOnstants in the AeroGlassNonClientView - AeroGlassFrame now uses the actual bounds of the tabstrip to adjust the DWM frame, rather than hard-coding constants. - fix bug in hit testing that meant that tabs weren't selectable... wrong coordinate system used for one function call... not sure how this didn't affect XP?!! B=1031854 Review URL: http://codereview.chromium.org/1882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1996 0039d316-1c4b-4281-b951-d872f2087c98
* Add gothicx@gmail.com (for issue 1783, integrated as r1840).sgk@google.com2008-09-101-0/+1
| | | | | | Review URL: http://codereview.chromium.org/1899 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1995 0039d316-1c4b-4281-b951-d872f2087c98
* Do a better job at bounding HexToInt.deanm@chromium.org2008-09-101-1/+1
| | | | | | | http://codereview.chromium.org/1703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1994 0039d316-1c4b-4281-b951-d872f2087c98
* more cross-platform graphics changespinkerton@google.com2008-09-102-5/+4
| | | | | | Review URL: http://codereview.chromium.org/1704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1993 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uses of PlatformCanvasWin and get compiling under gcc.pinkerton@google.com2008-09-102-9/+8
| | | | | | Review URL: http://codereview.chromium.org/1702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1992 0039d316-1c4b-4281-b951-d872f2087c98
* include SkGraphicsContextMac.mm and PlatformContextSkiapinkerton@google.com2008-09-102-7/+408
| | | | | | Review URL: http://codereview.chromium.org/1897 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1991 0039d316-1c4b-4281-b951-d872f2087c98
* BUG = 1357667fqian@google.com2008-09-105-38/+63
| | | | | | | | | | | | | Redo the fix of issue 1357667. Previous fix does not address all cases (HTMLLinkElement.sheet). It works by create a hidden reference from JS wrapper of StyleSheet object to its owner node. This is down when creating the JS wrapper object. Add a test for HTMLLinkElement that crashes both Chrome and Safari 3.1.2. Review URL: http://codereview.chromium.org/1678 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1990 0039d316-1c4b-4281-b951-d872f2087c98
* Glue now fully builds, add it to "all" targetpinkerton@google.com2008-09-101-0/+13
| | | | | | Review URL: http://codereview.chromium.org/1894 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1988 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out webplugin_impl to make more progress on testshellpinkerton@google.com2008-09-102-4/+58
| | | | | | Review URL: http://codereview.chromium.org/1701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1987 0039d316-1c4b-4281-b951-d872f2087c98
* Bring layout_test_controller.cc into the mac project.avi@google.com2008-09-105-11/+24
| | | | | | Review URL: http://codereview.chromium.org/1856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1986 0039d316-1c4b-4281-b951-d872f2087c98
* make more cross platform, use process_utils to get proc id. remove unused ↵pinkerton@google.com2008-09-101-6/+6
| | | | | | | | header. Review URL: http://codereview.chromium.org/1857 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1985 0039d316-1c4b-4281-b951-d872f2087c98
* Update include path for TestShell to be able to use Skia headers like SkTypes.hmark@chromium.org2008-09-101-0/+2
| | | | | | Review URL: http://codereview.chromium.org/1893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1984 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a mis-merge in TLS changes.deanm@chromium.org2008-09-101-4/+1
| | | | | | Review URL: http://codereview.chromium.org/1699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1983 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of code from the old to new TLS interface.deanm@chromium.org2008-09-109-61/+63
| | | | | | Review URL: http://codereview.chromium.org/1660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1982 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send queries when URL is like:darin@chromium.org2008-09-104-16/+52
| | | | | | | | | | | | | | | - starts with http:// or https:// and includes username (e.g. http://me@test.com/) - starts with http:// or https:// and includes query (e.g. http://test.com/?q=x) - starts with https:// and includes path component (e.g. https://test.com/path) so as not to leak user data to the suggest server. Patch by takayoshi.kochi@gmail.com BUG=1647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1978 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the pre-launch bzip2 hack.ericroman@google.com2008-09-101-23/+0
| | | | | | Review URL: http://codereview.chromium.org/1691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1974 0039d316-1c4b-4281-b951-d872f2087c98
* Patch for bug 1994:fqian@google.com2008-09-106-9/+121
| | | | | | | | | Make sure that customized properties set on window.location and window.navigator survive GC. Matches Safari and Firefox's behaviors. Review URL: http://codereview.chromium.org/1884 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1973 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some constants in the binding code.fqian@google.com2008-09-103-42/+40
| | | | | | Review URL: http://codereview.chromium.org/1879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1966 0039d316-1c4b-4281-b951-d872f2087c98
* Add suggested parentheses to fix build with GCC 4.3evanm@google.com2008-09-101-4/+4
| | | | | | | | | BUG=1876 Patch from James Vega <vega.james@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1965 0039d316-1c4b-4281-b951-d872f2087c98