| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
before skipping it. Also update a couple instances and comments to reflect current behaviour (see also http://codereview.chromium.org/1681).
Review URL: http://codereview.chromium.org/1709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1918
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
crash the browser.
BUG=1966
TEST=Open a page that opens a popup which is served over bad SSL. Close the tab.
Review URL: http://codereview.chromium.org/1898
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
resultion from the time APIs there should be enough.
Review URL: http://codereview.chromium.org/2420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
staying put for now, because they're all trivial and identical.
Review URL: http://codereview.chromium.org/1925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1936
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Check whether uloc_getdata returns the default locale because an invalid or unsupported (not a part of ICU data file we use) locale is passed.
2. Replace 'se' with 'sv' in IDNToUnicode test and change the corresponding
test result to true. U+00C4 IS used in Swedish, but the result was set to
false because the test results were machine generated with the same
typo ('se' in place of 'sv') under en_US.UTF-8 locale on Linux and
we ran this test only on Windows with en_US locale.
1st part of patch is by Matthias Reitinger <reimarvin@gmail.com>
BUG=1153
TEST=NetUtilTest.IDNToUnicode passes in various locales, C, en_US, en_US.utf8,
ja_JP.utf8, sv_SE.utf8, hi_IN.utf8, ru_RU.utf8, fr_CA
Review URL: http://codereview.chromium.org/1655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
B=1031854
Review URL: http://codereview.chromium.org/2414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1928
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to port the underlying SharedMemory machinery, like ShareToProcess,
before we can add all the tests in this file to the Mac and linux
builds. This change removes the Windows threading dependencies.
Review URL: http://codereview.chromium.org/1922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ERR_FAILED.
In the remaining place, log the original Win32 error
code to help diagnose a failure in the field.
R=darin
Review URL: http://codereview.chromium.org/2401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string.
B=1368905
Review URL: http://codereview.chromium.org/2409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=1669
Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0.
When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping.
To recap on how Find works (since I know it has been a while since you looked at this problem):
Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead.
BUG=1341577
Review URL: http://codereview.chromium.org/1847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
forward.
Review URL: http://codereview.chromium.org/1822
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I will pursue making this change upstream as well,
but as best I can tell, this function is dead code upstream
and should just be deleted.
Review URL: http://codereview.chromium.org/1880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
with webkit_version.h. Remove duplicate file from glue target.
Review URL: http://codereview.chromium.org/1713
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
SCons build (linked by the parent SConscript file).
bitmap_platform_device.cc => bitmap_platform_device_win.cc
Review URL: http://codereview.chromium.org/1710
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reuses the four states of writing the request headers
and reading the response headers.
Add a boolean member is_connect_method_ to tell, while
we're in one of those four states, whether we're doing
the HTTP CONNECT method (to set up a tunnel) or the
real transaction.
The motivation of this refactoring is that I need to
read the response body when the CONNECT request fails,
which makes me realize I'd need to duplicate more code
with the original design.
R=darin
BUG=b/1272555
Review URL: http://codereview.chromium.org/1875
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
use. Effectively there should be no change here. This is not required for the beta branch.
Review URL: http://codereview.chromium.org/1901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>
http://codereview.chromium.org/1891
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The cause was that the DOM binding code didn't treat HTMLAppletElement as a plugin element.
I couldn't add a layout test because it requires Java plugin installed to run.
Review URL: http://codereview.chromium.org/1900
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
noticeably harder than with the Popup and I'm not at all sure I've made the right decisions :(. The View code is about 3x larger than the model.
BUG=1343512
Review URL: http://codereview.chromium.org/1872
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit.
Review URL: http://codereview.chromium.org/1708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1707
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
malware blocking page is shown but it says that the malware page is a resource of the originating page.
This is because the blocking page was using the page URL to determine if we are dealing with the main frame, and in these cases the URL was not set yet.
BUG=1335251
TEST=Navigate to a page that has a link to malware. Click on the link. The malware blocking page should be displayed and should indicate that the page is malware (and not that the originating page contains malware).
Review URL: http://codereview.chromium.org/1881
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- better names and documentation for varions kOnstants in the AeroGlassNonClientView
- AeroGlassFrame now uses the actual bounds of the tabstrip to adjust the DWM frame, rather than hard-coding constants.
- fix bug in hit testing that meant that tabs weren't selectable... wrong coordinate system used for one function call... not sure how this didn't affect XP?!!
B=1031854
Review URL: http://codereview.chromium.org/1882
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1899
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1703
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1704
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1702
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1897
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Redo the fix of issue 1357667. Previous fix does not address all cases (HTMLLinkElement.sheet).
It works by create a hidden reference from JS wrapper of StyleSheet object to its owner node.
This is down when creating the JS wrapper object.
Add a test for HTMLLinkElement that crashes both Chrome and Safari 3.1.2.
Review URL: http://codereview.chromium.org/1678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1894
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1701
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header.
Review URL: http://codereview.chromium.org/1857
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1660
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- starts with http:// or https:// and includes username (e.g.
http://me@test.com/)
- starts with http:// or https:// and includes query (e.g. http://test.com/?q=x)
- starts with https:// and includes path component (e.g. https://test.com/path)
so as not to leak user data to the suggest server.
Patch by takayoshi.kochi@gmail.com
BUG=1647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1691
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make sure that customized properties set on window.location and window.navigator survive
GC. Matches Safari and Firefox's behaviors.
Review URL: http://codereview.chromium.org/1884
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1876
Patch from James Vega <vega.james@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1965 0039d316-1c4b-4281-b951-d872f2087c98
|