| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The success/failure of this test depends on the location of the mouse. Other
StatusBubbleMacTest.* tests may have the same issue too.
BUG=none
TEST=trybots and less flakiness
Review URL: http://codereview.chromium.org/460029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
need rebaselined hashes.
BUG=29259
TEST=LayoutTests/fast/layers/self-painting-outline.html
TEST=LayoutTests/fast/repaint/inline-relative-positioned.html
TEST=LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b.svg
R=vandebo@chromium.org
Review URL: http://codereview.chromium.org/465019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lines of code, but I think it'd be better this way. Setting the ICU
default locale 'quitely' as a part of IsLocaleAvailable is partly responsible for bug 26856.
With the fix for that bug, Mac Chrome sets the ICU default locale explicitly.
Putting Linux/Windows on the same footing is a "good thing" (TM).
In addition, I fixed a typo (a spurrious L modifier to a char literal) and
resolved one TODO comment (use uloc_getCharacterOrientation to determine
the text layout direction).
BUG=NONE
TEST=Covered by unittests: L10nUtilTest.*
Review URL: http://codereview.chromium.org/449077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/455036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=24182
Review URL: http://codereview.chromium.org/460034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=24182
Review URL: http://codereview.chromium.org/464010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The most important changes are that we bin the failures into mutually
exclusive buckets, so that they aren't double-reported like before. As a
result of this, compare_failures became much simpler and I ended up folding
it into run_webkit_tests and test_expectations
In addition, a lot of the data structures for holding different sets of
failures have been revised to be more consistent and extensible. This allows
me to have the output match the LTTF dashboard as well.
R=ojan@chromium.org,tc@chromium.org,pam@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jrg@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/465017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
TEST=none
BUG=27996
Review URL: http://codereview.chromium.org/462015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I missed one of your comments in the last CL
Review URL: http://codereview.chromium.org/464009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Rebaselined/disabled tests as necessary.
Review URL: http://codereview.chromium.org/465016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
NOTE: This CL was already reviewed.
See: http://codereview.chromium.org/437044/show
Add ids and stubs for new common commands
and change it so command ids are 11 bits
and the size is 21 bits.
Since size is in command elements and
1 command element is 4 bytes that allows you
to pass 2^23rd bytes inside the command
buffer which is 8meg.
Review URL: http://codereview.chromium.org/465013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=willchan
BUG=29241
TEST=none
Review URL: http://codereview.chromium.org/455029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support both not picking invisible objects and
the option to pick even if invisible.
The idea is you can do something like this
// Make a picking manager
var pm = o3djs.picking.createPickManager(rootTransform);
... // add a bunch of transforms.
// generate picking objects.
pm.update();
// Get the picking object that was created for some specific transform
var info = pm.getTransformInfo(someTransform);
// Set properties on that object related to picking
info.pickEvenIfInvisible = true;
I think this is just a first step. How an object should
be defined as pickable is up for debate. As it is,
you can basically override info.isPickable.
as in
info.isPickable = function() {
// do something custom.
}
You can also start adding things easier like
info.onPick = function() {
// do something.
}
and then write code like
info = pm.pick(worldRay);
if (info) {
info.onPick();
}
While you could have done that before there was no
easy way to find a the TransformInfo for a
specific Transform. Now you can use
PickManager.getTransformInfo
Review URL: http://codereview.chromium.org/452027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so that unittests run faster.
BUG=22061
TEST=this is the test
Review URL: http://codereview.chromium.org/462010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X-UA-Compatible HTTP header (in addition to the meta tag support).
Also pins the CF module into the process such that it won't get unloaded. Doing this to work around how we can get unloaded without unpatching properly.
BUG=22802
TEST=Navigate to a web site whose server sends the X-UA-Compatible: chrome=1 HTTP header and ensure that the page is loaded in CF.
Review URL: http://codereview.chromium.org/465009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ukai@chromium.org
Review URL: http://codereview.chromium.org/449021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33611
Review URL: http://codereview.chromium.org/455031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This fixes decompression failures with some sites.
R=wtc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=2844
Review URL: http://codereview.chromium.org/465011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A couple of icon changes to news. Bump the version for mappy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/458011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build of Chromium, for both the views and the gtk versions of the
options panel.
BUG=768
TEST=Built chrome for chromeos and verified that the default browser
items were no longer there.
Review URL: http://codereview.chromium.org/464006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make_page_red
Review URL: http://codereview.chromium.org/465015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=brettw
TEST=none
BUG=27548
Review URL: http://codereview.chromium.org/462012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This prevents console spew when ctrl+c closing works gracefully.
Review URL: http://codereview.chromium.org/462013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These tests (NotifyOtherProcessFailure and NotifyOtherProcessDifferingHost) involve killing the browser process, which under valgrind leaves incomplete valgrind output.
BUG=25176
TEST="tools/valgrind/chrome_tests.sh -t ui --gtest_filter=ProcessSingletonLinuxTest.\*" should not output any valgrind warnings.
Review URL: http://codereview.chromium.org/460003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29174
Review URL: http://codereview.chromium.org/464005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Crashes report uptime in milliseconds instead of seconds.
Review URL: http://codereview.chromium.org/463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28796
TEST=Link on about:crash is not blue on blue.
Review URL: http://codereview.chromium.org/444008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29217
Review URL: http://codereview.chromium.org/460028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=tools/valgrind/chrome_tests.sh t unit gtest_filter=ProfileManagerTest.CreateProfile
Review URL: http://codereview.chromium.org/455031
TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/458012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Rebaseline test expectations appropriately.
TBR=awong
TEST=existing suffice
Review URL: http://codereview.chromium.org/464007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile
Review URL: http://codereview.chromium.org/455031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
locking the user out. Matches existing UI in Linux/Windows.
BUG=http://crbug.com/26800
TEST=as in bug
Review URL: http://codereview.chromium.org/460025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527
Review URL: http://codereview.chromium.org/449073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/458010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
confirmation dialogs.
BUG=26357
TEST=try to install any extension on Mac, verify that the default (blue) button with the key equivalent of 'Return' is the abort action, NOT the install action.
Review URL: http://codereview.chromium.org/463008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/459009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina <thiago.farina@gmail.com>
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/442014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We had a suppression for this race, but it couldn't hide the race in some rare cases like
http://build.chromium.org/buildbot/waterfall/builders/Linux Tests (tsan)/builds/1213/steps/valgrind test%3A base/logs/stdio
when the order of the racing accesses was different.
Review URL: http://codereview.chromium.org/466009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- download shelf
- find bar
- blocked popup container
Notably, don't theme the infobar close button.
In a follow up patch, I will fix the findbar and blocked popup container of Windows.
BUG=29101
Review URL: http://codereview.chromium.org/454024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also enable the task_manager_browsertest.cc (where I added the new test) on Linux.
TEST=Covered by browser_tests.
BUG=21635
Review URL: http://codereview.chromium.org/465007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
clicking a browser action multiple times very quickly. The other has to do with the frame of the popup changing mid-animation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/464004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29212
TBR=ajwong
Review URL: http://codereview.chromium.org/462008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- enable mouse-over event to show hand-cursor
- enable mouse-click event, which launches help url
win and linux_view: use TabContents to launch url for link in crash page
- was using BrowserList::GetLastActive, but in chrome frame, this is null, so url can't launch.
- now, TabcontentsView passes its TabContents when creating SadTabView.
- SadTabView only creates learn-more link if TabContents is not null.
BUG=27298,29034
TEST=chromeos: verify that link in crash page shows hand cursor on mouse over, and launches help url when clicked.
win, chromeos: link in crash page can be launched successfully in chrome-frame release.
Review URL: http://codereview.chromium.org/460021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests and test_shell_tests.
BUG=12710
Review URL: http://codereview.chromium.org/460014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/455034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29208
TEST=Happier Mac UI valgrind bots
Review URL: http://codereview.chromium.org/465010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33590 0039d316-1c4b-4281-b951-d872f2087c98
|