summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* mojo: fix python unittests.Benjamin Lerman2014-09-191-1/+1
| | | | | | | | TBR=sdefresne@chromium.org Review URL: https://codereview.chromium.org/586683002 Cr-Commit-Position: refs/heads/master@{#295685}
* mojo: Add deserialization to python structs.qsr2014-09-194-29/+254
| | | | | | | | | | | | | This is a reland of https://codereview.chromium.org/578263003 using buffer instead of memoryview, because on some early version of python 2.7, memoryview cannot be used with struct.unpack_from. BUG=415491 R=sdefresne@chromium.org,cmasone@chromium.org Review URL: https://codereview.chromium.org/588493002 Cr-Commit-Position: refs/heads/master@{#295684}
* Revert of Make ONCCertificateImporter async. (patchset #5 id:190001 of ↵eugenis2014-09-1911-392/+324
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/547553005/) Reason for revert: Use-after-free. https://code.google.com/p/chromium/issues/detail?id=415916 Original issue's description: > Make ONCCertificateImporter async. > > This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ > > Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. > > Now, the import itself is asychronous and calls back on completion. > > While there, this also removes the GMock of the importer. > > BUG=413219 > > Committed: https://crrev.com/bc656c0e7b7bd67fb28e5a880d21b9510ebd3e3a > Cr-Commit-Position: refs/heads/master@{#295534} TBR=joaodasilva@chromium.org,eroman@chromium.org,pneubeck@chromium.org NOTREECHECKS=true NOTRY=true BUG=413219 Review URL: https://codereview.chromium.org/580283005 Cr-Commit-Position: refs/heads/master@{#295683}
* Roll WebRtc/Libjingle to r7234.perkj2014-09-192-3/+3
| | | | | | | | TBR=kjellander@chromium.org Review URL: https://codereview.chromium.org/578383005 Cr-Commit-Position: refs/heads/master@{#295682}
* Fix is_chrome_branded check in chrome_repack_locales.gni.engedy2014-09-191-4/+4
| | | | | | | | | | It was using chromium resources when it should have used chrome resources, and vice versa. BUG=None Review URL: https://codereview.chromium.org/575923004 Cr-Commit-Position: refs/heads/master@{#295681}
* Fix and re-enable v8 idle notification after commit.ernstm2014-09-191-2/+3
| | | | | | | | | | | | | For idle times < 1000us, we sent notifications with 0ms. This patch adds a check for idle_time_in_ms to be non-zero and re-enables the feature by default. R=jochen@chromium.org BUG=414815 Review URL: https://codereview.chromium.org/583833002 Cr-Commit-Position: refs/heads/master@{#295680}
* Upgrade liblouis to 2.6.0.plundblad2014-09-1912-5863/+101
| | | | | | | | | | | | | | | | | | | | This changes to the new mirror of the third_party library liblouis, necessary because the project moved to github from an svn repository on code.google.com. Since the git mirroring infrastructure doesn't support excluding parts of the tree, this means adding some GPL files and some files without license headers. The whitelist in tools/checklicenses/checklicenses.py has been extended as needed. One braille table (Hindi computer braille) is not available in liblouis and has been removed. A follow-up CL will add support for new braille tables added in this release. BUG=341951 R=dtseng@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/579623003 Cr-Commit-Position: refs/heads/master@{#295679}
* Revert of [telemetry] Read MSRs from a separate privileged process. ↵vasilii2014-09-195-238/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:40001 of https://codereview.chromium.org/578123002/) Reason for revert: Fails telemetry_unittests and telemetry_perf_unittests on XP Tests (2) http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/35314 Traceback (most recent call last): run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331 testMethod() testPowerMonitoringSync at tools\telemetry\telemetry\core\platform\platform_backend_unittest.py:16 if not platform.CanMonitorPower(): CanMonitorPower at tools\telemetry\telemetry\core\platform\__init__.py:248 return self._platform_backend.CanMonitorPower() CanMonitorPower at tools\telemetry\telemetry\core\platform\win_platform_backend.py:313 return self._power_monitor.CanMonitorPower() CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51 if self._PackageEnergyJoules() <= 0: _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97 return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) * ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347 self._StartMsrServerIfNeeded() _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338 sys.executable, parameters, elevate_privilege=True) LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293 if elevate_privilege and not IsCurrentProcessElevated(): IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80 win32security.GetTokenInformation(token, win32security.TokenElevation)) error: (87, 'GetTokenInformation', 'The parameter is incorrect.') Locals: handle : -1 token : <PyHANDLE:0> [ FAILED ] platform.platform_backend_unittest.PlatformBackendTest.testPowerMonitoringSync (3422 ms) Traceback (most recent call last): run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331 testMethod() wrapper at tools\telemetry\telemetry\decorators.py:84 func(*args, **kwargs) testMsrRuns at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor_unittest.py:19 if not power_monitor.CanMonitorPower(): CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51 if self._PackageEnergyJoules() <= 0: _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97 return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) * ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347 self._StartMsrServerIfNeeded() _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338 sys.executable, parameters, elevate_privilege=True) LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293 if elevate_privilege and not IsCurrentProcessElevated(): IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80 win32security.GetTokenInformation(token, win32security.TokenElevation)) error: (87, 'GetTokenInformation', 'The parameter is incorrect.') Locals: handle : -1 token : <PyHANDLE:0> [ FAILED ] platform.power_monitor.msr_power_monitor_unittest.MsrPowerMonitorTest.testMsrRuns (32 ms) [----------] 1 test (32 ms total) Traceback (most recent call last): run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331 testMethod() wrapper at tools\telemetry\telemetry\decorators.py:55 func(*args, **kwargs) BenchmarkSmokeTest at tools\perf\benchmarks\benchmark_unittest.py:59 self.assertEqual(0, SinglePageBenchmark().Run(options), Run at tools\telemetry\telemetry\benchmark.py:95 page_runner.Run(pt, ps, expectations, finder_options, results) Run at tools\telemetry\telemetry\page\page_runner.py:429 page, credentials_path, possible_browser, results, state) _PrepareAndRunPage at tools\telemetry\telemetry\page\page_runner.py:259 finder_options) StartBrowserIfNeeded at tools\telemetry\telemetry\page\page_runner.py:54 test.WillStartBrowser(possible_browser.platform) WillStartBrowser at tools\perf\measurements\webrtc.py:21 self._power_metric = power.PowerMetric(platform) __init__ at tools\perf\metrics\power.py:31 self._MeasureQuiescentPower(quiescent_measurement_time_s) _MeasureQuiescentPower at tools\perf\metrics\power.py:54 if not self._platform.CanMonitorPower() or \ CanMonitorPower at tools\telemetry\telemetry\core\platform\__init__.py:248 return self._platform_backend.CanMonitorPower() CanMonitorPower at tools\telemetry\telemetry\core\platform\win_platform_backend.py:313 return self._power_monitor.CanMonitorPower() CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51 if self._PackageEnergyJoules() <= 0: _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97 return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) * ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347 self._StartMsrServerIfNeeded() _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338 sys.executable, parameters, elevate_privilege=True) LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293 if elevate_privilege and not IsCurrentProcessElevated(): IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80 win32security.GetTokenInformation(token, win32security.TokenElevation)) error: (87, 'GetTokenInformation', 'The parameter is incorrect.') Locals: handle : -1 token : <PyHANDLE:0> [ FAILED ] BenchmarkSmokeTest.webrtc.webrtc_cases (766 ms) Original issue's description: > [telemetry] Read MSRs from a separate privileged process. > > This allows us to read MSRs on Windows Vista+. > Also move ReadMsr into PlatformBackend. > > BUG=336558 > TEST=tools/telemetry/run_tests msr > > Committed: https://crrev.com/2156b0323c83d6f11e68344ecf7e7e0c833cfa14 > Cr-Commit-Position: refs/heads/master@{#295634} TBR=tonyg@chromium.org,thestig@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=336558 Review URL: https://codereview.chromium.org/582123003 Cr-Commit-Position: refs/heads/master@{#295678}
* Revert of Remove void** from disk_cache interface. (patchset #30 id:650001 ↵vasilii2014-09-1921-353/+346
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/542733002/) Reason for revert: Introduced memory leaks on linux asan http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892: Direct leak of 80 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5 #2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #4 0x2e3b0bf in Run base/callback.h:401:12 #5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 64 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5 #2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #6 0x2e3b0bf in Run base/callback.h:401:12 #7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 36 byte(s) in 1 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5 #2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121 #3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8 #4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8 #5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #9 0x2e3b0bf in Run base/callback.h:401:12 #10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Remove void** from disk_cache interface. > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org > BUG=413644 > > Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342 > Cr-Commit-Position: refs/heads/master@{#295659} TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,pasko@chromium.org,piman@chromium.org,michaeln@chromium.org,cbentzel@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=413644 Review URL: https://codereview.chromium.org/585833002 Cr-Commit-Position: refs/heads/master@{#295677}
* Update V8 to version 3.29.78 (based on bleeding_edge revision r24051).v8-autoroll2014-09-191-1/+1
| | | | | | | | TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/583023003 Cr-Commit-Position: refs/heads/master@{#295676}
* Abstract class WebTestDelegate to chromium c++ style.abhishek.a212014-09-1926-514/+531
| | | | | | | | BUG=331299 Review URL: https://codereview.chromium.org/583113002 Cr-Commit-Position: refs/heads/master@{#295675}
* Add cdbs to install-build-depsHenrik Kjellander2014-09-191-2/+2
| | | | | | | | | | | | | | | | | | The Common Debian Build System (cdbs) is needed for packaging .deb files in some configurations. http://packages.ubuntu.com/search?keywords=cdbs shows that it's available for all common Ubuntu distributions. On Precise and Trusty, the package is very small (~40kB), so it shouldn't have much impact on users. TESTED=ran install-build-deps.sh on Ubuntu Precise. R=friedman@chromium.org Review URL: https://codereview.chromium.org/531513002 Cr-Commit-Position: refs/heads/master@{#295674}
* Remove "device scale factor" option from about flags page.oshima2014-09-192-34/+0
| | | | | | | | | | --force-device-scale-factor is kept for dev purpose. BUG=None Review URL: https://codereview.chromium.org/580083004 Cr-Commit-Position: refs/heads/master@{#295673}
* Add UMA for app list creation time.calamity2014-09-192-0/+14
| | | | | | | | | | | This CL adds a UMA histogram for the amount of time taken to build the app list. BUG=415389 Review URL: https://codereview.chromium.org/580993003 Cr-Commit-Position: refs/heads/master@{#295672}
* Rename AppsClient -> AppWindowClientoshima2014-09-1934-181/+186
| | | | | | | | | | | per the comment in apps_client.h BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/583583008 Cr-Commit-Position: refs/heads/master@{#295671}
* Revert of Cleanup: Remove remaining generated extensions APIs on Android. ↵thestig2014-09-1910-90/+73
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:60001 of https://codereview.chromium.org/573933002/) Reason for revert: Android bot fails with error: gen/extensions/common/api/generated_schemas.cc: No such file or directory Original issue's description: > Cleanup: Remove remaining generated extensions APIs on Android. > > BUG=305852 > > Committed: https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472 > Cr-Commit-Position: refs/heads/master@{#295669} TBR=yoz@chromium.org NOTREECHECKS=true NOTRY=true BUG=305852 Review URL: https://codereview.chromium.org/582933003 Cr-Commit-Position: refs/heads/master@{#295670}
* Cleanup: Remove remaining generated extensions APIs on Android.thestig2014-09-1910-73/+90
| | | | | | | | BUG=305852 Review URL: https://codereview.chromium.org/573933002 Cr-Commit-Position: refs/heads/master@{#295669}
* NaCl: Update revision in DEPS, r13748 -> r13759dschuff2014-09-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This pulls in the following Native Client changes: r13749: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13750: (dyen) Added tests for remaining directory functions in irt_ext. r13751: (uekawa) NonSFI mode: Make tests/common/register_set.h PIC-friendly r13752: (uekawa) NonSFI mode: Add libcrt_platform for native/mixed linking. r13753: (dschuff) Remove i686-hosted Linux build and start switching to new directory layout r13754: (dschuff) export_header.py: Mangle include guards in exported headers r13755: (bradnelson) Turning on goma on nacl bots. r13756: (dbrazdil) Implemented the _exit() syscall in MinSFI. r13757: (bradnelson) Disable goma on win7-32 bots because it doesn't suport that platform. r13758: (mseaborn) Cleanup: Use NaClCopyInFromUser() in one case in mmap() r13759: (dschuff) Update revision for PNaCl r13739->r13753 BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/582213004 Cr-Commit-Position: refs/heads/master@{#295668}
* Roll src/third_party/skia b14e4a0:3c29c4dskia-deps-roller2014-09-191-1/+1
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/b14e4a0..3c29c4d CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/586593003 Cr-Commit-Position: refs/heads/master@{#295667}
* [Telemetry] Specify units for tab switching time.tonyg2014-09-191-1/+1
| | | | | | | | BUG=415564 Review URL: https://codereview.chromium.org/586503002 Cr-Commit-Position: refs/heads/master@{#295666}
* Move extension_test_message_listener to extensions.lfg2014-09-1986-88/+88
| | | | | | | | | | This CL is part of the refactoring of webview into extensions/, and the webview test infrastructure depends heavily on this. Webview tests will be added to extensions soon. BUG=352290 Review URL: https://codereview.chromium.org/584513003 Cr-Commit-Position: refs/heads/master@{#295665}
* Migrate browsertest to use ServiceWorkerRegistration.unregister()ksakamoto2014-09-191-3/+7
| | | | | | | | | | | | ServiceWorkerContainer.unregister() is going away. This patch updates ServiceWorkerBrowserTest.ImportsBustMemcache to use ServiceWorkerRegistration.unregister() function. BUG=404064 Review URL: https://codereview.chromium.org/579183002 Cr-Commit-Position: refs/heads/master@{#295664}
* Remove unnecessary font list creation in AppListItemView.calamity2014-09-191-12/+17
| | | | | | | | | | | | | | | This CL improves the app list startup time on non-Linux platforms. A new FontList object was being unnecessarily created on every AppListItemView which forced recalculations of otherwise cached values. This was most noticeable on ChromeOS where the app list is rebuilt every time it is shown. BUG=415389 Review URL: https://codereview.chromium.org/574983002 Cr-Commit-Position: refs/heads/master@{#295663}
* Retire obsolete Valgrind supressions ..333992ericwilligers2014-09-191-123/+0
| | | | | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_293088 bug_298887 bug_299647 bug_310351 bug_312332 bug_327672 bug_329960 bug_331061 bug_333992 BUG=293088,298887,299647,310351,312332,327672,329960,331061,333992 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/583103003 Cr-Commit-Position: refs/heads/master@{#295662}
* [Chrome Shell]Added code to regain focus on selection of any item from ↵ankit2.kumar2014-09-191-0/+7
| | | | | | | | | | | | | | options menu. Currently if some option is selected from options menu then in that case content view does not gain focus in operations(like prev,next ). Added code to handle this. BUG=414219 Review URL: https://codereview.chromium.org/573653003 Cr-Commit-Position: refs/heads/master@{#295661}
* Retire obsolete Valgrind supressions ..269844ericwilligers2014-09-191-97/+0
| | | | | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_259188 bug_259303 bug_259789 bug_259799 bug_262875 bug_262934 bug_268258 bug_269201 bug_269844 BUG=259188,259303,259789,259799,262875,262934,268258,269201,269844 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/582983003 Cr-Commit-Position: refs/heads/master@{#295660}
* Remove void** from disk_cache interface.gavinp2014-09-1921-346/+353
| | | | | | | | | | | | Enumeration and iteration were passing around void**. With this CL, we instead use an Iterator object. R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org BUG=413644 Review URL: https://codereview.chromium.org/542733002 Cr-Commit-Position: refs/heads/master@{#295659}
* Retire obsolete Valgrind supressions ..253797ericwilligers2014-09-191-134/+0
| | | | | | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_246148 bug_246153 bug_247525a bug_247525b bug_247525c bug_250533 bug_250688 bug_252209 bug_252228 bug_253797 BUG=246148,246153,247525,250533,250688,252209,252228,253797 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/587453004 Cr-Commit-Position: refs/heads/master@{#295658}
* [Ash] Only snap windows that can maximize.jackhou2014-09-193-8/+24
| | | | | | | | | | | | | | | | Previously, windows that have only one of maxWidth or maxHeight defined could not be maximized by the user, but they would still snap when dragged to the edge of the screen. This changes WindowState::CanSnap to use CanMaximize which is false when there is a maxWidth or maxHeight, or when the window is not resizable. BUG=412610, 408737 Review URL: https://codereview.chromium.org/557693002 Cr-Commit-Position: refs/heads/master@{#295657}
* We now have the GLHelperReadBackSupport, this should tell ussiva.gunturi2014-09-192-0/+5
| | | | | | | | | | | if some format is supported or not.IsReadbackConfigSupported takes care of validating this. BUG=376769, 415131 Review URL: https://codereview.chromium.org/570003002 Cr-Commit-Position: refs/heads/master@{#295656}
* Bookmark context menu should appear over the bookmark folder menu.gajendra.n2014-09-191-4/+9
| | | | | | | | | | | | | | | | | | | If user right clicks immediately on entering a bookmark button, then open the folder without delay so that context menu appears over the folder menu. BUG=168758 R=asvitkine@chromium.org TEST= 1. Add a bookmark folder to Bookmarks Bar (folder1). 2. Add a subfolder (folder2) inside folder1. 3. Add few bookmarks to folder2. 4. Click on folder1 and immediately right click on folder2 and observe. 5. Context Menu should appear over the folder menu (folder contents window). Review URL: https://codereview.chromium.org/581053002 Cr-Commit-Position: refs/heads/master@{#295655}
* Retire obsolete Valgrind supressions ..243753ericwilligers2014-09-191-53/+0
| | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_233541 bug_238547 bug_241044 bug_243132 bug_243753 BUG=233541,238547,241044,243132,243753 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/587563002 Cr-Commit-Position: refs/heads/master@{#295654}
* Refactoring PasswordAutofillAgent::FillUserNameAndPassword for early return ↵deepak.m12014-09-191-5/+4
| | | | | | | | | | | | if password_element is not autocompleteable. PasswordAutofillAgent::FillUserNameAndPassword function refactor done for early return as we chould check this at start only. BUG=398436 Review URL: https://codereview.chromium.org/557703002 Cr-Commit-Position: refs/heads/master@{#295653}
* Make it clear that WeakPtrFactory is the last data memberanujk.sharma2014-09-191-2/+2
| | | | | | | | | | | Move declaration of AttachmentServiceProxyForTest's destructor to make it clear the WeakPtrFactory is the last data member. BUG=303818 Review URL: https://codereview.chromium.org/575383002 Cr-Commit-Position: refs/heads/master@{#295652}
* Removing onBookmarkChanged notification to application on history changekn.darshini2014-09-193-1/+7
| | | | | | | | | | and added proper history change notification on history data change. BUG=None Review URL: https://codereview.chromium.org/579753002 Cr-Commit-Position: refs/heads/master@{#295651}
* Retire obsolete Valgrind supressions ..225596ericwilligers2014-09-191-62/+0
| | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_180381 bug_184264 bug_222363 bug_222898 bug_224747 bug_225596 BUG=180381,184264,222363,222898,224747,225596 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/585783002 Cr-Commit-Position: refs/heads/master@{#295650}
* Retire obsolete Valgrind supressions ..176270ericwilligers2014-09-191-65/+0
| | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_170340 bug_172025 bug_173096 bug_175100 bug_175985 bug_176270 BUG=170340,172025,173096,175100,175985,176270 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/585773002 Cr-Commit-Position: refs/heads/master@{#295649}
* Retire obsolete Valgrind supressions ..166976bericwilligers2014-09-191-115/+0
| | | | | | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_162828 bug_164198 bug_166470 bug_166470c bug_166470d bug_166709 bug_166709b bug_166709c bug_166976a bug_166976b BUG=162828,164198,166470,166709,166976 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/585753002 Cr-Commit-Position: refs/heads/master@{#295648}
* Retire obsolete Valgrind supressions ..160877ericwilligers2014-09-191-114/+0
| | | | | | | | | | | | | | | | | | | | | The following supressions are no longer needed: bug_150995 bug_151006 bug_151007 bug_151908 bug_155404 bug_156829 bug_158514 bug_159005 bug_160877 BUG=150995,151006,151007,151908,155404,156829,158514,159005,160877 TBR=groby@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/586603002 Cr-Commit-Position: refs/heads/master@{#295647}
* Move ownership of the AppListViewDelegate into the AppListServicetapted2014-09-1928-100/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's currently hard for the AppListService to access the model. The model is now profile keyed. However, to get the "right" profile, the AppListViewDelegate is the current source of truth. And to get this, AppListService needs to dig into its platform-specific parts to get it via the platform-specific view. However, the AppListView can be destroyed, so the delegate doesn't always exist. Therefore the AppListViewDelegate doesn't always exist -- it is created each time the AppListView is created. On ChromeOS, this is each time the app list is shown. Before the model was profile-keyed, some state was tricky to store. E.g., some is stored in ExtensionAppModelBuilder, and updated via notifications (e.g. NOTIFICATION_APP_INSTALLED_TO_APPLIST). Also, since the model must now outlive the AppListView for sync, it makes less sense for the AppListViewDelegate to be owned by the view. Currently showing the app list can create a new ALVD, which must be re-attached to the model each time. This change moves ownership of the AppListViewDelegate into the AppListServiceIpml or test/shell controllers, which will create it lazily and then cache the result. BUG=403647, 404535 Review URL: https://codereview.chromium.org/508813002 Cr-Commit-Position: refs/heads/master@{#295646}
* Reland: Add GCMChannelStatusSyncer to schedule requests and enable/disable GCMjianli2014-09-1916-21/+607
| | | | | | | | | | | | BUG=384041 TEST=new tests added Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 Cr-Commit-Position: refs/heads/master@{#295524} Review URL: https://codereview.chromium.org/561943002 Cr-Commit-Position: refs/heads/master@{#295645}
* Fix target arch for x86 bots.navabi2014-09-191-2/+2
| | | | | | | | | | | | The target_arch should be ia32 for x86 builders. This is causing the x86 try and fyi bots to fail during runhooks because it doesnt match a case in common.gypi. BUG=359644 TBR=cmp@chromium.org Review URL: https://codereview.chromium.org/581173004 Cr-Commit-Position: refs/heads/master@{#295644}
* Add script to update Closure Compiler version and chrome_extensions.jsvitalyp2014-09-193-0/+7233
| | | | | | | | | | R=dbeam@chromium.org BUG=393873 TEST=./third_party/closure_compiler/bump_compiler_version Review URL: https://codereview.chromium.org/582193002 Cr-Commit-Position: refs/heads/master@{#295643}
* Remove the --event-page-idle-time and --event-page-suspending-time switches.yoz2014-09-1912-92/+75
| | | | | | | | They were used only in tests, so change those tests to set a global state instead. Review URL: https://codereview.chromium.org/547003002 Cr-Commit-Position: refs/heads/master@{#295642}
* Change the OOP PDF plugin to use BrowserPlugin mime type handling.raymes2014-09-196-50/+107
| | | | | | | | | | | This changes OOP PDF to use BrowserPlugin which allows it to be loaded without navigating to the extension page. BUG=303491 Review URL: https://codereview.chromium.org/582583002 Cr-Commit-Position: refs/heads/master@{#295641}
* Don't immediately timeout upon range request cache lock.dalecurtis2014-09-191-4/+8
| | | | | | | | | BUG=408765 TEST=back-to-back requests don't bypass the cache lock. Review URL: https://codereview.chromium.org/579393002 Cr-Commit-Position: refs/heads/master@{#295640}
* [Checkstyle] Enable left and right curly checks in Java.Aurimas Liutikas2014-09-191-2/+2
| | | | | | | | | BUG=318404,320774 R=newt@chromium.org Review URL: https://codereview.chromium.org/582303002 Cr-Commit-Position: refs/heads/master@{#295639}
* Modify the action of cancel button in syncing status to cancel all jobs.iseki2014-09-193-35/+34
| | | | | | | | | | | | | | | | * Previous behavior is to cancel only one item. * After Issue 400636, this behavior doesn't make sense because only the number is decreased. BUG=414610 TEST=manually 1. Copy the file from Download to Drive. 2. Push the button in syncing status. 3. Confirm all jobs are canceled. Review URL: https://codereview.chromium.org/576063002 Cr-Commit-Position: refs/heads/master@{#295638}
* Compile chrome://settings, part 7. 33 errors leftvitalyp2014-09-1917-64/+121
| | | | | | | | | | R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l Review URL: https://codereview.chromium.org/559423003 Cr-Commit-Position: refs/heads/master@{#295637}
* More fixes to make 32 bit Linux builds pass compile.John Abd-El-Malek2014-09-191-3/+3
| | | | | | | | | | | This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/587503002 Cr-Commit-Position: refs/heads/master@{#295636}
generated by cgit v1.1 at 2025-02-19 16:19:05 +0000