summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixed the memory leak of callback Task in PostPingMessage.rtenneti@chromium.org2011-02-241-12/+16
| | | | | | | | | | | | If PostTask to watched thread fails, we will stop monitoring that thread. BUG=73915,73844 TEST=performance testing Review URL: http://codereview.chromium.org/6575007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix runtime break on XP.pkasting@chromium.org2011-02-241-1/+8
| | | | | | | | | BUG=none TEST=none TBR=nsylvain Review URL: http://codereview.chromium.org/6575018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75836 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed pyauto tests broken on Mac by r75344 for autofill.py.dyu@chromium.org2011-02-242-47/+103
| | | | | | | | | | | Mac runs on python2.5 and the 'with statement' is not supported in version 2.5. Used alternative code so the test runs and passes on Mac running python2.5. BUG=none TEST=none Review URL: http://codereview.chromium.org/6546053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75834 0039d316-1c4b-4281-b951-d872f2087c98
* Remove browsing_instance.h stub file and update all the references.tfarina@chromium.org2011-02-249-26/+15
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6576006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75832 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WillGain/Lose/DidGainFocus, Focus methods. Now there are only two ↵ben@chromium.org2011-02-2456-493/+440
| | | | | | | | | | | | | | | | | | | | notifications: OnFocus() OnBlur() View gains a Focus()/Blur() processing method pair. Cleans up code in FocusManager::SetFocusedView. Also adds OVERRIDE to a bunch of methods. BUG=72040 TEST=existing unittests. Review URL: http://codereview.chromium.org/6577010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75830 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI Prefs: Fix favicon location of search engine manager in RTLstuartmorgan@chromium.org2011-02-241-2/+3
| | | | | | | | | BUG=70014 TEST=Search engine manager favicons should look right in RTL mode. Review URL: http://codereview.chromium.org/6538107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75829 0039d316-1c4b-4281-b951-d872f2087c98
* Following example of BrowserRenderProcessHost::OnMessageReceived, respond to ↵amarinichev@chromium.org2011-02-241-3/+11
| | | | | | | | | | | sync messages even if router failed to route. BUG=none TEST=remove a route in a debugger and see what happens Review URL: http://codereview.chromium.org/6574008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75828 0039d316-1c4b-4281-b951-d872f2087c98
* Update autofill watchlist pathsisherman@chromium.org2011-02-241-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6575017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75827 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill crasher ↵dhollowa@chromium.org2011-02-241-1/+2
| | | | | | | | | | | | | | | | | | Chrome:+Crash+Report+-+Stack+Signature:+WebCore::Node::renderBoxModelObject() Attempt at fix for new crasher specific to 11.0.680.0. The Autofill code on the renderer side has not changed in a couple weeks. Upon inspection of WebCore::Node::renderBoxModelObject() it would seem that the |this| pointer is NULL. This change adds an isNull() check on the node in question, but this doesn't address the source of the issue. Will follow-up with QE to bisect and isolate if possible. BUG=73895 TEST=observe crash reports on canary Review URL: http://codereview.chromium.org/6577009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75826 0039d316-1c4b-4281-b951-d872f2087c98
* Fix HTML issues in chrome://crashesstuartmorgan@chromium.org2011-02-244-21/+9
| | | | | | | | | | | Also adopts the new 'hidden' attribute. BUG=None TEST=None Review URL: http://codereview.chromium.org/6546061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75825 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of chrome\browser\renderer_host\test alongside their source. ↵jam@chromium.org2011-02-2455-195/+182
| | | | | | | | Most of them went to content\browser\renderer_host. Review URL: http://codereview.chromium.org/6575009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75824 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor of NetworkDelegate.willchan@chromium.org2011-02-2427-132/+212
| | | | | | | | | | | | | | * Renames HttpNetworkDelegate to NetworkDelegate, moves to net/base/network_delegate.h. NOTE: this is a layering violation. wtc/eroman/willchan have agreed to this exception because the other solutions are less palatable. * Move the virtuals in NetworkDelegate to the private section. Use non-virtual public interface as the network stack's interface for notifying the delegate. Add sanity checking to the implmentation in NetworkDelegate. The private virtual interface is for consumers to receive notifications. * Remove ExtensionIOEventRouter from ChromeURLRequestContext, it is only used by the ChromeNetworkDelegate. Pass it directly to the ChromeNetworkDelegate's constructor. * Introduce a SystemNetworkDelegate. It does nothing right now. BUG=67232 TEST=none Review URL: http://codereview.chromium.org/6580002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75822 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-02-2421-283/+168
| | | | | | | | | | | | | * Remove InfoBarTextButton and just use a normal views::TextButton. The custom things InfoBarTextButton wanted to do (like fixing some button sizing issues) are now part of the base TextButton. * Restore the "needs elevation" badge for the "set default browser" infobar, which was lost in http://src.chromium.org/viewvc/chrome?view=rev&revision=70913 . * Factor out common code for creating buttons, labels, and links into static methods on InfoBarView. * Remove the ability of LinkInfoBar to draw links right-aligned, which was unused. BUG=none TEST=none Review URL: http://codereview.chromium.org/6574011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75821 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Organize all the import UI files into the ↵tfarina@chromium.org2011-02-2410-28/+28
| | | | | | | | | | | chrome/browser/ui/gtk/importer/ directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6568008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75820 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the newly added net test URLRequestTest.NetworkDelegateProxyError ↵ananta@chromium.org2011-02-241-0/+2
| | | | | | | | | | | | | | for ChromeFrame as it uses the host (IE's) network stack. BUG=none TEST=chrome frame net tests. TBR=amit Review URL: http://codereview.chromium.org/6580015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75819 0039d316-1c4b-4281-b951-d872f2087c98
* Fix watchlist syntax errorisherman@chromium.org2011-02-231-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6578012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75818 0039d316-1c4b-4281-b951-d872f2087c98
* Add command-line flag for developing cross-platform panels.jennb@chromium.org2011-02-232-0/+4
| | | | | | | | | BUG=73936 TEST=none Review URL: http://codereview.chromium.org/6581009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75817 0039d316-1c4b-4281-b951-d872f2087c98
* Change gpu_blacklist.json filename to software_rendering_list.json.zmo@google.com2011-02-232-4/+4
| | | | | | | | | | BUG=73796 TEST=compile and start chrome and view about:gpu page fine TBR=vangelis@chromium.org Review URL: http://codereview.chromium.org/6581011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75816 0039d316-1c4b-4281-b951-d872f2087c98
* Implement cryptographicallyRandomValues to let WebKit have someabarth@chromium.org2011-02-232-2/+16
| | | | | | | | cryptographically strong random values inside the sandbox. Review URL: http://codereview.chromium.org/6581007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75815 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "virtual" from AddInfoBar() method.tfarina@chromium.org2011-02-231-1/+1
| | | | | | | | | BUG=None TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/6532080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75814 0039d316-1c4b-4281-b951-d872f2087c98
* CRX files now specified with absolute paths in PyAuto NTP Apps tests.nirnimesh@chromium.org2011-02-233-12/+17
| | | | | | | | | | | | | Documentation for a few associated functions has also been revised to explicitly state that app/theme/extension files must be specified with absolute paths. BUG=64271 TEST=None Review URL: http://codereview.chromium.org/6580012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75813 0039d316-1c4b-4281-b951-d872f2087c98
* Remove google chrome expectations that are now covered by thetony@chromium.org2011-02-231-2/+0
| | | | | | | | | | upstream test_expectations.txt file. TBR=kareng Review URL: http://codereview.chromium.org/6581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75812 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ViewTest.MouseEvent by NULL checking widget_ in WidgetGtk::SetCursor.ben@chromium.org2011-02-232-2/+3
| | | | | | | | | | BUG=none TEST=re-enables MouseEvent. TBR=sky Review URL: http://codereview.chromium.org/6575010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75811 0039d316-1c4b-4281-b951-d872f2087c98
* Fix multiple issues in the way O3D IPC server address name strings were ↵tschmelcher@chromium.org2011-02-232-10/+14
| | | | | | | | | | | | | | | generated: - They had a small chance of colliding. e.g., message queue 41 for process 4 and message queue 1 for process 44 would both attempt to acquire the name "o3d441", and whichever one came second would fail since it was already in use. The fix is to separate the PID and instance number with a hypen. This way the names in such a case become "o3d4-41" and "o3d41-4", which are distinct. - The PID in the name was truncated if it was greater than 65535 (possible in some edge cases on Windows and Linux). - Incrementing of the per-process id was not thread-safe. TEST=loaded o3d on Linux and verified IPC still works BUG=none Review URL: http://codereview.chromium.org/6578008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75810 0039d316-1c4b-4281-b951-d872f2087c98
* temporarily disable ViewTest.MouseEvent while I fix.ben@chromium.org2011-02-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75809 0039d316-1c4b-4281-b951-d872f2087c98
* Allow terminated extension to be uninstalled from chrome://extensions page.jennb@chromium.org2011-02-237-18/+91
| | | | | | | | | BUG=73210 TEST=Added CrashAndUninstall browser test. Review URL: http://codereview.chromium.org/6576003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75808 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of ExtensionEventRouterForwarderbattre@chromium.org2011-02-2311-4/+501
| | | | | | | | | | | Implementation of ExtensionEventRouterForwarder, a class that allows forwarding events from contexts without a profile (e.g. system URL request context) and from the IO thread to extensions. BUG=73903 TEST=unit_tests --gtest_filter='ExtensionEventRouterForwarderTest.*' Review URL: http://codereview.chromium.org/6538093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75807 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Increment the version numbers for PPB_{FileRef,FileSystem}_Dev.viettrungluu@chromium.org2011-02-232-3/+3
| | | | | | | | | | | | The PP_FileSystemType_Dev enum was changed in r75566, implicitly changing these interfaces (whose revision numbers weren't changed). BUG=none TEST=none Review URL: http://codereview.chromium.org/6579018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75806 0039d316-1c4b-4281-b951-d872f2087c98
* Added CHECKs to make sure histogram caller's don't creatertenneti@chromium.org2011-02-232-2/+8
| | | | | | | | | | | | histogram that are larger 1G. Added CHECK's to catch bucket_count_ is not corrupted before accessing ranges_ vector. BUG=73452 TEST=none. histogram unit tests are enough. Review URL: http://codereview.chromium.org/6542034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75804 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: make right-clicking on task manager body show menu againevan@chromium.org2011-02-231-1/+7
| | | | | | | | | | | | My change to make it show on mouse-down rather than up regressed this. While I'm here, make it so we show the first column full title as a tooltip. BUG=73081 Review URL: http://codereview.chromium.org/6580003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75802 0039d316-1c4b-4281-b951-d872f2087c98
* Don't always steal key events in WebUI listsstuartmorgan@chromium.org2011-02-231-1/+21
| | | | | | | | | | | Allows input elements to have normal keyboard behavior when in WebUI lists. BUG=72467 TEST=Key commands should work normally for inputs and selects in WebUI lists (e.g., tabbed options) Review URL: http://codereview.chromium.org/6532097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75801 0039d316-1c4b-4281-b951-d872f2087c98
* PPB_Flash cleanup part 1: move the net connector stuff to its own files.viettrungluu@chromium.org2011-02-2317-286/+335
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/6578007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75800 0039d316-1c4b-4281-b951-d872f2087c98
* Remove depricated arg |urgent| from SchedulePaintInRect calls.msw@chromium.org2011-02-232-3/+3
| | | | | | | | | BUG=73919 TEST=build Chrome with toolkit_views and touchui GYP_DEFINES. Review URL: http://codereview.chromium.org/6579010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75799 0039d316-1c4b-4281-b951-d872f2087c98
* Fix OOL issues for linux from the last few days.erg@google.com2011-02-2312-30/+69
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6575004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75798 0039d316-1c4b-4281-b951-d872f2087c98
* Use named automation interface to control the primary chrome to run ↵nirnimesh@chromium.org2011-02-239-17/+308
| | | | | | | | | | | | | | | | | | | | | | | | pyauto-based chrome tests on ChromeOS. This CL includes: - enable_testing.py -- sends dbus call to session_manager to enable testing interface - pyauto.py -- integration of named automation interface with PyAuto - desktopui_PyAutoFunctionalTests.py -- setup to use named automation interface. Uses a suid-root binary (as discussed with cmasone) to dbus mesg to session_manager - PYAUTO_TESTS -- a new suite called "PRIMARY_CHROME" which currently consists of a basic hello world test that controls the primary chrome - chromeos_basic.py -- a basic test All plumbing necessary to integrate the named automation interface with autotest and pyauto is included. It's designed such that it's easy to work directly on a chromeos device while adding/editing a pyauto test, without having to run via autotest every time. Also, the existing pyauto tests (about 200 of them) will begin controlling the primary chrome. Can be run with run_remote_tests.sh as: $ ./run_remote_tests.sh --remote <IP> desktopui_PyAutoFunctionalTests BUG= TEST= Review URL: http://codereview.chromium.org/6410134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75797 0039d316-1c4b-4281-b951-d872f2087c98
* Add some files to the C compilation test, and fix the stuff that wasn't C ↵dmichael@google.com2011-02-235-22/+27
| | | | | | | | | | | compatible. TEST=test_c_includes.c compiles successfully BUG=None Review URL: http://codereview.chromium.org/6542064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75796 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Blow away the plugin build directory before every run.thakis@chromium.org2011-02-231-0/+1
| | | | | | | | | | | | | | The mac trybot had and old copy of the plugin source in its build directory as a left-over from an old version of the update script. This caused clang's build system to build this old source instead of the current source. BUG=none TEST=none Review URL: http://codereview.chromium.org/6579011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75795 0039d316-1c4b-4281-b951-d872f2087c98
* Make MemoryMappedFile::IsValid consttommi@chromium.org2011-02-232-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/6574005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75794 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the flash plugin version for Windowsrohitbm@google.com2011-02-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6574004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75793 0039d316-1c4b-4281-b951-d872f2087c98
* Dup command-buffer SHM handle before auto-closing.piman@google.com2011-02-233-8/+19
| | | | | | | | | | | This also adds error logging to the various places we close file descriptors, to help diagnosing future similar issues. BUG=none TEST=Pepper Flash + youtube in oop with --enable-accelerated-plugins Review URL: http://codereview.chromium.org/6549037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75792 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the workaround for bug 43461. Use a g_use_system_sslwtc@chromium.org2011-02-236-72/+43
| | | | | | | | | | | | | | boolean flag in DefaultClientSocketFactory::CreateSSLClientSocket. Based on rch's code in http://codereview.chromium.org/6487012. R=rch BUG=43461 TEST=no ChromeFrame test program build failures. Review URL: http://codereview.chromium.org/6561003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75791 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: change install-build-deps.sh to install gold linker from binutils 2.21.thestig@chromium.org2011-02-231-7/+57
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6567002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75790 0039d316-1c4b-4281-b951-d872f2087c98
* More OOLing on Mac.erg@google.com2011-02-2324-87/+188
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6546073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75788 0039d316-1c4b-4281-b951-d872f2087c98
* Improved memory usage while applying patch.sra@chromium.org2011-02-236-16/+96
| | | | | | | | | | | | | | | | | | | | | | | Reduced total size of allocations from 520MB to 318MB. The general technique is to allocate the correct size rather than grow into the correct size and overshoot. 1. Find file sizes and allocate buffers of that size for the input files. 2. Pre-allocate a buffer for the collected inputs for the final diff. 3. Calculate the size for (2) during compression and include it in the patch header. The courgette.exe command line tool now calls the same ApplyEnsemblePatch entry point that is called by the installer. This ensures measurements of courgette.exe are a better reflection of the installer. BUG=72459 Review URL: http://codereview.chromium.org/6546008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75787 0039d316-1c4b-4281-b951-d872f2087c98
* More RootView cleanup:ben@chromium.org2011-02-2315-143/+88
| | | | | | | | | | | | | | - SetCursor->Widget API, remove platform ifdefs from root_view.cc for cursor updating - Remove weird native focus stuff, only used by ScrollView and seems not to have any effect on old options window. This is the sort of thing that should be handled by FocusManager anyway. - Remove DefaultKeyboardHandler concept in RootView. It does seem useful, but it's broken currently, and only ScrollView uses it (and hence only the old options window, which is not long for this earth). I would like to eventually replace this with a more generalized pre-processing/hierarchy processing/post-processing based event handling design. - Add OVERRIDE to RootView overrides. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6584001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75786 0039d316-1c4b-4281-b951-d872f2087c98
* net: remove comservicing.org from False Start blacklist.agl@chromium.org2011-02-231-1/+0
| | | | | | | | | (First one!) BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75785 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/6574006tburkard@chromium.org2011-02-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75784 0039d316-1c4b-4281-b951-d872f2087c98
* New automation hook to get information about apps on the new tab page.nirnimesh@chromium.org2011-02-233-12/+166
| | | | | | | | | | | | Several pyauto tests are included that exercise the new automation hook. Contributed by dennisjeffrey@chromium.org. BUG=64271 TEST=None Review URL: http://codereview.chromium.org/6532067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75783 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad merge at r75645.apatrick@chromium.org2011-02-233-364/+7
| | | | | | | | | TEST=try BUG=none Review URL: http://codereview.chromium.org/6580007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75782 0039d316-1c4b-4281-b951-d872f2087c98
* PrintPreview: Disable the print button until the preview is fully loaded.kmadhusu@chromium.org2011-02-232-1/+4
| | | | | | | | | BUG=none TEST=Enable print preview on mac. Print a webpage. In the preview tab, the print button is disabled until the preview is fully loaded. Review URL: http://codereview.chromium.org/6551013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75781 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 09:42:46 +0000