summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* A common pattern for Chrome is for dialogs to "own themselves"jrg@chromium.org2010-04-134-144/+1535
| | | | | | | | | | | | | | | | | | | | | (e.g. fire and forget). As implemented on the Mac, the termination chain (e.g. when OK is pressed) is to call [NSApp endSheet:]. didEndSheet then closes the window, and the controller (set as the delegate of the window) gets a windowWillClose: callback (so the controller knows to delete itself). The problem here was that the window was ordered out (offscreen) but not actually closed, so we didn't clean up properly. BUG=40429 TEST=no valgrind suppression needed and unit_tests stay happy. nib change: window controller (file's owner) is the delegate of the window (for both nibs) Review URL: http://codereview.chromium.org/1654003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44383 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Move reload in gtk mode and fix omnibox popup location.erg@chromium.org2010-04-136-126/+95
| | | | | | | | | | | | | - The reload button in GTK mode now is the normal stock gtk icon again. - The horizontal bounds of the omnibox popup are now the equal to the location bar box in GTK mode. BUG=41189 TEST=none Review URL: http://codereview.chromium.org/1604028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44380 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "Try again" button in the translate infobar not trigger a DCHECK .jeremy@chromium.org2010-04-132-3/+16
| | | | | | | | | | | Loosen up a DCHECK and add a unit test. BUG=41315 TEST=Repro steps in Bug. Review URL: http://codereview.chromium.org/1525030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix conditional in PasswordStoreMac initializationstuartmorgan@chromium.org2010-04-131-1/+1
| | | | | | | | | BUG=41332 TEST=Mac version should use keychain to read/store passwords. Review URL: http://codereview.chromium.org/1528035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44372 - Enable support for notifications layout tests in test shell.nsylvain@chromium.org2010-04-1311-158/+1
| | | | | | | | | | | | BUG=none TEST=notifications layout tests Review URL: http://codereview.chromium.org/1549039 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/1542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44377 0039d316-1c4b-4281-b951-d872f2087c98
* Update xpdual/moz/total_byte_* expectations.chase@chromium.org2010-04-131-2/+2
| | | | | | | | | | BUG=none TEST=xpdual moz step is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1613014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44376 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests to verify special tabs like chrome://history chrome://downloads, ...nirnimesh@chromium.org2010-04-132-1/+51
| | | | | | | | Most tests from krisr Review URL: http://codereview.chromium.org/1541009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44374 0039d316-1c4b-4281-b951-d872f2087c98
* Make it impossible to click OK if you've selected 0 datatypes.dantasse@chromium.org2010-04-134-9/+73
| | | | | | | | | BUG=40880 TEST=try to Customize Sync so you're syncing 0 datatypes. You shouldn't be able to. Review URL: http://codereview.chromium.org/1641001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44373 0039d316-1c4b-4281-b951-d872f2087c98
* Enable support for notifications layout tests in test shell.johnnyg@chromium.org2010-04-1311-1/+158
| | | | | | | | | BUG=none TEST=notifications layout tests Review URL: http://codereview.chromium.org/1549039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44372 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression leak.jcivelli@google.com2010-04-131-78/+0
| | | | | | | | | | | | The leaking code has been removed so the leak is gone. BUG=33427 TEST=Valgrind should be green. TBR=sky Review URL: http://codereview.chromium.org/1627020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44371 0039d316-1c4b-4281-b951-d872f2087c98
* Make views menu have a similar look and feel of native menu on ChromeOS:xiyuan@chromium.org2010-04-133-0/+42
| | | | | | | | | | | | | | - Mark menu host popup with GDK_WINDOW_TYPE_HINT_MENU so that window manager would add drop shadow and border to it; - Use the same gradient fill as menu's background; - Use the same selection color and text color; BUG=<http://crosbug.com/1885> TEST=Verify bookmark menu have a similar look and feel as other menus (e.g. wrench menu). Review URL: http://codereview.chromium.org/1547030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44370 0039d316-1c4b-4281-b951-d872f2087c98
* Preparation CL for executing READ and COOKIE network requests from the ↵stoyan@chromium.org2010-04-1312-262/+250
| | | | | | | | background thread. Review URL: http://codereview.chromium.org/1520033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix windows scaling bugfbarchard@chromium.org2010-04-131-4/+2
| | | | | | | | | BUG=41294 TEST=scale a video up on windows with filtering enabled. Review URL: http://codereview.chromium.org/1645004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44368 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the option to stop syncing if you're in Chrome OS. Also hide the ↵dantasse@chromium.org2010-04-137-7/+39
| | | | | | | | | | | "Customize" button in case of an error. BUG=none TEST=build and run Chrome for Linux. Start syncing. Then build for Chrome OS. Try to stop syncing. Note that you cannot. Review URL: http://codereview.chromium.org/1578020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44367 0039d316-1c4b-4281-b951-d872f2087c98
* Add more variations to Widget example.oshima@chromium.org2010-04-132-55/+180
| | | | | | | | | | | | | Transparent POPUP, CHILD and Transparent child example has been added. Transparent child is not working yet (it will crash) Changed ScrollView example so that scrollable view has view components BUG=none TEST=none Review URL: http://codereview.chromium.org/1521025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44365 0039d316-1c4b-4281-b951-d872f2087c98
* Return an error for command groups we don't support.tommi@chromium.org2010-04-131-1/+18
| | | | | | | | | | TEST=Should be no feature change but if anything this could clear up false positives where we report the status of a menu item as being enabled instead of not available. BUG=none Review URL: http://codereview.chromium.org/1589029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44364 0039d316-1c4b-4281-b951-d872f2087c98
* Added gl2ext.h for conformance tests to compile.alokp@chromium.org2010-04-131-0/+773
| | | | | | Review URL: http://codereview.chromium.org/1591030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44363 0039d316-1c4b-4281-b951-d872f2087c98
* On Mac, notifications needs the uninverted coordinate space, because we ↵johnnyg@chromium.org2010-04-133-2/+16
| | | | | | | | | | | invert already within the layout code. This change puts notifications in the correct place regardless of the height of the dock. BUG=40593 TEST=notifications on mac, with dock set to NOT auto-hide Review URL: http://codereview.chromium.org/1593017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44362 0039d316-1c4b-4281-b951-d872f2087c98
* Make autofill "make this default" buttons radio buttons to match function ↵avi@chromium.org2010-04-132-4/+4
| | | | | | | | | | | | | | and to match Windows. xib change: switch the default buttons to be radio buttons. BUG=none TEST=in autofill prefs, the "make this default" buttons should be radio buttons Review URL: http://codereview.chromium.org/1528033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44360 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash in bookmark manager crashes when closing file browser windowzelidrag@chromium.org2010-04-131-1/+1
| | | | | | | | BUG=39109 TEST=open bookmark manager, select Tools/Import/export, click on cancel, make sure it does not crash Review URL: http://codereview.chromium.org/1521024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44359 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for a variant of crbug.com/40429.rsesek@chromium.org2010-04-131-0/+26
| | | | | | | | | | TBR=jrg,aa BUG=40429 TEST=Mac Valgrind goes green Review URL: http://codereview.chromium.org/1633010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44358 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL as it causes chrome frame net tests to crash at exit. The ↵ananta@chromium.org2010-04-133-136/+23
| | | | | | | | | | | | | | | | | | | | | crash happens because the IPC channel proxy code relies on the listener threads message loop being around. This change destroys the message loop when it goes out of scope leading to the crash. Revert 44323 - Don't call Thread::CleanUp() before the MessageLoop destruction observers have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/1528034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44357 0039d316-1c4b-4281-b951-d872f2087c98
* Fix popups on secondary monitors.avi@chromium.org2010-04-131-2/+4
| | | | | | | | | BUG=http://crbug.com/40956 TEST=as in bug Review URL: http://codereview.chromium.org/1613012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44356 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44351 - Reland 44348 Add support for restricting broadcasting events ↵jochen@chromium.org2010-04-1335-227/+65
| | | | | | | | | | | | | | | to extensions based on host permissions BUG=38398 TEST=none TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1642005 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1521027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44355 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WebSocket tests because they broke with the last webkit mergensylvain@chromium.org2010-04-131-1/+2
| | | | | | | BUG:41319 Review URL: http://codereview.chromium.org/1508034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44354 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Update expectations with automatically generated file."chase@chromium.org2010-04-131-171/+52
| | | | | | | | | | | | This reverts r44299. BUG=none TEST=perf steps return to normal TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1625012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44353 0039d316-1c4b-4281-b951-d872f2087c98
* Share pasteboard population code between the BookmarkBarController and the ↵pinkerton@chromium.org2010-04-134-68/+61
| | | | | | | | | | BookmarkBarFolderController. Now all bookmarks can be dragged to the desktop, the tab strip, or other windows to load, even ones in folders. BUG=40834 TEST=see bug. Test bookmarks on the bookmark bar didn't regress. Review URL: http://codereview.chromium.org/1549037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44352 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 44348 Add support for restricting broadcasting events to extensions ↵jochen@chromium.org2010-04-1335-65/+227
| | | | | | | | | | | | based on host permissions BUG=38398 TEST=none TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1642005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44351 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57508 -> 57510.antonm@chromium.org2010-04-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1607016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44350 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44348 - Add support for restricting broadcasting events to extensions ↵jochen@chromium.org2010-04-1335-228/+66
| | | | | | | | | | | | | | based on host permissions. BUG=38398 TEST=none Review URL: http://codereview.chromium.org/1095002 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1575036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44349 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for restricting broadcasting events to extensions based on host ↵jochen@chromium.org2010-04-1335-66/+228
| | | | | | | | | | | permissions. BUG=38398 TEST=none Review URL: http://codereview.chromium.org/1095002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44348 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed alpha channel for Welcome to Chromium OS label color.avayvod@google.com2010-04-131-1/+1
| | | | | | | | | | | Updated it so it matches with what we have on the mocks. BUG=none TEST=Run with --login-manager --login-screen=oobe and check that Welcome to Chromium OS label is visible and has the right color. Review URL: http://codereview.chromium.org/1611025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44347 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a browser test to exercise ↵bulach@chromium.org2010-04-132-4/+48
| | | | | | | | | | | | | WebKit::WebGeolocationServiceBridgeImpl::stopUpdating(). (depends on the fix provided by http://trac.webkit.org/changeset/57335). BUG=40660,40478 TEST=GeolocationBrowserTest.InvalidUrlRequest Review URL: http://codereview.chromium.org/1626011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44346 0039d316-1c4b-4281-b951-d872f2087c98
* Rework NormalizeLanguageCode() so it returns codes compatible with Chrome's ↵satorux@chromium.org2010-04-133-30/+57
| | | | | | | | | | | | | | | application locale codes. The change is necessary to integrate UI language selection in the language settings dialog. In short, input languages and UI languaes (application locale codes are used for UI languages) need to be compatible. TEST=unit_tests BUG=2336 Review URL: http://codereview.chromium.org/1575034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44342 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a hack that prohibits users from removing English.satorux@chromium.org2010-04-132-23/+26
| | | | | | | | | | | | Along the way, refactor the code to use tags in ButtonPressed(), and remove members that are no longer necessary by the change. TEST=manually BUG=crosbug.com/2545 Review URL: http://codereview.chromium.org/1525028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44341 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 376.0 to 377.0chrome-release@google.com2010-04-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44339 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit CL#1629004 Support for client side buffersgman@chromium.org2010-04-1324-170/+2178
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44337 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57501:57508 + fixing the path to the script that starts adumi@chromium.org2010-04-133-7/+3
| | | | | | | | | | | | | | websocket server. Submitting this as a 2-sided patch to make it easier to roll it back if something breaks. BUG=none TEST=none TBR=antonm Review URL: http://codereview.chromium.org/1521026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44336 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting commit 44334gman@chromium.org2010-04-1324-2178/+170
| | | | | | | | | TEST=none BUG=none TBR=dumi@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44335 0039d316-1c4b-4281-b951-d872f2087c98
* Adds client side arraysgman@chromium.org2010-04-1324-170/+2178
| | | | | | | | | | | | | The code is conditional. I guess my gaming side spidey senses can't stand the overhead but I could be convinced to make it non-conditional. TEST=various unit tests BUG=none Review URL: http://codereview.chromium.org/1629004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44334 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable DevToolsSanityTest.TestProfilerTabmnaganov@chromium.org2010-04-131-0/+3
| | | | | | | | | | | BUG=41291 TEST=DevToolsSanityTest.TestProfilerTab TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/1578028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44333 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WorkerTest.WorkerSocketLayoutTests on all platforms.dumi@chromium.org2010-04-131-5/+2
| | | | | | | | | | | BUG=40995 TEST=none TBR=ukai Review URL: http://codereview.chromium.org/1542028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44332 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57286:57501.dumi@chromium.org2010-04-131-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1627018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44331 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44324 - WebKit roll 57286:57498.dumi@chromium.org2010-04-131-1/+1
| | | | | | | | | | | | | TEST=none BUG=none TBR=antonm Review URL: http://codereview.chromium.org/1618017 TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/1513032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44326 0039d316-1c4b-4281-b951-d872f2087c98
* Enable MMX for Chromefbarchard@chromium.org2010-04-131-1/+4
| | | | | | | | | BUG=41259,19113 TEST=build code that uses mmx intrinsics. Review URL: http://codereview.chromium.org/1604030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44325 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57286:57498.dumi@chromium.org2010-04-131-1/+1
| | | | | | | | | | TEST=none BUG=none TBR=antonm Review URL: http://codereview.chromium.org/1618017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44324 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call Thread::CleanUp() before the MessageLoop destruction observers ↵eroman@chromium.org2010-04-133-23/+136
| | | | | | | | | | | | | have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44323 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Remove one incorrect comment and one useless comment.jhawkins@chromium.org2010-04-131-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1653001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44319 0039d316-1c4b-4281-b951-d872f2087c98
* include emmintrin for chrome linux to use mmx _m64 types.fbarchard@chromium.org2010-04-132-12/+10
| | | | | | | | | BUG=19113 TEST=build official chrome on linux 32 bit. Review URL: http://codereview.chromium.org/1508031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44318 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring out a CancelRequestInternal() method whichtonyg@chromium.org2010-04-132-12/+29
| | | | | | | | | | | avoids unnecessarily performing a second map lookup in many cases. BUG=none TEST=none Review URL: http://codereview.chromium.org/1631012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44317 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 19:51:52 +0000