summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix layout test failures.darin@chromium.org2009-05-302-2/+3
| | | | | | | | | | | | | | | | | | | | 1- We need to be careful when converting from a null WebURL to a GURL since std::string(NULL, 0) crashes. 2- It turns out that in some layout tests, willSendRequest sets the request to null to indicate that we should not follow the redirect. In the few cases I debugged, this was happening because we were redirecting from "localhost" to "127.0.0.1". It seems like we probably need to change the hostname used to load HTTP based layout tests to match what the tests expect. For now, I just commented out the assertion since it was something that I had just newly added. BUG=none TEST=covered by layout tests TBR=dglazkov Review URL: http://codereview.chromium.org/115970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17291 0039d316-1c4b-4281-b951-d872f2087c98
* Start using WebURLLoader, et. al. from the WebKit API.darin@chromium.org2009-05-3033-1301/+2726
| | | | | | | | | | | | | | | | | | | | | | | | Moves our ResourceHandle to webkit/api/src/ResourceHandle.cpp from webkit/glue/resource_handle_impl.cc. A portion of resource_handle_impl.cc was moved into weburlloader_impl.{h,cc}, which now contains our implementation of WebURLLoader. The annoying parts of this CL involve WebPluginImpl. I had to convert it over to using WebURLLoader instead of ResourceHandle so that MultipartResourceDelegate can be shared. There is some complexity in WebURLRequest / WebURLResponse to make it cheap to wrap a ResourceRequest / ResourceResponse. I think this is worth it since there is a lot of conversion between the two types. BUG=10038 TEST=covered by existing tests R=dglazkov Review URL: http://codereview.chromium.org/113928 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17290 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 17288 - Test failures.mhm@chromium.org2009-05-304-494/+387
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/115968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17289 0039d316-1c4b-4281-b951-d872f2087c98
* Create a "User data" tab and remove the "minor tweaks" tab. The mockup is ↵mhm@chromium.org2009-05-304-387/+494
| | | | | | | | | | | | | included in the issue. Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. BUG=11435 (http://crbug.com/11435) TEST=Opened the option dialog and checked if functional. Review URL: http://codereview.chromium.org/113896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17288 0039d316-1c4b-4281-b951-d872f2087c98
* Fix msvs_guid for gmock and re-add gmock_unittest into base_unittest.ajwong@chromium.org2009-05-301-1/+1
| | | | | | | | | | | | The issue is that if there are lower case characters in the msvs_guid, incredibuild will silently ignore the target during a _command-line_ build. This issue does not affect builds in visual studio (incredibuild-based, or regular), but it does break the build bots. Review URL: http://codereview.chromium.org/118013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by fixing defines not to include windows.ben@chromium.org2009-05-302-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17286 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-305-0/+16
| | | | | | | | | | | TBR=sky BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17271 Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17285 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux compilation for printmhm@chromium.org2009-05-301-0/+2
| | | | | | Review URL: http://codereview.chromium.org/115966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17284 0039d316-1c4b-4281-b951-d872f2087c98
* Add --print command line argument to print a webpagemhm@chromium.org2009-05-303-0/+11
| | | | | | | | | | | | Added a new chrome switch called "print" and after the urls are being loaded, I call the last active browser and print the selected tab. BUG=6942 (http://crbug.com/6942) TEST=Added command line arguments [chrome.exe --print http://google.ca and the print dialog appeared for the selected tab component. based on: http://codereview.chromium.org/100027 Review URL: http://codereview.chromium.org/118048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17283 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce a max length for document titles.abarth@chromium.org2009-05-304-2/+19
| | | | | | | | | | R=deanm BUG=http://crbug.com/12810 TEST=None Review URL: http://codereview.chromium.org/113969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17282 0039d316-1c4b-4281-b951-d872f2087c98
* svn:ignore chrome/debugger.scons and testing/gmockmain.scons.thestig@chromium.org2009-05-300-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix project file for reverting 17273mhm@chromium.org2009-05-301-2/+1
| | | | | | Review URL: http://codereview.chromium.org/115965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17280 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17273 - Fails reliability testsmhm@chromium.org2009-05-3011-196/+158
| | | | | | Review URL: http://codereview.chromium.org/118047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17279 0039d316-1c4b-4281-b951-d872f2087c98
* linux: save window positions.evan@chromium.org2009-05-303-10/+36
| | | | | | | | | | | | | I followed the Windows code rather than the Mac code, and saved whenever the window is moved. Note that we only restore window *size*, not position. We looked at every software we could find and none restored position. BUG=12374 Review URL: http://codereview.chromium.org/115932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17277 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity underground warfare: Uninitalized membercpu@google.com2009-05-301-1/+5
| | | | | | | | | | | | - Fix ctor to init members - CID 4186 BUG = none TEST = well, it is a unit test Review URL: http://codereview.chromium.org/112076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17276 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity underground warfare: Uninitalized membercpu@google.com2009-05-301-1/+3
| | | | | | | | | | | | - Fix ctor to init members - CID 4187 BUG = none TEST = none Review URL: http://codereview.chromium.org/118035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17275 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17271.ben@chromium.org2009-05-305-16/+0
| | | | | | Review URL: http://codereview.chromium.org/118040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17274 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land the password store work from bug 8205, with changes that should fix ↵stuartmorgan@chromium.org2009-05-3021-156/+1411
| | | | | | | | | | bug 12479. The Linux pieces are still disabled, however. BUG=8205 TEST=Password autofill should continue to work on Windows. Review URL: http://codereview.chromium.org/114057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17273 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks found by Coverity Prevent.sra@chromium.org2009-05-302-8/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115947 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17272 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-305-0/+16
| | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17271 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Changes to stop tests breaking.sidchat@google.com2009-05-302-5/+0
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/112077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17270 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=12192rafaelw@chromium.org2009-05-3015-361/+15
| | | | | | | | R=aa Review URL: http://codereview.chromium.org/115681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17269 0039d316-1c4b-4281-b951-d872f2087c98
* Possible fix for UnitTestFailuresidchat@google.com2009-05-301-1/+1
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/115962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17268 0039d316-1c4b-4281-b951-d872f2087c98
* Fix msvs_guid for gmock and re-add gmock_unittest into base_unittest.ajwong@chromium.org2009-05-301-1/+1
| | | | | | | | | | | | The issue is that if there are lower case characters in the msvs_guid, incredibuild will silently ignore the target during a _command-line_ build. This issue does not affect builds in visual studio (incredibuild-based, or regular), but it does break the build bots. Review URL: http://codereview.chromium.org/118013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17267 0039d316-1c4b-4281-b951-d872f2087c98
* Split browser/debugger/* into a separate 'debugger' library target.sgk@google.com2009-05-301-40/+107
| | | | | | | | | | Add the 'automation' library target. Add rlz.gyp and gmock.gyp to the pull_in_all target. BUG=none TEST=none Review URL: http://codereview.chromium.org/115950 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17266 0039d316-1c4b-4281-b951-d872f2087c98
* Delete empty folders in system level install. Also cleanup uninstall error ↵kuchhal@chromium.org2009-05-291-13/+27
| | | | | | | | | | | | messages a little bit. BUG=11553 TEST=Uninstall system level chrome and select "delete profile data", %LOCALAPPDATA%\Chromium folder should get deleted. Review URL: http://codereview.chromium.org/115945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17265 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bad event signal name that was leading to crash.sky@chromium.org2009-05-291-3/+2
| | | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/118037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17264 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6223 - Drag and drop a new tab from RTL Chrome: the ↵xji@chromium.org2009-05-291-1/+4
| | | | | | | | | | | | | | docked window usually showing out of current screen The problem is that the dragged tab view is not rendered correctly in RTL locale. The view should be rendered in a position that the mouse is on tabstrip, which is consistent with the position in which the view will be docked when mouse release. The root cause is the dragged tab view's width is calculated incorrectly in RTL locale. BUG=http://crbug.com/6223 TEST=Open Chrome in Hebrew, drag and drop a tab, observe the tab view while dragging, the view should be rendered in a position that the mouse is on tabstrip. Review URL: http://codereview.chromium.org/115938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17263 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the status bar size to adapt to the size of the font,mirandac@chromium.org2009-05-293-32/+45
| | | | | | | | | | | | | instead of being a const. BUG= http://crbug.com/1275 TEST=Set Windows XP font size to large or extra-large. Open Chrome. Hover over a link to bring up the status bubble. Text should sit comfortably in bubble, without being squeezed. Review URL: http://codereview.chromium.org/113490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17262 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes couple of bugs that occur now that we can actually run views onsky@chromium.org2009-05-293-3/+15
| | | | | | | | | | | gtk again. BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17261 0039d316-1c4b-4281-b951-d872f2087c98
* The ShelfItemDialog has an accelerator for Enter.jcampan@chromium.org2009-05-292-2/+9
| | | | | | | | | | | | Since it also had a default button (that would also register an accelerator for Enter), there would be an assertion failure when unregistering the first accelerator. Also removed the Esc accelerator (it is already handled by the dialog by default). BUG=12922 TEST=Repro the scenario described in bug. Review URL: http://codereview.chromium.org/115956 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17260 0039d316-1c4b-4281-b951-d872f2087c98
* Do not autocorrect words in capital letters, or having capital letters in ↵sidchat@google.com2009-05-292-0/+5
| | | | | | | | | | between, as they may refer to acronyms or terms not in the dictionary. BUG = www.crbug.com/12921 TEST = Type CLD (a library), should not change back to LCD Review URL: http://codereview.chromium.org/118008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17259 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-294-8/+14
| | | | | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. TBR=finnur Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some review comments I missed in the previous checkin of this file.brettw@chromium.org2009-05-291-4/+11
| | | | | | | Previous review: http://codereview.chromium.org/113909/diff/16/17 Patch my Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17256 0039d316-1c4b-4281-b951-d872f2087c98
* More views on gtk work: NativeViewPhotoboothGtk, adds a missing methodsky@chromium.org2009-05-295-0/+85
| | | | | | | | | | | to NativeViewHostGtk and location bar view colors. BUG=none TEST=none Review URL: http://codereview.chromium.org/115958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17255 0039d316-1c4b-4281-b951-d872f2087c98
* When copying urls in the render view context menu, copy them to PRIMARY as ↵estade@chromium.org2009-05-294-12/+27
| | | | | | | | | | well as CLIPBOARD. BUG=12716 Review URL: http://codereview.chromium.org/115949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17254 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.6.1 to fix build on certain GCC versions.ager@chromium.org2009-05-291-1/+1
| | | | | | | | | The only change is the addition of a couple of parenthesis. TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/118018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17252 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in gyp improvements.bradnelson@chromium.org2009-05-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17251 0039d316-1c4b-4281-b951-d872f2087c98
* Make DialogClientView compile on Linux.ben@chromium.org2009-05-294-9/+51
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17250 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot the CSS file.rspangler@google.com2009-05-291-0/+124
| | | | | | Review URL: http://codereview.chromium.org/118034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17249 0039d316-1c4b-4281-b951-d872f2087c98
* Add webkit crash after merge to r44252 to known crash list.tc@google.com2009-05-291-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/115952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17247 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-2911-14/+120
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Revision 17224glen@chromium.org2009-05-294-13/+7
| | | | | | | | | BUG=none TEST=non Review URL: http://codereview.chromium.org/115951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17245 0039d316-1c4b-4281-b951-d872f2087c98
* Updating version number for fetching from O3D Code repository in DEPS file.gspencer@google.com2009-05-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17244 0039d316-1c4b-4281-b951-d872f2087c98
* Final merge from O3D Perforce tree.gspencer@google.com2009-05-298-64/+660
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17243 0039d316-1c4b-4281-b951-d872f2087c98
* Better seeking for <video> and <audio>hclam@chromium.org2009-05-2911-71/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There two problems surrouding the seek feature for <video> and <audio>: 1. After each seek, the time goes back and forth until stable, so user has to "fight" the time bar for seeking. 2. When playing an audio file, sounds plays a litte bit and then the play position rewinded and plays again. The cause of above problems: 1. There are demuxed packets and decoded buffers inside decoders and renderers. When seek is requested only demuxer flush its buffers, decoders and renderers still plays a little bit of the old buffer, thus updating the time incorrectly. 2. When playing a media file, WebKit does: 1. load() 2. pause() 3. seek(0.0f) 4. play() Since load() does prerolling internally, there were some decoded buffers in the renderers, and when seek(0.0f) is fired the play position reset to time 0 and decode starts from there again, the internal buffer queue in the renderer would then look like: | 0.0s | | 0.1s | | 0.2s | | 0.0s | | 0.1s | ... Thus playback at the beginning goes back and forth. To solve the seek problems, here's what is done in this CL: 1. All decoders and renderers should receive the seek signal. 2. When seek signal is received, discard all buffers and schedule read again. With this CL, we can now scrub an <audio> tag with the timebar. The downside of this fix is that we don't have prerolling (notice that due to how WebKit starts playing back we didn't preroll anyway...), this should be fixed in another CL. Review URL: http://codereview.chromium.org/113891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-299-26/+51
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to be installed without any commandline flag, still require ↵glen@chromium.org2009-05-296-103/+211
| | | | | | | | | | | flag for Extensions. Expand themes unittests. BUG=12205,12231 TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure. Review URL: http://codereview.chromium.org/115798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17240 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17223 (http://codereview.chromium.org/115943). Seems to make ↵robertshield@google.com2009-05-291-4/+3
| | | | | | | | | | interactive UI tests unhappy. TBR=tommi Review URL: http://codereview.chromium.org/118029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17239 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up temporary files/folders in firefox importer tests.munjal@chromium.org2009-05-295-0/+51
| | | | | | Review URL: http://codereview.chromium.org/115930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17238 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 10:08:59 +0000