| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some errors appear to be bogus, but other may be real.
BUG=15276 (http://crbug.com/15276 )
TBR=erikkay,sidchat
TEST=XP unit (purify) does not fail due to CLD.
Review URL: http://codereview.chromium.org/147136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=15627 (http://crbug.com/15627)
TEST=Linux webkit (debug) does not report cancel-transition as a failure
Review URL: http://codereview.chromium.org/147134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
--isolated-world command line argument to let us iterate on this feature.R=aaBUG=12218TEST=None :( (I have a testing plan we can put in place once the upstream half of this CL lands.)
Review URL: http://codereview.chromium.org/118188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use hbox to pack location entry, security icons and EV cert info text.
Change ToolbarModel::GetInfoText not return SkColor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This facilitates easy QA for browser crash reporting.
Review URL: http://codereview.chromium.org/147126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- check connection state in mock read and write
- make possible simulating short reads in DynamicMockSocket
TEST=none
http://crbug.com/15259
Review URL: http://codereview.chromium.org/147117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and display LTR for RTL locales.
r19162 | jhawkins@chromium.org | 2009-06-24 13:15:04 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk toolbar layout.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
r19179 | jhawkins@chromium.org | 2009-06-24 14:38:25 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk bookmark bar.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
See http://i139.photobucket.com/albums/q315/failfast/revertrtl.png
Review URL: http://codereview.chromium.org/147130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=go incognito, toggle custom frame drawing
Review URL: http://codereview.chromium.org/146122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/147133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/147131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add linux-gate.so to the minidump mappings list by checking for the
load address in the aux vector and adding a filename of linux-gate.so
when we encounter that load address. This is necessary for crash
reporting to walk the stack correctly when a crash happens while in a
system call.
http://codereview.chromium.org/147032
Committed for Neal Sidhwaney.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=webkit test runs
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark two existing failure cases as flaky on Windows
BUG=13907,15267,15266
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/146128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Message loops are provided via MediaFilter::SetMessageLoop(). For now FFmpegDemuxer is the only filter taking advantage of injected message loops, and its unit tests have been updated as well.
TEST=FFmpegDemuxer tests should continue to run
BUG=none
Review URL: http://codereview.chromium.org/145014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stuff going on here, I can't begin to unravel it on more than one platform at a time.
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view-source mode not to show error page in view-source mode. However, on
cancellation, it's not necessary and sometimes render non-error page with
view-source: prefix in non view-source mode by mistake.
In fixing this, I pushed down SetInViewSourceMode to RenderView from
WebFrameImpl. We can control view-source state more precisely by this way.
Patch by tyoshino@google.com
Original review: http://codereview.chromium.org/122026
BUG=4516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that they can be built from scratch and complete.
Review URL: http://codereview.chromium.org/132056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Correct row index calculation in bookmark manager drag receive.
- Support multiple target dnd
also see http://crbug.com/15240
BUG=none
TEST=multi dragging in bookmark manager/bookmark bar. See cited bug for explanation of how to multi-drag.
Review URL: http://codereview.chromium.org/147107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is enabled by the --new-ftp command-line switch. On Mac and
Linux this is always enabled.
Fix some cpplint nits.
Remove the obsolete "net/http/http_network_layer.h" inclusion.
R=darin
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/147061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mark LayoutTests/tables/mozilla/bugs/45621.html as 'FAIL PASS CRASH' on Linux
Mark LayoutTests/fast/body-propagation/overflow/004.html as 'FAIL PASS' on all platforms
Mark LayoutTests/http/tests/cache/subresource-expiration.html as 'CRASH PASS' whether it's an opt or a debug build.
BUG=9798,9797,14752
TBR=dglazkov
TEST=Above 3 tests do now show up as failures on Linux webkit bots
Review URL: http://codereview.chromium.org/147120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If FontChromiumWin's Font::drawGlyphs() fails for some reason, we
may attempt to reload the font using ChromiumBridge::ensureFontLoaded().
This requires a sandbox routine, SandboxSupport::ensureFontLoaded() to be
implemented, and in test_shell, it wasn't, causing a null ptr deref and
weird things to happen.
Note that there is no easy way to provoke this codepath once the other
bugs causing the crash in #10977 are fixed.
R=darin
BUG=http://crbug.org/10977
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden.
Also, update the height of the lower section so that content does not
get clipped.
BUG=15234, 15106
TEST=Hide the thumbnails on the new new tab page. There should be no
way that clicking on some empty space would activate a hidden
.thumbnail For the second part of this bug close 5+ tabs and check that
the Recently closed section does not get clipped.
Review URL: http://codereview.chromium.org/146120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessed after the views have been removed.
This was causing a crasher in the browser tests (as a deleted object was accessed).
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/147110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(case-sensitive file system).
BUG=8647
TEST=Pass ui test on Linux
TBR=tony
Review URL: http://codereview.chromium.org/146117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit link.
BUG=14958, 15073
TEST=On the new new tab page. No "edit" link should show up after a
long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails,
show/hide list should all show tooltips.
Review URL: http://codereview.chromium.org/146108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Already filed with Apple.
BUG=none
TEST=fewer leaks reported from the UI tests under valgrind on Mac
Review URL: http://codereview.chromium.org/146115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368).
I've confirmed that no patch other than mine is submitted to the old file:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log
BUG=12290
TEST=See http://codereview.chromium.org/125111
Review URL: http://codereview.chromium.org/147074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15226
TEST=see bug
Review URL: http://codereview.chromium.org/147112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/132036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not required, yet were creating compile errors when building unit_tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added timer to clean unpopular thumbnails from the cache/disk every hour.
Still need to implement removal of blacklisted urls.
Review URL: http://codereview.chromium.org/126237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
hadn't expired (5 seconds), even if there was no backing store. We now use the
stashed one no matter what if there is no backing store to create a new one.
Review URL: http://codereview.chromium.org/147087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
figure these perf regressions out.
TEST=graphs
BUG=15232
Review URL: http://codereview.chromium.org/147113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The rebaselining tool seemed to miss them yesterday. The Mac layout
test result archives are missing all images, so no result for Mac.
BUG=15125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we ask fontconfig for an italic font, it might take a roman font
and set the undocumented property FC_MATRIX to a skew matrix. It'll
then say that the font is italic or oblique. So, if we see a matrix,
we don't believe that it's italic.
BUG=15212
http://codereview.chromium.org/147108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly.
2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring.
This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places).
Note : this CL will be landed after http://codereview.chromium.org/147038 is landed.
BUG=8647 (http://crbug.com/8647)
TEST=Pass l10n_util_unittest and other unit tests
Review URL: http://codereview.chromium.org/126223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
definitions file for installation.)
Review URL: http://codereview.chromium.org/146109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add a unittest that pretends to be the UtilityProcessHost and launches a chrome utility process for unpacking a theme.
Review URL: http://codereview.chromium.org/147001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For users with AFS home directories, we cannot create UNIX domain
sockets for ProcessSingleton. Before this patch we would spin because
the socket would be constantly 'readable' for accept.
http://codereview.chromium.org/139008
BUG=14237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It tried to send a QUIT command when sending QUIT command failed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19177 0039d316-1c4b-4281-b951-d872f2087c98
|