| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, it's a Singleton that gets passed a pointer to a Profile
during Init(), and holds onto that pointer even after the Profile gets
destroyed. With this change, it's owned by ExtensionService and is destroyed
when the profile is being destructed.
BUG=67927
TEST=On linux, run 'browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager --gtest_repeat=100 --gtest_break_on_failure'. Before this CL, you'll occasionally get a failure because of the race condition described above.
Review URL: http://codereview.chromium.org/6125003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the IE history
while processing a navigation update received for a tab loading state change. This is incorrectly
treated as an internal navigation which messes up the history.
Fix is to not treat the tab loading state change notification as an internal navigation.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=69096
BUG=69096
TEST=None at this point.
Review URL: http://codereview.chromium.org/6284002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6269001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/6338002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
(I tested locally for Mac OS X, but we'll need further testing for Windows and Linux as we add real-time threads, etc.)
Review URL: http://codereview.chromium.org/6002005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
frame or an embed element.
BUG=50285
Review URL: http://codereview.chromium.org/6142013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Some missing args in FillAutofillProfile() automation call are expected. Do not check for them.
Review URL: http://codereview.chromium.org/6247007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
know about the details of every feature. Observers get to filter and send IPC messages, and basic notifications of frame related events.I've moved over AutoFill related classes, and also made AutoFillManager implement the new WebAutoFillClient interface. For the rest of the classes, they implement the interface just for message filtering.
Review URL: http://codereview.chromium.org/6151011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fails on some platforms.
BUG=69724
TEST=WidgetWinTest.SetBoundsForZoomedWindow
Review URL: http://codereview.chromium.org/6259004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with former semantics.
Also force a flush when the buffer is getting full.
BUG=none
TEST=gpu_unittests, some webgl content, some 3d css content, pepper flash
Review URL: http://codereview.chromium.org/6316002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Manual
Review URL: http://codereview.chromium.org/6310002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68682
TEST=trybots
Review URL: http://codereview.chromium.org/6354002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
selection for instant queries. At some point I'll wire through the
actual cursor position, but this is better than what we had.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6363001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use GL rather than EGL by default on linux.
Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue.
Also, it looks like EGL, even if available, has some issues.
If GLX isn't available, it still falls back to EGL.
--use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed.
Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected.
TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct.
BUG=none
Review URL: http://codereview.chromium.org/6325005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle this in ChromeInvalidationClient so that we don't have to handle
it everywhere else.
We were handling it incorrectly anyway, but it wasn't a problem since
we always get all updates for all data types.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/6358001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
malware details to Google.
BUG=60831
TEST=relevant unit_tests,browser_tests, go to ianfette.org.
Review URL: http://codereview.chromium.org/6268001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. testBlockAllPlugins
2. testAllowPluginException
3. testBlockPluginException
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6015010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
TEST=check perms test
BUG=None
Review URL: http://codereview.chromium.org/6341002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ClientSideDetectionServiceTest
Review URL: http://codereview.chromium.org/6277002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile and trybots
Review URL: http://codereview.chromium.org/6339002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically undo http://codereview.chromium.org/5306002
because with the newer sandbox policy the IME editors
should not be crashing anymore.
Note that this does not fix the IME problem with sandboxed flash
BUG=63352
TEST=see bug for details
Review URL: http://codereview.chromium.org/6279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6291003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'maximized' state.
Now when SetBounds is called, we detect the maximized state and take the window
out of this state.
BUG=69618
TEST=WidgetWinTest.SetBoundsForZoomedWindow (added)
Review URL: http://codereview.chromium.org/6268002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
<div>s) -- this makes the underlying page clickable where previously it may
not have been.
BUG=63695
TEST=see bug
Review URL: http://codereview.chromium.org/6114004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now these two classes are not templates, and just handle raw data.
New ProtobufMessageReader is used to parse messages.
BUG=None
TEST=Unittests.
Review URL: http://codereview.chromium.org/6277003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use WebFrame::createAssociatedURLLoader.
See https://bugs.webkit.org/show_bug.cgi?id=49764 for the
WebKit side of this change.
R=michaeln
BUG=none
TEST=none
Originally reviewed at: http://codereview.chromium.org/5139005
Review URL: http://codereview.chromium.org/5920003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The fix is to keep track of the original URL.
BUG=69468
TEST=Manual test to verify.
Review URL: http://codereview.chromium.org/6131009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6281003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben
Review URL: http://codereview.chromium.org/6327005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids problems where multiple invocations of grit try to write to
the same intermediate file.
BUG=69633
TEST=Manually
Review URL: http://codereview.chromium.org/6245002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. testInstantDisabledInIncognito - instant should be disabled in incognito mode
2. testInstantOverlayNotStoredInHistory - instant overlay page not stored in history
3. testInstantDisabledForJavaScript - instant disabled for javascript urls
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6325003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move HiResTimerManager to src/chrome/common.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6361002
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. testSharingProcess
2. testKillSharedProcess
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5322012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move HiResTimerManager to src/chrome/common.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6320004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=senorblanco
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6290005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux, also set the timeouts.
BUG=27400
TEST=Start wireshark and capture packets. Start chrome. Open www.facebook.com. Let it sit idle for awhile. Wait for TCP keep alive packets to be sent out after 45 seconds on Linux.
Review URL: http://codereview.chromium.org/6162005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetAdditionalErrorState() was being called, which stores the error state into the ClientSocketHandle. When we preconnect, we never have a ClientSocketHandle, so don't bother tryiing to store the error state nor get the error socket.
BUG=69214
TEST=net_unittests
Review URL: http://codereview.chromium.org/6293005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=senorblanco
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 71470 - Revert 71313 - Removed old login screen from source.
Deleted kEnableLoginImages flag.
BUG=chromium-os:7214
TEST=Old login screen should not show up even under automation tests for login.
Review URL: http://codereview.chromium.org/5809001
TBR=avayvod@chromium.org,tbroch@chromium.org
TBR=avayvod@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures. Basically
a dumb error caused by having a local variable with the same name as that of the parameter
to a function.
BUG=none
TEST=ChromeFrame InstallFlowTest.
TBR=amit
Review URL: http://codereview.chromium.org/6303005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69294
TEST=sequetially open two incognito windows and visit pages using indexed db.
Review URL: http://codereview.chromium.org/6275001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use Cairo double-buffering (prevents flickering when there is translucency).
- Add an API to allow JS to indicate the stacking order of layers. (Previously it was the arbitrary order of their creation!)
- Delete layer objects that have been discarded by the JS via Pack::RemoveObject().
TEST=loaded O2D and verified no significant change in perf as a result of double-buffering (~70% of a core before and ~72% of a core after)
BUG=none
Review URL: http://codereview.chromium.org/6320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue.
Also, it looks like EGL, even if available, has some issues.
If GLX isn't available, it still falls back to EGL.
--use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed.
Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected.
TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct.
BUG=none
Review URL: http://codereview.chromium.org/6342001
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/6314005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list for better testability.
Write preliminary test framework for testing these functions.
BUG=61609
TEST=setup_unittests.exe
Review URL: http://codereview.chromium.org/6153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue.
Also, it looks like EGL, even if available, has some issues.
If GLX isn't available, it still falls back to EGL.
--use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed.
Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected.
TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct.
BUG=none
Review URL: http://codereview.chromium.org/6342001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--single-process.
It isn't possible to have two UI threads with glib because it is not thread safe.
TEST=try
BUG=69674
Review URL: http://codereview.chromium.org/6296006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deleted kEnableLoginImages flag.
BUG=chromium-os:7214
TEST=Old login screen should not show up even under automation tests for login.
Review URL: http://codereview.chromium.org/5809001
TBR=avayvod@chromium.org,tbroch@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71470 0039d316-1c4b-4281-b951-d872f2087c98
|