| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When no ssl icon/ev text shown
show 4px|location_entry|4px only
When ssl icon/no ev text
show 4px|location_entry|4px + 2px|ssl_icon|8px
When ssl icon and ev text shown
show 4px|location_entry|4px + 2px|ssl_icon|8px + |ev_text|4px
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13674
Review URL: http://codereview.chromium.org/132069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains a message reporting bugfix, improved debugger
support and general optimizations.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is caused by my bonehead mistake that I forgot filtering out U_STRING_NOT_TERMINATED_WARNING while checking the return value in SpellCheckWordIterator::Normalize() in my change r10087.
I have added code that checks if the result value is U_STRING_NOT_TERMINATED_WARNING and added a couple of test cases which verify this issue.
BUG=13432 "Any word of 13 or 14 characters is not spellcheck"
TEST=run unit_test.exe.
Review URL: http://codereview.chromium.org/146074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
renderer_host.
Review URL: http://codereview.chromium.org/150011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/150012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
for integrating the native client build.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There still seem to be some issues. (Odd it worked locally...)
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/151005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WillDestroyWindow is already plumbed over to the browser process in the
multiproc case; we want to plumb it to our RenderView delegate so we
can do similar cleanup in test_shell.
BUG=15423
Review URL: http://codereview.chromium.org/147251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactoring of void BuildHandshakeWriteBuffer() to const std::string BuildHandshakeWriteBuffer() const,and removing private members handshake_buf_len_ and buffer_len_ (since buffer_ is now std::string, buffer_.size()) is more than sufficient for buffer size.
TEST=unittests
BUG=469
Review URL: http://codereview.chromium.org/139009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the tree.... :-(
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/150009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ended up moving it to a separate gyp file so that msvs_use_common_release
gets applied at the right time (has to be before the include gets
evaluated).
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/150006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/150005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/151001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
SetUp method.
Review URL: http://codereview.chromium.org/149039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=15491
TEST=Open the options menu and there should be no "null" in the UI
Review URL: http://codereview.chromium.org/147249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactoring of void BuildHandshakeWriteBuffer() to const std::string BuildHandshakeWriteBuffer() const,
and removing private members handshake_buf_len_ and buffer_len_ (since buffer_ is now std::string, buffer_.size()) is more than sufficient.
TEST=unittests
BUG=469
Review URL: http://codereview.chromium.org/139009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A recent change broke the load times. It also revealed some deficiencies.
This adds a new time marker for when a load is committed, which is
a more interesting value than the start of the load (which we still keep).
Also, the first layout time wasn't an interesting time to keep, instead
we keep the time of the first paint.
The histograms were modified to use the new values when appropriate.
Review URL: http://codereview.chromium.org/149099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added another option in the DNS experiment: user 2 seconds or 500ms
for the congestion limit (that causes pre-resolutions to be discarded
from the queue.
The code in browser_main.cc was getting toooo large, so I pulled all
the experiment code into dns_global.cc.
BUG=15479
r=eroman
Review URL: http://codereview.chromium.org/147215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not try to complete on the IO thread.
This is an experiment for http://crbug.com/15513
BUG=15513
TBR=willchan
Review URL: http://codereview.chromium.org/150001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platforms don't like it as window. Will fix later.
TBR=sky
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkContextMenu controller (XP state bits) go back into browser/bookmarks. views::MenuItemView infrastructure lives in browser/views/bookmark_context_menu.
BUG=none
TEST=bookmark context menus on bookmark bar, bookmark manager, bookmark folder menus.
Review URL: http://codereview.chromium.org/149055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert.
Review URL: http://codereview.chromium.org/147233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=maruel
Review URL: http://codereview.chromium.org/149110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing interactive ui tests to fail with a crash:
kernel32.dll!_InterlockedDecrement@4()
> interactive_ui_tests.exe!sk_atomic_dec() Line 40 C++
interactive_ui_tests.exe!SkBitmap::MipMap::unref() Line 76 C++
interactive_ui_tests.exe!SkBitmap::freeMipMap() Line 367 C++
interactive_ui_tests.exe!SkBitmap::freePixels() Line 346 C++
interactive_ui_tests.exe!SkBitmap::~SkBitmap() Line 100 C++
interactive_ui_tests.exe!SkBitmap::`scalar deleting destructor'() C++
interactive_ui_tests.exe!BrowserThemeProvider::FreeImages() Line 744 C++
interactive_ui_tests.exe!BrowserThemeProvider::~BrowserThemeProvider() Line 141 C++
interactive_ui_tests.exe!BrowserThemeProvider::`scalar deleting destructor'() C++
interactive_ui_tests.exe!base::RefCounted<BrowserThemeProvider>::Release() Line 80 C++
interactive_ui_tests.exe!scoped_refptr<BrowserThemeProvider>::operator=() Line 209 C++
interactive_ui_tests.exe!ProfileImpl::~ProfileImpl() Line 584 C++
interactive_ui_tests.exe!ProfileImpl::`scalar deleting destructor'() C++
interactive_ui_tests.exe!ProfileManager::~ProfileManager() Line 57 C++
interactive_ui_tests.exe!ProfileManager::`scalar deleting destructor'() C++
interactive_ui_tests.exe!scoped_ptr<ProfileManager>::reset() Line 81 C++
interactive_ui_tests.exe!BrowserProcessImpl::~BrowserProcessImpl() Line 164 C++
interactive_ui_tests.exe!BrowserProcessImpl::`scalar deleting destructor'() C++
interactive_ui_tests.exe!browser_shutdown::Shutdown() Line 135 C++
interactive_ui_tests.exe!BrowserMain() Line 826 C++
interactive_ui_tests.exe!InProcessBrowserTest::SetUp() Line 129 C++
interactive_ui_tests.exe!testing::Test::Run() Line 2021 C++
interactive_ui_tests.exe!testing::internal::TestInfoImpl::Run() Line 2291 C++
interactive_ui_tests.exe!testing::internal::TestInfoImpl::RunTest() Line 656 C++
Review URL: http://codereview.chromium.org/147259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make build on Linux
BUG=http://crbug.com/15454
TEST=export GYP_GENERATORS=make; rm -rf sconsbuild; gclient runhooks --force; make -r base_unittests layout_tests; sh tools/valgrind/chrome_tests.sh -t base_unittests; verify that it finds and runs base_unittests; same thing with -t layout_tests
Review URL: http://codereview.chromium.org/147209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- I mean to spawn setup.exe --flag but it does setup.exe --uninstall
- sweet overloaded functions also let you shoot yourself in the foot
BUG=b/1484308
TEST=see the bug
Review URL: http://codereview.chromium.org/147253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer.
BUG=http://crbug.com/14664
TEST=existing unit tests.
Review URL: http://codereview.chromium.org/149053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ajwong
Review URL: http://codereview.chromium.org/149122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13326
TEST=Open options, click search engines manage button, try adding, removing, making default, etc.
Review URL: http://codereview.chromium.org/147243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes a bug where the same renderer could open several channels to the same plugin process, which end up having the same name. This CL makes it that there is only one channel for each (plugin, renderer) pair, just like on Windows.
The socketpair is created in the plugin process (which can ensure that only one channel per renderer gets created), and sends the renderer side through the browser process.
Note: this should essentially be a noop on Windows.
Review URL: http://codereview.chromium.org/149062
Patch from Antoine Labour <piman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when we create them.
We have to copy images that come from ResourceBundle because
ResourceBundle owns them.
Valgrind still sees more leaks in this area, but I need to investigate
some more and these are the biggies.
Review URL: http://codereview.chromium.org/149112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/149118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
You can only drag out of the web contents, and can only drag text.
http://crbug.com/15429
TEST=try dragging some text into gedit
Review URL: http://codereview.chromium.org/147245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the lastest plugin. This is important otherwise
fullscreen and samples that use feature requirements
will not run on machines that have the old plugin
and no message about why will appear.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=wtc
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/147234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NP_GetEntryPoints. The old code was assigning the size of the _pointer_ (i.e., 4). Apparently most browsers ignore this or else O3D wouldn't have worked anywhere, but nspluginwrapper started to care about this very much somewhere between 1.2.2 and 1.3.1-Pre (20090625). With the old code it stops before even calling our NPP_New because it thinks we don't have one.
Review URL: http://codereview.chromium.org/149113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the disk cache.
This switch is intended for troubleshooting, not to
add another supported configuration.
BUG=15117
TEST=none
Review URL: http://codereview.chromium.org/146136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I changed the command line switch "--new-new-tab-page" to
"-new-tab-page=<path>" so we can continue to iterate.
BUG=13362
TEST=The new new tab page should be on by default.
Review URL: http://codereview.chromium.org/147226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/147221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15410
Review URL: http://codereview.chromium.org/147216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directly.
Instead, pass the data to be written to disk so no cache_ lookups are necessary.
Review URL: http://codereview.chromium.org/149105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19435 0039d316-1c4b-4281-b951-d872f2087c98
|