summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* ipc: use strings, not wstrings for channel ids.evan@chromium.org2009-06-0450-119/+124
| | | | | | | | | | They're ASCII anyway. TEST=covered by existing tests Review URL: http://codereview.chromium.org/119131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17682 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline Linux layout test body-generated-image-propagated-to-root.html.dimich@google.com2009-06-043-11/+11
| | | | | | | | | TBR=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/118276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17681 0039d316-1c4b-4281-b951-d872f2087c98
* Twiddle some bits to get PNGEncoder to match ImageOperations. There's a ↵glen@chromium.org2009-06-041-9/+16
| | | | | | | | | | | Valgrind error that doesn't yet make sense. BUG=none TEST=none TBR=willchan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17680 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix layout test on Linux (overflow-scroll-delete.html).dimich@google.com2009-06-041-36/+0
| | | | | | | | | TBR=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/118273 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17679 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Alt+Tab not sending FocusWillChange events.finnur@chromium.org2009-06-041-5/+4
| | | | | | | | | | | | | This causes a DCHECK in FindBarWin if the Find box is open when the user switches to another app with Alt+Tab. The Focus manager now calls ClearFocus everywhere it used to set focused_view_ = NULL, to make sure the event reaches all listeners for FocusWillChange. BUG=13350 TEST=Open Chrome, press Ctrl+F then Alt+Tab. Swith focus back to Chrome and press Esc multiple times and you should not see the Find box flash briefly. Review URL: http://codereview.chromium.org/118267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17678 0039d316-1c4b-4281-b951-d872f2087c98
* Latest attempt at enabling task manager tests and not having them leak or crash!ben@chromium.org2009-06-043-12/+10
| | | | | | | | | | | Make Task Manager Table view a scoped_ptr so it and its columns are deleted regardless of whether or not the HWND has been constructed. BUG=none TEST=none Review URL: http://codereview.chromium.org/119208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17677 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in new gyp version (makes vs2005 the default).bradnelson@chromium.org2009-06-041-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/118243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17676 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most of the chrome .lib files to gyp generation:sgk@chromium.org2009-06-046-1975/+0
| | | | | | | | | automation.lib, common.lib, debugger.lib, plugin.lib, renderer.lib. BUG=none TEST=none Review URL: http://codereview.chromium.org/118254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the obsolete TabContents::GetSecurityStyle andwtc@chromium.org2009-06-042-39/+0
| | | | | | | | | | | | | TabContents::GetSSLEVText methods. This is discovered by Fumitoshi Ukai. R=jcampan BUG=none TEST=none Review URL: http://codereview.chromium.org/118145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17674 0039d316-1c4b-4281-b951-d872f2087c98
* For connection-based authentication schemes such as NTLM,wtc@chromium.org2009-06-041-41/+13
| | | | | | | | | | | | we keep the connection alive even if the server or proxy tells us to close it. R=eroman BUG=http://crbug.com/8771 TEST=none Review URL: http://codereview.chromium.org/119068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17673 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid tab drops on application windows.ben@chromium.org2009-06-041-1/+2
| | | | | | | | | | Change by Chase Phillips <cmp@google.com> http://crbug.com/9576 TEST=open a standalone GMail shortcut window, attempt to drop a tab from an existing browser window into it. It should not be added. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17672 0039d316-1c4b-4281-b951-d872f2087c98
* Always redraw the location bar background when we resize.tc@google.com2009-06-041-0/+3
| | | | | | | | | BUG=13342 Review URL: http://codereview.chromium.org/119207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17671 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a first pass at thumbnail store storage to disk, including a unit ↵brettw@chromium.org2009-06-043-10/+427
| | | | | | | | | test for the new behavior. TEST=covered by unittest BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17670 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Interface for the sparse cache support.rvargas@google.com2009-06-047-2/+171
| | | | | | | | | | | | This is just the interface declaration plus a mocked implementation of the interface. BUG=12258 TEST=none Review URL: http://codereview.chromium.org/119072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17669 0039d316-1c4b-4281-b951-d872f2087c98
* Only update files from .version templates when a file changesgk@google.com2009-06-043-81/+43
| | | | | | | | | | | | | indicates it's necessary (now that fetching the last change info is in a separate target executed every build) by getting rid of the never-built .bogus files in the rules. Update chrome/installer/installer.gyp with the new patterns. Make the use of the *_path variable names more consistent. BUG=none TEST=none Review URL: http://codereview.chromium.org/119181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17668 0039d316-1c4b-4281-b951-d872f2087c98
* On Linux, look in $HOME/.icons for mime icons as well for backwards ↵thestig@chromium.org2009-06-041-11/+14
| | | | | | | | | | compatibility. BUG=13001 TEST=Put an icon theme in $HOME/.icons, set it as the icon theme, and make sure Chromium picks it up on the download page. (May need to restart Chromium.) Review URL: http://codereview.chromium.org/119206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17667 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline Linux layout tests (using new and shiny rebaseline.py!)dimich@google.com2009-06-0427-39/+61
| | | | | | | | | I've looked through old/new images and it looks to me they are all correctly passing tests and the difference is the recently updated scrollbar rendering, as described in bug http://code.google.com/p/chromium/issues/detail?id=13313. BUG=13313, 13314 TEST=none Review URL: http://codereview.chromium.org/118257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17666 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: SizeTo() must synchronously size the content area."willchan@chromium.org2009-06-042-38/+12
| | | | | | | | | This reverts svn://svn.chromium.org/chrome/trunk/src@17664 0039d316-1c4b-4281-b951-d872f2087c98 It broke linux test_shell_tests. Review URL: http://codereview.chromium.org/119203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17665 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing PrintLayoutTest test. Commenting out because of local ↵sverrir@google.com2009-06-041-0/+3
| | | | | | | | | | | | compilation issues BUG=none TEST=none Review URL: http://codereview.chromium.org/118261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17664 0039d316-1c4b-4281-b951-d872f2087c98
* linux: SizeTo() must synchronously size the content area.evan@chromium.org2009-06-042-12/+38
| | | | | | | | | The old code was wrong and racy and the new message loop really exposed the bug. Review URL: http://codereview.chromium.org/119197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17663 0039d316-1c4b-4281-b951-d872f2087c98
* Don't update our text from toolbar if the toolbar's text doesn'tshess@chromium.org2009-06-041-5/+13
| | | | | | | | | | | | | | | | | visibly differ from the model's text. In most cases, this doesn't come up, because focus is usually not in the field (so there wouldn't be local changes), but when opening NTP you can type between when the tab opens in the browser and when the renderer finishes loading it. In that case, the model and toolbar both have "" as the url text, so this case is hit. http://crbug.com/13109 TEST=Browse to www.google.com. Command-t for new tab and type http as fast as you can. Before this fix, you sometimes got "tp" or something of the sort. Review URL: http://codereview.chromium.org/119125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17662 0039d316-1c4b-4281-b951-d872f2087c98
* To show IDN in view-source URLs, add special handling for view-source scheme inbrettw@chromium.org2009-06-042-1/+81
| | | | | | | | | | | | net::FormatUrl(). TEST=add a unit test BUG=3991 Original review: http://codereview.chromium.org/118071 Checked in for tkent@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17661 0039d316-1c4b-4281-b951-d872f2087c98
* Harmonizing ProcessUtil::GetAppOutput on Win/Unixjcampan@chromium.org2009-06-043-23/+13
| | | | | | | | BUG=None TEST=Run the base unit-tests Review URL: http://codereview.chromium.org/119190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17660 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when dragging bookmarks from one bookmark bar to another (as ↵estade@chromium.org2009-06-041-6/+13
| | | | | | | | | | | with multiple chrome windows). BUG=none TEST=drag a bookmark icon from one a bookmark bar to a bar in another window without crashing. Review URL: http://codereview.chromium.org/119114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17659 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable memory tests now that bug 13078 is fixed.tc@google.com2009-06-041-2/+2
| | | | | | | | | BUG=13078 Review URL: http://codereview.chromium.org/118256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17658 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the view size when printing. This is to re-layout everything on the ↵sverrir@google.com2009-06-041-26/+80
| | | | | | | | | | | page so the print will fill out the full page. BUG=http://crbug.com/1566 TEST=See bug description. Create a html page with a table that fills the screen. Print and make sure it aligns with the margins. Review URL: http://codereview.chromium.org/118176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17657 0039d316-1c4b-4281-b951-d872f2087c98
* Handle end of stream for mediahclam@chromium.org2009-06-0415-58/+130
| | | | | | | | | | When FFmpegDemuxer failed to decode a raw packet, the signal of end of stream should bubble up to the renderers. It is done in this CL by creating fake buffers. This change also fixes a bug with video of only 1 frame. Review URL: http://codereview.chromium.org/113611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17656 0039d316-1c4b-4281-b951-d872f2087c98
* On linux, add a context menu item in the tab strip for disablingtc@google.com2009-06-048-14/+60
| | | | | | | | | | | | | window decorations. This is mostly just an experiment. The window currently looks bad because of no rounded corners. It's also not possible to resize in this state and if you have too many tabs, you can't move. Review URL: http://codereview.chromium.org/114075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17655 0039d316-1c4b-4281-b951-d872f2087c98
* Make the inactive tab background line up with the parent without using magic ↵glen@chromium.org2009-06-045-8/+29
| | | | | | | | | | | numbers. BUG=12761 TEST=Verify that the inactive tab background lines up with the frame image in maximized and unmaximized mode - you will need a heavily patterned theme to test with. Review URL: http://codereview.chromium.org/118221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17654 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit 44405:44419dimich@google.com2009-06-042-5/+1
| | | | | | | | | Roll DEPS for WebKit. Also, fixed layout test from 13305 upstream, removing it from expectations. BUG=13305 (fixed) TEST=none Review URL: http://codereview.chromium.org/118251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17653 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for DWM crash.glen@chromium.org2009-06-041-1/+2
| | | | | | | | | | BUG=13075 TBR=ben TEST=On XP, verify that Chrome doesn't crash when a theme is installed or reset. Review URL: http://codereview.chromium.org/118252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17652 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash 12519: in views::DialogClientView::AcceptWindow()finnur@chromium.org2009-06-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | We don't have repro steps for this crash so this is a blind fix. But looking at the function that crashes and the history of this file I see: Ben's r11070 and r11047: Which add this check. Ben's r11132: Which removes this check (according to the comments it is a test to see if we can get away with it). It looks to me like the check would prevent the crash and since this is still crashing, I am proposing we re-add it. BUG=12519 TEST=We'll need to verify this by checking the crash dumps sent from the field. Review URL: http://codereview.chromium.org/119183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17651 0039d316-1c4b-4281-b951-d872f2087c98
* Change from CRLF to LF - a later patch does not work on the try bots because ↵sverrir@google.com2009-06-042-374/+374
| | | | | | | | | | | of this. BUG=none TEST=none Review URL: http://codereview.chromium.org/118249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17650 0039d316-1c4b-4281-b951-d872f2087c98
* Why can't passing localy and on the try bots mean it compiles on the ↵erg@google.com2009-06-041-0/+1
| | | | | | | | | | builders? Fix 2. TBR=beng Review URL: http://codereview.chromium.org/112094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17649 0039d316-1c4b-4281-b951-d872f2087c98
* Add atlapp.h. Wasn't neccessary on my local windows machine but builders ↵erg@google.com2009-06-041-0/+1
| | | | | | | | | | want it. TBR=beng Review URL: http://codereview.chromium.org/119194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17648 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0417-674/+797
| | | | | | | | | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. This version has minor windows compile fixes that changed from under me. Original Review URL: http://codereview.chromium.org/119006 TBR=beng TEST=Popup notification still works. Review URL: http://codereview.chromium.org/119107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17647 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a NOTREACHED in RenderViewHost::OnExtensionRequest. It was firing becausempcomplete@google.com2009-06-041-1/+2
| | | | | | | | RenderViewHosts created via window.open don't have their enabled_bindings_ set. Review URL: http://codereview.chromium.org/119134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17646 0039d316-1c4b-4281-b951-d872f2087c98
* Allow sysctl-read in the mac sandbox, making drawing of zoomed controls more ↵thakis@chromium.org2009-06-042-35/+8
| | | | | | | | | | | reliable. TEST=Zoom a page with multiple form controls, check that they don't become invisible when zoomed. BUG=11325 Review URL: http://codereview.chromium.org/119151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17645 0039d316-1c4b-4281-b951-d872f2087c98
* Linux toolbar cleanups.tc@google.com2009-06-043-38/+54
| | | | | | | | | | | | | | | | 1) Set a consistent padding between toolbar buttons by grouping controls that have different paddings into hboxes. E.g., back/forward are in a grouped hbox and the menu buttons are in an hbox. 2) Hook the home button up to the user pref. 3) Change how we show the various widgets so home button only shows up when the pref is enabled. Review URL: http://codereview.chromium.org/118195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17642 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window state restoration for the views-gtk window.ben@chromium.org2009-06-046-34/+63
| | | | | | | | | | | Allows the window to be resized smaller than its current size by setting a minimum size before initiating the drag. Fixes a crash in TabContentsViewGtk due to a NULL delegate deref. BUG=none TEST=none Review URL: http://codereview.chromium.org/118227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17641 0039d316-1c4b-4281-b951-d872f2087c98
* Make tab resize relayout on mouse out work.ben@chromium.org2009-06-042-18/+35
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix make build by providing a hint as to when to expand the filename.tc@google.com2009-06-041-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/119182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17639 0039d316-1c4b-4281-b951-d872f2087c98
* Fix purify freeze. Revert "Use a priority queue to assure that subresources ↵willchan@chromium.org2009-06-046-256/+24
| | | | | | | | | | | are resolved asap" This reverts git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17605 0039d316-1c4b-4281-b951-d872f2087c98 TBR=jar Review URL: http://codereview.chromium.org/118239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17638 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix expression evaluation while on a breakpoint.pfeldman@chromium.org2009-06-041-1/+1
| | | | | | | | BUG=13251 Review URL: http://codereview.chromium.org/118236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17637 0039d316-1c4b-4281-b951-d872f2087c98
* One more attempt at fixing the keyboard focus issue when the windowless ↵ananta@chromium.org2009-06-041-2/+22
| | | | | | | | | | | | | | | | | | | | | | | Flash plugin puts up a context menu and we click on the browser window. The Flash plugin at times sets focus to its hidden popup window with class name SWFlash_PlaceholderX in the context of the TrackPopupMenu call. This causes the browser ui thread to receive a WM_ACTIVATEAPP message indicating that another top level window has become active, which causes this issue. This also happens in Firefox at times. However in Firefox the popup lives on the ui thread and hence the sideeffect is that no window has keyboard focus. Our workaround/fix for this scenario is to identify when this occurs and send over a raw mousedown/mouseup event via SendInput to the last focus window. Fixes http://code.google.com/p/chromium/issues/detail?id=8988 Bug=8988 Review URL: http://codereview.chromium.org/119049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17636 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix memory leak again.glen@chromium.org2009-06-041-1/+1
| | | | | | | | | BUG=none TEST=none TBR=willchan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17635 0039d316-1c4b-4281-b951-d872f2087c98
* Fetch last change (revision) info in a separate action that can runsgk@google.com2009-06-046-70/+181
| | | | | | | | | | every build, instead of having it occur as a side effect of updating some other target for which we want to use normal up-to-date checks. BUG=none TEST=none Review URL: http://codereview.chromium.org/118192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17634 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/115998 for benm@google.comdglazkov@google.com2009-06-042-28/+15
| | | | | | | | | R=benm@google.com TEST=no layout test regressions. BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17633 0039d316-1c4b-4281-b951-d872f2087c98
* Fix timing issue with first run bubble, and tweak size of OEM bubble so it ↵mirandac@chromium.org2009-06-042-2/+7
| | | | | | | | | | | | looks more like Glen's mock. BUG= http://crbug.com/9233 TEST= Run Chrome with --first-run option. Notice that first run info bubble does not go away within the first second even if you click on or away from the browser. Review URL: http://codereview.chromium.org/118143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17632 0039d316-1c4b-4281-b951-d872f2087c98
* make extension apis tolerate browser absence during start-up & shutdownrafaelw@chromium.org2009-06-045-30/+63
| | | | | | | | | | | Note: I was never able to directly reproduce the 13082 bug, the error mode is clear (there was no selected tab during a call to tabs.getSelected()). This fix will address that issue and we should stop seeing this crash reports. R=erikkay BUG=13082 Review URL: http://codereview.chromium.org/119117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17631 0039d316-1c4b-4281-b951-d872f2087c98