| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in subtle and devious ways.
Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln,
which occured unbeknownst to the builders who continued to build webkit.sln
for most of the day. This wasn't an issue until we did a WebKit roll, where
the trickery was discovered and hell broke loose.
TBR=yaar
TEST=green bots
BUG=none
Review URL: http://codereview.chromium.org/385084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Profile::GetDefaultRequestContext() is initialized lazily, on the UI thread.
So, if SocketStreamHost runs before it has gotten lazily initialized yet,
SocketStream won't have context. In this case, SocketStream will die.
Rather than that, just close immediately.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/384077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because the posix version of std::set has no way to update the iterator when
calling erase(), and using the old invalid iterator was corrupting memory.
BUG=27589
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/385083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After the WK roll, 750 unexpected crashes are happening,
so it is being reverted.
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/384111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the WK roll, 750 unexpected crashes are happening,
so it is being reverted.
Review URL: http://codereview.chromium.org/391043
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/387046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/385003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer if they were not initiated there.
BUG=26755
TEST=Enter messages initiated in omnibox should not propagate to renderer
Review URL: http://codereview.chromium.org/384101
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/384109
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/393005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the failure on Mac, but apparently Linux's TEXT-only failure doesn't get
covered by this rule. Trying "IMAGE TEXT" instead of "IMAGE+TEXT" to see if it
fixes the problem.
TEST=this is a friggin test
BUG=none
Review URL: http://codereview.chromium.org/391043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
discussion on the (internal) group.
Review URL: http://codereview.chromium.org/363001
BUG=17818
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
were not initiated there.
BUG=26755
TEST=Enter messages initiated in omnibox should not propagate to renderer
Review URL: http://codereview.chromium.org/384101
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/384109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25677
Review URL: http://codereview.chromium.org/372075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and naming files according to the row ID of the respective DB in the
tracker database. Also, fixing a bug: caching the renderer process
handle in DatabaseDispatcherHost after it was set in
ResourceMessageFilter.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests started failing with this checkin:
AuthenticateSuccess AuthenticateWithTokenSuccess
Review URL: http://codereview.chromium.org/387042
TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/389031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/276071 by randy.posynick@gmail.com
Don't overwrite email with lowercase value from GetUserInfo().
BUG=20848
TEST=See bug for description
TBR=brg@chromium.org
Review URL: http://codereview.chromium.org/392016
TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/384106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rather then printing across two lines, just do it on one line.
Review URL: http://codereview.chromium.org/387043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
initiated there.
BUG=26755
TEST=Enter messages initiated in omnibox should not propagate to renderer
Review URL: http://codereview.chromium.org/384101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
can now outlive their parent pages and can be shared by multiple instances
across multiple tabs.
BUG=26233
TEST=ui tests
Review URL: http://codereview.chromium.org/390017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content-type (e.g., text/html; charset=utf-8) in multipart
responses.
This fixes a bug where e.g., CUPS pages wouldn't be rendered
properly.
BUG=25217
TEST=Covered by unittests.
Review URL: http://codereview.chromium.org/385046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
randy.posynick@gmail.com
Don't overwrite email with lowercase value from GetUserInfo().
BUG=20848
TEST=See bug for description
TBR=brg@chromium.org
Review URL: http://codereview.chromium.org/392016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mmoss
Review URL: http://codereview.chromium.org/389028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Eliminate header files that aren't needed
* Eliminate function declarations that are never defined
* Reorder header slightly for Google C++ Style Guide compliance and to make more functions private
* Move above-function comments like "Called on IO thread" from definitions to declarations for added visibility
* Reorder function definitions to match declaration order
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
If SetCookie is invoked via automation and load_requests_via_automation is true, the IPC will be sent back from the UI thread.
BUG=27568
Review URL: http://codereview.chromium.org/387042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
was spent reading/writing headers and reading/writing body.
Review URL: http://codereview.chromium.org/384098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/392009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dhg
BUG=none
Review URL: http://codereview.chromium.org/385081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
response to a user gesture, not arbitrary script.
Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script.
BUG=27215
TEST=included
Review URL: http://codereview.chromium.org/387011
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/385080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for observing tracking areas so that when tabs are moved underneath
our cursor, we highlight them correctly.
BUG=27458, 13208, 21448
TEST=Create a pile of tabs.
Select a middle one.
Put your cursor in some other tab.
Hit cmdw a couple of times
Watch to make sure highlights occur correctly in both the tabs and the
close buttons.
Review URL: http://codereview.chromium.org/386021
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/384100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/387040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to move to Chrome tree.
Review URL: http://codereview.chromium.org/392017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is uninstalled while in use.
BUG=27483,23999
TEST=Uninstall Chrome Frame while it is in use. Verify that all Chrome Frame folders are removed.
Review URL: http://codereview.chromium.org/392013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=27414
TEST=None
Review URL: http://codereview.chromium.org/384094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Partial revert of http://codereview.chromium.org/387034
BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/391038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly updating internal data structures, which could lead to a
future crash. When recursively deleting items we need to get the next
item before removing from the tree, otherwise the tree returns null.
BUG=27290
TEST=make sure no problems in using bookmark manager, especially when
adding/removing urls/folders.
Review URL: http://codereview.chromium.org/384092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Resolve ambiguity - error C2782 in VisualC or "no matching function to call" in gcc - when attempt to create functor for base class member function.
Support for free (non class members) functions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/371046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24638
TEST=Not sure how the duplicate crash reports were getting generated so can not test that but made sure that the crash reporting works fine.
Review URL: http://codereview.chromium.org/385030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the keep-alive connection is still connected and idle before
reusing it for authentication restart. An impatient server
may have closed the connection while waiting for the user to
enter the username and password.
In socket_test_util.cc, return the mock ERR_UNEXPECTED error
synchronously.
R=eroman
BUG=21675
TEST=new unit test
Review URL: http://codereview.chromium.org/389007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
QuickTime can be embedded for audio, with a 0x0 plugin, but it still expects to get information about the window via SetWindow. Windows in fact made this same fix a while ago, for the same reason, but in the Windowed version of this method.
BUG=25883
TEST=Open a site like the one in the bug with a 0x0 QuickTime plugin; the plugin should not crash.
Review URL: http://codereview.chromium.org/389026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27554
Review URL: http://codereview.chromium.org/384097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/387041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from the design team, but I wanted to at least get the words
in before the string freeze.
Review URL: http://codereview.chromium.org/385075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/382001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27167
Review URL: http://codereview.chromium.org/385072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture, not arbitrary script.
Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script.
BUG=27215
TEST=included
Review URL: http://codereview.chromium.org/387011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/385077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
scripts and extensions.
BUG=no
Review URL: http://codereview.chromium.org/384093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(No code changes). Includes rendered extension docs that should have been included with r31834.
TBR=aa
Review URL: http://codereview.chromium.org/384096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31836 0039d316-1c4b-4281-b951-d872f2087c98
|