summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Unit test now runs on the Mac.avi@google.com2008-09-224-25/+84
| | | | | | Review URL: http://codereview.chromium.org/3000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2440 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup EOL and include guards, including fixing one guard that was not the ↵deanm@chromium.org2008-09-2017-38/+27
| | | | | | | | correct path. Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC. Review URL: http://codereview.chromium.org/4007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2437 0039d316-1c4b-4281-b951-d872f2087c98
* Use of null string on DLLMatch happens on the botscpu@google.com2008-09-201-1/+2
| | | | | | | | | | - Not in my machine unless I incredibuild. - But change makes sense. Review URL: http://codereview.chromium.org/4006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2436 0039d316-1c4b-4281-b951-d872f2087c98
* Redo change 2413 that I had to back out beforecpu@google.com2008-09-2015-66/+343
| | | | | | | | | | | - CL is identical and was already lgtm TBR=rvargas Review URL: http://codereview.chromium.org/3179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2435 0039d316-1c4b-4281-b951-d872f2087c98
* Create a SafeBrowsing database interface to more easilypaulg@google.com2008-09-2011-1713/+1897
| | | | | | | | | | | facilitate alternate implementations. The current SafeBrowsingDatabase code is moved to *_impl files. Adding a new implementation can be done via command line flags in the SafeBrowsingDatabase::Create factory method. Review URL: http://codereview.chromium.org/3162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 2419 because it breaks the buildnsylvain@chromium.org2008-09-206-554/+181
| | | | | | | | | | | | | | | | | | | | | | | | | The stack crashing is this one: chrome_2650000!xmlTextWriterStartElement+0x23 chrome_2650000!MetricsLog::StartElement+0xb5 chrome_2650000!MetricsLog::ScopedElement::ScopedElement+0x67 chrome_2650000!MetricsLog::RecordHistogramDelta+0xd8 chrome_2650000!MetricsService::RecordHistogram+0x122 chrome_2650000!MetricsService::RecordCurrentHistograms+0xc3 chrome_2650000!MetricsService::StopRecording+0x94 chrome_2650000!MetricsService::PushPendingLogsToUnsentLists+0xbf chrome_2650000!MetricsService::SetRecording+0x36f chrome_2650000!MetricsService::Stop+0x11 chrome_2650000!BrowserMain+0xefa chrome_2650000!ChromeMain+0x862 It looks like writer_ is null on invalid. It also look like there is debugging code that was left in. Review URL: http://codereview.chromium.org/4005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2433 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AmountOfFreeDiskSpace to be able to differentiate an errorrvargas@google.com2008-09-204-6/+13
| | | | | | | | from a full disk. Review URL: http://codereview.chromium.org/4003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2431 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs:-iyengar@google.com2008-09-202-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.http://code.google.com/p/chromium/issues/detail?id=292 This was a painting issue in the XStandard plugin. The bug occurs in a windowed instance of the plugin. We handle window repositions in the plugin process until the window becomes visible. We set the SWP_NOREDRAW flag in the SetWindowPos call. This turns off client/non-client paints. After the SetWindowPos call we invalidate the client area. The plugin only receives WM_PAINT as a result. The plugin relies on the WM_NCPAINT message being received as well. In any case the SWP_NOREDRAW flag does not buy us much as we invalidate immediately after. The fix is to take out this flag. 2.http://code.google.com/p/chromium/issues/detail?id=2556 The plugin invoked the NPN_GetValue function to retreive the window script object. This call fails in this case probably because the plugin instance in the renderer process is in the process of shutting down. We return a failure from the call. The plugin fails to check the return code and ends up invoking NPN_GetProperty on a NULL NPObject which causes a crash in chrome when we try to create a proxy for the same. The fix is to add NULL NPObject checks in the NPObjectProxy members and return early. Bug=292,2556 R=jam Review URL: http://codereview.chromium.org/3176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2429 0039d316-1c4b-4281-b951-d872f2087c98
* Stop exposing manually_selected_match_ outside the AutocompletePopupModel. ↵pkasting@chromium.org2008-09-1911-362/+222
| | | | | | | | | | | | | | | | | | | The main goal of this is to be a first step towards divorcing the popup and the edit from each other. To do this, I changed the behavior of manual selections. They now do not persist once the user types more characters, hits esc, etc. Our old behavior, which Brett and I designed long ago, turns out to have been a mistake; users who arrowed to an item and then typed more weren't expecting "stickiness" on their previous choice, and it led to user mistakes. This also required changing how we do the "keyword UI" persistence in the case where the user switches into keyword UI, but then deletes all his text. Previously, we used manually_selected_match_ with a provider affinity to the keyword provider in order to accomplish this. Now we stick another flag on the AutocompleteInput, which, when set, biases the keyword provider to return the best results. The user-visible effect of this is that when in keyword UI mode with no query string, the selected entry in the popup will be the first, rather than third, entry. This is a small win. While here I fixed the bug where editing a string and transforming it into a keyword search would avoid switching into keyword UI (as expected), but also delete the keyword off the visible string (oops). I also made us lock the popup once the user changes the manually_selected_match_, in order to give a little more stability to it. I'm sorry this makes so many behavioral changes at once. All this code is tangled together and untangling it is hard :( The keyword-related variables in the AutocompleteEditModel seem a mess. They are probably worse now than before this change; I think I need a followup change at some point to make them all more sane. It seems like we have three variables and complex conditionals where two, and simpler ones, would do. BUG=997976,1201974,1204173 Review URL: http://codereview.chromium.org/3172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2426 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory corruption when EAT patching in sandboxcpu@google.com2008-09-191-9/+9
| | | | | | Review URL: http://codereview.chromium.org/3174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2425 0039d316-1c4b-4281-b951-d872f2087c98
* Do not time out in TestRunner while is being debuggedcpu@google.com2008-09-191-11/+7
| | | | | | | | | - Makes it impossible to debug without changing the code. Review URL: http://codereview.chromium.org/2997 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2424 0039d316-1c4b-4281-b951-d872f2087c98
* Accidental commit; oopsavi@google.com2008-09-194-84/+25
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2423 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test now runs on the Mac.avi@google.com2008-09-194-25/+84
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2421 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, expected value comes first.avi@google.com2008-09-191-24/+24
| | | | | | Review URL: http://codereview.chromium.org/3177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2420 0039d316-1c4b-4281-b951-d872f2087c98
* This is the same change as issue 1633 ( http://codereview.chromium.org/1633 ↵petersont@google.com2008-09-196-181/+554
| | | | | | | | ) together with the disabling of a test called MetricsServiceTest.CloseRenderersNormally which the change makes obsolete (see bug 2522.) Review URL: http://codereview.chromium.org/2995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2419 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for the X509 parsing. This only runs on Windows, but does so ↵avi@google.com2008-09-193-6/+165
| | | | | | | | successfully. Review URL: http://codereview.chromium.org/2993 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2418 0039d316-1c4b-4281-b951-d872f2087c98
* Landing a patch for Adam. See http://codereview.chromium.org/3136 for details.finnur@google.com2008-09-194-18/+7
| | | | | | | | TBR=abarth Review URL: http://codereview.chromium.org/2996 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2417 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash that can occur if PumpOutPendingPaintMessages is called outside ↵darin@chromium.org2008-09-191-0/+5
| | | | | | | | | | the context of MessagePump::Run. R=jar Review URL: http://codereview.chromium.org/3137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2415 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CPAPI function to make a function call asynchonously on the plugin ↵zork@google.com2008-09-194-1/+47
| | | | | | | | thread. Review URL: http://codereview.chromium.org/2969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2414 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the bookmark model to allow more than one bookmark tosky@google.com2008-09-1922-316/+510
| | | | | | | | | | | | | | | | reference the same url. Clicking the star button edits the most recently added bookmark for the URL. Dragging a button/star always does a move, otherwise drops on the bookmark bar create a new bookmark. Also changed the add page context menu for the bookmark bar to remember where you invoked it from. BUG=1173228 1678 Review URL: http://codereview.chromium.org/3203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2413 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in file_util::ReplaceExtension that could chop off pathsky@google.com2008-09-192-5/+39
| | | | | | | | | | | elements. This was causing some folks bookmarks not to get saved! BUG=1946 TEST=covered by unit tests Review URL: http://codereview.chromium.org/2990 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2412 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing flaky Find test.finnur@google.com2008-09-191-1/+6
| | | | | | | | The waterfall (build.chromium.org) has been complaining about this test for a while now. Nicolas and I looked at this, but we don't see anything wrong. We theorized this is because we issue Find right after the navigation and maybe the tab isn't ready. We'll see what happens with this change. Review URL: http://codereview.chromium.org/2978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2411 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure webkit/port and webkit/glue are in lower case because libGlue.a ↵tc@google.com2008-09-194-10/+8
| | | | | | looks funny. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2410 0039d316-1c4b-4281-b951-d872f2087c98
* Add empty stub to get classname so ImageMac can use it.pinkerton@google.com2008-09-192-2/+26
| | | | | | Review URL: http://codereview.chromium.org/3169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2409 0039d316-1c4b-4281-b951-d872f2087c98
* Build a bunch more of chrome/ on Linux.deanm@google.com2008-09-1921-74/+83
| | | | | | Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2408 0039d316-1c4b-4281-b951-d872f2087c98
* windows.h isn't needed, remove itpinkerton@google.com2008-09-191-1/+0
| | | | | | Review URL: http://codereview.chromium.org/3168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2407 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tooltip manager. Mouse coordinates for NC events are insky@google.com2008-09-192-4/+12
| | | | | | | | | | | screen coordinates and need to be converted. BUG=2523 TEST=see bug Review URL: http://codereview.chromium.org/3160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2406 0039d316-1c4b-4281-b951-d872f2087c98
* add computePageRectsForFrame from FrameWin to resolve a link error. pinkerton@google.com2008-09-191-0/+52
| | | | | | Review URL: http://codereview.chromium.org/3167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2405 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the fixes for the UI test single-process mode in the NPAPIiyengar@google.com2008-09-193-25/+9
| | | | | | | | | | tests. The offending Stream test has been disabled in single-process mode TBR=jam Review URL: http://codereview.chromium.org/3166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2404 0039d316-1c4b-4281-b951-d872f2087c98
* Add a byte factory method for unit testing.avi@google.com2008-09-193-29/+46
| | | | | | Review URL: http://codereview.chromium.org/2975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2403 0039d316-1c4b-4281-b951-d872f2087c98
* roll backbeng@google.com2008-09-191-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2402 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the NPAPI ui test failures in single-process mode.These tests ↵iyengar@google.com2008-09-192-2/+19
| | | | | | | | | | | | fail because of a crash in chrome.exe. This occurs because of an attempt to access member variables in the PluginStream object after it gets deleted in the context of NPP_NewStream. This crash only occurs in single-process mode as the NPN_GetURLNotify call executes synchronously. Added a mechanism to track if the PluginStream object is deleted in the context of NPP_NewStream. TBR=jam Review URL: http://codereview.chromium.org/2984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2401 0039d316-1c4b-4281-b951-d872f2087c98
* This CB fixes the following issue1. ↵iyengar@google.com2008-09-1929-182/+594
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=206This is a performance issue while loading PDF documents. The fix is to support PDF fast webview, which is basically support for the NPN_RequestRead API, which allows a plugin to request specific byte ranges in HTTP GET requests. This also needs support for seekable streams. Our support for seekable streams is limited to HTTP servers which allow byte range requests. Firefox also supports a mode in which the the browser caches the file on disk for servers which don't support byte range requests. The plugin_data_stream.cc/.h files are being removed as there is not much value in their existence. The needed functionality is available in the PluginStreamUrl class, which now services manual data streams as well. Testing this is a touch tricky as we need a HTTP server which serves byte range requests. Will add those in a subsequent CB.Also fixed a bug in the multipart parser where we need to ignore leading newline characters while parsing the header.Bug=206 Review URL: http://codereview.chromium.org/2896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2400 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the frame is set to the foreground when:ben@chromium.org2008-09-191-0/+3
| | | | | | | | | | | - opening from a shortcut when an existing frame is already open - pressing Ctrl+T from an app window http://crbug.com/2477 Review URL: http://codereview.chromium.org/3134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2399 0039d316-1c4b-4281-b951-d872f2087c98
* Only link the new event lib on Linux systems.sgk@google.com2008-09-192-2/+14
| | | | | | Review URL: http://codereview.chromium.org/2982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix whitespace back to before I screwed it up.evanm@google.com2008-09-191-129/+129
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2397 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to get latest breakpad that supports the full memory dump.huanr@chromium.org2008-09-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2396 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in the latest revision (18744:a1d3449a2cba) of the effective-TLDpamg@google.com2008-09-191-40/+150
| | | | | | | | | | data file from Mozilla. BUG=2450 TEST=none Review URL: http://codereview.chromium.org/2981 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2395 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak on the disk cache for posix.rvargas@google.com2008-09-181-0/+6
| | | | | | Review URL: http://codereview.chromium.org/3154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2393 0039d316-1c4b-4281-b951-d872f2087c98
* Moved over the test running part over to coverage.py and addressed comments ↵niranjan@google.com2008-09-181-10/+92
| | | | | | | | as per revision number 2823. Review URL: http://codereview.chromium.org/3139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2391 0039d316-1c4b-4281-b951-d872f2087c98
* Link TestShell against libevent, now required. Turn off objc-gc setting inmark@chromium.org2008-09-181-13/+84
| | | | | | | this file because it now comes from the xcconfig. Clean up ugly backslashes. Review URL: http://codereview.chromium.org/3158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2386 0039d316-1c4b-4281-b951-d872f2087c98
* Build libevent on Macmark@chromium.org2008-09-1812-8733/+535
| | | | | | Review URL: http://codereview.chromium.org/3157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2384 0039d316-1c4b-4281-b951-d872f2087c98
* Some tweaks pointed out by wtc.avi@google.com2008-09-181-11/+8
| | | | | | Review URL: http://codereview.chromium.org/2973 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2383 0039d316-1c4b-4281-b951-d872f2087c98
* * Change output of trace_event log to JSON to enable easier integration with ↵erikkay@google.com2008-09-189-15/+1407
| | | | | | | | | | | | visualization UI. * Simple (manual) trace visualizer with some sample data. * a few more trace events * add process_util function for current process handle Review URL: http://codereview.chromium.org/3086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2381 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in Add to dictionary code.sidchat@google.com2008-09-182-0/+6
| | | | | | Review URL: http://codereview.chromium.org/3148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2379 0039d316-1c4b-4281-b951-d872f2087c98
* Merge http://v8.googlecode.com/svn/branches/bleeding_edge/tools/v8.xcodeproj@319mark@chromium.org2008-09-182-0/+384
| | | | | | | to our copy (includes changes from r300 too). Review URL: http://codereview.chromium.org/2971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2375 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an old leak in tab_strip_model_unittest which had recently contributed ↵erikkay@google.com2008-09-182-59/+7
| | | | | | | | to a new leak showing up. The leak was caused by not cleaning up after ReplaceTabContents. Review URL: http://codereview.chromium.org/2954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2374 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CopyDirectory() for the POSIX branch of file_util.evanm@google.com2008-09-183-8/+106
| | | | | | | This lets us pass some more base unit tests and at least one net test. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2372 0039d316-1c4b-4281-b951-d872f2087c98
* Use libevent, second try. Changes this time:dkegel@google.com2008-09-1812-20/+658
| | | | | | | | | - remove bogus include of base/completion_callback.h - add DEPS rules to allow including third_party/libevent Review URL: http://codereview.chromium.org/2964 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2371 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall slightly less prone to chrome.exe crashes by changing default ↵kuchhal@chromium.org2008-09-183-45/+26
| | | | | | | | | | to uninstall confirmation. BUG=1215 Review URL: http://codereview.chromium.org/3128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2370 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 02:49:46 +0000