| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::wstring.
BUG=None
TEST=None
Patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/164383
Review URL: http://codereview.chromium.org/174168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and enable the related layout tests.
BUG=47548,12129
TEST=Covered by layout tests
Review URL: http://codereview.chromium.org/174175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
profile over NFS.
In order to avoid the singleton socket filename from exceeding the max socket name length, the socket is just named "SingletonSocket" and a new file "SingletonLock" is used for the hostname&pid.
BUG=17549
TEST=see bug
Review URL: http://codereview.chromium.org/174041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GoogleUpdateSettings::GetCollectStatsConsent uses the Chrome path provider, so
if the Breakpad glue is going to decide whether to enable Breakpad based on
that function, it can't call it until after the Chrome path provider has been
added to the path service.
TBR=jeremy
BUG=19913
TEST=Does Breakpad work in the browser process? If stats reporting is enabled,
in an official release Google Chrome build, you'd better not see this:
[mmdd/hhmmss:WARNING:.../chrome/app/breakpad_mac.mm(57)] Breakpad disabled
Review URL: http://codereview.chromium.org/173172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=tony@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/174207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ubuntu want to ship with the inspector files in a separate package and
having menu items which are broken isn't nice.
http://codereview.chromium.org/174162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=willchan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/174205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation clients to
handle URL requests.
This fixes bug http://b/issue?id=2068725
Bug=2068725
Review URL: http://codereview.chromium.org/174197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In path_utils and platform_utils, we had four functions:
- TestListPlatformName()
- TestListPlatformDir()
- PlatformDir()
- PlatformNewResultsDir()
TestListPlatformDir() was uniformly implemented as
TestListPlatformName().lower(), and never called. PlatformDir() and
PlatformNewResultsDir() returned the same value on win and linux -
"chromium-" + TestListPlatformDir(). On the mac, PlatformDir()
returned PlatformNewResultsDir() + "-leopard". PlatformDir() is used
to prepend the directory in the search path for test results, and this is
ironic since there is no chromium-mac-leopard directory, just chromium-mac.
I have replaced all of these with one routine called PlatformDir() that
returns "chromium-" + <platform name> [ + "-" + <platform version name> ].
I also modified the code so that test results will always go into a
directory with that name, and then modified all of the files that
referenced a _new_results_dir (which ostensibly used
PlatformNewResultsDir(), which might be different from options.platform,
but in practice never was). I also removed a number of platform parameters
from functions, since it seemed like that functionality wasn't being
used and was redundant with stuff stuffed into options contexts.
Lastly, I also attempted to bring some consistency to files needing to
import path_utils vs platform_utils, by adding wrapper functions to
path_utils and then banning platform_utils imports from all other files.
There's gotta be a cleaner way to do this, though.
You can still change the platform you're comparing to with the
--platform switch, and change the results directory with the
--results-directory switch.
BUG=none
R=pam@chromium.org,tony@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/164372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure that only the main cache runs an experiment.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't require the buildbot slave_scripts unless running a test that needs them.
BUG=none
TEST=run 'smoketests.py --tests=ui' without having tools\buildbot\scripts\slave
checked out
Review URL: http://codereview.chromium.org/174191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
last change, but missed it.
Review URL: http://codereview.chromium.org/174115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
quite a while.
TBR=pfeldman
Review URL: http://codereview.chromium.org/174203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16507
TEST=Unittests
Review URL: http://codereview.chromium.org/171085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
give to users that don't have a .deb or .rpm compatible distro. Creating a new issue since the last one was broken.
Review URL: http://codereview.chromium.org/173081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
o3djs.primitives.createCylinderVertices now delegates to
createTruncatedConeVertices. Updated primitives.html. Added
o3djs.primitives.VertexInfo.append to allow multiple VertexInfos to be
placed in a single Shape for efficiency; this functionality has been
tested but is not yet demonstrated in a sample.
Review URL: http://codereview.chromium.org/174186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test flakiness."
TBR=darin
Review URL: http://codereview.chromium.org/173165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14023
TEST=Make sure the option of choosing a different browser shows up during un
Review URL: http://codereview.chromium.org/174194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hbono
TEST=none
BUG=11577
Review URL: http://codereview.chromium.org/173163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
normalized to be delimited
by '\0' instead of '\r\n'. This causes URLs like microsoft.com, etc to not render correctly in
automation HTTP clients.
This fixes bug http://b/issue?id=2066632
Thanks to Eric Roman for his help in tracking this down.
Bug=2066632
Review URL: http://codereview.chromium.org/174132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
through to virtual functions in the subclass.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means we can avoid creating new page tables, but that we share our memory
mappings / stack with the parent. This is a bit more fragile, but should be
workable. This saves us some work since we are just going to exec().
This also removes some sandbox unsetting code, since we shouldn't be spawning
processing under the sandbox anyway.
BUG=19863
Review URL: http://codereview.chromium.org/173141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
config utilities.
Currently it still only ever starts gnome-network-properties but it is now easy to update.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can't reproduce the crash and it's building successfully on the bots it seems. This was hit during a webkit roll, so it's very possible it was fixed upstream.
BUG=19782
TEST=none
Review URL: http://codereview.chromium.org/173161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/platform/mac/editing/deleting/backward-delete.html to fail on Mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward.
TEST=Covered by ui_tests and browser_tests.
http://crbug.com/18365, http://crbug.com/19361
Review URL: http://codereview.chromium.org/174179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
marked as part of the webkit merge, but were not actually caused by the merge (the tests failed on main waterfall before the merge, see more details in bug).
TEST=none
BUG=19888
Review URL: http://codereview.chromium.org/174192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
refactoring change (http://src.chromium.org/viewvc/chrome?view=rev&revision=23589). Do that now.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Changed the indentation for long lines of "ExpectLogContains()".
* Moved host_resolver_impl_unittest into the net namespace to avoid lots of redundant net:: prefixes.
Review URL: http://codereview.chromium.org/173137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Maybe those are not defined when building the
unit tests?
If there is a better way to fix this tell me and
I'll change it to that way.
Review URL: http://codereview.chromium.org/174094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will help debugging when you have only the logs.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/174110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19754
TEST=Open a new window and browse to google.com. Hover the mouse over the tab and notice that the tooltip does not display. Open enough new tabs so that the google.com tab title is ellipsized. Hover the mouse over the tab and notice that the tooltip displays.
Review URL: http://codereview.chromium.org/174188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jianli
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
destructor. The pool operations are moving from SetUp and TearDown, which are
scoped slightly too narrowly for our needs. Using the constructor and
destructor ensures that the pools properly bracket tests.
Review URL: http://codereview.chromium.org/174171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
accomodate changes in the Chrome tree.
Review URL: http://codereview.chromium.org/174185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I will fix these later today.
http://code.google.com/p/chromium/issues/detail?id=19881
TBR=brg
Review URL: http://codereview.chromium.org/174182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark
BUG=10395
TEST=none
Review URL: http://codereview.chromium.org/174181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/19876
TBR=brg
Review URL: http://codereview.chromium.org/173156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18970
TEST=test matrix videos ending in 0 should have mute context menu disabled
Review URL: http://codereview.chromium.org/174018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from test-expectations. These layout tests were re-written in:
http://trac.webkit.org/changeset/47544
http://trac.webkit.org/changeset/47543
http://trac.webkit.org/changeset/47542
http://trac.webkit.org/changeset/47533
to not be pixel tests but instead just be text dumps. Thus we do not need any platform specfic results.
TEST=ran manually locally
BUG=19796
Review URL: http://codereview.chromium.org/174169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17864
TEST=contents of fields are saved regardless of in-progress editing.
Review URL: http://codereview.chromium.org/174166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14929
Sample image attached to bug.
TEST=Click the STAR to add a bookmark.
Watch bubble come up. Title is "Bookmark added!"
Confirm fields are OK.
Switch tabs and see bubble go away.
Click STAR again.
Watch bubble come up. Title is "Bookmark"
Make sure all the buttons work (Edit, Close, Remove).
Make sure you can change the title and parent folder.
Make sure "Choose another folder..." opens edit window.
Review URL: http://codereview.chromium.org/171016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
compiled earlier than other WebKit files. DerivedSourcesAllInOne.cpp is huge,
and it is beneficial to begin its compilation first. Given how Xcode
parallelizes, this allows other compilations to continue while the large file
is being built. When DerivedSourcesAllInOne.cpp comes last, it is likely that
nothing else will be available to be compiled at the same time. This is
wasteful.
Review URL: http://codereview.chromium.org/174157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the build.
Review URL: http://codereview.chromium.org/174148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10395
TEST=none
TBR=jparent
Review URL: http://codereview.chromium.org/173150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=16713
TEST=Watch perf. Startup time should be flat or possibly lose a very small
amount (~1%). Everything else should be a little bit faster.
Watch sizes. The .app and .dmg will grow, but I've cut their sizes way
down lately, and I'd like to cash in some of those gains for speed.
Review URL: http://codereview.chromium.org/174160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a range from the cache.
BUG=12258
TEST=unittests
Review URL: http://codereview.chromium.org/174039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The most noteworthy change here is the implementation of SendMouseMove() and SendMouseClick() in ui_controls. I've combed the interwebs and I don't think it's possible to figure out the GdkWindow that is showing for a given (x,y) coordinate pair (except perhaps by delving into X), so we have to just send clicks to wherever the pointer lies. This is unfortunate in that it means we have to move the pointer, wait for it to get where it's going, and only then make the click. But on the bright side there's this super helpful function called gdk_display_warp_pointer() which makes moving the mouse a breeze.
BUG=19076
Review URL: http://codereview.chromium.org/174113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23880 0039d316-1c4b-4281-b951-d872f2087c98
|