summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert 73304 (broke clang/linux) - Use early expansion for debug_optimize ↵thakis@chromium.org2011-02-011-2/+2
| | | | | | | | | | | | | | | | | and release_optimize This fixes a bug when these flags are not overriden from ~/.gyp/include.gypi which is the way they should be set for Valgrind builds (see http://dev.chromium.org/developers/how-tos/using-valgrind ) BUG=70107 TEST=gclient runhooks --force && grep "\-O" base/base.target.mk Review URL: http://codereview.chromium.org/6267004 TBR=timurrrr@chromium.org Review URL: http://codereview.chromium.org/6334026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73329 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutomationProvider RefCountedThreadSafe instead of RefCountedphajdan.jr@chromium.org2011-02-013-4/+14
| | | | | | | | | | | | | | | | We are calling AddRef/Release from multiple threads, and just RefCounted is very dangerous. This change also ensures AutomationProvider is always constructed and destroyed on the same thread: UI. There might be other issues caused by running dtor on the wrong thread. BUG=71066, 71456 TEST=none Review URL: http://codereview.chromium.org/6347065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73328 0039d316-1c4b-4281-b951-d872f2087c98
* - Add ChromeOS login and lock screen automation hooks.dtu@chromium.org2011-02-0112-110/+205
| | | | | | | | | | | | | | - Add AutomationProxy::SendJSONRequest that does not require a handle to a Browser/BrowserProxy. - Fix issue where AutomationProvider thinks it's never finished loading the login screen. - Not included: UI tests for login, since they should be PyAuto tests. - Not included: fix for Chrome quitting as a result of channel disconnect. BUG=chromium-os:11538 TEST=none Review URL: http://codereview.chromium.org/6320022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73327 0039d316-1c4b-4281-b951-d872f2087c98
* Show user list only to owner (settings->users).xiyuan@chromium.org2011-02-011-3/+5
| | | | | | | | | | | | | User list is still visible, but grayed out and empty. Land http://codereview.chromium.org/6250079/ for dgozman@chromium.org. BUG=chromium-os:9078 TEST=Observe empty user list in settings->users for non-owner. Review URL: http://codereview.chromium.org/6368029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73326 0039d316-1c4b-4281-b951-d872f2087c98
* Disable login panel correctly for chromoting client pluginhclam@chromium.org2011-02-011-1/+1
| | | | | | | | | | | TBR=sergeyu BUG=None TEST=None Review URL: http://codereview.chromium.org/6312065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73325 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 73197: Support Mozilla's GUID for ISimpleDOM and add a unit test for it.dmazzoni@chromium.org2011-02-013-13/+88
| | | | | | | | | | | | Original code review: http://codereview.chromium.org/6409025/ BUG=48185 TEST=Adds new test. TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/6386036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73324 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed leak and DCHECK()davemoore@chromium.org2011-02-012-7/+4
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6392028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73322 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 73220 - GpuProcessHost does not relaunch GPU process after threshold ↵apatrick@chromium.org2011-02-011-5/+12
| | | | | | | | | | | | | | | no. of crashes. Also added buckets to histograms to count the number of times the GPU process crashed in a single session. TEST=simulate crashes, try BUG=none Review URL: http://codereview.chromium.org/6343010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73321 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed null dereference in RenderWidget::UpdateAnimationsIfNeeded.apatrick@chromium.org2011-02-011-1/+1
| | | | | | | | | TEST=try, doesn't crash after exiting chrome while viewing WebGL. BUG=none Review URL: http://codereview.chromium.org/6287036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73320 0039d316-1c4b-4281-b951-d872f2087c98
* Release all Object PP_Vars when an instance goes away. This prevents a crashbrettw@chromium.org2011-02-017-90/+226
| | | | | | | | | | | | | | | | | when the instance is deleted but the reference to the var is kept in the ResourceTracker. When the ResourceTracker singleton is cleared on shutdown, the resource will attempt to dereference the invalid PluginInstance and crash. Properly delete the PluginObjects associated with an instance when the instance goes out of scope. A simple error in the PluginInstance made this not happen, and it could potentially dereference PluginObjects for instances that were deleted. BUG=http://crosbug.com/11438 BUG=http://crbug.com/71357 Review URL: http://codereview.chromium.org/6312038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73319 0039d316-1c4b-4281-b951-d872f2087c98
* Copy binary files from src/gfx to src/gfx/ui/sail@chromium.org2011-02-0117-0/+0
| | | | | | | | BUG=71063 TEST=Compiled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73317 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix host parameter in the remote debugger link.pfeldman@chromium.org2011-02-011-1/+1
| | | | | | TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73316 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in BookmarkMenuController::GetTooltipText that occurredsky@chromium.org2011-02-011-0/+5
| | | | | | | | | | | | because we were passing in an id that it wasn't prepared for. This happened if a menu had no children. BUG=71555 TEST=see bug Review URL: http://codereview.chromium.org/6368024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73315 0039d316-1c4b-4281-b951-d872f2087c98
* Add a grit define for enabling third_party translations.tony@chromium.org2011-02-019-52/+93
| | | | | | | | | | | | | Turn it off by default and add conditions to chromium_strings.grd for third_party specific outputs. Add the ability to filter xtb files (translations) using if nodes. TEST=still able to compile chrome Review URL: http://codereview.chromium.org/6392033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73314 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create bg pages if the opener doesn't have a background permission.atwilson@chromium.org2011-02-015-14/+40
| | | | | | | | | | | | Now window.open() returns undefined if the caller is trying to open a background window but does not have the proper permission. BUG=47119 TEST=verify that window.open(url, "name", "background") returns undefined Review URL: http://codereview.chromium.org/6250038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73313 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that desktop notifications display for the background page. This ↵ananta@chromium.org2011-02-012-0/+14
| | | | | | | | | | | | | | | regressed during the isolation of desktop notification IPC handling into an independent object Fixes bug http://code.google.com/p/chromium/issues/detail?id=71251 BUG=71251 TEST=As described in the bug at this point. Review URL: http://codereview.chromium.org/6347059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73312 0039d316-1c4b-4281-b951-d872f2087c98
* Add python tests for chromedriver and small test fixes.kkania@chromium.org2011-02-016-102/+204
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6344018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73311 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply and fix r73019. BalloonViewImpl has a different implemementation onerg@google.com2011-02-017-380/+400
| | | | | | | | | | | | | | | | | | | | | | | | linux_gtk, linux_views, and chromeos, but everyone uses the same class name. sizeof(linux_views BVI) > sizeof(linux_gtk BVI). Previously, the GTK version allocated on object of linux_views BVI, and just had some uninitialized memory at the end. Switching these around by changing the includes, the linux_views implementation wrote past the sizeof the linux_gtk BVI. Fix by #ifdefing on TOOLKIT. Fix style problems in the Balloon implementation on linux in preparation for turning on chrome-style bot. - Rename file that had all BalloonCollectionImpl code from balloon_collection.cc to balloon_collection_impl.cc so I could add a real balloon_collection.cc for deinlining. - GTK implementation files shouldn't depend on views/ code. BUG=none TEST=compiles Original Review URL: http://codereview.chromium.org/6400006 Review URL: http://codereview.chromium.org/6260040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73310 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all history tests as flaky. They no longer time out or crash, but ↵skerner@chromium.org2011-02-011-2/+4
| | | | | | | | | | | | | still fail flakily. TBR=motownavi BUG=none TEST=ExtensionHistoryApiTest.* Review URL: http://codereview.chromium.org/6246026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73309 0039d316-1c4b-4281-b951-d872f2087c98
* Created test case for posting a form 1000 times to test autofill crowd ↵dyu@chromium.org2011-02-014-0/+55
| | | | | | | | | | source feature. BUG=none TEST=none Review URL: http://codereview.chromium.org/6368020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73294 - Move find-in-page from TabContents to TabContentsWrapper.davemoore@chromium.org2011-02-0131-553/+349
| | | | | | | | | | | | BUG=71097 TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6378014 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6286019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73307 0039d316-1c4b-4281-b951-d872f2087c98
* Update GetWebKitRootDirFilePath to handle the move of WebKit/ into Source/.mihaip@chromium.org2011-02-011-3/+4
| | | | | | | | BUG=none TEST=layout tests Review URL: http://codereview.chromium.org/6334024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73306 0039d316-1c4b-4281-b951-d872f2087c98
* Removed icon from View Background Pages menu item in wrench menu.atwilson@chromium.org2011-02-014-23/+0
| | | | | | | | | BUG=71489 TEST=Install extension with background page, pull up wrench menu, see no icon next to View Background Pages item. Review URL: http://codereview.chromium.org/6347062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73305 0039d316-1c4b-4281-b951-d872f2087c98
* Use early expansion for debug_optimize and release_optimizetimurrrr@chromium.org2011-02-011-2/+2
| | | | | | | | | | | | This fixes a bug when these flags are not overriden from ~/.gyp/include.gypi which is the way they should be set for Valgrind builds (see http://dev.chromium.org/developers/how-tos/using-valgrind ) BUG=70107 TEST=gclient runhooks --force && grep "\-O" base/base.target.mk Review URL: http://codereview.chromium.org/6267004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73304 0039d316-1c4b-4281-b951-d872f2087c98
* Add some logging to pyauto downloads test testNoUnsafeDownloadsOnRestart.rdsmith@chromium.org2011-02-011-1/+7
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6303020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73303 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore memory accesses below mbsrtowcs under ThreadSanitizertimurrrr@chromium.org2011-02-011-0/+3
| | | | | | | | | BUG=71435 TEST=TSan/UI bots should become greener TBR=glider Review URL: http://codereview.chromium.org/6312060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73302 0039d316-1c4b-4281-b951-d872f2087c98
* Check for NULL view before passing plugin focus and IME messagesstuartmorgan@chromium.org2011-02-011-2/+4
| | | | | | | | | | | If the host has been destroyed, focus tracking is no longer relevent, so the messages can be safely discarded. BUG=71550 TEST=None Review URL: http://codereview.chromium.org/6286017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and refactor for ProxyLauncher browser disconnect.dtu@chromium.org2011-02-017-33/+65
| | | | | | | | | | | In ProxyLauncher, the new TerminateConnection() function is paired with InitializeConnection(). shutdown_type_ moved from UITestBase to ProxyLauncher, since that's the only place it's used. BUG=chromium-os:8514 TEST=none Review URL: http://codereview.chromium.org/6248022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73300 0039d316-1c4b-4281-b951-d872f2087c98
* Small "fix" to make window deallocation similar to window allocation.backer@chromium.org2011-02-011-7/+9
| | | | | | | | | | | | r72998 fixed a regression in how windows were allocated for the GPU process. This patch applies a similar fix for window deallocation. BUG=none TEST=none Review URL: http://codereview.chromium.org/6334023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73299 0039d316-1c4b-4281-b951-d872f2087c98
* Another Windows TTS fix; handle the case where we call GetStatus while it's ↵dmazzoni@chromium.org2011-02-011-2/+6
| | | | | | | | | | | | still waiting to speak. BUG=none TEST=manual testing, trybots Review URL: http://codereview.chromium.org/6409025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73298 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Allow +suffix in email addresescmasone@chromium.org2011-02-012-9/+4
| | | | | | | | | BUG=chromium-os:11141 TEST=unit tests, install and log in to device with an account that has + and a suffix Review URL: http://codereview.chromium.org/6392025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73297 0039d316-1c4b-4281-b951-d872f2087c98
* The CEEE project is now deprecated.mad@chromium.org2011-02-01342-69135/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6386038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73296 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure we don't copy over the default suggest text ifsky@chromium.org2011-02-015-12/+49
| | | | | | | | | | | leading/trailing whitespace is added. BUG=69752 TEST=see bug, covered by unit test as well Review URL: http://codereview.chromium.org/6250060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73295 0039d316-1c4b-4281-b951-d872f2087c98
* Move find-in-page from TabContents to TabContentsWrapper.avi@chromium.org2011-02-0131-349/+553
| | | | | | | | | BUG=71097 TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6378014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73294 0039d316-1c4b-4281-b951-d872f2087c98
* Split history tests into parts that run in under 6 seconds.skerner@chromium.org2011-02-0114-526/+576
| | | | | | | | | | | I don't see how the failures listed in the bug can happen. Because the logs are old, reenabling the tests to see if the failures re-occur. BUG=26296 TEST=ExtensionHistoryApiTest.* Review URL: http://codereview.chromium.org/6260050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73293 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 77243:77251yurys@chromium.org2011-02-011-1/+1
| | | | | | | | | | TBR=dglazkov BUG= TEST= Review URL: http://codereview.chromium.org/6286015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73291 0039d316-1c4b-4281-b951-d872f2087c98
* Test NamedInterfaceTest.BasicNamedInterface hangs on Mac Valgrinddhollowa@chromium.org2011-02-011-0/+4
| | | | | | | | | | | | | | | | Disables NamedInterfaceTest.BasicNamedInterface on Mac. As of revision r73124, this test started failing on "Chromium Mac UI (Valgrind)(4)". http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20UI%20%28valgrind%29%284%29/builds/1384/steps/memory%20test%3A%20ui/logs/stdio BUG=56090 TEST=Chromium Mac UI (Valgrind)(4) memory bot goes green TBR=dtu@chromium.org Review URL: http://codereview.chromium.org/6368021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73289 0039d316-1c4b-4281-b951-d872f2087c98
* Enable and implement account creation through Guest mode.avayvod@chromium.org2011-02-017-12/+41
| | | | | | | | | BUG=chromiumos:2226 TEST=Verify that Create Account link is on new user pod and opens account creation page in Guest mode. Review URL: http://codereview.chromium.org/6409015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73288 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserTest to make sure plugins aren't loaded on prerendered pagesmmenke@chromium.org2011-02-013-4/+42
| | | | | | | | | | | | | until the pages are loaded into a TabContents. Also a little PrerenderBrowserTest cleanup. BUG=71216 TEST=PrerenderBrowserTest.PrerenderDelayLoadPlugin Review URL: http://codereview.chromium.org/6409023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73287 0039d316-1c4b-4281-b951-d872f2087c98
* Adds basic error text for all errors with a 1% or greatermmenke@chromium.org2011-02-012-2/+71
| | | | | | | | | | | | | | | frequency on the dev channel build. The text for most of the errors isn't terribly useful, but the default "Unkown Error" is a little embarrassing. Also nice to get the error descriptions internationalized. BUG=55726 TEST=none Review URL: http://codereview.chromium.org/6392030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73286 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents::OnStartDownload crash.pfeldman@chromium.org2011-02-012-1/+13
| | | | | | | | | BUG=68522 TEST= Review URL: http://codereview.chromium.org/6260061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73285 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Use background window as a parent window for OOBE dialogs.nkostylev@chromium.org2011-02-016-20/+23
| | | | | | | | | BUG=chromium-os:11322 TEST=Manual. Review URL: http://codereview.chromium.org/6409043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73284 0039d316-1c4b-4281-b951-d872f2087c98
* Improved the way managed settings are shown in the DOMUI settings windows.pastarmovj@chromium.org2011-02-012-12/+32
| | | | | | | | | | | | There is now separate banner for every window and the banner is being shown always when there is some managed controls on the page. BUG=69259 TEST=Enable/disable a policy and observe if a banner appears/disappears on the respective DOMUI settings page. Review URL: http://codereview.chromium.org/6170007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73282 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 77227:77243yurys@chromium.org2011-02-011-1/+1
| | | | | | | | | | TBR=dglazkov BUG= TEST= Review URL: http://codereview.chromium.org/6260060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73281 0039d316-1c4b-4281-b951-d872f2087c98
* Introduced a new policy DefaultBrowserSettingEnabled.pastarmovj@chromium.org2011-02-0119-31/+164
| | | | | | | | | | | | | | When set it either enforces Chrome's registration as default browser, or prevents the user from seeing the reminder about Chrome not being default as well as disabled the UI for setting it as default browser. When not set the old behavior is observed. BUG=65290 TEST=Manual. Set the policy and the UI should be disabled. If set to true the browser should become default browser immediately. Review URL: http://codereview.chromium.org/6348021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73280 0039d316-1c4b-4281-b951-d872f2087c98
* Add ContentSettingsProvider Interface.markusheintz@chromium.org2011-02-012-2/+99
| | | | | | | | | BUG=63656 TEST=TBA Review URL: http://codereview.chromium.org/6253012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73279 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Change "Can't access your account" help link text to "Learn more".nkostylev@chromium.org2011-02-011-3/+2
| | | | | | | | | BUG=chromium-os:9045 TEST=N/A Review URL: http://codereview.chromium.org/6250047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73278 0039d316-1c4b-4281-b951-d872f2087c98
* Remove temporary layout test expecations. New baselines have landed inager@chromium.org2011-02-011-8/+0
| | | | | | | | WebKit. Review URL: http://codereview.chromium.org/6409041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73277 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of more examples from header to source file.tfarina@chromium.org2011-02-0110-299/+419
| | | | | | | | | BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6347030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73276 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB: CursorDispathcerHost::OnUpdate should use ↵hans@chromium.org2011-02-011-2/+1
| | | | | | | | | | | | | | | IndexedDBCallbacks<WebIDBKey> The result of the update operation is a key. This is a preparatory patch for implementing cursor updates. BUG=64052 TEST=none Review URL: http://codereview.chromium.org/6287017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73273 0039d316-1c4b-4281-b951-d872f2087c98