| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and release_optimize
This fixes a bug when these flags are not overriden from ~/.gyp/include.gypi
which is the way they should be set for Valgrind builds
(see http://dev.chromium.org/developers/how-tos/using-valgrind )
BUG=70107
TEST=gclient runhooks --force && grep "\-O" base/base.target.mk
Review URL: http://codereview.chromium.org/6267004
TBR=timurrrr@chromium.org
Review URL: http://codereview.chromium.org/6334026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are calling AddRef/Release from multiple threads, and just
RefCounted is very dangerous.
This change also ensures AutomationProvider is always
constructed and destroyed on the same thread: UI.
There might be other issues caused by running dtor
on the wrong thread.
BUG=71066, 71456
TEST=none
Review URL: http://codereview.chromium.org/6347065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add AutomationProxy::SendJSONRequest that does not require a handle to a Browser/BrowserProxy.
- Fix issue where AutomationProvider thinks it's never finished loading the login screen.
- Not included: UI tests for login, since they should be PyAuto tests.
- Not included: fix for Chrome quitting as a result of channel disconnect.
BUG=chromium-os:11538
TEST=none
Review URL: http://codereview.chromium.org/6320022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
User list is still visible, but grayed out and empty.
Land http://codereview.chromium.org/6250079/ for dgozman@chromium.org.
BUG=chromium-os:9078
TEST=Observe empty user list in settings->users for non-owner.
Review URL: http://codereview.chromium.org/6368029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sergeyu
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6312065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/6409025/
BUG=48185
TEST=Adds new test.
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/6386036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6392028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
no. of crashes.
Also added buckets to histograms to count the number of times the GPU process crashed in a single session.
TEST=simulate crashes, try
BUG=none
Review URL: http://codereview.chromium.org/6343010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=try, doesn't crash after exiting chrome while viewing WebGL.
BUG=none
Review URL: http://codereview.chromium.org/6287036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the instance is deleted but the reference to the var is kept in the
ResourceTracker. When the ResourceTracker singleton is cleared on shutdown,
the resource will attempt to dereference the invalid PluginInstance and crash.
Properly delete the PluginObjects associated with an instance when the instance
goes out of scope. A simple error in the PluginInstance made this not happen,
and it could potentially dereference PluginObjects for instances that were
deleted.
BUG=http://crosbug.com/11438
BUG=http://crbug.com/71357
Review URL: http://codereview.chromium.org/6312038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=Compiled.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because we were passing in an id that it wasn't prepared for. This
happened if a menu had no children.
BUG=71555
TEST=see bug
Review URL: http://codereview.chromium.org/6368024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn it off by default and add conditions to chromium_strings.grd
for third_party specific outputs.
Add the ability to filter xtb files (translations) using if nodes.
TEST=still able to compile chrome
Review URL: http://codereview.chromium.org/6392033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now window.open() returns undefined if the caller is trying to open a background
window but does not have the proper permission.
BUG=47119
TEST=verify that window.open(url, "name", "background") returns undefined
Review URL: http://codereview.chromium.org/6250038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regressed during
the isolation of desktop notification IPC handling into an independent object
Fixes bug http://code.google.com/p/chromium/issues/detail?id=71251
BUG=71251
TEST=As described in the bug at this point.
Review URL: http://codereview.chromium.org/6347059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6344018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux_gtk, linux_views, and chromeos, but everyone uses the same class
name. sizeof(linux_views BVI) > sizeof(linux_gtk BVI). Previously, the GTK
version allocated on object of linux_views BVI, and just had some uninitialized
memory at the end. Switching these around by changing the includes, the
linux_views implementation wrote past the sizeof the linux_gtk BVI. Fix by #ifdefing on TOOLKIT.
Fix style problems in the Balloon implementation on linux in preparation for
turning on chrome-style bot.
- Rename file that had all BalloonCollectionImpl code from
balloon_collection.cc to balloon_collection_impl.cc so I could add a real
balloon_collection.cc for deinlining.
- GTK implementation files shouldn't depend on views/ code.
BUG=none
TEST=compiles
Original Review URL: http://codereview.chromium.org/6400006
Review URL: http://codereview.chromium.org/6260040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
still fail flakily.
TBR=motownavi
BUG=none
TEST=ExtensionHistoryApiTest.*
Review URL: http://codereview.chromium.org/6246026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
source feature.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6368020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change.
Review URL: http://codereview.chromium.org/6378014
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6286019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=layout tests
Review URL: http://codereview.chromium.org/6334024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71489
TEST=Install extension with background page, pull up wrench menu, see no icon next to View Background Pages item.
Review URL: http://codereview.chromium.org/6347062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug when these flags are not overriden from ~/.gyp/include.gypi
which is the way they should be set for Valgrind builds
(see http://dev.chromium.org/developers/how-tos/using-valgrind )
BUG=70107
TEST=gclient runhooks --force && grep "\-O" base/base.target.mk
Review URL: http://codereview.chromium.org/6267004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6303020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71435
TEST=TSan/UI bots should become greener
TBR=glider
Review URL: http://codereview.chromium.org/6312060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the host has been destroyed, focus tracking is no longer relevent, so the messages can be safely discarded.
BUG=71550
TEST=None
Review URL: http://codereview.chromium.org/6286017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In ProxyLauncher, the new TerminateConnection() function is paired with InitializeConnection(). shutdown_type_ moved from UITestBase to ProxyLauncher, since that's the only place it's used.
BUG=chromium-os:8514
TEST=none
Review URL: http://codereview.chromium.org/6248022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r72998 fixed a regression in how windows were allocated for the GPU process.
This patch applies a similar fix for window deallocation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6334023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
still waiting to speak.
BUG=none
TEST=manual testing, trybots
Review URL: http://codereview.chromium.org/6409025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11141
TEST=unit tests, install and log in to device with an account that has + and a suffix
Review URL: http://codereview.chromium.org/6392025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6386038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
leading/trailing whitespace is added.
BUG=69752
TEST=see bug, covered by unit test as well
Review URL: http://codereview.chromium.org/6250060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change.
Review URL: http://codereview.chromium.org/6378014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I don't see how the failures listed in the bug can happen. Because the logs are old, reenabling the tests to see if the failures re-occur.
BUG=26296
TEST=ExtensionHistoryApiTest.*
Review URL: http://codereview.chromium.org/6260050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=
TEST=
Review URL: http://codereview.chromium.org/6286015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disables NamedInterfaceTest.BasicNamedInterface on Mac.
As of revision r73124, this test started failing on "Chromium Mac UI (Valgrind)(4)".
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20UI%20%28valgrind%29%284%29/builds/1384/steps/memory%20test%3A%20ui/logs/stdio
BUG=56090
TEST=Chromium Mac UI (Valgrind)(4) memory bot goes green
TBR=dtu@chromium.org
Review URL: http://codereview.chromium.org/6368021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:2226
TEST=Verify that Create Account link is on new user pod and opens account creation page in Guest mode.
Review URL: http://codereview.chromium.org/6409015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
until the pages are loaded into a TabContents.
Also a little PrerenderBrowserTest cleanup.
BUG=71216
TEST=PrerenderBrowserTest.PrerenderDelayLoadPlugin
Review URL: http://codereview.chromium.org/6409023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
frequency on the dev channel build.
The text for most of the errors isn't terribly useful,
but the default "Unkown Error" is a little embarrassing.
Also nice to get the error descriptions internationalized.
BUG=55726
TEST=none
Review URL: http://codereview.chromium.org/6392030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68522
TEST=
Review URL: http://codereview.chromium.org/6260061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11322
TEST=Manual.
Review URL: http://codereview.chromium.org/6409043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is now separate banner for every window and the banner is being shown
always when there is some managed controls on the page.
BUG=69259
TEST=Enable/disable a policy and observe if a banner appears/disappears on the respective DOMUI settings page.
Review URL: http://codereview.chromium.org/6170007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=
TEST=
Review URL: http://codereview.chromium.org/6260060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When set it either enforces Chrome's registration as default browser,
or prevents the user from seeing the reminder about Chrome not being default
as well as disabled the UI for setting it as default browser. When not set
the old behavior is observed.
BUG=65290
TEST=Manual. Set the policy and the UI should be disabled. If set to true the browser should become default browser immediately.
Review URL: http://codereview.chromium.org/6348021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63656
TEST=TBA
Review URL: http://codereview.chromium.org/6253012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9045
TEST=N/A
Review URL: http://codereview.chromium.org/6250047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
WebKit.
Review URL: http://codereview.chromium.org/6409041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run out/Debug/views_examples, everything should works as before.
Review URL: http://codereview.chromium.org/6347030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IndexedDBCallbacks<WebIDBKey>
The result of the update operation is a key.
This is a preparatory patch for implementing cursor updates.
BUG=64052
TEST=none
Review URL: http://codereview.chromium.org/6287017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73273 0039d316-1c4b-4281-b951-d872f2087c98
|