| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14395
Review URL: http://codereview.chromium.org/131017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Broke purify and mac valgrind. "Pull Extension-related prefs into its own class. Also add a notification for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none"
Review URL: http://codereview.chromium.org/132008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This breaks the dependency between ClientSocketPoolBase and the specific ConnectingSocket.
The derived class of ClientSocketPool passes in a ConnectingSocketFactory to ClientSocketPoolBase.
BUG=http://crbug.com/13289
Review URL: http://codereview.chromium.org/125282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Relands r18641, original code review: http://codereview.chromium.org/125268
Expect a crash on Windows.
The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1.
Review URL: http://codereview.chromium.org/131007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No visible changes yet
Review URL: http://codereview.chromium.org/131010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'll be needing in some pending WebKit changes.
http://codereview.chromium.org/131006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a command-line switch.
BUG=4938
Review URL: http://codereview.chromium.org/131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It worked for me :-)
Review URL: http://codereview.chromium.org/126255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A guess at fixing a crash seen by users.
BUG=14483
Review URL: http://codereview.chromium.org/132001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=gclient runhooks --force completes successfully.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13326
Review URL: http://codereview.chromium.org/126307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser/views/tab_contents/tab_contents_view_gtk.cc implements sizing in a similar fashion to windows - i.e. when the GtkWidget is resized, it tells the RenderViewHost that it was sized, which causes the RVH to resize the view. A check for if (parent_) in the Gtk RenderWidgetHostView impl was preventing this sizing from occurring.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
A full chromebot run on 189.0 revealed them getting out of sync, so this should reveal where they get out of sync.
BUG=http://crbug.com/14395.
Review URL: http://codereview.chromium.org/125276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
SimpleDataSource might be stopped before StartTask is called,
so handle this case.
Review URL: http://codereview.chromium.org/125278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
click context menu.
After I spent more time investigating, it seems that when the popup menu closes, it always returns focus to the toplevel that previously had it. Thus we don't have to worry about some other toplevel getting focus without us getting another focus-out.
BUG=13554
TEST=right click spellcheck correction works in gmail
Review URL: http://codereview.chromium.org/126301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use cross-platform method to get the NativeWindow.
BUG=13326
Review URL: http://codereview.chromium.org/126302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
texture-set-test
Review URL: http://codereview.chromium.org/125281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code change here is to compensate for
http://trac.webkit.org/changeset/44758
which changed how to get to theme().
BUG=None
TEST=Possible (but unlikely) whitespace changes in the autocomplete popup menu.
Review URL: http://codereview.chromium.org/128003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=nirnimesh
Review URL: http://codereview.chromium.org/126212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Loading media*.png for <video> and <audio>
Review URL: http://codereview.chromium.org/125277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none
Review URL: http://codereview.chromium.org/126281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=everything behaves the same, and you don't sad tab when resizing a very large autocomplete popup
BUG=13805
Review URL: http://codereview.chromium.org/125274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This script was trying to only rebuild the symbols when the binary
file was more recent than the symbols file. However, -nt fails when
the right hand side doesn't exist. Therefore it wouldn't actually dump
symbols and the sed script would fail later on.
This adds a test for the non-existance of the output file first.
TBR=mmoss
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/126288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AdditionalManifestFiles of setup.exe and mini_installer.exe.
BUG=14439
TEST=none
Review URL: http://codereview.chromium.org/125273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14006
A first pass at the DOM Storage V8 bindings. Android needs these ASAP and Chromium will need them soon. I've created my own test suite which I will be converting into layout tests over time and used this to manually test on a slightly hacked up version of Chromium running with --single-process. Before these changes are compiled into Chrome by default, I will add tests.
I've taken the GYP and webview_impl out of this patch since we don't want it to be compiled in by default yet.
Review URL: http://codereview.chromium.org/125035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Copy in the "First Run" file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wired up yet, but will be shortly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/13907
TEST=some media layout tests might start passing
Review URL: http://codereview.chromium.org/125229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new tab on the left edge of the strip. We don't have this bug on
windows because the tab strip isn't painted until after the animation
progresses.
BUG=none
TEST=on linux create new tabs by way of control-t (or plus button),
make sure you don't get the new tab to momentarily appear on the
left edge.
Review URL: http://codereview.chromium.org/126240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=joi
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/125270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Broke ui_tests.
Review URL: http://codereview.chromium.org/125268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
goes away.
Combine the various ExtensionMessageService IPC message into a single "Invoke"
message.
BUG=12686
TEST=no
Review URL: http://codereview.chromium.org/126234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/126284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Splits out the code that was in chrome/browser/views/page_info_window.{cc,h}
into a platform-independent class PageInfoWindow in
chrome/browser/page_info_window.{cc,h}
- The Windows implementation now lives in
chrome/browser/views/page_info_window_win.{cc,h}
- Created a Mac implemenation PageInfoWindowMac in
chrome/browser/cocoa/page_info_window_mac.{h,mm} to bridge to a Cocoa
NSWindowController
- Created a new NSWindowController subclass PageInfoWindowController that is in
chrome/browser/cocoa/page_info_window_controller.{h,mm}
- Created a XIB for the page info window in
chrome/app/nibs/en.lproj/PageInfo.xib
Patch by Robert Sesek <rsesek@bluestatic.org>
Review URL: http://codereview.chromium.org/115116
Review URL: http://codereview.chromium.org/125266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
don't seem to have a need for having the name and the tooltip be separate.
Review URL: http://codereview.chromium.org/125264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add support for zygotes to call DidProcessCrash on renderers.
TEST=metrics_server_uitest.cc
Review URL: http://codereview.chromium.org/126264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds the inactive user toast logic
- Some refactoring of helper functions
BUG=b/1484308
TEST=see the bug
Review URL: http://codereview.chromium.org/125234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/128002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
BUG=13907
These three tests should now pass:
LayoutTests/media/video-src-plus-source.html
LayoutTests/media/video-src-invalid-remove.html
LayoutTests/media/video-load-networkState.html
Review URL: http://codereview.chromium.org/125263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Preparation for adding GTK implementation.
BUG=13326
TEST=Edit existing search engine, add new search engine, add engine by clicking on OpenSearch description file.
Review URL: http://codereview.chromium.org/125161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Spawn PS to collect the data and parse the output.
Add ifdef checks in the page cyclers so on mac we can use the other helper since base methods can't ever be made to work.
BUG=none
TEST=memory info should now show in the waterfall and on the perf graphs for the page cycler tests.
Review URL: http://codereview.chromium.org/125254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
This patch resolve failures for:
LayoutTests/media/video-src-plus-source.html
LayoutTests/media/video-src-invalid-remove.html
LayoutTests/media/video-load-networkState.html
Review URL: http://codereview.chromium.org/125226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
compressed setup.exe size by another 10-20%.
BUG=none
TEST=Make sure mini_installer stills installs Chromium
Review URL: http://codereview.chromium.org/126233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make it a const method too.
Review URL: http://codereview.chromium.org/126282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
built before it tries to run test_shell_tests or the layout tests.
Review URL: http://codereview.chromium.org/125228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This applies only to things which use TimeDelta::InMilliseconds, because
it returns int64. Before this patch callers static_casted that to int,
and after this patch they use the returned value as int64.
Review URL: http://codereview.chromium.org/126279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
|