summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-0385-146/+267
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* Uses POINT instead of CPoint to reduce the dependency in ATL.scherkus@chromium.org2009-09-038-15/+11
| | | | | | | | | | | | | Patch submitted by Thiago Farina: http://codereview.chromium.org/188017 BUG= http://crbug.com/2185 TEST=None Review URL: http://codereview.chromium.org/199009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25365 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make the Page/Wrench buttons place their menu in the right place.viettrungluu@chromium.org2009-09-039-761/+403
| | | | | | | | | | | | | | | | | | | | | | Also makes the buttons drag-able -- you can drag or click and wait to open their menu. Lucky for me, I wrote reusable code. To do (not now): The "off-the-end" button on the bookmark bar needs the same fix. Bug (not to be fixed now): The menu doesn't do the right thing when the window is moved off the left edge to the screen -- it doesn't open to the right in the correct fashion. Nor does it do the proper thing when you move the window off the bottom edge of the screen -- it doesn't open upwards entirely correctly. <shrug> BUG=18572 TEST=Click on the Page and Wrench menu buttons and observe. Also test \ dragging to open. Review URL: http://codereview.chromium.org/174556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25362 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme cache corruption.mirandac@chromium.org2009-09-032-34/+42
| | | | | | | | | BUG= http://crbug.com/20957 TEST= Install many themes quickly, with many windows open. Close browser and reopen. Theme should not be corrupted. Review URL: http://codereview.chromium.org/197010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25359 0039d316-1c4b-4281-b951-d872f2087c98
* Display the LoadLogs for recent and in-progress URLRequests on the ↵eroman@chromium.org2009-09-032-5/+66
| | | | | | | | | | net-internals page. BUG=http://crbug.com/14478 Review URL: http://codereview.chromium.org/184008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25358 0039d316-1c4b-4281-b951-d872f2087c98
* Add "other bookmarks" to bookmark menu.jrg@chromium.org2009-09-033-31/+93
| | | | | | | | | | | | | | | | | BUG=http://crbug.com/18734 TEST=Launch Chrome. Add some bookmarks then open the bookmark menu. You should see all "bookmark bar" bookmarks, followed by a separator line, followed by an "Other bookmarks" submenu at the end. Go to a bookmark then click on STAR. Change folder to "other bookmarks". Now open bookmark menu; see item moved from "main page" to the "other bookmarks" folder at the end. Undo that change by clicking on STAR, changing parent. Make sure back to normal. Review URL: http://codereview.chromium.org/195001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25357 0039d316-1c4b-4281-b951-d872f2087c98
* Properly show/hide "off the side" button/menu (chevron) on bookmark bar as ↵jrg@chromium.org2009-09-033-17/+12
| | | | | | | | | | | | | | | | | | | needed. BUG=http://crbug.com/17852 TEST=delete all bookmarks. No chevron. Add one bookmark to bookmark bar. No chevron. Make window real wide. Add some more bookmarks (but not enough that it spills over). No chevron. Make window thinner. Chevron appears! Widen window until chevron hides. Add more bookmarks until it appears again. Review URL: http://codereview.chromium.org/201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25356 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tool updatevictorw@chromium.org2009-09-036-30/+245
| | | | | | | | | | | | | | | | | - Do not add unnecessary baselines Check whether a baseline is duplicate and can fallback to same baseline for another platform. For example, if a test has same baseline on linux and windows, then we only store windows baseline and linux baseline will fallback to the windows version. - Set new baseline svn property. TEST=rebaseline tool BUG=18906 Review URL: http://codereview.chromium.org/174567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25355 0039d316-1c4b-4281-b951-d872f2087c98
* Update to valgrind-3.5.0. From timur, http://codereview.chromium.org/190008dkegel@google.com2009-09-037-80/+89
| | | | | | | | | | Also use it if present. Especially use its new xml suppression record if present, which is more correct than the one we synthesize. Also fix a warning about global use before declare in memcheck_analyze.py. Review URL: http://codereview.chromium.org/191006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25353 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a Mac suppression, add two one-offs from Linux.stuartmorgan@google.com2009-09-032-4/+11
| | | | | | | | | BUG=21010 TEST=Happier valgrind bots Review URL: http://codereview.chromium.org/201006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25352 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disable Omnibox editing in popup windows.shess@chromium.org2009-09-031-2/+2
| | | | | | | | | | | http://crbug.com/20243 TEST=Go to www.popuptest.com. Select test #2, allow one of the popups through. Try to edit in the omnibox. Should be able to select and copy, but not enter text. Review URL: http://codereview.chromium.org/183043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix messy includes in media\player.maruel@chromium.org2009-09-0313-149/+68
| | | | | | | | | | This should never have been checked-in as-is. TEST=still compiles BUG=none Review URL: http://codereview.chromium.org/193007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25350 0039d316-1c4b-4281-b951-d872f2087c98
* Exracted CommandBuffer class from GPUPluginObject.apatrick@google.com2009-09-039-120/+314
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25348 0039d316-1c4b-4281-b951-d872f2087c98
* Drop new strings (copied over all existing files, so what you see in this CL ↵laforge@chromium.org2009-09-0352-29/+845
| | | | | | | | is what has changed). Review URL: http://codereview.chromium.org/196005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25347 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make I-beam cursor match editing area.shess@chromium.org2009-09-033-2/+22
| | | | | | | | | | | | Due to our tweaking of the text area, the I-beam cursor was sometimes janky. http://crbug.com/20238 TEST=I don't even know how to really test this. Review URL: http://codereview.chromium.org/181011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25346 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a WONTFIX line from test_expectations now that we skip running tests ↵michaeln@google.com2009-09-031-6/+0
| | | | | | | | | | | in 'script-tests' directories. TBR=hamaji BUG=20908 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25345 0039d316-1c4b-4281-b951-d872f2087c98
* Skip running layout tests contained in 'script-tests' directories too.michaeln@google.com2009-09-031-1/+1
| | | | | | | | | BUG=20908 TEST=none Review URL: http://codereview.chromium.org/187017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25344 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Initialize the focus ring color preference values. This fixes an UMR ↵jhawkins@chromium.org2009-09-032-12/+3
| | | | | | | | | | when running the RenderView unit tests. The tests create a RenderView object using the default constructor of RendererPreferences. The uninitialized values are then passed through to WebKit to set the focus ring color. BUG=20964 TEST=Covered by valgrinding unit tests. Review URL: http://codereview.chromium.org/194009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25343 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete comment about a test being disabled.asargent@chromium.org2009-09-031-1/+0
| | | | | | | | | BUG=16106 TEST=none Review URL: http://codereview.chromium.org/176016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25341 0039d316-1c4b-4281-b951-d872f2087c98
* Add functions to alpha-blend two colors and pick the more readable of two ↵pkasting@chromium.org2009-09-032-4/+50
| | | | | | | | | | | | colors. These will be used to make the UI more readable on non-default themes. Also removes a function that no one was calling. BUG=92, 18367 TEST=none Review URL: http://codereview.chromium.org/190001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25340 0039d316-1c4b-4281-b951-d872f2087c98
* Change Mac O3D executable name (the actual name of the binary inside the ↵maf@google.com2009-09-032-15/+15
| | | | | | | | | | bundle) to O3D, not o3d. This matches the name it gets in the GYP build and enabled them to share an Info.plist file (also changed in this CL in the same way). Add include dir for the Breakpad header to scons, so it can cope with us #including "Breakpad.h" as required by the GYP build, rather than <Breakpad/Breakpad.h>. Review URL: http://codereview.chromium.org/200002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25339 0039d316-1c4b-4281-b951-d872f2087c98
* A couple comment changes -- update an out of date comment and add a note ↵pkasting@chromium.org2009-09-032-2/+7
| | | | | | | | | | about some awful behavior that dates back to the earliest days. BUG=none TEST=none Review URL: http://codereview.chromium.org/185002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25338 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks for bug 20703asargent@chromium.org2009-09-031-0/+11
| | | | | | | | BUG=http://crbug.com/20703 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25337 0039d316-1c4b-4281-b951-d872f2087c98
* Make the omnibox 2 hover code a tiny bit less goofy by removing a now-unused ↵pkasting@chromium.org2009-09-037-37/+20
| | | | | | | | | | | | function (although it may have to come back eventually) and using the Model's conception of hover state instead of direct hot-tracking in the view. Unfortunately, there are still problems, including bogus mousemove events for the same point and no WM_MOUSELEAVE events, all of which the old code handled. I think fixing this is going to require implementing a TODO in the code to hoist mouse handling to the main dropdown view, at which point I can probably address issue 13703 as well. BUG=13279 TEST=none Review URL: http://codereview.chromium.org/187002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25336 0039d316-1c4b-4281-b951-d872f2087c98
* Correct Windows baselines for:jparent@chromium.org2009-09-037-5/+3
| | | | | | | | | | | | | | | LayoutTests\editing\pasteboard\paste-blockquote-after-blockquote.html LayoutTests\editing\pasteboard\paste-blockquote-into-blockquote-3.html LayoutTests\editing\deleting\delete-br-013.html This is the follow up to http://codereview.chromium.org/190019 where the incorrect baselines were removed. TEST=layout test try servers BUG=20933 Review URL: http://codereview.chromium.org/195005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25335 0039d316-1c4b-4281-b951-d872f2087c98
* Do not permit a seek to a negative position. This was already an errorcevans@chromium.org2009-09-032-1/+5
| | | | | | | | | | | | | | | condition (in the FFmpeg glue code) but the position would be left set to negative. If the API consumer ignored the error code for the seek and then attempted a read, that might be a bad state. I am fixing this to avoid any risk of this upsetting the stream read code. FFmpeg would seem to commit this sort of API abuse. BUG=NONE TEST=FFmpegDemuxerTest.ProtocolGetSetPosition Review URL: http://codereview.chromium.org/201002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25334 0039d316-1c4b-4281-b951-d872f2087c98
* Make Convertor project compile in GCC - fixes release-build only compiler ↵maf@google.com2009-09-032-219/+219
| | | | | | | | errors. Review URL: http://codereview.chromium.org/197003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25333 0039d316-1c4b-4281-b951-d872f2087c98
* Fix other things blocking the Mac GYP release build from completing.maf@google.com2009-09-032-1/+5
| | | | | | Review URL: http://codereview.chromium.org/194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25332 0039d316-1c4b-4281-b951-d872f2087c98
* Print a backtrace when a test binary crashes.phajdan.jr@chromium.org2009-09-031-0/+14
| | | | | | | | | | | For now only for POSIX, Windows to follow very soon. TEST=none http://crbug.com/20996 Review URL: http://codereview.chromium.org/200004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25330 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-0317-93/+236
| | | | | | | | | | | | privileges to the new"" Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed. BUG=17636 Review URL: http://codereview.chromium.org/172120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25329 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes a SSL related message non Window specific.jcampan@chromium.org2009-09-031-1/+1
| | | | | | | | BUG=http://crbug.com/20938 TEST=Visit https://alioth.debian.org/ A warning page is shown. Click the 'Help me understand' link. The text shown should not mention Windows. Review URL: http://codereview.chromium.org/192002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25328 0039d316-1c4b-4281-b951-d872f2087c98
* Another suppression for Mac UI Valgrindstuartmorgan@google.com2009-09-031-0/+7
| | | | | | | | | BUG=20997 TEST=Mac UI valgrind bots may actually go green Review URL: http://codereview.chromium.org/201004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25326 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Workaround Skia and Pango measuring font heights differently by ↵evan@chromium.org2009-09-032-25/+4
| | | | | | | | | asking Pango" This reverts commit r25131. It seems to have regressed Linux startup; will track perf builder after committing this to be sure. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25325 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit revision 48020.victorw@chromium.org2009-09-032-1/+9
| | | | | | | | | | | | | | | | | - Two layout test failures: * LayoutTests/storage/statement-error-callback.html: To fix it, we need to implement layoutTestController.clearAllDatabases, bug 20995, skip for now. * LayoutTests/fast/forms/input-maxlength-ime-completed.html: This is a new test from webkit, bug 20993 filed and assigned. R=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25323 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't have a blank line in bookmark folder tooltips.erg@google.com2009-09-031-1/+4
| | | | | | Review URL: http://codereview.chromium.org/198006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25322 0039d316-1c4b-4281-b951-d872f2087c98
* Update my watchlists to cover more files.phajdan.jr@chromium.org2009-09-031-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/192007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25321 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: improve KDE proxy settings parsing and add unit tests for it.mdm@chromium.org2009-09-033-59/+419
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/176056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25320 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily delete the checksum and png files for some tests that have the ↵jparent@chromium.org2009-09-037-3/+5
| | | | | | | | | | | | | correct checksums checked in, but the wrong pngs. This will allow me to use the rebaseline tool in a follow up CL to generate the correct baselines. Temporarily add these test to test-expectations so I don't turn things red in the meantime. The incorrect pngs come from http://codereview.chromium.org/100128/show and http://codereview.chromium.org/99147. TEST=layout test try servers BUG=20933 Review URL: http://codereview.chromium.org/190019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25319 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix link and link underline colorsarv@google.com2009-09-037-34/+125
| | | | | | | | | | | | | The fall back color for the link underline is the link color with the alpha channel set to 1/3 of the link color. BUG=20697 TEST=All links on the NTP should have different underline color. Also, try with different themes. Review URL: http://codereview.chromium.org/194004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25318 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Add basic unit tests for gtk themes.erg@google.com2009-09-036-13/+180
| | | | | | Review URL: http://codereview.chromium.org/186019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25317 0039d316-1c4b-4281-b951-d872f2087c98
* The iterator used to walk through the set of throbbers might become invalidmark@chromium.org2009-09-031-4/+11
| | | | | | | | | | | if a throbber decides it's done animating during the walk. This might happen for toast throbbers, like the sad tab icon. TEST=none, really BUG=20907 Review URL: http://codereview.chromium.org/185016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25316 0039d316-1c4b-4281-b951-d872f2087c98
* Generates a class hierarchy using graphviz "dot", thegman@google.com2009-09-035-0/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | same tool that doxygen uses. This is not ready for primetime but I had already looked at this and it didn't look to hard so I stuck it in. With this CL nothing will happen unless graphviz is added to third_party/graphviz/files but I wanted to at least check in what has to happen so that if someone else wants to finish it they can. Basically jsdoctoolkit generates a .dot file that lists the inheritance, that is passed to dot which creates a png and a map file for a client side image map. To actually use it online would require inserting the map file into an html file, probably using EZT or python. Otherwise, to be useful we'd need to split the template into ParamMatrix4 and its derived classes, Param and its derived classes. RenderNode and its derived classes, ParamObject and its derived classes and then finally everything not covered by the above. Otherwise the chart is too big. http://www/~gman/images/class_hierarchy.png To be honest though, given it's just a tree a simple HTML page could also do this without the graphing. Just a simple -NamedObject | +-Param | +--ParamFloat | +--ParamInteger etc. Nearly as simple would be to save the data to JSON and graph it in JavaScript live in the browser using canvas or O3D. That would be a lot smaller than the 9meg for the binary parts of graphviz Review URL: http://codereview.chromium.org/174384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25315 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky ExtensionApi tests. #1 source of flakiness.phajdan.jr@chromium.org2009-09-032-2/+4
| | | | | | | | | TEST=none http://crbug.com/19866, http://crbug.com/20828 Review URL: http://codereview.chromium.org/195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25314 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Back and Forwards button broken in 23101idanan@chromium.org2009-09-031-4/+4
| | | | | | | | | | | | | | | | Issue 165318 was accepted but caused the back and forwards button to become unresponsive to middle-clicks. This should fix the issue but if there is a problem, we should revert 23101 because it causes a major regression while only providing a cosmetic enhancement. BUG=20323 TEST=none Review URL: http://codereview.chromium.org/199007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25313 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme setup a little faster by not blurring images for tab backgrounds.mirandac@chromium.org2009-09-031-5/+5
| | | | | | | | | BUG= http://crbug.com/20956 TEST= Install themes, note that tab backgrounds look good. Review URL: http://codereview.chromium.org/198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25312 0039d316-1c4b-4281-b951-d872f2087c98
* Check the right Info.plist to determine whether the app is the browser or amark@chromium.org2009-09-031-2/+5
| | | | | | | | | | | | | | | | | | | | | | background helper. This fixes the Breakpad about:crash problem, but not directly. I'm not exactly sure of the failure mechanism here. It's likely that doing this call properly here caches the Info.plist dictionary, and that something in Breakpad crashes when that's not done. Without this fix, we're seeing a double fault, with the second exception occurring in the renderer while it is processing the crash. Likely because of the use of fork && execv instead of posix_spawn to launch the renderer, the second exception is delivered to the browser process. The browser's Breakpad instance recognizes that the exception is not its own, but attempts to act on it in part anyway. There may be a Breakpad bug here, I'll investigate more tomorrow. BUG=20371 TEST=In a Breakpad-enabled build, about:crash should bring up a sad tab and not crash the browser process Review URL: http://codereview.chromium.org/194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25311 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing the valgrind error probably caused by WebKit r47756.yusukes@google.com2009-09-031-0/+5
| | | | | | | | | | BUG=20941 TEST=none TBR=hclam Review URL: http://codereview.chromium.org/198005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25310 0039d316-1c4b-4281-b951-d872f2087c98
* Traceline: Pass a STARTUPINFOA to CreateProcessA.deanm@chromium.org2009-09-031-1/+1
| | | | | | | | | This should help building in UNICODE (but there might be other problems). Review URL: http://codereview.chromium.org/194011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25308 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing the valgrind error probably caused by r25278 (TAKE 2).yusukes@google.com2009-09-031-0/+6
| | | | | | | | | | BUG=20964 TEST=none TBR=estade Review URL: http://codereview.chromium.org/192006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25307 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 25302 since ExtensionBrowserTest.ParseFeed in browser_tests has ↵yusukes@google.com2009-09-031-1/+1
| | | | | | | | started to fail. Review URL: http://codereview.chromium.org/197009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25306 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 20:52:22 +0000