| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
to prevent from going from STATE_HANDSHAKE back to the
STATE_GET_OB_CERT_COMPLETE by mistake.
R=mattm@chromium.org
BUG=88782
TEST=Chrome should not time out when connecting to a site requesting
an origin-bound certificate for the first time.
Review URL: http://codereview.chromium.org/8305008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Cast from size_t to int.
TEST=compile views_examples target, it should work without errors.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8252009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98306
TEST=
Review URL: http://codereview.chromium.org/8303003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86301
TEST=memcheck no longer complains
Review URL: http://codereview.chromium.org/8289013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderWidget::is_fullscreen (used in DidChangeView to detect fullscreen mode)
was implemented.
Review URL: http://codereview.chromium.org/8301010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100315
BUG=99016
TEST=Memory bots go green
Review URL: http://codereview.chromium.org/8302001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
VisitedLinkEventListener.
BUG=99391
TEST=updated unit tests
Review URL: http://codereview.chromium.org/8286015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the internal TabContents when asked to.
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/8220026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8299007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/8267012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is not failing.
BUG=91887
Review URL: http://codereview.chromium.org/8275017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/8302010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100381
TEST=Run on NX with no window manger and verify popups come up instead of panels.
Review URL: http://codereview.chromium.org/8302003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18185
TEST=None
Review URL: http://codereview.chromium.org/8231022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
treat it as a typed navigation.
This fixes two different problems:
(1) Due to scheme-stripping, a user who navigated to e.g. "host/path" via a link or bookmark, for a not-previously-typed host, would erroneously get a search page instead of a navigation when reloading via hitting enter or when editing the path to be something else. We could instead fix this by being more conservative about scheme-stripping, but that is uglier UI, a bigger change, and doesn't solve problem (2).
(2) Users who navigated to intranet hosts (with or without a path or other URL components) via link clicks/bookmarks/etc. would later try to type them and be frustrated that the omnibox would do a search and then show the accidental search infobar. This change makes the omnibox more aggressive about learning that such hostnames are valid intranet hosts even before users type them, if they've at least visited them.
There are four issues here:
(1) Because in incognito mode we never add navigations to any history DBs, users there won't see the above benefits. In fact, users there will struggle to use (new) intranet hosts in general. I filed bug 100271 about this.
(2) The omnibox will now be more likely to inline-autocomplete intranet URLs you haven't actually typed before. After thinking for a while I don't think this will have a large effect either way especially as intranet URLs are often short (and thus it's less likely users will try to search or navigate to a pure prefix of one).
(3) Heavy intranet users will have a larger in-memory DB. I don't think this effect will be dramatic since it's just one URL per unique hostname, and there's no real way around this anyway.
(4) The additional checking in AddPage() could make navigation slower. I don't think this ought to happen because most navigations will fail the RCDS check for "no known TLD" (which ought to be fast, as that code is called by things like cookie management), so they'll never even check the database. If this turns out to be wrong, then we'll need to fall back on something like the solution in bug 100271.
BUG=94806
TEST=On a clean profile, add a bookmark for some intranet host (without navigating there), with or without a path. Click on the bookmark. Then try to modify the path and check that the omnibox still wants to navigate, not search.
Review URL: http://codereview.chromium.org/8286011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prior to refactoring/cleanup.
TBR=jam@chromium.org
http://crbug.com/99757
TEST=none
Review URL: http://codereview.chromium.org/8289005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
appropriately release/reacquire resources.
BUG=5175544
TEST=None
Review URL: http://codereview.chromium.org/7890046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we'll garbage collect stale sessions every time the model associator
starts up (so on first time sync and with each client restart). Doing it this
way avoids multiple clients racing to try and delete the same session that just
became stale. By default the threshold before which a session is stale is 14
days.
BUG=96931
TEST=unit_tests --gtest_filter="*ProfileSyncServceSessionTest*"
R=tim@chromium.org,yfriedman@chromium.org
Review URL: http://codereview.chromium.org/8253007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=81263
Review URL: http://codereview.chromium.org/8276028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
New name is more suitable because clipboard access tested in the test is specific for DOM centric extensions.
TEST=ClipboardApiTest.*
BUG=None
Review URL: http://codereview.chromium.org/8294004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The string description for IDS_EXTENSIONS_ENABLED is misleading.
It's used for an individual extension instead of 'extensions'.
In some languages, the difference in number would lead to different
translations.
While doing so, change other related descriptions (extensions -> an extension).
BUG=99633
TEST=NONE
Review URL: http://codereview.chromium.org/8231029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cevans
Review URL: http://codereview.chromium.org/8298006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99854
TEST=none
Review URL: http://codereview.chromium.org/8298004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98046
TEST=Create app with BC in manifest. Have app use a different window name (not "background"), window should not be visible.
Review URL: http://codereview.chromium.org/8247011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8302002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99332
TEST=none
Review URL: http://codereview.chromium.org/8295006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetUnmodifiedCharacter().
BUG=99129
TEST=NONE
Review URL: http://codereview.chromium.org/8286006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Need to include some resources files.
BUG=none
TEST=resize the chrome window until it shows scrollbars, they should paint
TBR=saintlou@chromium.org
Review URL: http://codereview.chromium.org/8304003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dcheck error.
BUG=99923
TEST=start chrome with new profile and --no-first-run --use-pure-view. type in http://sites.google.com/a/google.com/ several times until autocomplete kicks in. continue typing while with autocomplete, browser should not crash.
Review URL: http://codereview.chromium.org/8252001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=100308
TEST=none
Review URL: http://codereview.chromium.org/8274028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93937
TEST=Manual
Review URL: http://codereview.chromium.org/8275023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidget.
This enables the RenderWidget to know when it has been placed into fullscreen
mode (which will be hooked up to Pepper in a subsequent change).
BUG=100264
Review URL: http://codereview.chromium.org/8283029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8228024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92644
TEST=
Review URL: http://codereview.chromium.org/8273036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=this is a test
Review URL: http://codereview.chromium.org/7824019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100301
TEST=*WebstorePrivate*
Review URL: http://codereview.chromium.org/8294001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We walk down the tree looking for windows that have
delegates, are visible, and are fullscreen.
BUG=99710
TEST=added
Review URL: http://codereview.chromium.org/8233023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rsleevi
Review URL: http://codereview.chromium.org/8298012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94920
TEST=Make sure that new profiles have the search app installed by default
in NTP along with the youtibe and gmail apps.
Review URL: http://codereview.chromium.org/8255001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
prerender type), and one for global counts.
R=dominich, cbentzel
Review URL: http://codereview.chromium.org/8303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The WebstoreInstallListener was exiting the browser test early, when it should only quit the message loop when the test is waiting on its callbacks.
BUG=100301
TEST=ExtensionWebstorePrivateApiTest.AppInstallBundle
Review URL: http://codereview.chromium.org/8289003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlashFullscreen.
Tested with ppapi/native_client/tests/ppapi_browser/ppb_fullscreen
upgraded with 2D graphics. Will commit in a separate patch.
BUG=41780
TEST=ppapi/tests/test_fullscreen + see above
Review URL: http://codereview.chromium.org/8275031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Add a printer which supports grayscale and cmyk color models. Preview a
color webpage. Observe that the color options is displayed to the user.
Review URL: http://codereview.chromium.org/8280002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8268006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8273024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the default pane name for apps panes to Apps (rather than blank). Also, fix a bug where app pane renames didn't get propagated across open NTPs.
BUG=97821
TEST=manual
Review URL: http://codereview.chromium.org/8264001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105524 0039d316-1c4b-4281-b951-d872f2087c98
|